diff options
| author | Sebastian Dröge <sebastian@centricular.com> | 2014-07-10 12:50:17 +0200 |
|---|---|---|
| committer | Sebastian Dröge <sebastian@centricular.com> | 2014-07-11 13:54:07 +0200 |
| commit | b389ac62ea3b8bc1f0ea9a24d4d1b5532fb529bc (patch) | |
| tree | 62bfaf37402e9f3f59c86c07bcc82c95b766563b | |
| parent | b8bb260d3c890b2a0804b66768d6169958b65a86 (diff) | |
decodebin: Only link elements further after setting them to PAUSED
They might fail to go to PAUSED, and when connecting them further
we might already expose their srcpads on decodebin if we're unlucky.
This prevents us to handle failures going to PAUSED gracefully.
| -rw-r--r-- | gst/playback/gstdecodebin2.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/gst/playback/gstdecodebin2.c b/gst/playback/gstdecodebin2.c index 788b48155..882ef54d7 100644 --- a/gst/playback/gstdecodebin2.c +++ b/gst/playback/gstdecodebin2.c @@ -2203,9 +2203,6 @@ connect_pad (GstDecodeBin * dbin, GstElement * src, GstDecodePad * dpad, } } - /* link this element further */ - connect_element (dbin, delem, chain); - /* try to configure the subtitle encoding property when we can */ pspec = g_object_class_find_property (G_OBJECT_GET_CLASS (element), "subtitle-encoding"); @@ -2302,6 +2299,9 @@ connect_pad (GstDecodeBin * dbin, GstElement * src, GstDecodePad * dpad, SUBTITLE_UNLOCK (dbin); } + /* link this element further */ + connect_element (dbin, delem, chain); + res = TRUE; break; } |