diff options
author | Chris Wilson <chris@chris-wilson.co.uk> | 2007-01-22 17:25:28 +0000 |
---|---|---|
committer | Chris Wilson <cpwilson@src.gnome.org> | 2007-01-22 17:25:28 +0000 |
commit | 758e6a5cb998c527cafce10292f7f3b0aed57de5 (patch) | |
tree | 1d41db5104f4a40824799a8d4ada4d0639c0450d /python | |
parent | 59bbbea8be0cbfdd075419b8e248eb64f957341b (diff) |
Bug 123591 – vte_terminal_fork_command succeeds even when it does not
2007-01-22 Chris Wilson <chris@chris-wilson.co.uk>
Bug 123591 – vte_terminal_fork_command succeeds even when it does not
* python/vte.defs:
* python/vte.override:
* src/reaper.c: (vte_reaper_child_watch_cb):
* src/vte-private.h:
* src/vte.c: (vte_terminal_catch_child_exited),
(_vte_terminal_fork_basic), (vte_terminal_forkpty):
* src/vte.h:
* src/vteapp.c:
s/pid_t/GPid/ portable variant, no API/ABI implications
* src/pty.c: (vte_pty_child_setup), (_vte_pty_run_on_pty),
(_vte_pty_fork_on_pty_name), (_vte_pty_fork_on_pty_fd),
(_vte_pty_open_unix98), (_vte_pty_pipe_open), (n_read), (n_write),
(_vte_pty_start_helper), (_vte_pty_open_with_helper),
(_vte_pty_open), (main):
Replace custom fork() and pipe based syncrohonisation scheme
with g_spawn_async_with_pipes() as it actually handles all
failure modes correctly, and gives us overtures of portability.
svn path=/trunk/; revision=1493
Diffstat (limited to 'python')
-rw-r--r-- | python/vte.defs | 4 | ||||
-rw-r--r-- | python/vte.override | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/python/vte.defs b/python/vte.defs index c9cf75c..e95dfe7 100644 --- a/python/vte.defs +++ b/python/vte.defs @@ -59,7 +59,7 @@ (define-method fork_command (of-object "VteTerminal") (c-name "vte_terminal_fork_command") - (return-type "pid_t") + (return-type "GPid") (parameters '("const-char*" "command") '("char**" "argv") @@ -74,7 +74,7 @@ (define-method forkpty (of-object "VteTerminal") (c-name "vte_terminal_forkpty") - (return-type "pid_t") + (return-type "GPid") (parameters '("char**" "envv") '("const-char*" "directory") diff --git a/python/vte.override b/python/vte.override index f775377..1d396ea 100644 --- a/python/vte.override +++ b/python/vte.override @@ -114,7 +114,7 @@ _wrap_vte_terminal_fork_command(PyGObject * self, PyObject * args, PyObject *py_argv = NULL, *py_envv = NULL, *loglastlog = NULL, *logutmp = NULL, *logwtmp = NULL; int i, n_args, n_envs; - pid_t pid; + GPid pid; if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|sOOsOOO:fork_command", kwlist, &command, &py_argv, &py_envv, @@ -190,7 +190,7 @@ _wrap_vte_terminal_forkpty(PyGObject * self, PyObject * args, PyObject * kwargs) PyObject *py_envv = NULL, *loglastlog = NULL, *logutmp = NULL, *logwtmp = NULL; int i, n_args, n_envs; - pid_t pid; + GPid pid; if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|OsOOO:forkpty", kwlist, &py_envv, &directory, |