diff options
| author | sewardj <sewardj@a5019735-40e9-0310-863c-91ae7b9d1cf9> | 2010-10-20 15:43:09 +0000 |
|---|---|---|
| committer | sewardj <sewardj@a5019735-40e9-0310-863c-91ae7b9d1cf9> | 2010-10-20 15:43:09 +0000 |
| commit | f90dcbc6bfab3c26fa1802c1e307d4673a1412e5 (patch) | |
| tree | 52ed0e9e0bc6013f03a5fe436a9c2956aca254bc | |
| parent | 8559152b66aa3123da7aa7f9c4f899637833a8dd (diff) | |
Size the ARM_LINUX_FAKE_COMMPAGE correctly and add explanatory
comments. Fixes #254556. (Peter Maydell, peter.maydell@linaro.org)
git-svn-id: svn://svn.valgrind.org/valgrind/trunk@11460 a5019735-40e9-0310-863c-91ae7b9d1cf9
| -rw-r--r-- | coregrind/m_aspacemgr/aspacemgr-linux.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/coregrind/m_aspacemgr/aspacemgr-linux.c b/coregrind/m_aspacemgr/aspacemgr-linux.c index d69f38e4..8ed8b840 100644 --- a/coregrind/m_aspacemgr/aspacemgr-linux.c +++ b/coregrind/m_aspacemgr/aspacemgr-linux.c @@ -341,10 +341,17 @@ static void parse_procselfmaps ( /* ----- Hacks to do with the "commpage" on arm-linux ----- */ /* Not that I have anything against the commpage per se. It's just that it's not listed in /proc/self/maps, which is a royal PITA -- - we have to fake it up, in parse_procselfmaps. */ + we have to fake it up, in parse_procselfmaps. + + But note also bug 254556 comment #2: this is now fixed in newer + kernels -- it is listed as a "[vectors]" entry. Presumably the + fake entry made here duplicates the [vectors] entry, and so, if at + some point in the future, we can stop supporting buggy kernels, + then this kludge can be removed entirely, since the procmap parser + below will read that entry in the normal way. */ #if defined(VGP_arm_linux) # define ARM_LINUX_FAKE_COMMPAGE_START 0xFFFF0000 -# define ARM_LINUX_FAKE_COMMPAGE_END1 0xFFFFF000 +# define ARM_LINUX_FAKE_COMMPAGE_END1 0xFFFF1000 #endif |