summaryrefslogtreecommitdiff
path: root/slirp/arp_table.c
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2013-08-23 17:36:48 +0100
committerMichael Tokarev <mjt@tls.msk.ru>2013-09-01 19:09:09 +0400
commited6bc28e8a448b9005af50eed12893c5f7711c6e (patch)
treec2d2db3d6d8c0216666e90b8ae9b0587555520ce /slirp/arp_table.c
parent714290979abf551d5116346e4fbd3d54eb24bd12 (diff)
slirp/arp_table.c: Avoid shifting into sign bit of signed integers
"0xf << 28" shifts right into the sign bit, since 0xf is a signed integer. Use the 'U' suffix to force an unsigned shift to avoid this undefined behaviour and a clang sanitizer warning. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Eric Blake <eblake@redhat.com> Acked-by: Jan Kiszka <jan.kiszka@siemens.com> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'slirp/arp_table.c')
-rw-r--r--slirp/arp_table.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/slirp/arp_table.c b/slirp/arp_table.c
index bf698c1ac5..ecdb0baee4 100644
--- a/slirp/arp_table.c
+++ b/slirp/arp_table.c
@@ -38,7 +38,7 @@ void arp_table_add(Slirp *slirp, uint32_t ip_addr, uint8_t ethaddr[ETH_ALEN])
ethaddr[3], ethaddr[4], ethaddr[5]));
/* Check 0.0.0.0/8 invalid source-only addresses */
- if ((ip_addr & htonl(~(0xf << 28))) == 0) {
+ if ((ip_addr & htonl(~(0xfU << 28))) == 0) {
return;
}
@@ -74,7 +74,7 @@ bool arp_table_search(Slirp *slirp, uint32_t ip_addr,
DEBUG_ARG("ip = 0x%x", ip_addr);
/* Check 0.0.0.0/8 invalid source-only addresses */
- assert((ip_addr & htonl(~(0xf << 28))) != 0);
+ assert((ip_addr & htonl(~(0xfU << 28))) != 0);
/* If broadcast address */
if (ip_addr == 0xffffffff || ip_addr == broadcast_addr) {