diff options
authorColin Harrison <>2012-01-04 17:16:36 +0000
committerJon TURNEY <>2012-01-27 11:52:14 +0000
commit80c073352a276bad3722263629de3cd61df758ab (patch)
parentced9db65950e402d7ddc663225b888e8482b8c57 (diff)
hw/xwin: Fix winEnqueueMotion() for change in miPointerSetPosition()
Commit 3b36fd1b49030ead44358945f62e5abe7f4609ce changed miPointerSetPosition() to take co-ordinates as doubles, not ints, so this code as it stands is now wrong (if it ever was correct in the first place :-)) It's unclear that we can safely promote x,y to doubles, apply miPointerSetPosition() which potentially constrains the cursor, and then convert back to ints. Fortunately, this whole dance seems to be unnecessary, and we can simply remove the call to miPointerSetPosition() entirely, and just QueuePointerEvents() like any other input driver. Signed-off-by: Colin Harrison <> Reviewed-by: Jon TURNEY <>
1 files changed, 0 insertions, 3 deletions
diff --git a/hw/xwin/winmouse.c b/hw/xwin/winmouse.c
index 3193e3e51..99509f28e 100644
--- a/hw/xwin/winmouse.c
+++ b/hw/xwin/winmouse.c
@@ -356,15 +356,12 @@ winMouseButtonsHandle (ScreenPtr pScreen,
* Enqueue a motion event.
- * XXX: miPointerMove does exactly this, but is static :-( (and uses a static buffer)
- *
void winEnqueueMotion(int x, int y)
int valuators[2];
ValuatorMask mask;
- miPointerSetPosition(g_pwinPointer, POINTER_RELATIVE, &x, &y);
valuators[0] = x;
valuators[1] = y;