diff options
| author | Keith Packard <keithp@keithp.com> | 2021-03-30 21:05:48 -0700 |
|---|---|---|
| committer | Keith Packard <keithp@keithp.com> | 2021-03-30 21:05:48 -0700 |
| commit | 53581bba3ee20671e6e5ab7c743bfbf6ffbe6974 (patch) | |
| tree | b5bc58e7d507c47e34dcb85696a64d4aec8ea5b3 /include/X11/extensions | |
| parent | 3e6bdd90c604e061c71715865eb403ffdd0dd7f0 (diff) | |
Note ABI of XResQueryClientIds
XResQueryClientIds is now documented to return an array of 32-bit
values, not an array of longs. The previous implementation allocated
space for 32-bit values but read longs into that, overflowing the
array. Applications using this were expecting 32-bit values.
This "worked" on little endian 64-bit systems because only one value
was typically provided and the low 32-bits got stuck in the right
place, although the allocation was overrun at the end. That might
cause trouble if the allocator is checking carefully.
Signed-off-by: Keith Packard <keithp@keithp.com>
Diffstat (limited to 'include/X11/extensions')
| -rw-r--r-- | include/X11/extensions/XRes.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/X11/extensions/XRes.h b/include/X11/extensions/XRes.h index 1c81616..bedf625 100644 --- a/include/X11/extensions/XRes.h +++ b/include/X11/extensions/XRes.h @@ -98,6 +98,7 @@ Status XResQueryClientPixmapBytes ( /* v1.2 */ +/* Returns an array of uint32_t values, not an array of long */ Status XResQueryClientIds ( Display *dpy, long num_specs, |