summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Wilson <chris@chris-wilson.co.uk>2011-06-09 16:00:30 +0100
committerChris Wilson <chris@chris-wilson.co.uk>2011-06-09 16:00:30 +0100
commit1638a0a6c0b335dd31def93a9199f7407ae51170 (patch)
treeb0b20663df53d11fee8a50c5b3ebca078ce5471c
parent4b54c89fbddc7aa72e5f2c5eded44e84bce70b77 (diff)
sna/dri: Add a comment to warn about a potential race between DRI clients
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
-rw-r--r--src/sna/sna_dri.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/src/sna/sna_dri.c b/src/sna/sna_dri.c
index 7fe9aff0..9abc66d0 100644
--- a/src/sna/sna_dri.c
+++ b/src/sna/sna_dri.c
@@ -376,7 +376,12 @@ sna_dri_copy_region(DrawablePtr drawable, RegionPtr region,
}
ValidateGC(dst, gc);
- /* Invalidate src to reflect unknown modifications made by the client */
+ /* Invalidate src to reflect unknown modifications made by the client
+ *
+ * XXX But what about any conflicting shadow writes made by others
+ * between the last flush and this request? Hopefully nobody will
+ * hit that race window to find out...
+ */
damage(src, region);
/* Wait for the scanline to be outside the region to be copied */