summaryrefslogtreecommitdiff
path: root/HACKING
diff options
context:
space:
mode:
authorRobert Knutsson <zybreak@proton.me>2026-11-02 12:28:39 +0100
committerRobert Knutsson <zybreak@proton.me>2026-11-02 12:28:39 +0100
commitdea37a7033abfdef3376dc9ad5e8756e9fee959b (patch)
treeebb6e04ec41f8aa396f1bce644aa24d1070a232c /HACKING
parentc1a5132346e88739f80a927af289b1d5b9935e07 (diff)
xkb: pad the explicit components and the modmap in SetMapHEADmaster
The X server reads both padded to 4 bytes (CheckKeyExplicit, CheckModifierMap), and requires the request length to match (_XkbSetMapCheckLength), as the GetMap reply already describes. Without the pads, with an odd number of explicit components or modmap keys, the parts after them were sent 2 bytes early, and the server returned BadLength or BadValue. With the modmap last, libxcb failed the length assertion in xcb_send_request instead. The pads have no serialize="true", so xcb_xkb_set_map_values_t and the C API don't change. Fixes: https://gitlab.freedesktop.org/xorg/lib/libxcb/-/work_items/65 Part-of: <https://gitlab.freedesktop.org/xorg/proto/xcbproto/-/merge_requests/72>
Diffstat (limited to 'HACKING')
0 files changed, 0 insertions, 0 deletions