Age | Commit message (Collapse) | Author | Files | Lines |
|
https://bugs.freedesktop.org/show_bug.cgi?id=92370
|
|
As exported through BlueZ's org.bluez.Battery1 D-Bus interface. This
interface is only used for device where the battery information cannot
be processed in the kernel.
This is the first UpDevice type that doesn't use UdevDevice for the
Linux backend, and it is also the first that does not poll() status at
all.
https://bugs.freedesktop.org/show_bug.cgi?id=92370
|
|
Rather than using != NULL, followed by unref().
https://bugs.freedesktop.org/show_bug.cgi?id=103380
|
|
Rather than using != NULL, followed by unref().
https://bugs.freedesktop.org/show_bug.cgi?id=103380
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=103380
|
|
Those "API documentation" don't document the function below it, they
just name it, so aren't needed.
https://bugs.freedesktop.org/show_bug.cgi?id=103380
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=99906
|
|
Since libimobiledevice 5a8449a, LOCKDOWN_E_NOT_ENOUGH_DATA was renamed
to LOCKDOWN_E_RECEIVE_TIMEOUT. We'll use "-7" to avoid having to use
build glue.
|
|
The take_action_timeout_cb() function returns G_SOURCE_REMOVE which
makes GLib destroy the timeout. However the action_timeout_id
stayed != 0 so when warning level turned to "action" again the daemon
assumed that the timeout is already set and did nothing.
(It only logged: "Not taking action, timeout id already set")
https://bugs.freedesktop.org/show_bug.cgi?id=87791
|
|
The patchset was pushed by mistake and is still being reviewed.
|
|
Remove pointless upperbound, SENSOR_MAX_TYPES has no meaning here
and we break from the loop anyway when needed (i.e. when ENOENT
is returned). This aligns the code with other sensor device
walkers in OpenBSD.
https://bugs.freedesktop.org/show_bug.cgi?id=95257
|
|
If the poll timeout is actually changed because the warning level
has changed, only reset the actual poll code, not the warning level
notifications and the booking structures.
https://bugs.freedesktop.org/show_bug.cgi?id=99862
|
|
No semantic change.
https://bugs.freedesktop.org/show_bug.cgi?id=99862
|
|
When a device is refreshed because the poll timeout has been reached,
the warning-level change notification can also be fired, which then
will reset (i.e. disable, re-enable) polling. For batteries this can
happen three times in a row.
Now we reset polling only if the calculated timeout actually differs
from the current one.
https://bugs.freedesktop.org/show_bug.cgi?id=99862
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=93095
|
|
GDBus doesn't like '@' in the object path, so escape it.
https://bugs.freedesktop.org/show_bug.cgi?id=93095
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=92487
|
|
Remove the trailing linefeed from the sysfs attribute to be able to
print it, and simplify the loop by the same token.
|
|
The initial "refresh" for devices would fail if there was no data to
read. Instead, we should set the level to unknown, so that the device
appears in the Power panel, and in the "upower -d" output.
|
|
UPower sets property LidIsPresent to true only if hw.acpi.lid_switch_state
is different from "NONE", "NONE" being the default value for FreeBSD.
Thus, the property is always false on default configurations.
Force UPower not to care about the value of the sysctl, making it check
only for its existence.
See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=175531
https://bugs.freedesktop.org/show_bug.cgi?id=101828
|
|
The "model_name" and "serial_number" information that upower exports for
batteries that supply a laptop or UPS are supposed to be that of the
battery. But that's very unlikely to happen for devices, such as
wireless mice, keyboards or joysticks.
Look for a sibling input device if a device battery does not contain
model information so as to avoid generic names in UIs.
https://bugs.freedesktop.org/show_bug.cgi?id=102493
|
|
Move up_device_supply_get_sibling_with_subsystem() so we can use
it in up_device_supply_refresh_device()
https://bugs.freedesktop.org/show_bug.cgi?id=102493
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=102493
|
|
Mostly for the type of device rather than the connections.
https://bugs.freedesktop.org/show_bug.cgi?id=102493
|
|
The unref of the FD list for the inhibitor was missing which means that
the FD was leaked and the lock was never released. This means that for
each suspend/resume cycle a new inhibitor would be added.
Signed-off-by: Richard Hughes <richard@hughsie.com>
|
|
Only set up the polling once the write has succeeded.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=100626
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=100359
|
|
Export approximate battery levels that devices can use, exported by
the kernel as POWER_SUPPLY_CAPACITY_LEVEL_* values.
This avoids bizarrely accurate values showing up in UIs when we only
have ok/warning levels of accuracy in some cases.
https://bugs.freedesktop.org/show_bug.cgi?id=100359
|
|
Those levels will not be used to cover warning levels, but approximate
battery levels that devices can use, exported by the kernel as
POWER_SUPPLY_CAPACITY_LEVEL_* values.
See linux/power_supply.h
https://bugs.freedesktop.org/show_bug.cgi?id=100359
|
|
Some devices, such as a number of wireless Logitech unifying devices
don't have a precise battery level reporting, and use the Linux
POWER_SUPPLY_CAPACITY_LEVEL_* values.
This minimal fix matches the levels against approximate percentage
values. This is good enough to make the Logitech T650 report battery
again when using the kernel HID++ battery support.
https://bugs.freedesktop.org/show_bug.cgi?id=100359
|
|
A 5% battery level should already be in "critical", this matches the
configurable thresholds where the bounds of critical warnings are
inclusive. This also makes it easier to create fake percentages for the
Logitech devices with coarse battery level reporting.
https://bugs.freedesktop.org/show_bug.cgi?id=100359
|
|
Paths supplied to testbed.add_device() are relative to /sys/devices
already and therefore must not start with /sys/devices.
This does not change the result of the test.
https://bugs.freedesktop.org/show_bug.cgi?id=100539
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=99763
|
|
The NoPollbatteries option should disable battery polling. Create
a config file with 'NoPollBatteries=true' and ensure we don't get
polling setup for the virtual battery.
https://bugs.freedesktop.org/show_bug.cgi?id=99763
|
|
This also tests suspending and resuming polling as a
by-product.
https://bugs.freedesktop.org/show_bug.cgi?id=99763
|
|
Use an inhibitor lock obtained via logind to make sure the polling
is paused before the system is put to sleep, rather than racing with
the suspension.
https://bugs.freedesktop.org/show_bug.cgi?id=99763
|
|
The battery levels might have changed drastically compared to
before sleep. Since we poll batteries at set intervals, it can
take quite some time for the new level to be picked up by the
polling code.
Listen to the "PrepareForSleep" signal emitted by logind, that
gets emitted on suspend and wake up. Pause polling globally on
suspend, and refresh all devices manually and resume polling when
waking up.
https://bugs.freedesktop.org/show_bug.cgi?id=99763
|
|
Pausing stops the polling for all registered devices and resuming
re-enables the previously disabled polling, after re-calculating
the poll timeout.
https://bugs.freedesktop.org/show_bug.cgi?id=99763
|
|
The test would fail without the fix from commit 86e5237, and succeed
with it.
|
|
GUdev-CRITICAL **: g_udev_device_get_sysfs_path: assertion 'G_UDEV_IS_DEVICE (device)' failed
This is caused by looking for devices in a particular subsystem which
don't have parents. This can happen with virtual devices, such as the
ones created by test suites.
|
|
Instead of using comments to explain the magic values.
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=99763
|
|
Derive from dbusmock.DBusTestCase and add {start,stop}_logind
to enable tests that need logind.
https://bugs.freedesktop.org/show_bug.cgi?id=99763
|
|
g_debug() already adds a linefeed.
|
|
When setting up polling for our devices, it's possible that the device
hasn't yet been exported on D-Bus, meaning that the object would be
unhelpfully empty.
Use the "native path" instead, so we don't get null in debug outputs, or
timeout names.
|
|
duplicate ‘const’ declaration specifier
We can't use a const char const because we actually want to assign
values to elements of the array.
|
|
|
|
Backlights, starting with kernel 4.11 [1] can have a
"brightness_hw_changed" sysfs attribute, which can be polled to detect
hardware initiated brightness changes, such as ones done through
firmware-handled keyboard backlight hotkeys, or firmware controlled
changes (eg. turn off backlight on low battery).
[1] https://patchwork.kernel.org/patch/9544111/
https://bugs.freedesktop.org/show_bug.cgi?id=98404
|
|
Pass the fd to use to up_kbd_backlight_brightness_read() so that it can
be used with multiple fds. This will be used to support the
"brightness_hw_changed" sysfs attribute.
https://bugs.freedesktop.org/show_bug.cgi?id=98404
|
|
There are multiple possible causes for the keyboard brightness to change,
e.g. SetBrightness may get called, or the brightness may get changed
through a hotkey which is handled in firmware.
https://bugs.freedesktop.org/show_bug.cgi?id=98404
|