diff options
| author | Albert Astals Cid <aacid@kde.org> | 2018-01-08 18:07:38 +0100 |
|---|---|---|
| committer | Albert Astals Cid <aacid@kde.org> | 2018-01-08 18:37:33 +0100 |
| commit | 8794789a72f845b009656e6d7ae6a00b709e09bc (patch) | |
| tree | 82220f5640d4abcf726f6e83e59cd6bb59cc4d67 /poppler/SplashOutputDev.cc | |
| parent | 4c7814342806b61fedbb2d45ce74462f9dbc20bc (diff) | |
Delete lots of copy constructors and copy assignment operators
Fixes rule-of-three and copyable-polymorphic warnings reported by clazy.
The default copy constructor and copy assignment operator are
only valid for simple classes so we delete them (i.e. make then not exist)
when we have either a virtual class or a destructor, the code still compiles
so this doesn't fix any bug, it is more a protection for when you think you
can copy a class and don't realize the default copy constrcutor is not doing
what you want and you get crashes. Hopefully this helps us in the future :)
Diffstat (limited to 'poppler/SplashOutputDev.cc')
| -rw-r--r-- | poppler/SplashOutputDev.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/poppler/SplashOutputDev.cc b/poppler/SplashOutputDev.cc index 28174356..19d43d71 100644 --- a/poppler/SplashOutputDev.cc +++ b/poppler/SplashOutputDev.cc @@ -15,7 +15,7 @@ // // Copyright (C) 2005 Takashi Iwai <tiwai@suse.de> // Copyright (C) 2006 Stefan Schweizer <genstef@gentoo.org> -// Copyright (C) 2006-2017 Albert Astals Cid <aacid@kde.org> +// Copyright (C) 2006-2018 Albert Astals Cid <aacid@kde.org> // Copyright (C) 2006 Krzysztof Kowalczyk <kkowalczyk@gmail.com> // Copyright (C) 2006 Scott Turner <scotty1024@mac.com> // Copyright (C) 2007 Koji Otani <sho@bbr.jp> @@ -1232,6 +1232,8 @@ public: int glyphXA, int glyphYA, int glyphWA, int glyphHA, GBool aa, GBool validBBoxA); ~T3FontCache(); + T3FontCache(const T3FontCache &) = delete; + T3FontCache& operator=(const T3FontCache &) = delete; GBool matches(Ref *idA, double m11A, double m12A, double m21A, double m22A) { return fontID.num == idA->num && fontID.gen == idA->gen && |