GfxDeviceNColorSpace: Port to std::vector<std::string>

I was tired of having two constructors for GfxDeviceNColorSpace, both
taking GooString ** but one copying those strings and the other keeping
them for itself.

Moved to std::vector<std::string> without much fallout in the rest of
the code

1 files changed, 4 insertions, 4 deletions

diff --git a/poppler/SplashOutputDev.cc b/poppler/SplashOutputDev.cc
index e3fcf9cb..aba4578e 100644
--- a/poppler/SplashOutputDev.cc
+++ b/poppler/SplashOutputDev.cc
@@ -1740,13 +1740,13 @@ void SplashOutputDev::setOverprintMask(GfxColorSpace *colorSpace,
       GfxDeviceNColorSpace *deviceNCS = (GfxDeviceNColorSpace *)colorSpace;
       additive = mask == 0x0f && !deviceNCS->isNonMarking();
       for (i = 0; i < deviceNCS->getNComps() && additive; i++) {
-        if (deviceNCS->getColorantName(i)->cmp("Cyan") == 0) {
+        if (deviceNCS->getColorantName(i).compare("Cyan") == 0) {
           additive = false;
-        } else if (deviceNCS->getColorantName(i)->cmp("Magenta") == 0) {
+        } else if (deviceNCS->getColorantName(i).compare("Magenta") == 0) {
           additive = false;
-        } else if (deviceNCS->getColorantName(i)->cmp("Yellow") == 0) {
+        } else if (deviceNCS->getColorantName(i).compare("Yellow") == 0) {
           additive = false;
-        } else if (deviceNCS->getColorantName(i)->cmp("Black") == 0) {
+        } else if (deviceNCS->getColorantName(i).compare("Black") == 0) {
           additive = false;
         }
       }