Age | Commit message (Collapse) | Author | Files | Lines |
|
lima driver exposes GL_ARB_blend_func_extended, but it has no
GL_EXT_gpu_shader4 support. The only way to use it in GL
is by using GLES2 shaders.
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/688>
|
|
All tests pass on the AMD closed driver, except the
GL_ARB_gpu_shader_int64 test as the driver doesn't support that
extension and skips the test.
Acked-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/698>
|
|
Fix defects reported by Coverity Scan.
Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value use_gl_sample_position.
uninit_use: Using uninitialized value use_interpolate_at_sample
Fixes: 5e9ede3e8 ("add GL_ARB_sample_locations")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/667>
|
|
Fix defect reported by Coverity Scan.
Uninitialized pointer read (UNINIT)
uninit_use_in_call: Using uninitialized value ctx when calling glXDestroyContext.
Fixes: 4991384f1 ("glx: add test for GLX_ARB_create_context_no_error")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/692>
|
|
This tests whether the loop will unroll if one component of vec4 is
used as a loop counter. Similar code can be produced by running C&C3
Tiberium Wars under nine with non-integer hardware and than going
through ttn.
Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/673>
|
|
This is based on the existing vs-loop-complex-unroll-with-else-break
test, however this one can't be unrolled and demonstrates an issue
with copy propagation in r300 compiler.
More details in: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6467
Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/694>
|
|
Fix defect reported by Coverity Scan.
Use after free (USE_AFTER_FREE)
pass_freed_arg: Passing freed pointer got_pixels as an argument to *piglit_dispatch_glTextureImage2DEXT.
Fixes: 1429c2c69 ("ext_direct_state_access: add tests for glTexture*EXT functions")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/691>
|
|
Seriously.
The Linux OpenGL ABI has always required at least OpenGL 1.2. The
Windows OpenGL ABI has always required at least OpenGL 1.1. I don't
know what the Mac OS X ABI requires, but every supported device has
had 1.1 at least as far back as 10.5.8. SGI O2 and Octane support at
least OpenGL 1.1. I don't think piglit needs to fail gracefully on
systems from before 1996.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/686>
|
|
piglit_require_GLSL() only checks that shader objects and the shading
language exist. It does *NOT* check that any particular shader stage
exists. It is perfectly valid to have an OpenGL 1.5 implementation that
has only vertex shaders or only fragment shaders.
piglit_require_GLSL_version(110) and piglit_require_GLSL_version(120)
have the same failings as piglit_require_GLSL() and more. GLSL 1.10 is
the minimum GLSL version that actually exists, so anything that has GLSL
has version 1.10. GLSL 1.20 can be exposed by any implementation, so
checking that version doesn't guarantee anything either. GLSL 1.30
implicitly requires OpenGL 3.0, so that is a strong check.
All of the non-shader drivers in Mesa advertise shader objects and GLSL
1.20 and NEITHER vertex nor fragment stages. This fixes these tests to
just skip on those drivers.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/686>
|
|
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/686>
|
|
Remove check for:
1. GLSL version checks that are redundant with GL version checks (e.g.,
checking for GLSL 1.30 when the test already required OpenGL 3.0).
2. GL version checks that are redundant with the requirements section.
3. One call to piglit_require_GLSL() when no GLSL related API calls are
made.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/686>
|
|
Neither GL_EXT_packed_depth_stencil nor GL_ARB_depth_buffer_float
implies that the implementation can create depth textures. This affects
the R200 driver in Mesa, for example.
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/686>
|
|
Here we make sure gl_FragColor.x is always given a value. Otherwise
the if (b) check, the coord uniform etc can all be optimised away
because gl_FragColor.x can simply always be set to 1.0 as anything
else is undefined.
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/690>
|
|
sqrt() on Mali4x0 PP is too imprecise, so with 3 passes
accumulated error is enough for the test to fail.
Since we don't really care how to transform the data,
replace sqrt() with multiplication.
Acked-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/689>
|
|
Fix defect reported by Coverity Scan.
Logically dead code (DEADCODE)
dead_error_condition: The condition enable_dither & visualize & (num_samples = 0) cannot be true.
Fixes: 8ea4dcbd2 ("tests: Added tests for nv_alpha_to_coverage_dither_control")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/684>
|
|
The counter exposed by this ARB_shader_clock is "monotonically
incrementing [...] within a single shader invocation" so we
can't compare the value from one dispatch with one from a later
dispatch.
Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/685>
|
|
Switch to one-based indices for primitive and index and use the table
from https://www.khronos.org/opengl/wiki/Primitive to compute the
correct index.
This fixes the test for radeonsi, llvmpipe and zink (and probably
other drivers but I can't test them).
Acked-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/680>
|
|
Fix defects reported by Coverity Scan.
Resource leak (RESOURCE_LEAK)
leaked_storage: Variable attachments going out of scope leaks the storage it points to.
Fixes: deec4392c ("ext_direct_state_access: add test for Framebuffer functions")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/679>
|
|
GL_MAX_TEXTURE_BUFFER_SIZE_ARB + 1 won't necessarly fit in an int32_t so use
a int64_t in the computation.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/675>
|
|
Fix defects reported by Coverity Scan.
Resource leak (RESOURCE_LEAK)
leaked_storage: Variable dst_data going out of scope leaks the storage it points to.
leaked_storage: Variable src_data going out of scope leaks the storage it points to.
leaked_storage: Variable exp_data going out of scope leaks the storage it points to.
Fixes: c02fca9f8 ("Ported logicop test from Glean to Piglit.")
Fixes: c773ae680 ("test/logicop: expand tests to also cover MSAA render target")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/666>
|
|
prop_count is of type uint32_t.
Fix defect reported by Coverity Scan.
Unsigned compared against 0 (NO_EFFECT)
unsigned_compare: This less-than-zero comparison of an unsigned value is never true. prop_count < 0U.
Fixes: a0722042b ("ext_external_objects: Selecting a queue that supports graphics")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/663>
|
|
Fix defect reported by Coverity Scan.
Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking attachments suggests that it may
be null, but it has already been dereferenced on all paths leading
to the check.
Fixes: 8713fbda2 ("ext_external_objects: Vulkan framework additions")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/660>
|
|
Fix defect reported by Coverity Scan.
Resource leak (RESOURCE_LEAK)
leaked_storage: Variable texel_fetch_macro going out of scope leaks the storage it points to.
Fixes: 8e842367d ("ext_framebuffer_multisample_blit_scaled: Rewrite the fragment shader")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/657>
|
|
"'GL_PROGRAM_INPUT(vs,fs) active resources' expected 2 but got 6" is
not very useful without also seeing the list of resources you got.
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/661>
|
|
From the ARB_shader_objects spec:
The error INVALID_VALUE is generated by any command that takes one or
more handles as input, and one or more of these handles are not an
object handle generated by OpenGL.
However, Mesa's implementation of glDeleteObjectARB does not emit that
error at the time of writing.
Let's add a test to make sure we don't regress this in the future.
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/656>
|
|
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/658>
|
|
Fix defect reported by Coverity Scan.
Resource leak (RESOURCE_LEAK)
leaked_storage: Variable name going out of scope leaks the storage it points to.
Fixes: 98f9fb5f8 ("texture integer getTexImage clamping: Remove GLenum string literals.")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/646>
|
|
This fixes the logic that prevents windows to take focus that was
specifically added for glx tests.
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/659>
|
|
piglit_get_glx_window calls it.
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/659>
|
|
Fix defects reported by Coverity Scan.
Resource leak (RESOURCE_LEAK)
leaked_storage: Variable name going out of scope leaks the storage it points to.
Fixes: 9be783604 ("use a glsl1.30 version of texture integer")
Fixes: 08b9bf310 ("texture integer glsl130: Remove GLenum string literals.")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/654>
|
|
In order to check the values in gl_SampleMaskIn, we need to make sure
multisampling rasterization is turned on.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: ed153b51b577 ("Add GL_INTEL_conservative_rasterization tests")
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/649>
|
|
Tests that texture buffer's size cannot exceed GL_MAX_TEXTURE_BUFFER_SIZE_ARB
even if underlying buffer allows it to be bigger. In other words the size of
texture buffer must be clamped to the GL_MAX_TEXTURE_BUFFER_SIZE_ARB by the driver.
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1723
Signed-off-by: Dmytro Nester <dmytro.nester@globallogic.com>
Signed-off-by: Sergii Melikhov <sergii.v.melikhov@globallogic.com>
Signed-off-by: Viktoriia Palianytsia <v.palianytsia@globallogic.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/231>
|
|
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/609>
|
|
From section 5.7 "Structure and Array Operations" of the GLSL 1.30 spec:
"Behavior is undefined if a shader subscripts an array with an index less
than 0 or greater than or equal to the size the array was declared with."
The behaviour becomes defined only in robustness extensions, however even
if driver is technically allowed to crash or hang, it most likely
doesn't want to.
Robustness extensions encourage to us to return zero on out-of-bounds
read, however it's not clearly applicable to the array of opaque types.
What will happen when we call a built-in function which expects the
opaque type with the instance returned from oob access?
In the spirit of the spec - I think neither compilation should fail nor
a hang occur.
Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
Acked-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/373>
|
|
From section 5.7 "Structure and Array Operations" of the GLSL 1.30 spec:
"Behavior is undefined if a shader subscripts an array with an index less
than 0 or greater than or equal to the size the array was declared with."
The behaviour becomes defined only in robustness extensions, however even
if driver is technically allowed to crash or hang, it most likely
doesn't want to.
Large local array may be spilled, so out-of-bounds access should be tested
for them separately.
Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
Acked-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/373>
|
|
From section 5.7 "Structure and Array Operations" of the GLSL 1.30 spec:
"Behavior is undefined if a shader subscripts an array with an index less
than 0 or greater than or equal to the size the array was declared with."
The behaviour becomes defined only in robustness extensions, however even
if driver is technically allowed to crash or hang, it most likely
doesn't want to.
gl_SampleMaskIn may be handled differently in a driver than ordinary arrays.
Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
Acked-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/373>
|
|
From section 5.7 "Structure and Array Operations" of the GLSL 1.30 spec:
"Behavior is undefined if a shader subscripts an array with an index less
than 0 or greater than or equal to the size the array was declared with."
The behaviour becomes defined only in robustness extensions, however even
if driver is technically allowed to crash or hang, it most likely
doesn't want to.
gl_TessLevel* may be handled differently in a driver than ordinary arrays.
Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
Acked-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/373>
|
|
From section 5.7 "Structure and Array Operations" of the GLSL 1.30 spec:
"Behavior is undefined if a shader subscripts an array with an index less
than 0 or greater than or equal to the size the array was declared with."
The behaviour becomes defined only in robustness extensions, however even
if driver is technically allowed to crash or hang, it most likely
doesn't want to.
gl_ClipDistance may be handled differently in a driver than ordinary arrays.
Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
Acked-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/373>
|
|
|
|
fixes incomplete texture initialization
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/640>
|
|
Policy CMP0115 is not set: Source file extensions must be explicit.
https://cmake.org/cmake/help/v3.20/policy/CMP0115.html
Fixes: 075b8d99d ("arb_blend_func_extended: add three api tests")
Fixes: 383c37e5f ("arb blend func extended - check errors at glBegin")
Fixes: 7ad3d6669 ("GL: Verify that when GL_COORD_REPLACE is set, fragment shader texture coordinates do not get eliminated.")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/522>
|
|
Demonstrates a potential issue with u_threaded_context in iris.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/604>
|
|
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/604>
|
|
Earlier expectation of this test was that glBufferSubData is not
supposed to work since mapping the buffer is prohibited by the spec.
However while spec explicitly prohibits mapping via MapBufferRange
and MapNamedBufferRange, it does not prohibit buffer updates via
glBufferSubData.
This commit changes test to render reversed bands pattern with
Vulkan. In GL side, we update buffer with glBufferSubData to the
expected pattern, render with buffer to the display and verify
results match expectation.
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/636>
|
|
Earlier expectation of this test was that glBufferSubData is not
supposed to work since mapping the buffer is prohibited by the spec.
However while spec explicitly prohibits mapping via MapBufferRange
and MapNamedBufferRange, it does not prohibit buffer updates via
glBufferSubData.
This commit changes test to create empty buffer at VK side, import
that to GL, update it with checkerboard pattern, render with buffer
to the display and verify results.
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/636>
|
|
optimizations from undefs
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/633>
|
|
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/632>
|
|
STENCIL_INDEX8 and RGBA are not compatible formats, and the former also
isn't compatible with GL_FLOAT, so add special casing here
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/629>
|
|
Use some non-obvious arithmetic to try to avoid some NIR optimizations
that hide a bug in the Intel compiler backend for Gfx12+ (Tigerlake and
newer) GPUs. Basically, when NIR sees
x = (gl_FrontFacing ? -1.0 : 1.0) * a;
it converts it to
x = gl_FrontFacing ? -a : a;
This avoids the bad code generation for the (gl_FrontFacing ? -1.0 :
1.0) case.
v2: Make this a separate test. Suggested by Marcin.
Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/627>
|
|
These try to reproduce some possible errors introduced by replacing the
logic joined comparisons with either min or max. Without proper
conditioning, the min or max could be repalced by an fsat that would
produce incorrect results.
Both of these tests fail in mesa!10012 without the corrections suggested
by Rhys.
Acked-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/514>
|