summaryrefslogtreecommitdiff
path: root/.pick_status.json
AgeCommit message (Collapse)AuthorFilesLines
2020-07-22panfrost: Fix write to free'd memoryAlyssa Rosenzweig1-1/+1
No clue how this worked before. Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Fixes: 82f18b713ac ("panfrost: Keep track of active BOs") Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5859> (cherry picked from commit 37d89e0f93601e520edcdc41dc68197dff736c1e)
2020-07-22panfrost: Fix fence leakAlyssa Rosenzweig1-1/+1
When overwriting the writer, we need to release the old reference. Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Fixes: 2dad9fde505 ("panfrost: Start tracking inter-batch dependencies") Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5859> (cherry picked from commit 20dd37024b045881d98a55b1927b0dab29d1edd3)
2020-07-22spirv: Allow block-decorated struct types for constantsJason Ekstrand1-1/+1
Whenever a struct type is decorated Block or BufferBlock we turn that into a GLSL_TYPE_INTERFACE. Since these decorations can end up random places, we should allow them for constants. Closes: #3252 Fixes: 9d0ae777dd6 "spirv: Use interface type for block and buffer..." Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5855> (cherry picked from commit 351b5137d71b8dc944bad6dcb83cd93e6d38c44e)
2020-07-22spirv: Skip phis in unreachable blocks in the second phi passJason Ekstrand1-1/+1
Closes: #3253 Fixes: 22fdb2f8551 "nir/spirv: Update to the latest revision" Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5855> (cherry picked from commit 81773b4b441fbd8ec284de78e4dfdcecdca112dc)
2020-07-22iris: fix fallback to swrast driverLionel Landwerlin1-1/+1
The helper we use to query the kernel returns -1 if the getparam is not supported. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: f402b7c57641dd ("iris: fail screen creation when kernel support is not there") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3188 Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5838> (cherry picked from commit e3ddba73241901a75844b39e6e3b12eaf15f9b26)
2020-07-22st/mesa: set compressed_data to NULL when freedPierre-Eric Pelloux-Prayer1-1/+1
Reported-by: Karol Herbst <kherbst@redhat.com> Fixes: b6db703e0f0 ("st/mesa: make texture views inherit compressed_data storage") Reviewed-by: Karol Herbst <kherbst@redhat.com> Tested-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5821> (cherry picked from commit 51bdaf0b601522dfc599bd352806e66ef56876a3)
2020-07-22glsl: only allow 32 bits atomic operations on imagesPierre-Eric Pelloux-Prayer1-1/+1
EXT_shader_image_load_store says: The format of the image unit must be in the "1x32" equivalence class otherwise the atomic operation is invalid. ARB_shader_image_load_store says: We will only support 32-bit atomic operations on images Fixes: fc0a2e5d017 ("glsl: add EXT_shader_image_load_store new image functions") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5688> (cherry picked from commit 1e3aeda5281e5d246e37a035d91f08af4bb0e5e3)
2020-07-22glsl: don't expose imageAtomicIncWrap for signed imagePierre-Eric Pelloux-Prayer1-1/+1
The spec says that it's only allowed for unsigned ones. Same from imageAtomicDecWrap. Fixes: fc0a2e5d017 ("glsl: add EXT_shader_image_load_store new image functions") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5688> (cherry picked from commit 233af4a412db87a9b8430104a58c1b6adb704b1c)
2020-07-22glsl: reject size1x8 for image variable with floating-point data typesPierre-Eric Pelloux-Prayer1-1/+1
Fixes: 8d07d66180b ("glsl,nir: Switch the enum representing shader image formats to PIPE_FORMAT.") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5688> (cherry picked from commit 0c8873d85db371dea9ec34fefc6fec531aa404b9)
2020-07-22freedreno/a2xx: fix compressed texturesJonathan Marek1-1/+1
Two problems: * Multiply has higher priority than shift * rsc->layout.format isn't initialized for a2xx Fixes: 5a8718f01b397 ("freedreno: Make the slice pitch be bytes, not pixels.") Signed-off-by: Jonathan Marek <jonathan@marek.ca> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5796> (cherry picked from commit 344e764b01202d9894c793d393d060dc5530145b)
2020-07-22.pick_status.json: Update to fd20e986249f88129d81353d79dd248d7664953bEric Engestrom1-0/+4644
2020-07-08radv: Use correct semaphore handle type for Android import.Bas Nieuwenhuizen1-1/+1
Coincidentally got a bugreport of a game that is broken without the import fix below, but it turns out I made a copy-paste error as well .. In good news it is clearly tested now. Fixes: ad151499583 "radv: Set handle types in Android semaphore/fence import." Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5783> (cherry picked from commit ffb8020f6e7ae3fb89d5b5ab17ff6fbdc6798ac4)
2020-07-08v3d/compiler: Fix sorting the gs and fs inputsNeil Roberts1-1/+1
ntq_setup_fs_inputs and ntq_setup_gs_inputs sort the inputs according to the driver location. This input array is then used to calculate the VPM offset for the outputs in the previous stage. However, it wasn’t taking into account variables that are packed into a single varying slot. In that case they would have the same driver_location and are distinguished by location_frac. This patch makes it additionally sort by location_frac when the driver locations are equal. This can happen when the compiler packs varyings that are sized less than vec4. Without this fix, when the VPM is used to transmit data free-form between the stages (such as VS->GS) then it would end up writing to inconsistent locations. Fixes dEQP tests such as: dEQP-GLES31.functional.primitive_bounding_box.lines.global_state. vertex_geometry_fragment.default_framebuffer_bbox_equal Fixes: 5d578c27cec ("v3d: add initial compiler plumbing for geometry shaders") Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Reviewed-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5787> (cherry picked from commit deefebc55be4478afbfd98e0d5094f09d7739640)
2020-07-08radeonsi: fix SI_NUM_ATOMSTimothy Arceri1-1/+1
This is not used anywhere so maybe we should just drop it instead. Fixes: 639b673fc3b8 ("radeonsi: don't use an indirect table for state atoms") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5766> (cherry picked from commit bba766d85db2aa13425036cbbf80ff10d2b49d44)
2020-07-08radv: enable zerovram for Quantic Dream gamesRhys Perry1-1/+1
Fixes various artifacts with Detroit: Become Human. This assumes other Vulkan games using the same engine could have the same issues. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Cc: <mesa-stable@lists.freedesktop.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5710> (cherry picked from commit e4654a35b00315465ad84afcf92162ddf15eec40)
2020-07-08anv: Handle clamping of inverted depth rangesJason Ekstrand1-1/+1
Tested-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Reviewed-by: Ivan Briano <ivan.briano@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5792> (cherry picked from commit 1d5e1882f662fb4a922353ea272c1e94398f9155)
2020-07-08iris: Fix fast-clearing of depth via glClearTex(Sub)ImageDanylo Piliaiev1-1/+1
If we clear depth only texture via glClearTex(Sub)Image it may cause: ../src/intel/blorp/blorp_genX_exec.h:1554: blorp_emit_surface_states: Assertion `params->depth.enabled || params->stencil.enabled' failed. due to clear_depth_stencil calling blorp_clear_depth_stencil when depth is already fast-cleared and there is no stencil. Fixes piglit test: arb_clear_texture-depth Fixes: 51638cf18a532510f9e1fd8f36207b56d38137b8 Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5770> (cherry picked from commit 77844690be7ef8e6e2b24ff1acd85f908ec566f4)
2020-07-08anv: garbage collect timeline semaphore when querying valueLionel Landwerlin1-1/+1
If we don't garbage collect the timeline, the value never progresses even though work completed. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3226 Fixes: 34f32a6d664807 ("anv: implement VK_KHR_timeline_semaphore") Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5774> (cherry picked from commit edc8119da4eafb45ae90b70ba33b2c1f5b85c4c1)
2020-07-08v3d: Use stvpmd for non-uniform offsets in GSNeil Roberts1-1/+1
The offset for the VPM write for storing outputs from the geometry shader isn’t necessarily uniform across all the lanes. This can happen if some of the lanes don’t emit some of the vertices. In that case the offset for the subsequent vertices will be different in each lane. In that case we need to use the stvpmd instruction instead of stvpmv because it will scatter the values out. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3150 Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5621> (cherry picked from commit 3b1c511b099e88d1b153de784e3bf7e951a6288f)
2020-07-08v3d: Add missing macro for stvpmd instructionNeil Roberts1-1/+1
stvpmd is like stvpmv but it scatters the output. It can be used with non-dynamically uniform offsets. Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5621> (cherry picked from commit dab8a9169c197a98df23f2bd0eb5e18cdeb71c99)
2020-07-08etnaviv: replace prims-emitted queryChristian Gmeiner1-1/+1
As we do not support stream output buffers we only count the primitives processed by the pipeline. Use the correct query type. Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Lucas Stach <l.stach@pengutronix.de> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5754> (cherry picked from commit 01a1926fb9da774e6f3d9c630d3a10cd7fc2942b)
2020-07-08freedreno/fdperf: better compatible string matchingRob Clark1-1/+1
Previously we would match the start of the compatible string, in a couple of cases, in order to match compatible strings like "qcom,adreno-630.2". But these cases would always list a more generic compatible (ie. "qcom,adreno") as a later choice. So if we parse all the compatible strings, we can do a more precise exact match. This avoids us accidentially matching on "qcom,adreno-smmu" and the hilarity that ensues. Fixes: 5a13507164a ("freedreno/perfcntrs: add fdperf") Signed-off-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5762> (cherry picked from commit 385d036f5836714bc59937369fdc3447fc0da5fb)
2020-07-08vulkan/wsi: Don't consider VK_SUBOPTIMAL_KHR to be an error conditionJason Ekstrand1-1/+1
This was causing vkAcquireNextImageKHR to not signal the fences and semaphores. In the case where the semaphore was brand new, this could cause an unsignalled syncobj to be passed into execbuffer2 which it will reject with -EINVAL leading to VK_ERROR_DEVICE_LOST. Thanks to Henrik Rydgård who works on the PPSSPP project for helping me figure this out. Fixes: ca3cfbf6f1e00 "vk: Add an initial implementation of the actual..." Fixes: 778b51f491cfe "vulkan/wsi: Add a hooks for signaling semaphores..." Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5672> (cherry picked from commit b0bbb62325b829427d87acb25b00b3e0eb0343cb)
2020-07-08radv: Always enable PERFECT_ZPASS_COUNTS.Bas Nieuwenhuizen1-1/+1
We have an issue with early depth testing and discard, where non-perfect counts count the tile if the early depth test succeeds. We could spend a lot of effort to set this conditionally based on the presence of the two conditions, but in the presence of inherited queries let's try this first. Changing PERFECT_ZPASS_COUNTS since I'm pretty sure this has a lower performance impact than always using late depth testing. CC: <mesa-stable@lists.freedesktop.org> Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3218 Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5757> (cherry picked from commit ad913a18b14f25b4f6995cb8a8b0c55c747029d8)
2020-07-08radv: Set handle types in Android semaphore/fence import.Bas Nieuwenhuizen1-1/+1
Seems like we forgot to set it all this time ... Fixes: b1444c9ccb0 "radv: Implement VK_ANDROID_native_buffer." Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5759> (cherry picked from commit ad151499583f1814280218bf2eae4eaf1e7090a4)
2020-07-08radv: disable FMASK compression when drawing with GENERAL layoutSamuel Pitoiset1-1/+1
Fixes: 96063100 "radv: enable shaderStorageImageMultisample feature on GFX8+" Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3219 Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/855 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3165> (cherry picked from commit 7b21ce401f7e81deca5ab6a4353b1369d059bcee)
2020-07-08iris: return max counter value for AMD_performance_monitorMarcin Ślusarz1-1/+1
glGetPerfMonitorCounterInfoAMD(..., ..., GL_COUNTER_RANGE_AMD, ...) returned NAN (binary representation of uint64_t(-1) as float) as a max value. Fixes: 0fd4359733e6 ("iris/perf: implement routines to return counter info") Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5473> (cherry picked from commit 00d3b13837c5edd299dc40cbd84505c8d1d5927f)
2020-07-08st/mesa: fix reporting of float perf counters max valueMarcin Ślusarz1-1/+1
Some Piglit tests (rightfully) fail because of min >= max when exposed to perf counters that do not explicitly define their max value. Failing tests: spec/amd_performance_monitor/api/test_counter_info spec/amd_performance_monitor/vc4/test_counter_info u32/u64 changes are no-ops. Fixes: 4cd1cfb9831d ("st/mesa: implement GL_AMD_performance_monitor") Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5473> (cherry picked from commit 2f4a112ec4a4c45bdc99634af113531ddd7914a2)
2020-07-08nouveau: fix pointer-sign warningTimothy Arceri1-1/+1
Fixes: e630271e0ec3 ("mesa: don't ever set NullBufferObj in gl_vertex_array_binding") Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5730> (cherry picked from commit ec8fdf8579d7f95257316d29a6e58ccdf6e5aaba)
2020-07-08gallium,util: undef ALIGN on FreeBSD to prevent name clashGreg V1-1/+1
Some rare headers like ipc/shm and pthread_np cause machine/param.h to be included which defines a macro called ALIGN. Signed-off-by: Matt Turner <mattst88@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3559> (cherry picked from commit 29e2a3b8f5e75508202cd651d16648256f303779)
2020-07-08i965: Explicitly cast value to uint64_tEmmanuel1-1/+1
In FreeBSD x86 and aarch64 __u64 is typedef to unsigned long and is the same size as unsigned long long. Since we are explicitly specifying the format, cast the value to the proper type. Reviewed-by: Matt Turner <mattst88@gmail.com> Signed-off-by: Emmanuel <manu@FreeBSD.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3559> (cherry picked from commit f678811b567aafba60842bf0b3cff124da4daa0e)
2020-07-08iris: Explicitly cast value to uint64_tEmmanuel1-1/+1
In FreeBSD x86 and aarch64 __u64 is typedef to unsigned long and is the same size as unsigned long long. Since we are explicitly specifying the format, cast the value to the proper type. Reviewed-by: Matt Turner <mattst88@gmail.com> Signed-off-by: Emmanuel <manu@FreeBSD.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3559> (cherry picked from commit 565a80450d28f6daa0ca8b98dad93924e712f94b)
2020-07-08meson: Do not enable USE_ELF_TLS for FreeBSDEmmanuel1-1/+1
Compiling with this option result in too much TLS usage and FreeBSD cannot handle that. Reviewed-by: Eric Engestrom <eric@engestrom.ch> Signed-off-by: Emmanuel <manu@FreeBSD.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3559> (cherry picked from commit 708db983dd08984b0cade15be576497661ef154c)
2020-07-08meson: Add versioning for xvmc trackerEmmanuel Vadot1-1/+1
The xvmc tracker used to be versionned with autotool but this seems to have been lost in the meson switch. Fixes: 22a817af8a89eb3c762f ("meson: build gallium xvmc state tracker") Reviewed-by: Eric Engestrom <eric@engestrom.ch> Signed-off-by: Emmanuel Vadot <manu@FreeBSD.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5708> (cherry picked from commit 02d0b2d5604d4a9e0ddfa8234db4c92682de0e69)
2020-07-08mesa: fix unintended fallthrough in glIsEnabled()Timothy Arceri1-1/+1
Fixes: 08fae07f5246 ("mesa: Handle GL_TEXTURE_GEN_STR_OES in _mesa_Enable()") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5705> (cherry picked from commit dfb9be6994f663c47930f3b2ed46b9f880306730)
2020-07-08mesa: fix fallthrough in glformatsTimothy Arceri1-1/+1
Before 908f817918fb this would fallthrough to GL_INVALID_OPERATION if the validation condition was not met. But since that change it will now only return GL_INVALID_OPERATION if !_mesa_has_EXT_texture_compression_bptc(ctx) is true. This seems unintended. Here we fix up the fallthrough and add the fallthrough comment so this doesn't happen again. Fixes: 908f817918fb ("mesa: expose EXT_texture_compression_bptc in GLES") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3005 Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5705> (cherry picked from commit 040b07c7feebac90858f7426c2c20784642d0ca5)
2020-07-08nir/algebraic: Don't distrubte absolute-value into dot-productsIan Romanick1-1/+1
Dot product is multiplication followed by addition, and absolute value does not distribute into addition. Only vec4 platforms are affected by this change as scalar-only platforms never have any of the fdot_replicated instructions. In the shader-db results, below, shaders in MANY different applications are affected. Trine, Doom3, Enemy Territory: Quake Wars, Counter Strike: Global Offensive, Mad Max, Metro Last Light, and on and on... I'm really shocked that there were no test regressions! All Haswell and earlier platforms had similar results. (Haswell shown) total instructions in shared programs: 16219743 -> 16219820 (<.01%) instructions in affected programs: 12171 -> 12248 (0.63%) helped: 1 HURT: 78 helped stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 helped stats (rel) min: 0.78% max: 0.78% x̄: 0.78% x̃: 0.78% HURT stats (abs) min: 1 max: 1 x̄: 1.00 x̃: 1 HURT stats (rel) min: 0.35% max: 2.38% x̄: 0.91% x̃: 1.06% 95% mean confidence interval for instructions value: 0.92 1.03 95% mean confidence interval for instructions %-change: 0.78% 1.00% Instructions are HURT. total cycles in shared programs: 538481383 -> 538491045 (<.01%) cycles in affected programs: 470796 -> 480458 (2.05%) helped: 149 HURT: 142 helped stats (abs) min: 1 max: 1338 x̄: 71.13 x̃: 4 helped stats (rel) min: 0.06% max: 40.99% x̄: 2.76% x̃: 0.67% HURT stats (abs) min: 1 max: 2092 x̄: 142.68 x̃: 12 HURT stats (rel) min: 0.07% max: 55.38% x̄: 5.07% x̃: 1.07% 95% mean confidence interval for cycles value: -5.28 71.69 95% mean confidence interval for cycles %-change: -0.07% 2.19% Inconclusive result (value mean confidence interval includes 0). Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Fixes: 62795475e8f ("nir/algebraic: Distribute source modifiers into instructions") Closes: #3129 Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5581> (cherry picked from commit 8591adea38b82f973948cd120ffd9f93eb3bd71d)
2020-07-08radv,vulkan: add a new x11 wsi drirc workaround for DOOM EternalSamuel Pitoiset1-1/+1
DOOM Eternal happily creates a swapchain with 2 images for IMMEDIATE. This fixes a 10% performance issue with RADV. Cc: 20.1 <mesa-stable@lists.freedesktop.org> Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5704> (cherry picked from commit ab9ecb607b88dd4610815ac254205656918e408e)
2020-07-08Revert "vulkan/wsi/x11: Ensure we create at least minImageCount images."Samuel Pitoiset1-1/+1
This breaks some games like Wolfenstein Youngblood or Wolfenstein 2 that crash at launch if the number of images is more than what they expected. We could add vk_x11_strict_image_count to fix these game bugs but it seems more conservative to revert that change and add a new wsi drirc workaround for Doom Eternal. This reverts commit 5f97dfc4c848cb6388ec138c19a22a8a880901d1. Cc: 20.1 <mesa-stable@lists.freedesktop.org> Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5704> (cherry picked from commit 311b9f25834d9ad6ad91f9eb41ec77ab71ab2a73)
2020-07-08nir: add missing break to nir_opt_access()Timothy Arceri1-1/+1
Fixes: f2d0e48ddc74 ("glsl/nir: Add optimization pass for access flags") Reviewed-by: Connor Abbott <cwabbott0@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5714> (cherry picked from commit d55aa78615f0b80a5e35f28b32201189c86345b7)
2020-07-08gallivm: add missing breakTimothy Arceri1-1/+1
Fixes: 26c5ae80f0b5 ("llvmpipe: enable ARB_shader_group_vote") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5714> (cherry picked from commit 06dc2f3f4759d5541fd52bf66ee43158c8405423)
2020-07-08st/mesa: do not clear NewDriverState for inactive statesPierre-Eric Pelloux-Prayer1-1/+1
Fixes: 085aa7f91e8 ("st/mesa: don't update atomic, SSBO, UBO and TBO states that have no effect") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2951 Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5660> (cherry picked from commit 5f1a16d06d8b2cf6942b1e4b250842ec0be2c8a4)
2020-07-08gallium/docs: remove reference to non-existent labelErik Faye-Lund1-1/+1
This label was removed a long time ago, let's also remove the reference to it. Fixes: 3acd7a34ab0 ("st/vega: Remove.") Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Acked-by: Eric Engestrom <eric@engestrom.ch> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5691> (cherry picked from commit 686f6c72068767c7343943790510aa82562795d8)
2020-07-08gallium/docs: fixup formatting of numbered listsErik Faye-Lund1-1/+1
Fixes: 0caf74bbcdf ("gallium: add PIPE_CAP_FRAMEBUFFER_MSAA_CONSTRAINTS") Fixes: 8632626c81a ("gallium: add pipe_resource::nr_storage_samples, and set it same as nr_samples") Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Acked-by: Eric Engestrom <eric@engestrom.ch> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5691> (cherry picked from commit 686cf8eaada1a6a73a7e9ea6ebde1e573cf91966)
2020-07-08draw/llvm: fix big-endian mask adjustingDave Airlie1-1/+1
This code was broken, but it worked by accident, as the pad and the edgeflag were reversed, however when Roland removed the cliptest field back in 2015, he stopped copying the pad which actually stopped copy the edgeflag. Fix the function to actually copy the edgeflag. Fixes: 1b22815af624 ("draw: don't pretend have_clipdist is per-vertex") Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5679> (cherry picked from commit 2bf2e6c83d2b97ecc84589ec94c17cb7beed2c53)
2020-07-08mesa/get: fix enum16 big-endian getting.Dave Airlie1-1/+1
These values were getting casted up to 32-bit, but then extracted via 16-bit pointer later. Just store via 16-bit. Fixes a lot of piglit on s390 Fixes: f96a69f916ae ("mesa: replace GLenum with GLenum16 in common structures (v4)"); Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5679> (cherry picked from commit 0e6dfd11f220fd1c55b4dc2f371263414874f1fd)
2020-07-08llvmpipe: fix occlusion queries on big-endian.Dave Airlie1-1/+1
Casting to u8 arrays and picking the lowest byte is fairly LE specific grab the other byte. Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5679> (cherry picked from commit b743c9bf2d5c987c97a22e725a56a2b641b58ae4)
2020-07-08gallivm/nir: fix big-endian 64-bit splitting/merging.Dave Airlie1-1/+1
The shuffles need to be swapped to do this properly on big-endian Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5679> (cherry picked from commit 3aeb61da49cf0e141759c23d4790ad5dd96bcf52)
2020-07-08glsl: fix constant packing for 64-bit big endian.Dave Airlie1-1/+1
In a piglit run on s390 a lot of double tests fail, explicitly packing/shifting things rather than using memcpy seems to help Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5679> (cherry picked from commit 928660527697bc37b475037f9f2579aa4d2205b4)
2020-07-08Revert "CI: Disable Panfrost Mali-T820 jobs"Neil Armstrong1-1/+1
This reverts commit 46a32f0b6bf91279d001a4905babe4e50007696e. The lab has recovered health, thus re-enable T820 Panfrost jobs. Acked-by: Michel Dänzer <mdaenzer@redhat.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4727> (cherry picked from commit 4cf4fe9d8217eb686f2220423fefede746cd427a)