summaryrefslogtreecommitdiff
path: root/.pick_status.json
AgeCommit message (Collapse)AuthorFilesLines
2022-05-10.pick_status.json: Mark 8c1d9c7b744b2e5b40fd42cfd51256b16deea6a8 as denominatedDylan Baker1-1/+1
2022-05-10radv: fix memory leak of descriptor set layoutBenjamin Cheng1-1/+1
We need to be able to track the descriptor sets explicity to unref the descriptor sets, otherwise these descriptor sets will not unref the descriptor set layout it holds. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6222 Fixes: 66f7289d568 ("radv: add reference counting for descriptor set layouts") Tested-by: Jakob Bornecrantz <jakob@collabora.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15741> (cherry picked from commit 96a240e176701f9b305c4bd273da9a8aee78e280)
2022-05-10anv: re-alloc push constants after secondary command buffersIván Briano1-1/+1
If the secondary command buffer executed used push constants on a different set of stages than the primary is using, we may end up not reallocating them for the primary, getting misrender artifacts at best, or a nice GPU hang at worst. Fixes the tests from a CTS from the future: dEQP-VK.dynamic_rendering.random.* Cc: mesa-stable Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16439> (cherry picked from commit 2e46f38902b9409f06f6b3fad6c0666031935794)
2022-05-10gallivm: fix oob txf swizzlingMike Blumenkrantz1-1/+1
this wasn't taking into account the format swizzle, returning broken alpha values in most cases Fixes: 0b6554ba6f2 ("gallivm,llvmpipe: handle TXF (texelFetch) instruction, including offsets") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16137> (cherry picked from commit f5caaf2d750184deee2b991a7f2e2cded9980a94)
2022-05-10llvmpipe: always set ssbo data pointers for drawMike Blumenkrantz1-1/+1
skipping these would lead to reading the previously-set data if a null buffer was set after a valid buffer cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16137> (cherry picked from commit 6a219f318af7282ba26318364e1138f0d91a3908)
2022-05-10gallivm/draw: fix oob ubo readsMike Blumenkrantz1-1/+1
the first case in gallivm did no checking, so this was always going to be broken, so instead just copy the now-correct ssbo logic cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16137> (cherry picked from commit f1d1371e512e32d03f7f54d873020e589ee67d47)
2022-05-10st/draw_feedback: set constant buffer strideMike Blumenkrantz1-1/+1
these shaders all do float-based reads, so using vec4 for robustness checks breaks gallivm cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16137> (cherry picked from commit a51e83b74e04ad47d7e61113aef3db2db53f2e8c)
2022-05-10lavapipe: fix CmdPushDescriptorSetWithTemplateKHR with refcountingMike Blumenkrantz1-1/+1
this is a cmdbuf function, which means it gets enqueued, which means the template can't be destroyed until the cmdbuf has finished using it cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16137> (cherry picked from commit 49df9eeb9d6a1a659786ef226f6ece0f9950e6ba)
2022-05-10gallivm: fix ssbo oob readsMike Blumenkrantz1-1/+1
this was checking (offset < size) when really it needs to be (offset < size && extent < size && offset >= 0) Fixes: 591899eedd2 ("gallivm/nir: Add a short circuit uniform-offset mode for load_ssbo/load_shared.") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16137> (cherry picked from commit aa98a90265ca9ec844f07b4b2a1d1e07fe33511a)
2022-05-10nir/opt_algebraic: Fix mask in shift by constant combining.Georg Lehmann1-1/+1
The comment above is correct, but the code to calculate the mask was broken. No Foz-db changes outside of noise. Fixes: 0e6581b87dc ("nir/algebraic: Reassociate shift-by-constant of shift-by-constant") Signed-off-by: Georg Lehmann <dadschoorse@gmail.com> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15990> (cherry picked from commit 66e917fff69497143ebf6593a40891ea3d1daf93)
2022-05-10gallium/u_threaded_context: Use PIPE_MAX_SHADER_SAMPLER_VIEWS for ↵Jason Ekstrand1-1/+1
sampler_buffers Sampler views and samplers may not be the same limit; in fact one is 32 while the other is 128. The sampler_buffers field is tracking sampler views (yes, naming is confusing) so we should use the right limit. Fixes: e9c41b321488 ("gallium/u_threaded: add buffer lists - tracking of buffers referenced by tc") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Reviewed-by: Karol Herbst <kherbst@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15988> (cherry picked from commit 620c5e9dd05c57c253fa1e56218e88fe7bd23d86)
2022-05-10pan/mdg: Fix multiple spilt writes in the same bundleIcecream951-1/+1
If two instructions in a single bundle both write to a spilt destination, then we need to reuse the fill and spill instructions, otherwise the value will be overwritten. This and the rest of this set of Midgard bug fixes were found from a vertex shader in Firefox WebRender that is used when a video is clipped, for example by setting the border-radius CSS property. CC: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16382> (cherry picked from commit c65afe541b764a75da68b6bf83aca60d72f88916)
2022-05-10pan/mdg: Return the instruction from mir_insert_instruction_*_scheduledIcecream951-1/+1
We can't return a pointer to the bundle itself because it might move about in memory. CC: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16382> (cherry picked from commit 7b9c976c2dabf07050efb1c9d0deb82d57efa944)
2022-05-10pan/mdg: Fix mask usage when filling before a spillIcecream951-1/+1
Check the bytemask against 0xFFFF rather than 0xF so that the fill is skipped for a .xyzw write rather than a .x write. Set the mask on the store to 0xF when doing a read so that all components are written back. Fixes: 31d26ebf1b9 ("pan/mdg: Fill from TLS before spilling non-SSA nodes") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16382> (cherry picked from commit c750ab8a389b82795bb1509250711671c19f583d)
2022-05-10pan/mdg: Use MAX2 to set min_alignmentIcecream951-1/+1
If a value is written in a vector CSEL but then written again by other instructions, it still needs full alignment, so set min_alignment using MAX2 to avoid ever reducing it. Fixes: 1798f6bfc33 ("pan/midgard: Fix masks/alignment for 64-bit loads") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16382> (cherry picked from commit b281843974aa86594288ca3c096eedf9965739f5)
2022-05-10pan/mdg: Keep min_bound at 16 when alignment requires itIcecream951-1/+1
Otherwise LCRA will try to divide by zero when calculating m_max. Fixes: 553c2cf16b7 ("pan/mdg: Set RA bounds for fp16") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16382> (cherry picked from commit b1ecb90941c9b3d9a9780b9dbb264e7b3b097fdb)
2022-05-10nir/lower_shader_calls: put inserted instructions into a dummy blockLionel Landwerlin1-1/+1
When moving code into the main block or loop blocks, put the code into its own : if(true) { ... } block so that we avoid break/continue/return issues. v2: Also take care of the main block with return instructions v3: Make deletion more obvious with dummy if blocks (Jason) v4: Fixup assert for loops (Lionel) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 8dfb240b1f06 ("nir: Add raytracing shader call lowering pass.") Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16036> (cherry picked from commit 35d82ecf1ee117bef575731100fa6ae532f225fc)
2022-05-10nir/lower_shader_calls: don't insert code after break/continueLionel Landwerlin1-1/+1
When moving code from below to the insertion cursor point, if the cursor points to a jump instruction, don't bother inserting the code. It would break the break/continue assumptions of NIR and would not be executed anyway. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 8dfb240b1f06 ("nir: Add raytracing shader call lowering pass.") Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16036> (cherry picked from commit 9cf986dcff3c4364aacea5f36afdae7c3d3957f5)
2022-05-10nir/lower_shader_calls: don't use nop instructions as cursorsLionel Landwerlin1-1/+1
Stop using nop instructions which are causing issues with break/continue, instead use a nir_cursor (which brings its share of pain). Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 8dfb240b1f06 ("nir: Add raytracing shader call lowering pass.") Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16036> (cherry picked from commit 51dea59eb44f80a7a59d76c77798216a05f2b8e3)
2022-05-10nir/cf: Return a cursor from nir_cf_extract as wellJason Ekstrand1-1/+1
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16036> (cherry picked from commit 25661ea028b4d904693b165cd43bb42a6d2d99a2)
2022-05-10nir/cf: return cursor after insertion of cf_listLionel Landwerlin1-1/+1
This will be useful to cut code from one location and paste it at another place and later keep pasting after the previous insertions. v2: update comment (Jason) deal with stiching 2 empty blocks (Jason) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16036> (cherry picked from commit d65cf403f30e7b6d0d67f94c095687ae1724ff68)
2022-05-10gallium/clover: pass -no-opaque-pointers to ClangThomas Debesse1-1/+1
Clang opaque pointers have been enabled by default but the Clover code currently expects them to be disabled. Signed-off-by: Thomas Debesse <dev@illwieckz.net> Reviewed-by: Francisco Jerez <currojerez@riseup.net> Cc: mesa-stable Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6342 Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16129> (cherry picked from commit 06e9607478b780c9bcc6e08d69cfbe9020b4602c)
2022-05-10vulkan/wsi/x11: Ensure we have the required number of images for acquire.Bas Nieuwenhuizen1-1/+1
For games that needs >1 at the same time the existing check wasn't enough. Cc: mesa-stable Reviewed-by: Hans-Kristian Arntzen <post@arntzen-software.no> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15132> (cherry picked from commit a7f44b626943642e0cc0d132dd80aa820a45749f)
2022-05-10nir/lower_tex: Copy more fields in lower_tex_to_txd and friendsIcecream951-1/+1
Fixes NIR validation errors for OpenMW on Panfrost. Fixes: 1f97819fbe5 ("panfrost: Emulate GL_CLAMP on Bifrost") Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15939> (cherry picked from commit ad864a7c150a15221fb9c85d3214d4bcb6db7518)
2022-05-10anv: advertise rectangularLines only for Gen10+Chia-I Wu1-1/+1
We use the non-strict algorithm (with parallelograms) prior to Gen10 for wide lines. We can not advertise rectangularLines. Signed-off-by: Chia-I Wu <olvaffe@gmail.com> Fixes: f6e7de41d7b ("anv: Implement VK_EXT_line_rasterization") Reviewed-by: Ivan Briano <ivan.briano@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15432> (cherry picked from commit b2b810ebff657b3d24d93a1fdbd6adc79bc38153)
2022-05-10util/blitter: fix sampler restore with 0 saved samplersMike Blumenkrantz1-1/+1
in a sequence where a driver saves 0 sampler/views before calling u_blitter, the previous state of having 0 sampler/views bound would not be restored as expected, resulting in stale sampler/views which could affect behavior before new sampler/views were bound cc: mesa-stable Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16178> (cherry picked from commit 38ab178c4addb1e45a61d7fc7aa00f0d5254f5f6)
2022-05-10.pick_status.json: Mark 8daf8ff730b777bb512a237a36783d781cbf9de9 as backportedDylan Baker1-1/+1
2022-05-10.pick_status.json: Mark 8b28d1751c76b0ba72dae1f6b916cb7f2bbc1c0c as backportedDylan Baker1-1/+1
2022-05-10.pick_status.json: Mark ae369e9f6d4f2c826f1f2a748c32a14f9d5f1f54 as backportedDylan Baker1-1/+1
2022-05-10.pick_status.json: Mark 0e49ef5c9f2ec34567613226ad498edca28bce88 as backportedDylan Baker1-1/+1
2022-05-10.pick_status.json: Mark 9a412c10b7a96adf71c9a2ca44a0abca75de1c49 as backportedDylan Baker1-1/+1
2022-05-10.pick_status.json: Mark 5ff3fa5912778adb8117fa26bfe4786b583e741b as backportedDylan Baker1-1/+1
2022-05-10.pick_status.json: Mark 6317f88b044501354a052064478d5b43dfe41809 as backportedDylan Baker1-1/+1
2022-05-10.pick_status.json: Update to 14b1ed1ce105d42652f70e2fd13c90fc4f2e7ffcDylan Baker1-0/+2628
2022-05-05radv: disable instance packing to fix pipeline query statsSamuel Pitoiset1-1/+1
RDNA2 is affected by a hardware bug when instance packing is enabled for adjacent primitive topologies and instance_count > 1, pipeline stats generated by GE are incorrect. It needs to be applied for indexed and non-indexed draws. This is based on PAL waDisableInstancePacking. This fixes KHR-GL46.pipeline_statistics_query_tests_ARB.* with Zink. Gitlab: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6257 Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15877> (cherry picked from commit 9348620946e667e9485d010980ac9ffdd0446a23)
2022-05-05.pick_status.json: Update to 17c98393f9f3cb0801b73b2d4c62442859417368Dylan Baker1-0/+189
2022-05-04vulkan/wsi: Set the right stage flags for semaphore waitsJason Ekstrand1-1/+1
This is currently technically broken for compute. Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Adam Jackson <ajax@redhat.com> Cc: mesa-stable@lists.freedesktop.org Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16333> (cherry picked from commit 233be8ee592a0119501d9459fdafdc94c70902a4)
2022-05-04anv: remove static_state_maskLionel Landwerlin1-1/+1
This is now unnecessary. Either an instruction is never dynamic and it's emitted in genX_pipeline.c or it can be and it's emitted in genX_cmd_buffer.c/gfx8_cmd_buffer/gfx7_cmd_buffer.c Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16220> (cherry picked from commit 797a8850b94132361bfa586ec459705169a20c99)
2022-05-04anv: don't emit 3DSTATE_VF_TOPOLOGY in pipeline batchLionel Landwerlin1-1/+1
v2: drop primitive_topology = 0xffffffff (Tapani) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16220> (cherry picked from commit 74a27a6ccb32b4c81eff4bcc808401bdb0adba0b)
2022-05-04anv: don't emit 3DSTATE_DEPTH_BOUNDS in pipeline batchLionel Landwerlin1-1/+1
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16220> (cherry picked from commit 48229d11bab48569250e8ef43d6476f2ef3b9281)
2022-05-04anv: don't emit 3DSTATE_BLEND_STATE_POINTERS in pipeline batchLionel Landwerlin1-1/+1
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16220> (cherry picked from commit 76e735d09cb8ff2902d20f7c8b02b6c0e9a05358)
2022-05-04anv: don't emit 3DSTATE_WM in pipeline batchLionel Landwerlin1-1/+1
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16220> (cherry picked from commit e9d000a831c767f93c9e22087eb92ce4db044935)
2022-05-04anv: don't emit 3DSTATE_STREAMOUT in pipeline batchLionel Landwerlin1-1/+1
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16220> (cherry picked from commit 065242d623d89e84ef3ed9dd5558b40aa6f46ec2)
2022-05-04anv: never emit 3DSTATE_CPS in the pipeline batchLionel Landwerlin1-1/+1
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16220> (cherry picked from commit ce8bb293429142aeb89e424ba7879934def74637)
2022-05-04anv: rework sample locationLionel Landwerlin1-1/+1
On Gfx7 we can only give the sample location for a given multisample number. This means everytime the multisampling value changes, we have to re-emit the locations. It's fine because it's also where (3DSTATE_MULTISAMPLE) the number of samples is stored. On Gfx8+ though, 3DSTATE_MULTISAMPLE only holds the number of samples and all the sample locations for all number of samples are located in 3DSTATE_SAMPLE_PATTERN. So to be more effecient there, we need to track the locations for all sample numbers and compare new values with the relevant sample count when touching the dynamic state. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16220> (cherry picked from commit 168b13364f052be00d2015b6851d6c84e61064e9)
2022-05-04Revert "anv: fix dynamic state emission"Lionel Landwerlin1-1/+1
This reverts commit f348103fce4484b891a58bf3147b71e3a3558135. The change was causing performance regressions. Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16220> (cherry picked from commit 810518fda7628811adb2dc274ed11d125fbd3cd9)
2022-05-04anv: add missing logic op set in pipeline dyn stateLionel Landwerlin1-1/+1
v2: add ANV_CMD_DIRTY_DYNAMIC_LOGIC_OP check (Tapani) Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 75ad0e4b0874 ("anv: support blending logic op dynamic state") Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16220> (cherry picked from commit 69e6417e19793043e4bb3cd500cfcf377bce4c03)
2022-05-04anv: reset all dynamic state after secondary executionLionel Landwerlin1-1/+1
We don't know in what state the secondary buffer will leave the HW when it ends. It's easier to consider everything needs to be reemitted for now. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16220> (cherry picked from commit 5048f15737806d2b6795e736e547e4e4de7a37d1)
2022-05-04radv: re-emit dynamic line stipple state if the primitive topology changedSamuel Pitoiset1-1/+1
The dynamic primitive topology could change from LINE_LIST to LINE_STRIP for example and the stipple state depends on this. Found by inspection. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16295> (cherry picked from commit f5cffbb8df7721efc1698ea2289f40b8e6372f9e)
2022-05-04aco/ra: fix vgpr_limitRhys Perry1-1/+1
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Fixes: b98a4d4dd7e ("aco: refactor GPR limit calculation") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16297> (cherry picked from commit 1b639a0ce5b239ff06f1dfc8256f6512cb260144)