summaryrefslogtreecommitdiff
path: root/.pick_status.json
AgeCommit message (Collapse)AuthorFilesLines
2021-07-27glsl: Properly handle .length() of an unsized arrayYevhenii Kolesnikov1-1/+1
There are two distinct cases: - The last member of a shader storage block (length determined at run-time) - Implicitly-sized array (length determined at link-time) Fixes: 273f61a0051a ("glsl: Add parser/compiler support for unsized array's length()") Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com> Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11952> (cherry picked from commit c3f47f6e300ef1ec18b2c55ec82bccf263292351)
2021-07-27glsl: Add operator for .length() method on implicitly-sized arraysYevhenii Kolesnikov1-1/+1
ARB_shader_storage_buffer_object extension (promoted to core in 4.3) allows us to call .length() method on arrays declared without an explicit size. The length is determined at link time as a maximum array access. Fixes: 273f61a0051a ("glsl: Add parser/compiler support for unsized array's length()") Signed-off-by: Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com> Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11952> (cherry picked from commit 441826aaaac54e84629269c4622be2f17a465209)
2021-07-27lima: avoid crash with negative viewport valuesErico Nunes1-1/+1
The viewport value computations done in lima_set_viewport_states can result in a negative value for viewport. These could end up converted to unsigned values in lima_clip_scissor_to_viewport causing crashes from invalid scissor commands. Prevent this by limiting the minimum value to zero as is already done for the left and bottom values. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2938 Cc: mesa-stable Signed-off-by: Erico Nunes <nunes.erico@gmail.com> Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12055> (cherry picked from commit e6cdb01c517b42dece9ed532fd6eba7a74aa8f71)
2021-07-27dlist: don't handle unmerged draws as mergedPierre-Eric Pelloux-Prayer1-1/+1
The comment was incorrect: we can have N draws using the same mode with N > 1 (eg: GL_QUAD_STRIP draws cannot be merged). This commit fixes the drawing code to use the correct draw function. This fixes a hang in Starsector (see issue #5086). Fixes: b328d8e9bc9 ("dlist: use an union instead of allocating a 1-sized array") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11978> (cherry picked from commit 11d6441b94c7bf59ee32c8bcb0e30d370f3bd42c)
2021-07-27venus: suballocate memory in more casesChia-I Wu1-1/+1
When a dedicated allocation is not required, ignore it and suballocate. Fixes dEQP-VK.api.invariance.random. Cc: 21.2 mesa-stable Signed-off-by: Chia-I Wu <olvaffe@gmail.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12072> (cherry picked from commit 567bbfd56b507735d00868774c4b73866ae0a10f)
2021-07-27venus: clean up vn_AllocateMemoryChia-I Wu1-1/+1
Mainly to add vn_device_memory_should_suballocate. Cc: 21.2 mesa-stable Signed-off-by: Chia-I Wu <olvaffe@gmail.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12072> (cherry picked from commit f06b0df741e018bb02218e149ef5e4e17f339162)
2021-07-27llvmpipe: fix nir dot products (fsum op)Roland Scheidegger1-1/+1
When the dot product uses a source which can be optimized to a scalar, after a bunch of nir optimization steps the source to fsum will be a scalar with a x replicate swizzle. Hence nir_src_num_components is just 1 and the fsum was just a no-op which is not correct. Arguably this could be optimized a bit better, but just determine the number of addends by using nir_op_infos instead (the operand fetch was fixed already by 39a938ecf41b doing the same). Fixes: 4eb0475b5a00 ("gallivm/nir: add fsum support") Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Reviewed-by: Brian Paul <brianp@vmware.com> Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12066> (cherry picked from commit cac5711d433fa1519be101ad3dae1e1d53c9a55a)
2021-07-27freedreno/a6xx: Add missing PC_CCU_INVALIDATE_xRob Clark1-1/+1
The kernel normally inserts these between submits, but when we merge submits in userspace we need to add them ourselves. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5114 Fixes: cccdc513e3e ("freedreno/drm/sp: Implement deferred submit merging") Signed-off-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12049> (cherry picked from commit 53c39f710ffa86fbc1107002b818cb5ed8ddd1f0)
2021-07-27zink: use array size in spirv bo length calculationsMike Blumenkrantz1-1/+1
I don't know why I was dropping this, but doing so breaks drivers that have optimization passes based on the lengths of these variables Fixes: c1cdf30a119 ("zink: apply Delete All The Code methodology to the ubo/ssbo variables") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12070> (cherry picked from commit 1dc7b9b08b6a272693f85e956ec3c4e498823a65)
2021-07-27crocus/gen4: restrict memcpy mapping to gen5Dave Airlie1-1/+1
This is due to gen4 + 4.5 having some rather strange swizzling that we can't actually detect properly in userspace Fixes: f3630548f1da ("crocus: initial gallium driver for Intel gfx 4-7") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12058> (cherry picked from commit 5bf6ec31ccf6c24a407df9443a534f8036d26861)
2021-07-27.pick_status.json: Update to 49908c602ffd2d84063effa7ddd0ee842be41a89Dylan Baker1-0/+567
2021-07-26nv30: fix emulated vertex index buffersKarol Herbst1-1/+1
We ended up applying the offset twice. Quite embarrassing. This fixes a bunch of vertex shader related issues like the gnome desktop is less broken and probably a lot of other applications. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5061 Cc: mesa-stable Signed-off-by: Karol Herbst <kherbst@redhat.com> Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12054> (cherry picked from commit 1387d1d41103b3120d40f93f66a7cfe00304bfd7)
2021-07-26radv: allow unused VkSpecializationMapEntriesSamuel Pitoiset1-1/+1
Fixes future CTS: dEQP-VK.pipeline.spec_constant.*.basic.*unused_* Cc: 21.2 mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12062> (cherry picked from commit 0497588eac63e2b43ba2ff46f7edd103ba6fdf3c)
2021-07-26v3dv: assert job->cmd_buffer is validJuan A. Suarez Romero1-1/+1
In v3dv_write_uniforms_wg_offsets() function, the job's cmd_buffer is a valid command buffer, so there is no reason to check if its NULL or not. This fixes CID#1487441 ("Dereference after null check") error. v1: - `job->cmd_buffer` is the same as `cmd_buffer` (Alejandro) v2: - Use `cmd_buffer` instead of `job->cmd_buffer` (Iago) Fixes: 31a786c80ad ("v3dv: handle QUNIFORM_FB_LAYERS") Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11999> (cherry picked from commit 4eb0475b5a0047e368129550e4c07a450a233a74)
2021-07-26isl: fix mapping of format->stringnameLionel Landwerlin1-1/+1
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: ed6e586562f444 ("intel: properly constify isl_format_layouts") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5110 Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12051> (cherry picked from commit 8a99873712492067afa8b08c0436c2794a516884)
2021-07-26teximage: return correct desktop GL error for compressedteximageDave Airlie1-1/+1
For GL4.6 the spec says to return GL_INVALID_OPERATION for this. Cc: mesa-stable Reviewed-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12032> (cherry picked from commit 2138d1b9e630b4c481c9d1ff555fb77a71ef78cc)
2021-07-26agx: Plug memory leak in register allocatorAlyssa Rosenzweig1-1/+1
Fixes: 85e18deb18a ("agx: Assign registers locally") Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Reported-by: Coverity Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053> (cherry picked from commit 465224379c319dc42cc533ae53542cdf01dd7650) Conflicts: src/asahi/compiler/agx_register_allocate.c
2021-07-26agx: Fix mismatched units in load_uboAlyssa Rosenzweig1-1/+1
Fixes assertion failure in dEQP-GLES3.functional.ubo.single_basic_type.shared.highp_float_fragment Assertion failed: ((value & 1) == 0), function agx_print_sized, file ../src/asahi/compiler/agx_print.c, line 39. Fixes: 033d4d09fc7 ("agx: Implement load_ubo/kernel_input") Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053> (cherry picked from commit 5fb9159eb97e439e67145107b11512a66fe86cc8)
2021-07-26asahi: Fix sampler filtering flagAlyssa Rosenzweig1-1/+1
Typo in the XML. Fixes broken filtering. Still chasing an off-by-one. Fixes: cad54e2721d ("asahi: Add command buffer XML definitions") Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12053> (cherry picked from commit 23f5ad668f1220e905a6f35d947c04b126c457e0)
2021-07-26nir/lower_tex: Rework invalid implicit LOD loweringJason Ekstrand1-1/+1
Only fragment and some compute shaders support implicit derivatives. They're totally meaningless without helper invocations and some understanding of the dispatch pattern. We've got code to lower nir_texop_tex in these shader stages to use an explicit derivative of 0 but it was pretty badly broken: 1. It only handled nir_texop_tex, not nir_texop_txb or nir_texop_lod. 2. It didn't take min_lod into account 3. It was conflated with adding a missing LOD parameter to opcodes which expect one such as nir_texop_txf. While not really a bug, this does make it way harder to reason about the code. 4. Unless you set a flag (which most drivers don't), it left the opcode nir_texop_tex instead of nir_texop_txl which it should have been. This reworks it to go through roughly the same path as other LOD lowering only with a constant lod of 0 instead of calling out to nir_texop_lod. We also get rid of the lower_tex_without_implicit_lod flag because most drivers set it and those that don't are probably subtly broken. If someone really wants to get nir_texop_tex in their vertex shaders, they can write a new patch to add the flag back in. Fixes: e382890e25c0 "nir: set default lod to texture opcodes that..." Fixes: d5ac5d6e836f "nir: Add option to lower tex to txl when..." Reviewed-by: Connor Abbott <cwabbott0@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11775> (cherry picked from commit 74ec2b12be17a7796186b3100a5a6b208be45b23)
2021-07-26pan/mdg: Garbage collect silly quirkAlyssa Rosenzweig1-1/+1
As discussed with Jason and Connor, this is probably subtly broken on Mali T720. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Connor Abbott <cwabbott0@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11775> (cherry picked from commit f9442e46ff61c37358d5dc3fa49c6e4f474b4674)
2021-07-26targets/graw-xlib: Add missing dep_x11Alyssa Rosenzweig1-1/+1
Required to build Mesa on macOS with -Dbuild-tests=true -Dglx=gallium-xlib Without this change, the build fails with In file included from ../src/gallium/targets/graw-xlib/graw_xlib.c:8: ../src/gallium/include/frontend/xlibsw_api.h:5:10: fatal error: 'X11/Xlib.h' file not found #include <X11/Xlib.h> With `brew sh` X11 is found but linking fails due to `llvm-ar` missing in the path. That issue appears to be unrelated to this missing dependency. X11 is installed via XQuartz, so Homebrew should not be required. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Emma Anholt <emma@anholt.net> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12022> (cherry picked from commit 061508d3105a320514fa8415a418229ae5250a3e)
2021-07-26glsl: relax rule on varying matching for shaders older than 4.20Timothy Arceri1-1/+1
This expands on commit c54c42321ea5. See the code comment for full justifications. At the time of the previous commit Ian wanted to limit the relaxing of the rule to GLSL 3.30 as that was the highest version of shaders seen in the wild that were having trouble with the stricter rules. However since then I've found that the long standing issue with tess shaders failing to compile in the game 'Layers Of Fear' is due to this same issue. The game uses 4.10 shaders and also makes use of explicit varying locations, so here we relax the rule to 4.20 and make sure to apply the restriction to shaders using varyings with explicit locations also. Fixes: c54c42321ea5 ("glsl: relax rule on varying matching for shaders older than 4.00") Reviewed-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com> Reviewed-by: Matt Turner <mattst88@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11873> (cherry picked from commit 0e0633ca49425dbc869521cede6a82d2d91c8042)
2021-07-26draw/llvmpipe: multiply polygon offset units by 2Dave Airlie1-1/+1
I was trying to fix this test, but noticed brw_clip.c in i965 does a * 2 here, and it seems to fix this test as well. Fixes: dEQP-GLES2.functional.polygon_offset.default_displacement_with_units Fixes: f9e2c2432686 ("draw,llvmpipe,util: add depth bias calculation for arb_depth_buffer_float") Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12029> (cherry picked from commit 1e5a470b43fd1d72c3841a8759a4db38f366358a)
2021-07-26freedreno: Lock access to msm_pipe for RB object suballocation.Emma Anholt1-1/+1
Hopefully this fixes the flakes that have happened since the suballoc changes. Fixes: 737d4caa83a9 ("freedreno: Suballocate our long-lived ring objects.") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12002> (cherry picked from commit b1dbbc3dc1a763fff40e13de5dda4a227af4a583)
2021-07-26aco: don't create v_madmk_f32/v_madak_f32 from v_fma_legacy_f16Rhys Perry1-1/+1
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5105 Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12004> (cherry picked from commit 211d1dfd34499d57709c15d10bdadc514e9e13c2)
2021-07-26util: add workaround for Full BoreTimothy Arceri1-1/+1
Unfortunately I contacted the dev about this issue years ago and he made a fix, but it has never been released after all these years. This stops the screen from being completely black in game. CC: mesa-stable Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11941> (cherry picked from commit f3ec4a934d6a9776e6f67cd44565180c098a6846)
2021-07-26llvmpipe: add support for time elapsed queries.Dave Airlie1-1/+1
It turns out for QBO you really need to explicitly support time elapsed queries to avoid wierd interactions with the non-qbo query paths. Fixes: 506e51b8560f ("llvmpipe: initial query buffer object support. (v2)") Reviewed-by: Michel Dänzer <mdaenzer@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11946> (cherry picked from commit 2f5cd08ede0b9d445535d54beffcad0e5c4a62bb)
2021-07-26meson: allow egl_native_platform to be specifiedChia-I Wu1-1/+1
After commit f8dc22bf61c, it was no longer possible to have explicitly enabled platforms with surfaceless being the EGL native platform. This fixes that by adding -Degl-native-platform. Fixes: f8dc22bf61c ("meson: drop deprecated EGL platform build options") Signed-off-by: Chia-I Wu <olvaffe@gmail.com> Reviewed-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11992> (cherry picked from commit 47946855f19cc7d082fd59e090bb83f5d3930871)
2021-07-26egl/surfaceless: try kms_swrast before swrastChia-I Wu1-1/+1
Before commit f7e0cdcf1a5, we tried these in order - if (!ForceSoftware) surfaceless_probe_device(disp, false); - surfaceless_probe_device(disp, true); - surfaceless_probe_device_sw(disp); The commit changed it to - surfaceless_probe_device(disp, ForceSoftware); - surfaceless_probe_device_sw(disp); and broke 2D virtio-gpu and vgem when ForceSoftware is false. This commit restores the old behavior. Fixes: f7e0cdcf1a5 ("egl/surfaceless: simplify dri2_initialize_surfaceless()") Signed-off-by: Chia-I Wu <olvaffe@gmail.com> Reviewed-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11992> (cherry picked from commit 384181921c23fc7630b4a7d373f5b6755d20c8af)
2021-07-26.pick_status.json: Update to b45cddda183230232937387f91d009500b2372c9Dylan Baker1-0/+1260
2021-07-21nir/gcm: Clear out pass_flags before startingIan Romanick1-1/+1
With this pass enabled in Intel drivers, running shader-db on shaders/unity/38.shader_test resulted in Program received signal SIGSEGV, Segmentation fault. gcm_schedule_early_src (src=0x555555d45348, void_state=0x7fffffffba40) at ../../SOURCE/master/src/compiler/nir/nir_opt_gcm.c:297 297 if (info->early_block->index < src_info->early_block->index) (gdb) print src_info->early_block $1 = (nir_block *) 0x0 I tracked this down to an early exit from gcm_schedule_early_instr on the parent instruction because instr->pass_flags was 0x1c. That should be an impossible value for this pass, so I inferred that pass_flags must have dirt left from some previous pass. Fixes: 8dfe6f672f4 ("nir/GCM: Use pass_flags instead of bitsets for tracking visited/pinned") Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/597> (cherry picked from commit 436668874a1508edf127be16873c6811fe13a3e6)
2021-07-21aco: include <cstddef> in aco_util.hDaniel Schürmann1-1/+1
It's needed for ptrdiff. Fixes: 59fdaa1985f9269c40f0ca4704fbeb3fb05c4c2f ('aco: reorder and cleanup #includes') Closes: #5076 Reviewed-by: Tony Wasserka <tony.wasserka@gmx.de> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11947> (cherry picked from commit 1d8e9430d267d872941fe2af7c1336e58f089101)
2021-07-21egl/wayland: Allow EGLSurface to outlive wl_egl_windowDaniel Stone1-1/+1
According to the EGL spec, it is entirely valid for an EGLSurface to outlive the native_window it was created from, provided that SwapBuffers and MakeCurrent return EGL_BAD_NATIVE_WINDOW. We don't have any facility to error on MakeCurrent, so just make sure we can bundle on safely through rendering for now, then return EGL_BAD_NATIVE_WINDOW from SwapBuffers. Signed-off-by: Daniel Stone <daniels@collabora.com> Reviewed-by: Simon Ser <contact@emersion.fr> Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2251 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4902 Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11979> (cherry picked from commit 6455ab6e5ac5b1ad815d3e67e72d9adef7ffd21c)
2021-07-21egl/wayland: Error on invalid native windowDaniel Stone1-1/+1
We unconditionally require a wl_egl_window to be passed as the native window type, and do not permit a default window. The spec requires us to return EGL_BAD_NATIVE_WINDOW when doing this, rather than crashing. Further, if an EGLSurface has already been created for an existing native window, we are required to return EGL_BAD_ALLOC. Signed-off-by: Daniel Stone <daniels@collabora.com> Reviewed-by: Simon Ser <contact@emersion.fr> Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2251 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4902 Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11979> (cherry picked from commit 0e2464d26bace803aad575c117686412be82388a)
2021-07-21ci: actually run piglit tests with virglCorentin Noël1-1/+1
Make sure that the host is using llvmpipe while the guest is using virgl as driver. Note that the neverball/neverball.trace trace actually regressed in a way that the foreground is missing. Fixes: f1b952fa ("ci: Run tests inside Crosvm") Signed-off-by: Corentin Noël <corentin.noel@collabora.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11986> (cherry picked from commit 18fa8205063b5dc07d1e253806070ba008793e1b) Conflicts: src/gallium/drivers/virgl/ci/traces-virgl.yml
2021-07-21crocus/gen4-5: fix ff gs emit on VS vue map change.Dave Airlie1-1/+1
This should fix some texturing problems seen on gen4/5, I reproduced it with a minecraft.trace file Fixes: f3630548f1da ("crocus: initial gallium driver for Intel gfx 4-7") Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11993> (cherry picked from commit 8c6196e7e88a51a87f62d28e9f34197ff57cf5b8)
2021-07-21zink: Fix unused-variable warningMichel Zou1-1/+1
Fixes: 9b40fc48 Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11920> (cherry picked from commit 4c36224f95b61c71a79e00ddf8ef0f02dd1085eb)
2021-07-21broadcom/compiler: emit TMU flush before a jumpJuan A. Suarez Romero1-1/+1
Like in the case of emitting a block, process pending TMU operations before a jump is executed. Fixes dEQP-VK.graphicsfuzz.stable-binarysearch-tree-nested-if-and-conditional. Fixes: 197090a3fca ("broadcom/compiler: implement pipelining for general TMU operations") Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11971> (cherry picked from commit dc40157888a8825fe5c411f20029466c7c2f1d47)
2021-07-21st/mesa: always use PIPE_USAGE_STAGING for GL_MAP_READ_BIT usageMarek Olšák1-1/+1
This fixes CPU read performance. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5091 Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11974> (cherry picked from commit 54e1ec017d7852bfc4ba46b54c3ab516f96102f7)
2021-07-21radeonsi: Check aux_context on si_destroy_screen()Olivier Fourdan1-1/+1
The function radeonsi_screen_create_impl() tries to create the aux_context but doesn't actually check for the returned value from si_create_context(). Then, on si_destroy_screen() the aux_context is used without actually checking whether it's a thing or not. As a result, if for any reason si_create_context() failed, we shall crash in si_destroy_screen() with a NULL pointer dereference trying to access ((struct si_context *)sscreen->aux_context)->log. Simply check for aux_context not being NULL to avoid that crash. Cc: mesa-stable Signed-off-by: Olivier Fourdan <ofourdan@redhat.com> Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11948> (cherry picked from commit 5bfd1a7e19ec1c510c2ba4adadad98d78f712eaf)
2021-07-21mesa: fix bindless uniform samplers updatePierre-Eric Pelloux-Prayer1-1/+1
According to the comment below some extra magic is needed for bindless samplers, so don't do an early return in this case. Fixes: 736f1f70ab8 ("mesa: skip redundant uniform updates for glUniform") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4806 Reviewed-by: Marek Olšák <marek.olsak@amd.com> Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11930> (cherry picked from commit 8be61e8a9e49190593e0c90077a8ce100b5743de)
2021-07-21aco/optimizer: ensure to not erase high bits when propagating packed constantsDaniel Schürmann1-1/+1
Packed constants with non-zero values in the high half might have been propagated as 16 bit, dropping the high half. Cc: mesa-stable Closes: #5070 Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11954> (cherry picked from commit 9b1a296172df38561d650abf98ee2e1c77ac6fc2)
2021-07-21v3d/driconf: Expose non-MSAA texture limits for mutter and gnome-shellJose Maria Casanova Crespo1-1/+1
To enable dual 4k displays on mutter or gnome-shell under X11 we need to expose the non-MSAA texture limit as we did for Xorg at 60a64f028d75ad6 ("v3d: Use driconf to expose non-MSAA texture limits for Xorg.") https://gitlab.gnome.org/GNOME/mutter/-/issues/1874 Cc: 21.1 21.2 mesa-stable Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11926> (cherry picked from commit fd5fa73e6c8deeb8e09062e412d7d05fe57d0c59)
2021-07-21nv50/ir/nir: fix smem size for GLKarol Herbst1-1/+1
Originally I fixed the case where the nir itself has a shared mem size of 0, but the frontend (e.g. clover) set it to some other value. But st/mesa sets the shared mem size on the state object as well and we end up actually doubling the value in the driver as we set smemSize to the value from the state object before calling into the compiler. So just max the value instead. Fixes the compute_shader.shared-max CTS test. Fixes: dc667b1f192 ("nv50/ir/nir: fix smem size") Signed-off-by: Karol Herbst <kherbst@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11047> (cherry picked from commit ff55412f40a7d588e47e2c35d175aea0ac3cfe95)
2021-07-21softpipe/aniso: move DDQ calculation to after scaling.Dave Airlie1-1/+1
I've read the papers on EWA filters and it seems like the calculate DDQ = 2 * A after the scaling of A happens. This seems to make things less blurry and more like real aniso. Fixes: 2135aba8 ("softpipe: Constify variables") Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11917> (cherry picked from commit 57dcfb4e55346ee2d7e3da79e93a7d36a8a5ca17)
2021-07-21glsl: replace some C++ code with CTimothy Arceri1-1/+1
This replaces some new/delete uses with malloc/free. This is more consistent with most of the other glsl IR code but more importantly it allows the game "Battle Block Theater" to start working on some mesa drivers. The game overrides new and ends up throwing an assert and crashing when it sees this function calling new [0]. Note: The game still crashes with radeonsi due to similar conflicts with LLVM. CC: mesa-stable Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11907> (cherry picked from commit 749251391d967ce5450a6adfeb64cb773cce2508)
2021-07-21mesa: fix incorrect comment in draw_gallium_multimodeMarek Olšák1-1/+1
Fixes: 4566383ae4b ("gallium: move pipe_draw_info::index_bias to pipe_draw_start_count_bias") Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11939> (cherry picked from commit ed57666a5c10a601b89868fa986d9ef215b908ed)
2021-07-21util/foz: stop crashing on destroy if prepare hasn't been calledMike Blumenkrantz1-1/+1
Fixes: eca6bb9540d ("util/fossilize_db: add basic fossilize db util to read/write shader caches") Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11931> (cherry picked from commit 2850db0a9ef3751b1b3429d9b7e75ed22dc4e59e)
2021-07-21anv: fix feature/property/sizes reported for fragment shading rateIván Briano1-1/+1
Fixes: 790ff1ceac8 ("anv: fixup physical device properties of fragment shading rate") Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11897> (cherry picked from commit d27f7fa1b334f799bcb75d185bf359a4c5091572)