summaryrefslogtreecommitdiff
path: root/.gitlab-ci.yml
AgeCommit message (Collapse)AuthorFilesLines
2021-03-18CI: Try really hard to get updated Windows TLS certsDaniel Stone1-1/+1
Windows doesn't actually distribute a full TLS CA certificate store, but pulls them in over time with Windows Update. Try to prime it by manually pulling the certificates and installing them. This bumps the Windows tag to force a rebuild. Acked-by: Michel Dänzer <mdaenzer@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9618> (cherry picked from commit e6aacec9e101d6ce91513cb4cdf3361748d0f48e) Conflicts: .gitlab-ci.yml
2021-03-18CI: windows: Force using LLVM 12Benjamin Tissoires1-1/+1
LLVM is moving to the 13 release, but LLVM-SPIRV is still so in the past. Given that LLVM 12.0.0 is still not out (we are at 12.0.0-rc1 today), use the `release/12.x` branch for LLVM. We should also tag LLVM-SPIRV, but... it seems that they haven't caught up yet, so keep using the master branch, but add a note for a future committer. Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Reviewed-by: Daniel Stone <daniel@fooishbar.org> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8740> (cherry picked from commit 8deca5a72eaf0a014e52e446464be671454414ef)
2021-03-18CI: windows: split the layers to meet new registry requirementsBenjamin Tissoires1-1/+1
The new registry caching in place for registry.fd.o can not handle layers bigger than 5 GB. The last layer we used to build on windows was 5.2 GB, meaning that the upload would fail. Split the layers by calling multiple `RUN`, hoping that the size will be roughly split between those steps if we have a special layer for VS2019. Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Reviewed-by: Daniel Stone <daniel@fooishbar.org> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8740> (cherry picked from commit a69ab2ae3693fd817d6ba0d0345aca6931a6c5fd)
2021-03-18CI: windows: augment the timeout of building the windows containerBenjamin Tissoires1-1/+1
https://gitlab.freedesktop.org/mesa/mesa/-/jobs/6898838 failed at uploading the containers but got kicked out right before being able to give us a valid error. Bump the timeout for windows container builds, to not have this unfortunate situation. Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Reviewed-by: Daniel Stone <daniel@fooishbar.org> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8740> (cherry picked from commit 0ef1f418bb94d61cff76c4724b079059fb89906b)
2021-01-21ci: correct the trace image URLs in the piglit summaryAndres Gomez1-1/+1
Fixes: 09429fa85b6 ("ci: add piglit replay jobs and remove tracie ones") Signed-off-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8531> (cherry picked from commit 0773cd33c2bd14605eee471dd0dcc5306dd41cd4)
2021-01-12Revert "ci: Disable the freedreno farm, which went down last night."Eric Anholt1-19/+19
Networking broke on a reboot or something, fixed the broken setting and it's back up. This reverts commit ff67898dafaea82db669aef10ebb05e65eaa0921. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8454>
2021-01-10ci: Add a few more drivers to the cross buildsAdam Jackson1-10/+13
This is mostly to get additional -Werror coverage to avoid introducing unforced ILP32 or big-endian errors. i386 adds lavapipe, r600, nouveau, zink, and all the classic drivers. ppc64le adds lavapipe and zink, and also adds -Werror for symmetry with the other cross builds. s390x also adds lavapipe and zink. Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8394>
2021-01-08ci: Disable the freedreno farm, which went down last night.Eric Anholt1-19/+19
We're debugging it now, but let merges flow until then. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8395>
2021-01-06freedreno: Enable GLSL 3.30, updating us to GL 3.3 contextsDanylo Piliaiev1-1/+1
All necessary features are already supported. GL33 CTS failures: KHR-GL33.texture_swizzle.smoke - timeouts, passes otherwise KHR-GL33.cull_distance.coverage - see https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/2673 fix is not in the public repo yet. Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8270>
2021-01-04CI: Enable d3d12 driver for Linux CI buildsJesse Natalie1-3/+3
Acked-by: Daniel Stone <daniels@collabora.com> Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8251>
2021-01-04CI: Install DirectX-Headers package for x86 containerJesse Natalie1-1/+1
Acked-by: Daniel Stone <daniels@collabora.com> Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8251>
2021-01-02ci: Add a530 and a630 piglit runs.Eric Anholt1-0/+125
These bring a whole lot of new coverage to these drivers, since dEQP is bad at desktop GL feature coverage around early GL 3.x. piglit also gets at a lot of MSAA, fast clearing, and texture layout issues that dEQP doesn't do much with. Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7370>
2021-01-02ci/bare-metal: Pass through FDO_CI_CONCURRENT on bare-metal runners.Eric Anholt1-0/+1
I've set it up in the gitlab-runer config on all the freedreno boards. This means that for piglit, where the run.sh always choose either this variable or 4 threads otherwise, we'll have the right number of parallel tasks. Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7370>
2021-01-02ci/bare-metal: Drop extra DEQP_PARALLEL settings.Eric Anholt1-1/+0
The .baremetal_test sets DEQP_PARALLEL: 0 (number of CPUs), so existing DEQP tasks should already be auto-configured. This means we can drop a530's single-threaded overrides, since it's non-SMP. Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7370>
2021-01-02ci/bare-metal: build full piglit for baremetal ARM targets.Christian Gmeiner1-2/+2
ARM64 had it for traces only, upgrade it to a full build so we can test a630. We also add it for armhf, as we'll want it on both rpi and etnaviv. Bumped the LAVA tag as well, since the script changes a bit and it does impact the final image (even if we aren't pulling in full piglit there yet). Note I also had to drop the "v" on the tarring of their rootfs, as the verbosity on baremetal was exceeding job log size. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7370>
2021-01-02ci: build mesa with gbmChristian Gmeiner1-1/+1
We need gbm support for piglit. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7370>
2021-01-02ci: build ARM mesa with X11 OpenGL supportChristian Gmeiner1-7/+7
I want to run piglit with baremetal ci and for this opengl support is needed. Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7370>
2020-12-31ci/softpipe: Update the comment about the rasterpos flake.Eric Anholt1-1/+1
The noted fix landed, but a test fix was needed. Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8275>
2020-12-31ci/softpipe: Ban glx-multithread-texture, too.Eric Anholt1-0/+2
This one also flakes on us. Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8275>
2020-12-31ci/softpipe: Skip flaky triangle-rasterization-overdraw.Eric Anholt1-0/+2
It runs a different test each run based on current time, and fails occasionally. Until the test can get fixed, remove it. Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8275>
2020-12-30ci/softpipe: Re-enable GS tests that had been banned for being flaky.Eric Anholt1-2/+0
Now that the flakes should be fixed, turn the coverage on. Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8277>
2020-12-29freedreno: Enable GLSL 1.50, updating us to GL 3.2 contexts.Eric Anholt1-1/+1
We have been advertising 3.1, which waffle has issues creating contexts for, causing coverage (and performance!) issues in piglit. We should support all the necessary features already. Some new failures are caught by the 3.2 CTS, but they look like they're existing issues simply not covered by the minimal GL 3.0 CTS. Fixes: #3037 Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8255>
2020-12-27ci/softpipe: Include a piglit run.Eric Anholt1-0/+40
It's been regressed a couple of times recently, so let's try to make sure it doesn't happen again. The setup here is mostly like llvmpipe-quick-gl, but using quick_gl+quick_shader together, and a few more spectacularly long-running tests dropped. I also excluded a bunch of unsupported extensions, to minimize the size of the skip list checked into the tree (it's still 200k, though). The unfortunate exclusions in here are fp64 and int64 -- most of the piglit tests for them don't run because softpipe is still GL3.3, and it's an egregious number of skips to add to the checked in list. Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8068>
2020-12-27ci/piglit: Include the updated piglit results list in the job results.Eric Anholt1-0/+1
If you're standing up a new piglit CI, you're going to want it. Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8068>
2020-12-23ci/deqp: Upgrade the runner, enable junit output.Eric Anholt1-4/+9
I moved QPA-to-XML conversion to the runner, so Mesa CI (and developers!) don't need to do quite so much in bash. I also made it clean up caselist .qpa files since nobody ever wants them and we deleted them anyway. This cleans up a ton of the job log output. Additionally, I added a subcommend to turn the .csv into a junit output that we can expose to gitlab. Now, the pipeline's status page will report the failed testcases, and the "detail" button will give you a link to the .XML to view for the failure. (We don't report all testcases because it's too much load for the gitlab server). Note that this will 404 for the LAVA runners for now, as they don't retain artifacts in gitlab (the plan is to eventually have them minio upload the artifacts). This uprev also includes a deqp output parsing fix, resulting in us catching a couple more failures in some drivers. Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8206>
2020-12-23ci/deqp: Move .shader_cache artifacts exclusion to the yml.Eric Anholt1-0/+2
Less noise in the job log when we want to be highlighting deqp-runner's output. Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8206>
2020-12-22ci: add piglit job to baremetal and remove tracie onesAndres Gomez1-18/+18
v2: - Squashed the commit to remove tracie jobs (Eric). v3: - Rename *-piglit-traces jobs with *-traces (Eric). Signed-off-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6388>
2020-12-22ci: refactor arm64 jobs in preparation for piglit additionAndres Gomez1-27/+73
v2: - Rename the ".arm64-deqp-test-vk" template as ".arm64-deqp-test-freedreno-vk" (Eric). v3: - Rename the ".arm64-test" template as ".freedreno-test" (Eric). - Rename the ".arm64-deqp-test" template as ".baremetal-deqp-test" (Eric). - Rename the ".arm64-deqp-test-freedreno-vk" template as ".baremetal-deqp-test-freedreno-vk". Signed-off-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6388>
2020-12-22ci: build piglit inside baremetal and LAVA's rootfsAndres Gomez1-2/+2
v2: - Updated the ci-fairy commit to use. Signed-off-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6388>
2020-12-22ci: move API specification to driver instead of test suiteAndres Gomez1-17/+16
Signed-off-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6388>
2020-12-22ci: move general build commands to their own sectionAndres Gomez1-2/+2
The STRIP_CMD env var is used in several build scripts, not just by dEQP. Also, we want to have the rootfs destination directory created so it also exists for builds that only move directory trees in there. Signed-off-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6388>
2020-12-22ci: add Vulkan piglit traces jobs and remove tracie onesAndres Gomez1-41/+26
v2: - Rename *-piglit-traces jobs with *-traces. Signed-off-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> [v1] Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6388>
2020-12-22ci: add piglit replay jobs and remove tracie onesAndres Gomez1-37/+72
Along the way, modify the piglit run script and refactor the way piglit jobs are generated. v2: - Squashed the commit to remove tracie jobs (Eric). v3: - Extend information in the comments about the need to use a running X server for replaying with Vulkan (Tomeu). - Do actually fail if the upload doesn't work (Tomeu). v4: - Rename *-piglit-traces jobs with *-traces. Signed-off-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> [v3] Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6388>
2020-12-22ci: specify MinIO's host URL in a global variableAndres Gomez1-1/+2
Signed-off-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6388>
2020-12-22ci: build piglit in the Vulkan testing imageAndres Gomez1-1/+1
Signed-off-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6388>
2020-12-22ci: update piglit's version so it features replayerAndres Gomez1-2/+2
We also need that summary's aggregate command can use JUnit as backend, a cross-compilation fix for its CMakeList.txt, a fix for the JUnit backend and a small change in replayer's compare output. v2: - Updated the piglit commit so it features another couple of needed fixes. Signed-off-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> [v1] Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6388>
2020-12-22ci: spread the usage of the FDO_UPSTREAM_REPO variableAndres Gomez1-2/+2
Signed-off-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6388>
2020-12-22ci: install ci-fairy in the testing imagesAndres Gomez1-3/+3
v2: - Updated the ci-fairy commit to use. Signed-off-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6388>
2020-12-22ci: use ephemeral packages when building the build-base imageAndres Gomez1-6/+6
v2: - Update tag for the android_build image (Michel). Signed-off-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> [v1] Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6388>
2020-12-22ci: specify source and build directories with CMakeAndres Gomez1-5/+5
The -S and -B flags were officially introduced in CMake 3.13. Avoids the following warning: " CMake Warning: No source or binary directory provided. Both will be assumed to be the same as the current working directory, but note that this warning will become a fatal error in future CMake releases. " Signed-off-by: Andres Gomez <agomez@igalia.com> Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6388>
2020-12-21ci/deqp: Make sure that we pull in all board-specific xfail/skip/flake files.Eric Anholt1-27/+13
When introducing/removing these files, it's easy to forget to update the yml to point to them. Instead of requiring the separate update, just have the runner script pick the right one from a single per-gpu variable. As a result, we now pick up the new deqp-lvp-skips.txt that was added but not conected. This also required moving some bypass flakes from the shared a630 flakes list to a separate list, which is a feature because now we'd notice the introduction of flakes to the gmem path. Fixes: ab79e6b8e336 ("ci: skip failing test on lavapipe") Acked-by: Daniel Stone <daniels@collabora.com> Reviewed-by: Juan A. Suarez <jasuarez@igalia.com> Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8147>
2020-12-17ci/freedreno: Stop specifying the number of deqp threadsEric Anholt1-1/+1
For "0" (its default) deqp-runner picks a number of jobs corresponding to the CPU count, so set our hardware runners to use that (note that mesa's deqp-runner.sh will pick a default of 4 if we don't specify a DEQP_PARALLEL). This means we'll allocate threads for the slow cores on a630 now, reducing gles3 runtime from 6.5 minutes to around 5. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8132>
2020-12-17ci/freedreno: Treat all freedreno deqp runs as saving results.Eric Anholt1-3/+0
They've been doing so since the webdav results upload was added. This means that we'll get normal truncated failures lists with the pointer to the job artifacts, rather than filling a log file if you broke everything. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8132>
2020-12-17ci: Bump deqp to current vulkan-cts-1.2.5.0Juan A. Suarez Romero1-4/+5
This new version contains several fixes. v1 (Eric): - Rebuild fail list for freedreno and lavapipe - Move freedreno crashes to skip list Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3902 Reviewed-by: Eric Anholt <eric@anholt.net> Reviewed-by: Dave Airlie <airlied@redhat.com> Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8088>
2020-12-15CI: Add repeat-wait to Windows Piglit skipJesse Natalie1-1/+1
This test is flaky/racy due to an incorrect timeout value being used. See https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/433 Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8114>
2020-12-15ci: Add an ASan build on x86.Eric Anholt1-7/+15
I want to enable ASan runs on freedreno. It turns out it's a long road to get there, starting with making sure we can run our unit tests with the sanitizer enabled. While I'm revving this container, add in valgrind too to make sure that our build paths with valgrind enabled work. Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7936>
2020-12-11CI: Add Windows source dependency mapDaniel Stone1-0/+2
Now that we've soaked the Windows build in and it's working well, restrict it to only running on given pipelines, albeit in a somewhat surprising way. Signed-off-by: Daniel Stone <daniels@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8053>
2020-12-11CI: add lavapipe vulkan testingDave Airlie1-2/+13
Acked-by: Michel Dänzer <mdaenzer@redhat.com> Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7952>
2020-12-10ci: Make sure that osmesa stays warnings-clean in release builds.Eric Anholt1-2/+2
Reviewed-by: Eric Engestrom <eric@engestrom.ch> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1243>
2020-12-10mesa: Retire classic OSMesa.Eric Anholt1-20/+5
The classic OSMesa renders directly into user memory using src/mesa/swrast, while gallium OSMesa renders using softpipe or llvmpipe and copies out at glFlush() time. This would make gallium look like a worse choice for OSMesa, except that swrast is: 1) Painfully slow to render compared to llvmpipe 2) Incorrect at derivatives 3) Limited to GL 2.1 instead of GL 4.6 In my survey of OSMesa users, debian was the remaining holdout with classic OSMesa in use on hurd and some rare non-LLVM-supported architectures (sh4, alpha, etc.). As of today, they've switched to softpipe-based gallium OSMesa for them. To prevent people from running the wrong OSMesa (to the extent that running OSMesa can ever be the right thing), delete the classic version. Reviewed-by: Eric Engestrom <eric.engestrom@intel.com> Closes: #320 Closes: #877 Closes: #2297 Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1243>