diff options
| author | Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> | 2022-01-06 00:57:56 +0100 |
|---|---|---|
| committer | Eric Engestrom <eric@engestrom.ch> | 2022-01-12 19:54:25 +0000 |
| commit | 2cd9d700ac3ac575bd55b8a8b4695538975ad7a0 (patch) | |
| tree | 2cba4c6a50b8139745ba8fe6e8268a09aa6c5f59 | |
| parent | 08bea100a128ed7de9fb01767e0191418b03d094 (diff) | |
radv: Set optimal copy alignment to 1.
I think we set it to 128 for no reason at all. The app is still
required to align to the texel size.
Note that we prefer 4 bytes for non-formatted buffer->buffer copy,
but that isn't in scope for these properties according to the
Vulkan spec.
It also happens to help hide what looks like an application bug at
this point with Baldurs Gate 3.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5509
Cc: mesa-stable
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14415>
(cherry picked from commit 63101914f8879c37bd468781de1026e761ba6255)
| -rw-r--r-- | .pick_status.json | 2 | ||||
| -rw-r--r-- | src/amd/vulkan/radv_device.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/.pick_status.json b/.pick_status.json index 98580760c04..cc1f282bc91 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1786,7 +1786,7 @@ "description": "radv: Set optimal copy alignment to 1.", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null }, diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 258429ad95e..a69cccfe8bc 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -1791,8 +1791,8 @@ radv_GetPhysicalDeviceProperties(VkPhysicalDevice physicalDevice, .lineWidthGranularity = (1.0 / 8.0), .strictLines = false, /* FINISHME */ .standardSampleLocations = true, - .optimalBufferCopyOffsetAlignment = 128, - .optimalBufferCopyRowPitchAlignment = 128, + .optimalBufferCopyOffsetAlignment = 1, + .optimalBufferCopyRowPitchAlignment = 1, .nonCoherentAtomSize = 64, }; |