diff options
| author | Vinson Lee <vlee@freedesktop.org> | 2020-08-08 21:26:12 -0700 |
|---|---|---|
| committer | Dylan Baker <dylan.c.baker@intel.com> | 2020-08-12 10:12:26 -0700 |
| commit | 11edf2e35774499e2baf2e2c353964801506f967 (patch) | |
| tree | e6b4ecf5e00d15c9f0e9e89b6f1dbec6e0b8e690 | |
| parent | 6d14d91a808acd79c6fa7cb65efa1c24f6f06bbb (diff) | |
util: Fix memory leaks in unit test.
Fix warnings reported by Coverity Scan.
Resource leak (RESOURCE_LEAK)
leaked_storage: Variable bt1 going out of scope leaks the storage
it points to.
leaked_storage: Variable bt2 going out of scope leaks the storage
it points to.
Fixes: d0d14f3f6481 ("util: Add unit test for stack backtrace caputure")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6246>
(cherry picked from commit 96cfc684e63238a7aeabc8893fb04fe5f3781a66)
| -rw-r--r-- | .pick_status.json | 2 | ||||
| -rw-r--r-- | src/util/u_debug_stack_test.cpp | 3 |
2 files changed, 4 insertions, 1 deletions
diff --git a/.pick_status.json b/.pick_status.json index b99a9d46c74..ad8dd31bece 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -310,7 +310,7 @@ "description": "util: Fix memory leaks in unit test.", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "master_sha": null, "because_sha": "d0d14f3f6481e015b4413fa0487164b76fe45296" }, diff --git a/src/util/u_debug_stack_test.cpp b/src/util/u_debug_stack_test.cpp index b5f8ea4ba38..6add3e989b2 100644 --- a/src/util/u_debug_stack_test.cpp +++ b/src/util/u_debug_stack_test.cpp @@ -106,6 +106,9 @@ TEST(u_debug_stack_test, capture_not_overwritten) if (size > 0) { EXPECT_STRNE(bt1, bt2); } + + free(bt1); + free(bt2); } #endif |