diff options
| author | Mike Blumenkrantz <michael.blumenkrantz@gmail.com> | 2023-08-04 12:17:20 -0400 |
|---|---|---|
| committer | Dylan Baker <dylan.c.baker@intel.com> | 2023-08-31 23:30:45 -0700 |
| commit | 80f1e28d56deb10c3a5cd1183e539f151ff62377 (patch) | |
| tree | 7fa04431c14ebcf4bf5bbb5938a67a960a0e268f /.pick_status.json | |
| parent | b5330ce1d449c6404a9212cd3462657163112046 (diff) | |
zink: better handle separate shader dsl creation when no bindings exist
this otherwise underflows the array and provides a (probably huge) garbage
value for the binding id, which then causes the driver to massively overallocate
both the layout and set/pool/buffer
the main result of this is that on radv any simple test that should be near-instant
takes 2-3 seconds to execute, which somehow nobody noticed
Fixes: e3b746e3a31 ("zink: use GPL to handle (simple) separate shader objects")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24501>
(cherry picked from commit 652e87bc5d02903e4ea00602de84d803f10d414e)
Diffstat (limited to '.pick_status.json')
| -rw-r--r-- | .pick_status.json | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.pick_status.json b/.pick_status.json index d7556c226f1..5f06ede3adb 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -10514,7 +10514,7 @@ "description": "zink: better handle separate shader dsl creation when no bindings exist", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "e3b746e3a31e350e9f0962717e49acba28efee30", "notes": null |