diff options
author | David Tardon <dtardon@redhat.com> | 2018-03-25 16:30:08 +0200 |
---|---|---|
committer | David Tardon <dtardon@redhat.com> | 2018-03-25 16:35:38 +0200 |
commit | 160825ec6e25b3de6086479f856d14a6dcaaa60a (patch) | |
tree | da49ea5b348423cd73bbeb8e4dddbf19026ca8af | |
parent | e3f0216ba318fddbfab2b92159c363dced48082e (diff) |
use unique_ptr
Change-Id: I2677dfde71b049c287df2ea68d656b0ad63dc8df
-rw-r--r-- | src/lib/VDXParser.cpp | 12 | ||||
-rw-r--r-- | src/lib/VSD5Parser.cpp | 2 | ||||
-rw-r--r-- | src/lib/VSD6Parser.cpp | 2 | ||||
-rw-r--r-- | src/lib/VSDParser.cpp | 4 | ||||
-rw-r--r-- | src/lib/VSDStencils.cpp | 8 | ||||
-rw-r--r-- | src/lib/VSDStencils.h | 3 | ||||
-rw-r--r-- | src/lib/VSDXParser.cpp | 12 |
7 files changed, 20 insertions, 23 deletions
diff --git a/src/lib/VDXParser.cpp b/src/lib/VDXParser.cpp index bb7b9d3..72f78b9 100644 --- a/src/lib/VDXParser.cpp +++ b/src/lib/VDXParser.cpp @@ -488,7 +488,7 @@ void libvisio::VDXParser::readMisc(xmlTextReaderPtr reader) if (XML_READER_TYPE_ELEMENT == tokenType) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); readTriggerId(m_shape.m_xform1d->beginId, reader); } break; @@ -496,7 +496,7 @@ void libvisio::VDXParser::readMisc(xmlTextReaderPtr reader) if (XML_READER_TYPE_ELEMENT == tokenType) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); readTriggerId(m_shape.m_xform1d->endId, reader); } break; @@ -692,7 +692,7 @@ void libvisio::VDXParser::readXForm1D(xmlTextReaderPtr reader) if (XML_READER_TYPE_ELEMENT == tokenType) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); ret = readDoubleData(m_shape.m_xform1d->beginX, reader); } break; @@ -700,7 +700,7 @@ void libvisio::VDXParser::readXForm1D(xmlTextReaderPtr reader) if (XML_READER_TYPE_ELEMENT == tokenType) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); ret = readDoubleData(m_shape.m_xform1d->beginY, reader); } break; @@ -708,7 +708,7 @@ void libvisio::VDXParser::readXForm1D(xmlTextReaderPtr reader) if (XML_READER_TYPE_ELEMENT == tokenType) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); ret = readDoubleData(m_shape.m_xform1d->endX, reader); } break; @@ -716,7 +716,7 @@ void libvisio::VDXParser::readXForm1D(xmlTextReaderPtr reader) if (XML_READER_TYPE_ELEMENT == tokenType) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); ret = readDoubleData(m_shape.m_xform1d->endY, reader); } break; diff --git a/src/lib/VSD5Parser.cpp b/src/lib/VSD5Parser.cpp index 4caa901..50b3324 100644 --- a/src/lib/VSD5Parser.cpp +++ b/src/lib/VSD5Parser.cpp @@ -497,7 +497,7 @@ void libvisio::VSD5Parser::readMisc(librevenge::RVNGInputStream *input) void libvisio::VSD5Parser::readXForm1D(librevenge::RVNGInputStream *input) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); input->seek(1, librevenge::RVNG_SEEK_CUR); m_shape.m_xform1d->beginX = readDouble(input); input->seek(1, librevenge::RVNG_SEEK_CUR); diff --git a/src/lib/VSD6Parser.cpp b/src/lib/VSD6Parser.cpp index 745de2f..ea3be55 100644 --- a/src/lib/VSD6Parser.cpp +++ b/src/lib/VSD6Parser.cpp @@ -430,7 +430,7 @@ void libvisio::VSD6Parser::readMisc(librevenge::RVNGInputStream *input) if (0x40000073 == readU32(input)) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); if (m_shape.m_xform1d->beginId == MINUS_ONE) m_shape.m_xform1d->beginId = shapeId; else if (m_shape.m_xform1d->endId == MINUS_ONE) diff --git a/src/lib/VSDParser.cpp b/src/lib/VSDParser.cpp index 6bf380a..61e5f38 100644 --- a/src/lib/VSDParser.cpp +++ b/src/lib/VSDParser.cpp @@ -1154,7 +1154,7 @@ void libvisio::VSDParser::readXFormData(librevenge::RVNGInputStream *input) void libvisio::VSDParser::readXForm1D(librevenge::RVNGInputStream *input) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); input->seek(1, librevenge::RVNG_SEEK_CUR); m_shape.m_xform1d->beginX = readDouble(input); input->seek(1, librevenge::RVNG_SEEK_CUR); @@ -2268,7 +2268,7 @@ void libvisio::VSDParser::readMisc(librevenge::RVNGInputStream *input) if (0x40000073 == readU32(input)) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); if (m_shape.m_xform1d->beginId == MINUS_ONE) m_shape.m_xform1d->beginId = shapeId; else if (m_shape.m_xform1d->endId == MINUS_ONE) diff --git a/src/lib/VSDStencils.cpp b/src/lib/VSDStencils.cpp index 91865bd..2243c53 100644 --- a/src/lib/VSDStencils.cpp +++ b/src/lib/VSDStencils.cpp @@ -16,7 +16,7 @@ libvisio::VSDShape::VSDShape() m_textStyleId(MINUS_ONE), m_lineStyle(), m_fillStyle(), m_textBlockStyle(), m_charStyle(), m_charList(), m_paraStyle(), m_paraList(), m_tabSets(), m_text(), m_names(), m_textFormat(libvisio::VSD_TEXT_UTF16), m_nurbsData(), m_polylineData(), m_xform(), m_txtxform(nullptr), - m_xform1d(nullptr), m_misc(), m_layerMem() + m_xform1d(), m_misc(), m_layerMem() { } @@ -74,9 +74,7 @@ libvisio::VSDShape &libvisio::VSDShape::operator=(const libvisio::VSDShape &shap if (m_txtxform) delete m_txtxform; m_txtxform = shape.m_txtxform ? new XForm(*(shape.m_txtxform)) : nullptr; - if (m_xform1d) - delete m_xform1d; - m_xform1d = shape.m_xform1d ? new XForm1D(*(shape.m_xform1d)) : nullptr; + m_xform1d.reset(shape.m_xform1d ? new XForm1D(*shape.m_xform1d) : nullptr); m_misc = shape.m_misc; m_layerMem = shape.m_layerMem; } @@ -91,8 +89,6 @@ void libvisio::VSDShape::clear() if (m_txtxform) delete m_txtxform; m_txtxform = nullptr; - if (m_xform1d) - delete m_xform1d; m_xform1d = nullptr; m_geometries.clear(); diff --git a/src/lib/VSDStencils.h b/src/lib/VSDStencils.h index 1b0a464..5beedf9 100644 --- a/src/lib/VSDStencils.h +++ b/src/lib/VSDStencils.h @@ -11,6 +11,7 @@ #define __VSDSTENCILS_H__ #include <map> +#include <memory> #include <vector> #include "VSDStyles.h" #include "VSDGeometryList.h" @@ -53,7 +54,7 @@ public: std::map<unsigned, PolylineData> m_polylineData; XForm m_xform; XForm *m_txtxform; - XForm1D *m_xform1d; + std::unique_ptr<XForm1D> m_xform1d; VSDMisc m_misc; VSDName m_layerMem; }; diff --git a/src/lib/VSDXParser.cpp b/src/lib/VSDXParser.cpp index 10a6081..e6385d8 100644 --- a/src/lib/VSDXParser.cpp +++ b/src/lib/VSDXParser.cpp @@ -1050,7 +1050,7 @@ void libvisio::VSDXParser::readShapeProperties(xmlTextReaderPtr reader) if (XML_READER_TYPE_ELEMENT == tokenType) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); ret = readDoubleData(m_shape.m_xform1d->beginX, reader); } break; @@ -1058,7 +1058,7 @@ void libvisio::VSDXParser::readShapeProperties(xmlTextReaderPtr reader) if (XML_READER_TYPE_ELEMENT == tokenType) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); ret = readDoubleData(m_shape.m_xform1d->beginY, reader); } break; @@ -1066,7 +1066,7 @@ void libvisio::VSDXParser::readShapeProperties(xmlTextReaderPtr reader) if (XML_READER_TYPE_ELEMENT == tokenType) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); readTriggerId(m_shape.m_xform1d->beginId, reader); } break; @@ -1074,7 +1074,7 @@ void libvisio::VSDXParser::readShapeProperties(xmlTextReaderPtr reader) if (XML_READER_TYPE_ELEMENT == tokenType) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); readTriggerId(m_shape.m_xform1d->endId, reader); } break; @@ -1082,7 +1082,7 @@ void libvisio::VSDXParser::readShapeProperties(xmlTextReaderPtr reader) if (XML_READER_TYPE_ELEMENT == tokenType) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); ret = readDoubleData(m_shape.m_xform1d->endX, reader); } break; @@ -1090,7 +1090,7 @@ void libvisio::VSDXParser::readShapeProperties(xmlTextReaderPtr reader) if (XML_READER_TYPE_ELEMENT == tokenType) { if (!m_shape.m_xform1d) - m_shape.m_xform1d = new XForm1D(); + m_shape.m_xform1d = make_unique<XForm1D>(); ret = readDoubleData(m_shape.m_xform1d->endY, reader); } break; |