1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include "sal/config.h"
#include "config_clang.h"
#include "com/sun/star/uno/Sequence.hxx"
#include "com/sun/star/uno/XInterface.hpp"
#include "com/sun/star/io/XStreamListener.hpp"
#include "com/sun/star/io/XInputStream.hpp"
#include "com/sun/star/lang/XTypeProvider.hpp"
#include "com/sun/star/lang/XComponent.hpp"
#include "cppuhelper/implbase.hxx"
#include "cppuhelper/weak.hxx"
#include "rtl/ref.hxx"
void test1(const css::uno::Reference<css::io::XStreamListener>& a)
{
// expected-error@+1 {{the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]}}
css::uno::Reference<css::lang::XEventListener> b(a, css::uno::UNO_QUERY);
// expected-error@+1 {{the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]}}
auto c = css::uno::Reference<css::lang::XEventListener>::query(a);
}
namespace test2
{
css::uno::Reference<css::io::XStreamListener> getListener();
void test()
{
// expected-error@+1 {{the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]}}
css::uno::Reference<css::lang::XEventListener> b(getListener(), css::uno::UNO_QUERY);
}
}
namespace test3
{
void callListener(css::uno::Reference<css::uno::XInterface> const&);
void test(css::uno::Reference<css::io::XStreamListener> const& l)
{
// expected-error@+1 {{the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]}}
callListener(css::uno::Reference<css::lang::XEventListener>(l, css::uno::UNO_QUERY));
}
}
void test4(const css::uno::Reference<css::io::XStreamListener>& a)
{
// no warning expected, used to reject null references
css::uno::Reference<css::lang::XEventListener> b(a, css::uno::UNO_SET_THROW);
}
// no warning expected
namespace test5
{
void test(css::uno::Reference<css::io::XStreamListener> l)
{
css::uno::Reference<css::uno::XInterface> a = l;
}
}
namespace test6
{
void test(css::uno::Reference<css::io::XStreamListener> l)
{
css::uno::Reference<css::lang::XEventListener> a;
// expected-error@+1 {{the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]}}
a.set(l, css::uno::UNO_QUERY);
}
}
namespace test7
{
void test(css::uno::Reference<css::io::XStreamListener> l)
{
// expected-error@+1 {{unnecessary get() call [loplugin:referencecasting]}}
css::uno::Reference<css::lang::XEventListener> a(l.get(), css::uno::UNO_QUERY);
// expected-error@+1 {{unnecessary get() call [loplugin:referencecasting]}}
a.set(l.get(), css::uno::UNO_QUERY);
}
class FooStream : public css::io::XStreamListener
{
virtual ~FooStream();
};
void test(rtl::Reference<FooStream> l)
{
// expected-error@+1 {{unnecessary get() call [loplugin:referencecasting]}}
css::uno::Reference<css::io::XStreamListener> a(l.get());
// expected-error@+1 {{the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]}}
a.set(l.get(), css::uno::UNO_QUERY);
// expected-error@+1 {{unnecessary get() call [loplugin:referencecasting]}}
a.set(l.get());
// expected-error@+1 {{the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]}}
css::uno::Reference<css::io::XStreamListener> b(l.get(), css::uno::UNO_QUERY);
// no warning expected
css::uno::Reference<css::lang::XTypeProvider> c(l.get(), css::uno::UNO_QUERY);
// no warning expected
css::uno::Reference<css::io::XStreamListener> a2 = l;
(void)a2;
}
// not should about the exact version I should use here,
// clang 7.0.1 visits the CXXConstructorExpr inside the initializer, while clang 11 does not
#if CLANG_VERSION >= 80000
css::uno::Sequence<css::uno::Reference<css::io::XStreamListener>> getContinuations()
{
rtl::Reference<FooStream> noel1;
// expected-error@+1 {{unnecessary get() call [loplugin:referencecasting]}}
return { noel1.get() };
}
#endif
}
namespace test8
{
void test(css::io::XStreamListener* l)
{
// expected-error@+1 {{the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]}}
css::uno::Reference<css::lang::XEventListener> a(l, css::uno::UNO_QUERY);
// expected-error@+1 {{the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]}}
a.set(l, css::uno::UNO_QUERY);
}
}
// check for looking through casts
namespace test9
{
class StatusbarController : public css::io::XStreamListener, public ::cppu::OWeakObject
{
};
void test(StatusbarController* pController)
{
css::uno::Reference<css::io::XStreamListener> xController;
// expected-error@+1 {{the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]}}
xController.set(static_cast<::cppu::OWeakObject*>(pController), css::uno::UNO_QUERY);
}
}
// no warning expected when we have an ambiguous base
namespace test10
{
class Foo : public css::lang::XTypeProvider, public css::lang::XComponent
{
virtual ~Foo();
void bar()
{
css::uno::Reference<css::lang::XEventListener> xSource(
static_cast<css::lang::XTypeProvider*>(this), css::uno::UNO_QUERY);
}
};
}
// no warning expected for SAL_NO_ACQUIRE
namespace test11
{
void test(css::io::XStreamListener* l)
{
css::uno::Reference<css::lang::XEventListener> a(l, SAL_NO_ACQUIRE);
a.set(l, SAL_NO_ACQUIRE);
}
}
// no warning expected: querying for XInterface (instead of doing an upcast) has special semantics,
// to check for UNO object equivalence.
void test12(const css::uno::Reference<css::io::XStreamListener>& a)
{
css::uno::Reference<css::uno::XInterface> b(a, css::uno::UNO_QUERY);
}
// no warning expected: querying for XInterface (instead of doing an upcast) has special semantics,
// to check for UNO object equivalence.
struct Test13
{
css::uno::Reference<css::uno::XInterface> m_xNormalizedIFace;
void newObject(const css::uno::Reference<css::uno::XInterface>& _rxIFace)
{
m_xNormalizedIFace.set(_rxIFace, css::uno::UNO_QUERY);
}
};
void test14(css::uno::Sequence<css::uno::Reference<css::io::XStreamListener>> seq)
{
for (sal_Int32 i = 0; i < seq.getLength(); ++i)
{
// expected-error@+1 {{the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]}}
css::uno::Reference<css::io::XStreamListener> xDataSeries(seq[i], css::uno::UNO_QUERY);
}
}
namespace test15
{
class Foo : public cppu::WeakImplHelper<css::lang::XComponent, css::io::XInputStream>
{
virtual ~Foo();
css::uno::Reference<css::lang::XTypeProvider> bar()
{
// expected-error@+1 {{the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]}}
return css::uno::Reference<css::lang::XTypeProvider>(
static_cast<css::lang::XTypeProvider*>(this), css::uno::UNO_QUERY);
}
css::uno::Reference<css::io::XInputStream> bar2()
{
// expected-error@+1 {{the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]}}
return css::uno::Reference<css::io::XInputStream>(static_cast<css::io::XInputStream*>(this),
css::uno::UNO_QUERY);
}
};
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|
