summaryrefslogtreecommitdiff
path: root/xmloff
AgeCommit message (Collapse)AuthorFilesLines
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann28-83/+3
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-11coverity#735353 Unchecked return valueCaolán McNamara1-7/+13
Change-Id: Iab54019d07ac27b4d8247d789c29165d24e2288f
2014-10-11coverity#704113 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: If6537d84953c67801bc1959e17dd3662cd1face7
2014-10-10typo: follwing -> followingAndras Timar1-1/+1
Change-Id: Ia201473c84dc0923e8f4bee6329ad926cd6addd6
2014-10-10UBSan runtime error: division by zeroStephan Bergmann1-1/+3
...triggered by CppunitTest_sw_ooxmlexport. Though it iss unclear to me what is the best fix in this case, emit a style:legend-expansion-aspect-ratio value of 1, emit a style:legend-expansion value of "custom" without an accompanying style:legend-expansion-aspect-ratio (if that is even valid), emit another style:legend-expansion value, or emit no style:legend-expansion attribute (if that is even valid)? Change-Id: I36afe35082a841974bb2480fe11a7a3dd815ddf0
2014-10-08back out even more wrong tools::Time changes, geez..Eike Rathke1-4/+4
Change-Id: I52eb3400769999d7f554c3bdb8746f65b7990388
2014-10-08spelling: instanciated -> instantiatedNoel Grandin1-2/+2
Change-Id: I99f3010e30f81786b938dc11736ea1597cd5530d
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara1-2/+2
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-04sw textboxes: reimplement ODF import/exportMiklos Vajna3-13/+41
Turns out that for normal TextFrames and rectangular drawinglayer shapes, the engine is written in ODF implicitly. Use the same trick to describe if the shape content should be rendered by SW or editeng. This reverts 9d310ecfce3c2fc481b125e1493a534e2107a68e (sw textboxes: implement ODF import/export, 2014-06-02). Change-Id: Id8afa6368bedcd293e578244abb58e18949bec8d
2014-10-04coverity#1242759 Result is not floating-pointNorbert Thiebaud1-1/+1
Change-Id: I3a358722279d574f96a2270b5dee84b85ddb402f
2014-10-03rename SvRef::AddRef to AddFirstRefNoel Grandin12-17/+17
to make it's intended purpose clearly distinguishable from AddNextRef Change-Id: I5da780b48b19fd873667b648031bc394113f953b Reviewed-on: https://gerrit.libreoffice.org/11763 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01loplugin: cstylecastNoel Grandin28-156/+156
Change-Id: I25b82a96aace448a8debe90c181b22976ea95414
2014-10-01fdo#82577: Handle TimeNoel Grandin7-32/+34
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30fdo#82577: Handle PolyPolygonNoel Grandin2-6/+6
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows PolyPolygon typedef. Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30xmloff: std::auto_ptr -> std::unique_ptrStephan Bergmann6-29/+15
Change-Id: I8baa6c0573af3629bacbf1891c3196c165883d9e
2014-09-30WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'Tor Lillqvist1-2/+2
Change-Id: Ibcb6abe7162197dec35f4626f158448ff538542f
2014-09-29fdo#79269: fix ODF import of style:footer-firstMichael Stahl1-2/+6
The implementation of SwXStyle's FirstIsShared property is busted, and that causes xmloff to write the footer-first content into the master footer. Change-Id: I520a4929d9d7313da65bcdcf4094f8244382377d
2014-09-29Resolves: fdo#80468 and fdo#81223 image/frame backgrounds wrongCaolán McNamara1-14/+1
writer has code to fill in missing new properties from the old properties if they exist. But xmloff is stripping them out before they get there. Don't strip them out, and add in a missing check for one of the archaic bg colors and add a regression test for fdo#81223 Change-Id: I9a541a9bee0a01c90f2c33383f1144ecd8b0bfff
2014-09-25assert that XMLTransformerBase::m_xHandler is initializedMichael Stahl1-0/+2
Just seen a test with a null m_xHandler, no idea how that happened. Change-Id: I2e5ff9d3c799284beea5fdca37fa8a825f8a4756
2014-09-23loplugin: cstylecast, update PTR_CAST macro to use static_castNoel Grandin4-12/+12
I introduce a template method into the PTR_CAST machinery to maintain constness. There is now a FIXME in sd/../docshell.cxx because I needed to use a dynamic_cast there to work around the games it appears to be playing with OLE in-place activation. Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, dropping the GCC-extension, unnecessary use of typeof from tools/rtti.hxx Change-Id: Iba5ace1aa27e02b34fcc91af1e658c43371afd03
2014-09-18fdo#83512 Make use of OUStringHash and OStringHashDaniel Sikeler1-1/+1
Change-Id: I33cafe68c798e3d54943ea1790fa4e73f85e525d Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-15xmloff: sal_Bool -> boolStephan Bergmann6-11/+11
Change-Id: Ic1e599568ece7e6bba354845a6cf85fa090e67bd
2014-09-12xmloff: remove yet another SunStudio workaroundMichael Stahl1-8/+1
Change-Id: Ic9ec167d921c4c5f08914476bdbdd6a31a9391c1
2014-09-11Avoid ODR-violating name clashStephan Bergmann1-0/+4
Change-Id: I69c3b11b01d520a485b07c8e5397a7f971210af2
2014-09-11Avoid ODR-violating name clashStephan Bergmann2-0/+8
Change-Id: I4911dcb5d902a5b92d4c175054acd220e449459d
2014-08-22Remove some useless tools/debug.hxx includesMarcos Paulo de Souza18-21/+2
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h header was necessary in some cases because of a macro or a typedef that was needed. Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9 Reviewed-on: https://gerrit.libreoffice.org/11075 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-20xmloff: dead code gives MSVC fitsMichael Stahl1-30/+0
Change-Id: I1aaaaae4a38fb828e6801e444b6345fd8b60f5c1
2014-08-20ODF export: don't write invalid "group-name" attributeMichael Stahl2-6/+4
Radio buttons are grouped via their "form:name" attribute already. Change-Id: I9f8b27a2904d947c3d4665495d36961e3e41d2c6
2014-08-16prevent invalid ods files with loext:fill-characterMarkus Mohrhard2-4/+5
ODF specifies that extension elements in a document are removed before the validation. With our old implementation of the number format export this could result in two number:text elements following each other. According to the spec a number:text element may not follow another number:text element. The number:text element before loext:fill is actually not that interesting so it makes more sense to make this one an extension element. Possible documents showing issues: fdo45268-1.xlsx fdo49150-1.xlsx and many more Change-Id: I3ad92b8a61a246b3dbc0132d9a2c367488a766d0
2014-08-16just use a typedef, don't inherit from boost::ptr_containerMarkus Mohrhard1-2/+0
Change-Id: I1a63802dfeb702f6f6e9506339fd299b98fd8604
2014-08-13update_pchThomas Arnhold1-0/+1
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-12fdo#82165: ODF import: clear all shapes when removing header contentMichael Stahl1-2/+11
Shapes anchored to the first or last paragraph survive setString("") so need to be deleted with some ruse. (regression from b8499fc3dcf474050f026b8d5cd1d9037bbe42b7) Change-Id: I00a8132583c45d1953c207932cc7f02f3065ae77
2014-08-11-Werror,-Wundefined-bool-conversionStephan Bergmann22-40/+40
Change-Id: Icf4a55f7e76a723014a7b8b5f6b9350db7370dd9
2014-08-07fdo#75757: remove inheritance to std::mapTakeshi Abe1-7/+10
Change-Id: I2fd0b43c62c331d866d697c94dd57d17f903111b Reviewed-on: https://gerrit.libreoffice.org/10810 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-05fdo#75757: remove inheritance to std::vectorTakeshi Abe5-15/+5
typedefs just work. Change-Id: Ib91c0d4c383b5efac1ad9b93e574dec62e8234a4 Reviewed-on: https://gerrit.libreoffice.org/10754 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-05fdo#75757: remove inheritance to std::vectorTakeshi Abe1-2/+0
Typedef'ing SvxXMLListStyle_Impl is enough. Change-Id: I281766822aea60794510c959581f0b821aea6642 Reviewed-on: https://gerrit.libreoffice.org/10729 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-07-31cleanup usage of MapUnit enumNoel Grandin1-4/+4
some places were using the wrong enum constant, and some places were unnnecessarily converting to sal_Int16 Change-Id: I754993533c840cd33106820d99af2dc951f26a80
2014-07-31fix some dodgy FieldUnit conversionsNoel Grandin2-2/+8
the FieldUnit enum was being converted in some dodgy ways and in some places the MapUnit enum values were being used. Change-Id: Ic9aacb84058d1c14c3a4a79ef6676082df9a7270
2014-07-29Fix previous commitStephan Bergmann1-1/+1
Change-Id: Ia6437852a5ecd208510af20915bc982d1014458d
2014-07-29loplugin:stringconcatStephan Bergmann1-1/+1
Change-Id: Iaa5df366118b8766b47e7bd4e9875c44c0e5d8d9
2014-07-29Further OUString cleanup in xmloff/Joren De Cuyper5-181/+105
Change-Id: Ic749119931db569bf26c8d8a58da7d468811f927 Reviewed-on: https://gerrit.libreoffice.org/10598 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-07-26bnc#885825: Handle ODF import and export of data label border properties.Kohei Yoshida3-0/+32
Change-Id: Ic8c7bc873768008537cd52a3fd4b11031b403139
2014-07-25Simplify.Kohei Yoshida1-5/+2
Change-Id: Id7826839a6177532bb4c3885e798ac5feb95eaca
2014-07-25Reduce scope levels.Kohei Yoshida1-172/+172
Change-Id: I64684a80c79c3c7f5a8f23b07703fbcee3fe5887
2014-07-25pImplize XMLPropertyHandlerFactory.Kohei Yoshida3-6/+23
Change-Id: Iff524c9065e9374b39db998e3860704555130995
2014-07-25Store the handler as a const pointer.Kohei Yoshida1-3/+3
Handlers are conceptually stateless; we can keep them as const objects. Change-Id: I3d35ab0695037632e82f67f901c9795adf9bdd8d
2014-07-25The 'mutable' keyword exists for this kind of use.Kohei Yoshida1-3/+1
Change-Id: Ic52192f53039b7f1b4529a93c13de74c5f54e7f8
2014-07-25Document what's in the type of the map entry.Kohei Yoshida2-2/+2
And organize xmltypes.hxx a bit to make it easier to follow. Also rename MID_FLAG_PROPERTY_MAY_EXCEPT to MID_FLAG_PROPERTY_MAY_THROW. Change-Id: If18f07159a613555cf031bea5e07c04c7c45abec
2014-07-25Apply pimpl to XMLPropertySetMapper.Kohei Yoshida26-48/+197
Let's hide its implementation for real this time. Change-Id: I18c82f4969f2e3560536a68e9bbd86b9282e2ace
2014-07-23Resolves: #i125289# do apply possible changed <GraphicStreamURL>...Oliver-Rainer Wittmann1-13/+19
only for embedded images which already have its stream inside the package fixes also issue 125290 (cherry picked from commit 9602a121b458e7456fc533dad86f434f846a72ba) Conflicts: xmloff/source/draw/shapeexport2.cxx Change-Id: I5af0093b20f2f291d3a94c690bfbdb59a59320c3
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 07:43:12 +0000