summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)AuthorFilesLines
2018-03-26tdf#112343 Port ScreenSaverInhibitor to GDBusArkadiy Illarionov1-90/+90
Change-Id: I4f2f15931612191cc2557bb56abc4a8f8f1342bc Reviewed-on: https://gerrit.libreoffice.org/51816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-26use boost::optional in OutDevStateNoel Grandin1-17/+9
Change-Id: I83fb85fcba6cd2a5dc4f99fdfd3238d72afb7bc2 Reviewed-on: https://gerrit.libreoffice.org/51770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-26replace SalColor with ColorNoel Grandin57-513/+492
Change-Id: I615640a378a61cf6e44e84a647ce06bdd8a52807 Reviewed-on: https://gerrit.libreoffice.org/51239 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-25provide a route to weld accessibilityCaolán McNamara2-7/+56
Change-Id: I92e88a4356cb8e4bd958fd86d33c52f5be82be54 Reviewed-on: https://gerrit.libreoffice.org/51787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-25tdf#116509 OpenGL: Slideshows with Transitions crashing ImpressNoel Grandin1-1/+1
regression from commit e5012e53b919ae4921d6d35660bde323a6f28417 use scanline when reading pixel data Change-Id: I1980a1acfedadbea706b93aed7452790e03257f2 Reviewed-on: https://gerrit.libreoffice.org/51803 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-24hook up focus eventsCaolán McNamara2-0/+66
Change-Id: I9f5835e86550bd3d728936e5525262697e01e5fc Reviewed-on: https://gerrit.libreoffice.org/51786 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-23use boost::optional in vclNoel Grandin11-65/+46
instead of allocating small objects on the heap via std::unique_ptr Change-Id: Iba1d9ad90dc5a31908027336f85046a9de6f5bc4 Reviewed-on: https://gerrit.libreoffice.org/51769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23add set editable supportCaolán McNamara2-0/+10
Change-Id: I4ec9d3de426f760c38600d4960e2d37a3be8a9bb Reviewed-on: https://gerrit.libreoffice.org/51768 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-22Fix typoAndrea Gelmini1-1/+1
Change-Id: I11e9d7c3e26a7be5e9f251d6c5ea099914cb5392 Reviewed-on: https://gerrit.libreoffice.org/51716 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-22move btndlg from vcl to toolkitCaolán McNamara2-364/+0
Change-Id: Iecc528bce1df9a67af43f9d9dd3ed41af24b0fad Reviewed-on: https://gerrit.libreoffice.org/51713 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21block buttons with click handlers from setting a responseCaolán McNamara1-7/+49
which is effectively what vcl buttons do Change-Id: Ic4374b3a761b954548ff10d654422d14ef6e0763 Reviewed-on: https://gerrit.libreoffice.org/51710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21add get_widget_for_response supportCaolán McNamara3-0/+54
Change-Id: I49abb5e6621dbfe2fc92ef9c2a47568c62c372c2 Reviewed-on: https://gerrit.libreoffice.org/51709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21tdf#115117: Fix PDF ToUnicode CMAP for ligaturesKhaled Hosny6-38/+277
Move the glyph to character(s) mapping to CommonSalLayout where we have enough information to do this properly. This correctly handles ligatures at end of run that wasn’t handled before, and also fixes a bug in the PDF writer code when there is more than one ligature in the run (it forgot to clear aCodeUnitsPerGlyph vector after each iteration). Also drop the “temporary” fix for rotated glyph from 2009 that does not seem to be needed now (the document from that bug exports correctly after this change). Change-Id: I5b5b1f4470bbd0ef05cbbc86dfa29d2ff51249ea Reviewed-on: https://gerrit.libreoffice.org/51617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-21add optional helpid to add_buttonCaolán McNamara2-3/+6
Change-Id: I9606d0788c78397feb0840463991c5498e759b5a Reviewed-on: https://gerrit.libreoffice.org/51703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-21Don't initialize data for --enable-dbgutil onlyStephan Bergmann1-13/+0
This had originally been introduced with 0f6149593129c3d208f07d0d017dec0c71760778 "Make it easier to catch code that assumes SalBitmaps are created pre-cleared". But it only made it harder to find the issue reverted with ebe247642d85d39b6e1ffae3cf92c31748f2e983 "Revert 'tdf#116213 OS X and OpenGL bitmap scaline sizes are not 32-bit aligned'". Change-Id: I344e1ab4b390baa8364ade5fd2737a12708facdc
2018-03-21Revert "tdf#116213 OS X and OpenGL bitmap scaline sizes are not 32-bit aligned"Stephan Bergmann3-13/+48
This reverts commit 460f39e687393b3a8906d2adc3e8f7a0c749851a. For one, it had started to make bitmap checksum equality check in svx/qa/unit/XTableImportExportTest.cxx, CppunitTest_svx_unit, fail most of the time in macOS --disable-dbgutil builds, as the bitmap checksum is now computed also over padding bytes containing random values (but --enable-dbgutil initializes those bytes). And why would fixing tdf#116213 for Windows require touching the macOS-specific code, anyway? For another, tdf#116213 comments 6 and 7 report further problems that are likely linked to this commit. Change-Id: I3e158813ab89a1ead3780abbf6b120ec52660231
2018-03-21Turn on clang-format for these filesMiklos Vajna3-557/+531
I (tried to) keep these files consistent locally with astyle in the past, switching to clang-format makes sure that the recent problem with introducing inconsistencies in these files doesn't happen again. (On the flip side, it's great to see that now others also touch this PDF/pdfium code. :-) ) Change-Id: I6065eab77c584197a82fe48e7d3e81b445106efd Reviewed-on: https://gerrit.libreoffice.org/51701 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-21loplugin:unreffunStephan Bergmann1-0/+2
Change-Id: I7ed192011a930ea871d7efd2d966e6b746e2da3f Reviewed-on: https://gerrit.libreoffice.org/51656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-21vcl: support rendering multiple PDF pages to bitmapAshod Nakashian1-36/+49
Change-Id: Id42ecabcad90dde84475a01e5df4ed94f221f5ce Reviewed-on: https://gerrit.libreoffice.org/51255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-03-21pdf: refactor poppler importerAshod Nakashian1-1/+1
This paves the way to add pdf parsing via pdfium. Change-Id: I384687bcdce3011682ebeec18ee3de44759feb1a Reviewed-on: https://gerrit.libreoffice.org/51254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2018-03-21weld OExceptionChainDialogCaolán McNamara3-14/+30
Change-Id: I0092d2741055ab89ed4a97db9b8fad56144024c2 Reviewed-on: https://gerrit.libreoffice.org/51678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20Resolves: tdf#116483 smart art incorrectly renderedCaolán McNamara1-6/+5
HasPolyPolygon as true case sets an alternative non-broken region even if its legacy version would have been broken Change-Id: I4520b7d7a4032684afad61816380fef7171040f6 Reviewed-on: https://gerrit.libreoffice.org/51632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20drop unnecessary includesCaolán McNamara3-3/+0
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc Reviewed-on: https://gerrit.libreoffice.org/51603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20coverity#1430079 Overflowed return valueCaolán McNamara2-6/+6
Change-Id: I623f9f317496f281af408d1418d3cc7f2bd2d412 Reviewed-on: https://gerrit.libreoffice.org/51569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20weld SwSendWarningBoxCaolán McNamara5-4/+61
and then MessageDialog can become a vcl internal Change-Id: I8bf1f963971420b11f6c4163f624be26603cc942 Reviewed-on: https://gerrit.libreoffice.org/51601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19lok: 14pt font is too large for the context menus.Jan Holesovsky1-0/+3
Change-Id: I8403b2bea81e61c4fa24ed205b8d2c77a235238b Reviewed-on: https://gerrit.libreoffice.org/51438 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 8e98b3150f7ac0b569b686dd67f4699b307b30f8) Reviewed-on: https://gerrit.libreoffice.org/51439 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-19tdf#115420 fix DC usecount and drop wrong assertsJan-Marek Glogowski4-17/+8
For DC initialization we check the thread ID to assign a normal or cached DC to the corresponding WinSalGraphics variable. The cached DC has a usage count, as there are some limits on cached DCs count (DCX_CACHE). But for the WinSalGraphics DC init and release the variable just matters for the accounting, and generally which thread is doing the calls: the non-main thread always has to relay them to the main application thread. Since we're releasing all WinSalGraphics in ~WinSalFrame and do all release and re-init in ImplSetParentFrame, there is no way to correspond the thread ID to the WinSalGraphics variable. So this drops the wrong assertions based on the WinSalGraphics variables and renames the GETDC message to GETCACHEDDC to make usage of a cached DC (DCX_CACHE) more obvious. As a consequence of the different release DC handling this also fixes the accounting of the cached DCs, wich was broken in the initial fix; commit c15ea73f960bbd3d2a4b0c43b467ac62eeba3505 Change-Id: I11ce52a1b4005f26567f92588437fa37bf227a2e Reviewed-on: https://gerrit.libreoffice.org/51318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-03-19weld pdf warning dialogCaolán McNamara3-8/+37
Change-Id: I80b8324dcd575f6b537c4a0be264f0446c0fc32f Reviewed-on: https://gerrit.libreoffice.org/51516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19remove unused ucbstreamhelper includesJochen Nitschke1-1/+0
and a few vclunohelper includes Change-Id: I4803605766d155fe5044c2a65c0444631146831c Reviewed-on: https://gerrit.libreoffice.org/51496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-19cid#1430098: mbInSyncExecute is uninitializedPranav Kant1-0/+1
Change-Id: Id5288ce8680b121522c1e35edc52ef24be4ead8b
2018-03-19move bitmap copy code from CanvasBitmapHelper to vclNoel Grandin1-0/+53
part of making GetAlpha/GetMask an internal detail of vcl Change-Id: Ie1740df3d6435d9f0f2de3297e7f224d2c6b3cc5 Reviewed-on: https://gerrit.libreoffice.org/51436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-19move pixel color extracting from canvas to BitmapExNoel Grandin1-0/+21
part of making GetAlpha/GetMask an internal detail of vcl Change-Id: I874a68f340cd3074cfbeb6303f52adeeb13e56a5 Reviewed-on: https://gerrit.libreoffice.org/51435 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-19drop ErrCode::GetRestNoel Grandin1-1/+1
it was always a broken API because it includes the code, the class, and only part of the subsystemarea. Change-Id: I6f88b54aed2feab02a6aeaa783d7c642054b8075 Reviewed-on: https://gerrit.libreoffice.org/51430 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-18add id column support to tree viewCaolán McNamara2-46/+65
Change-Id: I11702f58e488bcf3fcd49c45c11b5059298f81fd Reviewed-on: https://gerrit.libreoffice.org/51512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-18unify the message dialogs with extra widgets casesCaolán McNamara1-2/+20
Change-Id: I9ad3573b15d24c3d1737b9f450792952ae20a31b Reviewed-on: https://gerrit.libreoffice.org/51476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-18remove define for GraphicObject url and inline the stringTomaž Vajngerl1-3/+1
Change-Id: I505f7c21f666d78955aace1776536d34a9e29ce3 Reviewed-on: https://gerrit.libreoffice.org/51391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-18cleanup UnoGraphicObjectTomaž Vajngerl1-28/+31
Change-Id: I7d8982223170b4675b85e350d9515ef99df0f715 Reviewed-on: https://gerrit.libreoffice.org/51390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-17Typos concerning hierarchyJulien Nabet1-1/+1
Change-Id: Ied3c6d1513f2181a5f7da2904a0df2f806146cec Reviewed-on: https://gerrit.libreoffice.org/51465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-17uitest logger: call correct function for key loggingSaurav Chirania1-2/+2
isMod2() and isMod3() functions have been used in place to isMod1() to generate correct key logs. Change-Id: Idcb83ad8bf00d31cac08cb7ff17ecca635b44967 Reviewed-on: https://gerrit.libreoffice.org/51367 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16rhbz#1392145 ensure titlebar close button matches 'outside' directionCaolán McNamara3-2/+34
Change-Id: I20e925c58adb56acd4d1a63720d330c8b6613441 Reviewed-on: https://gerrit.libreoffice.org/51433 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16use digit width instead of char widthCaolán McNamara4-6/+13
its the same across backends Change-Id: I37c83cbf1139babcd014c7cfdee06a13bea845c7 Reviewed-on: https://gerrit.libreoffice.org/51423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16move cairo extract bitmap code from canvas to vclNoel Grandin1-0/+291
part of making GetMask/GetAlpha an internal detail of vcl Change-Id: I45c2e9fdae08d7f444a64e8e04a6f65bb525cbd1 Reviewed-on: https://gerrit.libreoffice.org/51417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16move some mask code from SvxMSDffManager::ImportGraphic inside BitmapExNoel Grandin1-0/+8
part of moving GetMask/GetAlpha touching code inside vcl Change-Id: I46e908ed6216dd521143ca94d2dcbd7e95d8b9ce Reviewed-on: https://gerrit.libreoffice.org/51408 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-16weld SvxObjectTitleDescDialogCaolán McNamara1-0/+9
Change-Id: Id08c201ee4377fe84618906725e7699d29dc1160 Reviewed-on: https://gerrit.libreoffice.org/51395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-16Simplify codeStephan Bergmann1-2/+2
...avoiding loplugin:salunicodeliteral and loplugin:stringconstant Change-Id: I560682ac87b24f47fc16a6ef17232c7fbc8c9099
2018-03-16don't bother dithering for 256bit displaysNoel Grandin2-15/+2
which surely are a minority by now Also drop the GetColorCount() method on OutputDevice and clean up the remaining call sites to use GetBitCount() Change-Id: I4e2c6f2523796f7df7f54eb005f1539e34d9ea40 Reviewed-on: https://gerrit.libreoffice.org/51389 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-16move framework/toolkit use of BitmapEx::GetMask inside vclNoel Grandin1-0/+20
Change-Id: I2a942377d6e9b8b09673e5ad2804e0e7fb2bb943 Reviewed-on: https://gerrit.libreoffice.org/51387 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16remove constructor with UniqueID from GraphicObjectTomaž Vajngerl1-16/+0
Change-Id: I03924c993a95adaf6e19589779546fce2b38c745 Reviewed-on: https://gerrit.libreoffice.org/51333 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-16Remove XGraphic creation with Grap.Obj. URL in GraphicProviderTomaž Vajngerl1-28/+0
Change-Id: Ie51be332df88791cb13c3835582acc0a4e7250f9 Reviewed-on: https://gerrit.libreoffice.org/51332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-16tdf#116213 OS X and OpenGL bitmap scaline sizes are not 32-bit alignedChris Sherlock3-48/+13
Change-Id: I92b43ae2f034bf63cc3f212ec8728c5c6b5e8934 Reviewed-on: https://gerrit.libreoffice.org/51222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>