summaryrefslogtreecommitdiff
path: root/vcl/source
AgeCommit message (Collapse)AuthorFilesLines
2019-12-21tdf#126966: Make the colour swatches larger on iOSTor Lillqvist1-1/+8
We reduce the number of swatches per row from 12 to 4 and increase their size suitably so that the thing still fits in the sidebar in the iOS app on an iPad in portrait orientation. Change-Id: Ie81e5b54e88a02c6866de27448b5be72e97d9a16 Reviewed-on: https://gerrit.libreoffice.org/85620 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 18af8dc6a038d1e76274de7abc55ffa06b39a6c8)
2019-12-20tdf#127022 vcl: fix Windows RTL menu barMiklos Vajna2-1/+2
Regression from commit e8d5b8beb5958147235ff955ed38c47b51d860ff (tdf#113714 vcl menu bar window: avoid flicker, 2019-05-20), the problem was that while the original render context has RTL set up correctly, the intermediate virtual device had it disabled all the time. Change-Id: Ic063c4a6c0537891c0bfceb8927edb97cf1c6e86 Reviewed-on: https://gerrit.libreoffice.org/85624 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-12-20tdf#83248: Use the right text color when printing fieldsArnaud Versini1-2/+1
Change-Id: I81167207a35d524660b9a1d6740cfce551489c4a Reviewed-on: https://gerrit.libreoffice.org/84707 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-12-19get native gtk widgets in sidebars workingCaolán McNamara3-11/+15
Change-Id: If65aef1249f54a87d7854c3fa2db4319a24a5a05 Reviewed-on: https://gerrit.libreoffice.org/85326 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-19add a SystemChildWindow::GetOptimalSize overrideCaolán McNamara1-0/+7
Change-Id: I812d996e78a6d627fda6612307ca4cb2f111b6a9 Reviewed-on: https://gerrit.libreoffice.org/85325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-18lok: vcl: fix multiple floatwin removal case more robustly.Michael Meeks1-3/+12
Instead of this over-clever approach of recursively removing items which can easily fail, build a list, then iterate it in-line while disabling recursion. also includes: lok: vcl: fix multiple floatwin removal case. We need to progress in our while loop to remove children, even if they are currently not in popup-mode; fixes infinite loop with two popups present concurrently. Change-Id: Ic7b7f8e13a466d254abe53b77bc166c6a89fa8c3 Reviewed-on: https://gerrit.libreoffice.org/85368 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-18Fix typoAndrea Gelmini1-1/+1
Change-Id: Ic1daa649bbe73f2237f4e83e85cda88ba041e1f3 Reviewed-on: https://gerrit.libreoffice.org/85365 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-18Fix typoAndrea Gelmini1-1/+1
Change-Id: I2bebd1ea9e8bd7815f6a0fccf5a87af68c84fbb7 Reviewed-on: https://gerrit.libreoffice.org/85364 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-18use o3tl::optional rather than boost::optionalNoel Grandin1-2/+2
Change-Id: Ia02e4c37935445e35e806964570fa900e3981463 Reviewed-on: https://gerrit.libreoffice.org/85357 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-18vcl: sfx2: LOK: Support per-view popup windowsAshod Nakashian29-304/+446
While we do support multiple views, there is only one state for popup/floating windows, that also includes the dialogs open and related windows/data. This adds support to allow each view to have its own popups and state, thus allowing multiple users to interact with the dialogs independently of one another. (cherry picked from commit b50c341a53911f1d725947a4d8d3d2f782c94079) Change-Id: I3786a561ca6ca113ad12425bdb491e5a30bd1a28 Reviewed-on: https://gerrit.libreoffice.org/82440 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/85221 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-12-17tdf#112989 reduce export to PDF timeNoel Grandin1-3/+9
reduces the time from 33s to 24s for me Change-Id: Ia70e1c4220ebedf0b686ed76c5704efa551591fe Reviewed-on: https://gerrit.libreoffice.org/85281 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-17loplugin:expandablemethodsNoel Grandin2-7/+2
Change-Id: Ifc269d9996928085a3ab78033788465b4f029368 Reviewed-on: https://gerrit.libreoffice.org/85255 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-16sidebar: check for valid current deck before closingAshod Nakashian1-2/+2
Also, cleanup unused/unnecessary LOKNotifier logic from Deck.cxx and use emplace_back where possible. Change-Id: I300c5158b12593e8130f5b6273c1ea3bcbefea7f Reviewed-on: https://gerrit.libreoffice.org/82402 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-12-14tdf#127148 select-all on tabbing into version box in help->aboutCaolán McNamara2-1/+9
and allow select-all in readonly multiline edits too. Arguably this might be a universal settings, but just enable it for the about dialog for now. Change-Id: Ic2e64fe26593adf4ae630d1be1a7b196a5a0216c Reviewed-on: https://gerrit.libreoffice.org/85127 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-13Revert "Enable/Disable of children shouldn't be necessary"Jan-Marek Glogowski1-1/+1
This currently breaks the child sensitivity handling of frames used in the PDF export, when toggling the form export check box. I also tried to add a set_sensitive to SalInstanceContainer, but that didn't work. I found this while debugging tdf#127493, but I'm don't know, this is the correct fix wrt welding. This reverts commit 1d69cf32a73c0720882731ebf3eb5d2f07fce246. Change-Id: Ib468c82124dc3d1030d7b08b2e139f49f3c00630 Reviewed-on: https://gerrit.libreoffice.org/84976 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-13loplugin:expandablemethodsNoel Grandin7-45/+14
Change-Id: I333d91ea5ce78c82e9bb107f934614efc7bfb8f7 Reviewed-on: https://gerrit.libreoffice.org/85078 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-13loplugin:unusedmethodsNoel Grandin4-39/+0
Change-Id: I8ad75d1251df4d6f8097aaa68e4ec92331e38ad4 Reviewed-on: https://gerrit.libreoffice.org/85077 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-13loplugin:singlevalfieldsNoel Grandin5-60/+10
Change-Id: Idec5a7a732d5dc868ad3f9a147e18ee9685645e2 Reviewed-on: https://gerrit.libreoffice.org/85076 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-12tdf#123076 Get paper size for print previewGabor Kelemen1-0/+2
Initialize from current paper size which can be different from A4 Change-Id: Iae5e33d79c0783a32dad8635a66cc3fbe83dc568 Reviewed-on: https://gerrit.libreoffice.org/84920 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2019-12-12Remove some redundant user-provided dtorsStephan Bergmann3-7/+0
...which silences various -Wdeprecated-copy-dtor warnings from Clang 10 trunk about copy functions being implicitly defined as non-deleted even though the class has a user-declared dtor Change-Id: I3409d403c3c709de4ad94eccbc2d7869e41847cc Reviewed-on: https://gerrit.libreoffice.org/85032 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-12android: add abstraction to allow us to DetachThread sensibly.Michael Meeks1-0/+5
If we fail to do this after runLoop - some Android VMs can get really upset if we quit a thread without doing this, also ensure that we AttachThread to new polling loop threads as we come in for good measure - duplicate Attach's are NOPs. Change-Id: I32454773af4e02c97df0b6c02f61b1dc74df80b0 Reviewed-on: https://gerrit.libreoffice.org/84956 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 7241382ccc0a028c5f08304090a6344e582db068) Reviewed-on: https://gerrit.libreoffice.org/84969 Tested-by: Jenkins
2019-12-11Fix typosAndrea Gelmini1-1/+1
Change-Id: Idc42061d8832f9d7ca5402e756c81305a309eefc Reviewed-on: https://gerrit.libreoffice.org/84968 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-11do not allow both read and write bitmap access to the same bitmapLuboš Luňák3-0/+3
Since BitmapBuffer stores a copy of the bitmap's palette and the bitmap can update its state only when SalBitmap::ReleaseBuffer() is called, setting a palette using write access and then reading the bitmap before the write access is completed could result in inconsistencies. I wrote this while debugging tdf#129077, which eventually turned out to be a different problem, but it still makes sense to check this. Change-Id: I56e9e36c02f2da652cedb3bbc6eb5b630ebaf3ae Reviewed-on: https://gerrit.libreoffice.org/84771 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-12-11tdf#128824 Keep multiselection in style list on right clickSamuel Mehrbrodt1-1/+2
Change-Id: I196f8c7d3a1a0b3267498f6cde55069ba3a60523 Reviewed-on: https://gerrit.libreoffice.org/84882 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-12-11lok: Support per-view help dataTamás Zolnai4-73/+158
Used for showing tooltip windows in LO online. Change-Id: I8b6a7272c75025e717923c839fa8fd9f4cab2903 Reviewed-on: https://gerrit.libreoffice.org/84717 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/84803 Tested-by: Jenkins
2019-12-11tdf#105518 F6: Skip infobar when it has no childrenJim Raykowski1-1/+6
Change-Id: Id5375d9acfd20844a56da20fcf08c709423f75e0 Reviewed-on: https://gerrit.libreoffice.org/83636 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-12-11lok: fix welded dialogsHenry Castro1-0/+6
In the tiled rendering case the dialogs, run asynchronous due to multiple user access. In order to send the messages to the client side, the dialog has to hook a LOKNotifier in the constructor of the SfxViewShell. However, the new weld wrapper classes use the Frame Window, (i.e. Window::GetFarmeWeld()), as a parent of the dialogs. On the other hand, in order to avoid getting the interface implementation inside implementation classes, it has been created a new method Window::GetFrameWindow(), otherwise I have to do a bureaucratic conversion between Interfaces to Implementations ( i.e. UnoWrapperBase::GetUnoWrapper() ) Change-Id: I32c34d82a89211a025250e65a05ce47d30efa0b8 Reviewed-on: https://gerrit.libreoffice.org/84215 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-12-11lok: evaluate assertion if LOK Windows container is emptyHenry Castro3-3/+10
It has defined a map container for every LOK windows assigned a notifier to the client side. However the map container has elements with VclPtr (reference counter) and it is a global data, so when global data are disposing, the VclPtr will destroy the Window when the VCL framework was destroyed that will lead to undefined behavior. So this commit adds an assert inside DeInitVCL to ensure, if someone forgot to Release the LOK Notifier. Change-Id: Ib7f20751af2931f7b0ba3e3d526e734ffc33f171 Reviewed-on: https://gerrit.libreoffice.org/84792 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/84909 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-12-10lok: don't show tooltip for popup menus inside dialogsTamás Zolnai1-0/+10
Check Character Properties dialog -> Font Effects -> Font Color popup button. Moving the mouse above the colors, a tooltip is shown with the color name. However when the tooltip window is displayed LO online closes the popup window unexpectedly. Change-Id: I4bb8611640e122fc8187271c8c843c9f29fc0ce0 Reviewed-on: https://gerrit.libreoffice.org/84716 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/84802
2019-12-10lok: show tooltips on dialogsTamás Zolnai2-4/+5
Change-Id: I40fca6ff13cc41ec9e1ec6bba48dce207e364c79 Reviewed-on: https://gerrit.libreoffice.org/84715 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/84801 Tested-by: Jenkins
2019-12-09use HasChildPathFocus for SpinButton like ComboBoxCaolán McNamara1-0/+7
Change-Id: Ifb95d6f9df8ea1b3f0e678b60e83c9a99d538225 Reviewed-on: https://gerrit.libreoffice.org/84772 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-09Enable/Disable of children shouldn't be necessaryCaolán McNamara1-0/+4
the builder counterpart to... commit 1d69cf32a73c0720882731ebf3eb5d2f07fce246 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Oct 18 19:23:40 2019 +0100 Enable/Disable of children shouldn't be necessary Change-Id: Iaad132d1cabf657d884e38b33a167ed165216f43 Reviewed-on: https://gerrit.libreoffice.org/84773 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-09only connect to tooltip query when we have toCaolán McNamara1-1/+6
Change-Id: I0b7f1b798129b41c9831ccdd47cd509680b19de2 Reviewed-on: https://gerrit.libreoffice.org/84742 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-09Related tdf#108458 if no TooltipHdl set use usual tooltipCaolán McNamara2-11/+12
also if the Tooltip was blank continue to use usual tooltip Change-Id: I7dd02ffcbb558684ff41e50586284607a1ea4881 Reviewed-on: https://gerrit.libreoffice.org/84741 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-09tdf#108458 related: Add tooltip handling to TreeViewJim Raykowski2-2/+26
Supports GtkInstanceTreeView and SalInstanceTreeView Change-Id: I33984f78c26135319531eace2a3e2e2e28712af1 Reviewed-on: https://gerrit.libreoffice.org/84587 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-09weld Property BrowserCaolán McNamara2-7/+31
Replaced the odd HyperlinkField Edit whose text can be clicked on to activate listeners, with an ordinary Edit and a Button beside it which can be clicked instead to do that. I couldn't find a real world use of this HyperlinkField in the forms or control properties, nor in casual experimentation in the sidebar in the basicide dialog editor. Also replaced the other strange Edit-alike TextView with a real Edit entry and a dropdown which can be used to support entry of multi-line labels Change-Id: Iad5265e404f6de14c8e760d617dbad49cd6ddead Reviewed-on: https://gerrit.libreoffice.org/82213 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-09no longer have to worry about intra-module compatibilityCaolán McNamara1-12/+7
in 'the next minor update' Change-Id: I1faffbbdf6d3bb538737568931d9053c4ec6bd11 Reviewed-on: https://gerrit.libreoffice.org/84731 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-09tdf#122706 Fix built-in HID on Print dialogs Help buttonKelemen Gábor1-1/+1
to open the general Print page. Change-Id: I1ffee4a9d72bb6a4840dec3800a397a878ed2eca Reviewed-on: https://gerrit.libreoffice.org/84628 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-12-06Removed duplicated includeAndrea Gelmini1-1/+0
Change-Id: Iff578f6bbaf82c45562bd9aad0c8bd15498ce555 Reviewed-on: https://gerrit.libreoffice.org/84641 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-12-06remove the added pages grid and tabpage when remove page calledCaolán McNamara1-8/+16
Change-Id: Id2df8e320335e2578c2a3f879b1bb6612a77ca8b Reviewed-on: https://gerrit.libreoffice.org/84636 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-06handle unsetting ImageCaolán McNamara1-1/+4
Change-Id: If4a3ab94c268caeebdc42c664c568aa9004c50ad Reviewed-on: https://gerrit.libreoffice.org/84579 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-06lok preload: Some symbols are in-process when we need them.Jan Holesovsky1-7/+24
But OTOH in the preload case, the libraries we'd otherwise load are not there. An example was libcuilo.so where the instantiation of the spell checking dialog was failing, because it was impossible to find the makeSentenceEditWindow symbol. Change-Id: Ifc0bc5d8b295912728505fe3ce11fa4a0d198124 Reviewed-on: https://gerrit.libreoffice.org/80229 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-12-05use o3tl::optional instead of pointerNoel Grandin3-8/+6
Change-Id: I71084d668829fdaaf383319697d71b4299f9afea Reviewed-on: https://gerrit.libreoffice.org/84500 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-05turn TimeFormatter::ImplInit into initializer listCaolán McNamara1-15/+10
Change-Id: I2f21241f753b1fe1300a284cc80a29911cd223ae Reviewed-on: https://gerrit.libreoffice.org/84465 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-05turn DateFormatter::ImplInit into initializer listCaolán McNamara1-20/+14
Change-Id: If58b8f5c65f7d920dd3a186cf648db605799b790 Reviewed-on: https://gerrit.libreoffice.org/84464 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-05no point setting mnDecimalDigits to overwrite it immediatelyCaolán McNamara1-2/+2
Change-Id: I1651ab51bebf7cfa88d55276f9aec337a903083c Reviewed-on: https://gerrit.libreoffice.org/84463 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-05turn NumericFormatter::ImplInit into initializer listCaolán McNamara1-23/+16
Change-Id: I5f936ea61a3e17bb534282e4649b21c0ae2565c8 Reviewed-on: https://gerrit.libreoffice.org/84462 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-05turn MetricFormatter::ImplInit into initializer listCaolán McNamara1-7/+2
Change-Id: Iccb732517d7827eda1d8962d4dccdb3a01ebce78 Reviewed-on: https://gerrit.libreoffice.org/84461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-05replace only use of GetDefaultUnit() with FieldUnit::NONECaolán McNamara1-3/+1
Change-Id: Idf3cf6d0a361c67d4005d627f661ac49e0e3e9de Reviewed-on: https://gerrit.libreoffice.org/84459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-12-05the only call to MetricField::SetDefaultUnit doesn't change the defaultCaolán McNamara1-4/+1
so is of no use Change-Id: Ibb1187183abff6b8dc26ed5011b43af1a86a7d04 Reviewed-on: https://gerrit.libreoffice.org/84458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 11:42:42 +0000