summaryrefslogtreecommitdiff
path: root/vcl/source
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2019-12-13 15:58:57 +0000
committerCaolán McNamara <caolanm@redhat.com>2019-12-14 20:13:59 +0100
commit504d9e75f663497e7ba08ea4124c8a1b06d658ce (patch)
treed302e9d22b4cc66a49ee3f96ad7feb57a7d6a687 /vcl/source
parent1e278d1d0cfb1d5375195aa764739f00633f21e8 (diff)
tdf#127148 select-all on tabbing into version box in help->about
and allow select-all in readonly multiline edits too. Arguably this might be a universal settings, but just enable it for the about dialog for now. Change-Id: Ic2e64fe26593adf4ae630d1be1a7b196a5a0216c Reviewed-on: https://gerrit.libreoffice.org/85127 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'vcl/source')
-rw-r--r--vcl/source/edit/vclmedit.cxx2
-rw-r--r--vcl/source/window/aboutdialog.cxx8
2 files changed, 9 insertions, 1 deletions
diff --git a/vcl/source/edit/vclmedit.cxx b/vcl/source/edit/vclmedit.cxx
index 0225f79d487e..e21d5c4c8f57 100644
--- a/vcl/source/edit/vclmedit.cxx
+++ b/vcl/source/edit/vclmedit.cxx
@@ -852,7 +852,7 @@ void TextWindow::GetFocus()
if ( !mbActivePopup )
{
bool bGotoCursor = !mpExtTextView->IsReadOnly();
- if ( mbFocusSelectionHide && IsReallyVisible() && !mpExtTextView->IsReadOnly()
+ if ( mbFocusSelectionHide && IsReallyVisible()
&& ( mbSelectOnTab &&
(!mbInMBDown || ( GetSettings().GetStyleSettings().GetSelectionOptions() & SelectionOptions::Focus ) )) )
{
diff --git a/vcl/source/window/aboutdialog.cxx b/vcl/source/window/aboutdialog.cxx
index 879c94d2910f..882b47b09790 100644
--- a/vcl/source/window/aboutdialog.cxx
+++ b/vcl/source/window/aboutdialog.cxx
@@ -29,6 +29,14 @@ AboutDialog::AboutDialog(vcl::Window* pParent, WinBits nStyle, Dialog::InitFlag
m_xBuilder->get(m_xCopyrightText, "copyright");
m_xBuilder->get(m_xBuildIdLink, "buildIdLink");
+ // tdf#127148 so tabbing into the widget will auto select-all
+ AllSettings aSettings = m_xVersion->GetSettings();
+ StyleSettings aStyleSettings = aSettings.GetStyleSettings();
+ aStyleSettings.SetSelectionOptions(aStyleSettings.GetSelectionOptions()
+ | SelectionOptions::Focus);
+ aSettings.SetStyleSettings(aStyleSettings);
+ m_xVersion->SetSettings(aSettings, true);
+
#ifndef MACOSX
m_xVersion->RequestDoubleBuffering(true);
#endif