summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2021-03-21cid#1473798 silence Unchecked return value from libraryCaolán McNamara2-2/+2
Change-Id: I00174b5444749f3345f5691e24eb5219d1b47059 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112837 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-21remove need to const_castCaolán McNamara2-3/+3
Change-Id: Ie4cdf7fa49681201db9bbd9999ad423f8b195e6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-21update pchesCaolán McNamara3-22/+26
Change-Id: I60e61133c305673bb305e41957f5414820c7c358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112790 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-21select_by_text helper method for uitestsNoel Grandin17-125/+62
reduce the boilerplate associated with selecting an item in a combobox Change-Id: I035967d7b45c84788d67b9ab5bebf2dbfc13fdf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112817 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-20tdf#140182 DOCX table import: fix extra page breakAttila Szűcs2-0/+11
Hack with m_bDummyParaAddedForTableInSection didn't handle the case, when a page break (empty w:p with a w:br) after the table followed by a paragraph with a section break, resulting 2 page breaks after the table instead of a single one. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Ibd8ab5444becdfd09d0d05eb246e6853914e1f05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111600 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-20sw fr_FR AutoCorrect: fix crash using "Apply and Edit changes"Julien Nabet1-1/+1
Bad calling of SvxAutoCorrect::FnAddNonBrkSpace() in French documents, see tdf#140849 for a similar problem. Change-Id: I19b964fb8fe437c7f98342a873a456ffded75d82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112120 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-20add GetInputLanguage to EditViewCaolán McNamara1-7/+1
and hide the need to expose its vcl::Window Change-Id: Ide8a2e2500116af412a8717052a300e8ef4d1a48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112782 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-20drop unneeded includeCaolán McNamara1-1/+0
Change-Id: I2d678f6fcb1707fbf5274927f6dcae05061703c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112781 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-20ODT export: handle style name of covered cellsMiklos Vajna2-0/+21
This is the export side of commit 1001dbaef4dec2b51c25ed8343bab6910f1219e1 (ODT import: handle style name of covered cells, 2021-03-19). We already exported the autostyle, but <table:covered-table-cell> did not refer to it. This is useful when the covering and the covered table cells have different border settings. Change-Id: I7773903fa62f53686f000473f7a03c68dd77602a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112758 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-19silence coverity unchecked return value from library on xmlText* functionsCaolán McNamara43-659/+660
Change-Id: I651abb00d8ae1bdbf758a6a0176fd8912531a585 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112753 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-19cid#1473777 silence Using invalid iteratorCaolán McNamara1-2/+4
Change-Id: I6fd80c8b5cec6d1d9c398e45cbd30cc65caa23a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112749 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-19don't hide toolbar item widgets if the pane shrinksCaolán McNamara1-0/+5
Change-Id: Iac5df0f0233c9e97f84dce8a479cb50b944f45db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112746 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-19ODT import: handle style name of covered cellsMiklos Vajna5-1/+93
Similar to commit 66ac8e60896f6306bed8fbb34606fd14474f19ce (sw: fix unwanted long vertical border around vertically merged Word cell, 2021-03-04), but that one was for the DOCX import / rendering. Change-Id: I394a4f062544a9774b9b40ec757cb37e72220561 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112696 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-19Related: tdf#133933 sw: fix assertion failure in the SwIndexReg dtorMiklos Vajna2-3/+7
Make sure that by the time we delete a text node, no SwIndexes point to us. Change-Id: I9248a2ebe529e5a0aab0e37bf676e669b9bddb1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112698 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-18tdf#108518 partial revert tdf#64222 sw: better DOCX im/exportJustin Luth1-3/+3
...of paragraph marker formatting 6.4 commit 5ba30f588d6e41a13d68b1461345fca7a7ca61ac Ultimately, this just reverts back to an earlier 6.4 change (which means that this really is untested and unproven)... > Also revert the change in checkApplyParagraphMarkFormatToNumbering() > to consider hints that start before the end of the paragraph, > as it has unintended side effects as pointed out by Mike Kaganski. But those side effects were from a DOCX file, and DOCX isn't processed here anymore. The (unedited) comment (still) says: //Formatting for the paragraph mark is usually set to apply only to the //non-existent extra character at end of the text node but there can be //other hints too (ending at nTextLen), so look for all matching hints. //Still the (non-existent) extra character at the end is preferred So, that suggests that there is more than one possible valid autofmt, and that not ALL autofmts will have a start==end. This is being considered since it fixes the one example file that I could find that still broke when reverting OOo's 2012 hack commit 1c22545edf9085b9f2656ca92781158b6b123db3 Fix issue #i119405: Numbering text style changed after importing the *.doc The other alternative would be to // TODO remove this fallback (for WW8/RTF) Change-Id: I69b6e31fe570742b4b9dd94d2cce2b5b9850360d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112319 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-03-18tdf#140980 sw: fix bad strikethrough of annotationsLászló Németh5-8/+54
Not deleted annotation windows got a bad strikethrough in ChangesInMargin mode, if they annotate tracked deletions. Also clean-up commit a001a66ba27e2fe9a485388869d53f001f2b09af (tdf#140982 sw ChangesInMargin: fix annotation ranges). Change-Id: I06cb88113bf038c09702b6ef33e46c94c963730d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112672 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-18tdf#140590 Writer crash in Tools>Chapter NumberingNoel Grandin1-1/+1
and an assert in vcl to catch it a little higher up the stack. Change-Id: Iaa2e70f901f93ca9f678118e4f5a8bc1b6eda20a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112459 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-18tdf#139667 update Styles Inspector and tip of the day to "List Style"Seth Chaiklin2-2/+2
For Tip of the Day + add uri to Bullets and Numbering help page for tip about "Insert Unnumbered Entry" + adjust tip for applying List Style to tables, and add link to "List Style" help page. For Styles Inspector * change "Numbering Style" to "List Style" For Customize dialog ( sw/inc/strings.hrc ) * change "Numbering" to "List" for Style_Family Change-Id: Id43988490a61437d0068ea22a2bf3b0841b6ad42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110139 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-03-18tdf#118693: no need to use convertMm100ToTwip() for line shapes anymoreXisco Fauli3-10/+39
It was introduced in 11129d89b152db54c86bb2bda58c24b8abb6c5a8 < tdf#85232 WPG import: fix handling of line shapes > and later in 36bade04d3780bc54c51b46bb0b63e69789658a5 < tdf106792 Get rid of SvxShapePolyPolygonBezier > ForceMetricToItemPoolMetric was added to SvxShapePolyPolygon::setPropertyValueImpl to convert from 100thmm to twips as can be read in the comment in testTdf85232 With this change, xShape->getPosition().X in testTdf85232 is 2267, which was already in twips Change-Id: I30b757885327a477213f96f8f84541971f435164 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112663 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-18tdf#140892 Outline Content Visibility Window button improvementsJim Raykowski4-50/+60
- Makes the horizontal position of the button near to the first character horizontal position in the frame. - For RTL frames places the button to the right. - Changes the button symbol for show/expand content from a right-arrow to a down-arrow and for hide/collapse content from a down-arrow to an up-arrow. - SymbolType enums are replaced with ButtonSymbol enums to represent the button symbol for the outline content visibility state. Change-Id: Ie5d94b0dec0690c0798098ed19e38cc13d9d2682 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112463 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-03-18Sw Navigator: fix table selectionJim Raykowski1-2/+2
Fixes table selection from the Navigator not selecting the whole table. Change-Id: If6a9161d011a056aad02c3bd99c19e62802288c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112254 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-03-17make SalLayoutGlyphs work with MultiSalLayoutLuboš Luňák1-5/+1
Code that needs to lay out texts repeatedly can cache the result of SalLayout::GetGlyphs() can reuse it. But GetGlyphs() returns nullptr for MultiSalLayout, so caching for it doesn't work. Worse still, it actually increases the number of layout calls, because there's the initial layout for caching and then each call will need to do the layout again because of the nullptr that's not cached. This commit changes SalLayoutGlyphs to possibly include multiple SalLayoutGlyphsImpl objects, one for each SalLayout handled by MultiSalLayout. Changes include making GenericSalLayout work directly with the Impl class, which avoids an indirection and simplifies code. Change-Id: Ic4b19934a8a06d4955b51527fe3777c5e91107b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112590 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-17do not disable Writer font caching on zoom mismatchLuboš Luňák1-18/+0
This code disables font caching for some cases, e.g. when exporting to PDF if the zoom is set to anything else than 100%, or also when loading a document. It unfortunately comes from the OOo initial import, so it's impossible to find out why it should be needed. SwFntObj instances are created only using SwFntAccess ctor, which checks any SwFntObj it tries to reuse, so if this some additional factor to consider when reusing SwFntObj, then it can be checked there. But when I remove the code, I cannot see any breakage. Tests pass, normal rendering is fine, document thumbnail is fine, printing is fine, PDF export is fine, embedding in a spreadsheet is fine. We had a look at this with Miklos and concluded that it is not needed (until proven otherwise, in which case it'll be also known why it would be needed). Change-Id: I59d375229a265a4353c1da6dd067d892dd4ecfb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112589 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-17improve font caching in SwFntObjLuboš Luňák2-56/+103
The code previously cached only SalGlyphItems, but such caching fails if SalLayout::GetGlyphs() does not return valid glyphs, which is the case with MultiSalLayout. Worse, it not only fails, but layout is once computed for caching, that fails, and is computed a second time for actual use. This improved cache caches the result of GetTextWidth(), which itself improves the performance a bit, but it also allows caching the value for GetGlyph() not returning valid glyphs. Moreover this also caches failures to get valid glyphs from GetGlyphs(). There are quite some calls to GetTextArray(), I didn't cache those, but it might be added if needed. Change-Id: Ia2589fb1b778f4f154c88f65d9906584284239da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112588 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-17tdf#140982 sw ChangesInMargin: fix annotation rangesLászló Németh7-33/+131
Annotation ranges of tracked deletions collapsed in ChangesInMargin mode (as before saving the document, see commit d325cd0c69b7c0cc4f47105749a98995de81cc9d "tdf#115815 sw: fix lost annotation ranges of redlines"). Change-Id: I413804cfcdf972f054b65e28e6265c30d25731e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112644 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-17sw reqif-xhtml export: make sure OLE1 preview is WMF-onlyMiklos Vajna3-32/+72
reqif-xhtml has previews for embedded objects at 4 levels: - png preview - RTF preview - OLE1 preview - OLE2 preview The OLE1 preview has to be a WMF one, and in case our WMF export tries to inject EMF into it, Word will refuse to open the embedded object. So add a new flag to allow opting out of the EMF embedding for reqif-xhtml export purposes. The other option would be what Word does to just omit the OLE1 preview, but then this would break reqif-xhtml consumers who take the preview from the OLE1 data. Change-Id: Ia8d4626aefb6309743c9f4023f289c9a7b872035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112648 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-17tdf#46561 sw: fix lost undo stack setting header/footerDaniel Arato (NISZ)5-67/+156
Changing 'shared' setting of left vs right or first vs non-first page headers or footers removed the whole undo stack. Note: style changes before a 'shared' change can still not be undone. Co-authored-by: Attila Bakos (NISZ) Change-Id: I6875bd0581869ffeb853911347dbc9f8c666214b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111635 Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu> Tested-by: Balazs Varga <varga.balazs3@nisz.hu>
2021-03-17throw exception for errors in uitest actionsNoel Grandin3-3/+0
so we abort early when a uitest goes wrong, instead of letting tests become fragile because it looks like its passing, but the code is just accidentally working Remove code in python uitests that was not actually doing anything (and now crashes because we throw an exception for actions that don't mean anything) Change-Id: I9c52f9fdc06f1c01e9b93b58a5200f9c3684db1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112471 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-17sw: prefix members of SwIsoRefPortion, SwIsoToxPortion, ...Miklos Vajna7-67/+66
... SwSoftHyphPortion and SwSpaceManipulator See tdf#94879 for motivation. Change-Id: Ib7034bfa158885d23cf51b9db2e8f7095885cf39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112595 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-17tdf#52065 sw: revert tdf#45908: Cleaning up the tabs too earlyJustin Luth9-0/+147
... can cause loops from LO 3.5 commit 36c905d8c2874f6f984d5fbbc07784ec20c43524 The PostFormat for Center and Decimal tabstops is critical since the space they take up is unknown until the following text is evaluated. The search position in these two cases is invalid until the text position is calculated by PostFormat. PostFormat normally returns FALSE, so in almost all cases the rest of NewTabPortion completes. The function only returned early if the start of the tabstop was beyond the right margin. I assume the original intent was to avoid potentially unnecessary processing. However, returning early can cause looping, which the LO 3.5 commit "fixed" by removing everything. Well, just remove the early return and both problems are solved. Change-Id: I4afc4cce8249f90097bc1f263df1a39bc219098d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112559 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-16tdf#122894 skipping anchor in column in footnoteCaolán McNamara3-1/+7
a trawl of crash testing document didn't show up another example and it doesn't seem possible to create this scenario directly in out UI Change-Id: Ie65a51bf609e8bacd261f368f0b8037431c116ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112567 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-16tdf#138895 DOCX filter: fix handling for effect extent vs line widthMiklos Vajna3-0/+32
Regression from commit a5a836d8c43dc9cebbbf8af39bf0142de603a7c6 (DOCX filter: effect extent should be part of the margin, 2014-12-04), the problem was that effect extent is OK to be added as an extra margin, but line width is part of that effect extent in Word, so Writer margin should not be increased with the line width. The Word behavior seems to be that half of the line width is part of e.g. the top effect extent, then the other half is part of the bottom one (and so on). The bugdoc's case was that a too large margin shifted the last line below the shape, and this tiny half-line-width extra margin handled correctly puts the line back to its correct place. Change-Id: Ic897926f3d79f979ea84aef3dbda49c46b18a3ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112558 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-16devtools: move "Development Tools" menu from "Help" to "Tools"Tomaž Vajngerl2-3/+5
Change-Id: I82f3315321ecb3ef2796234968ff22392be828eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112551 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-15tdf#139667 tdf#126689 "Add to Previous List" in menus and toolbarsSeth Chaiklin11-11/+11
Change-Id: I85334320f6fde2b12b981ad7fdeee570e89fd74f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112420 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-15mark some more tests failing on non-default dpiNoel Grandin1-0/+2
Change-Id: I72713695d39ae188fa4f1fc13354f6bb4aeec8ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112489 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-15tdf#133487 sw ODF export: reorder flys' ZOrder/z-index...Michael Stahl4-6/+35
... so background shapes have lower z-index than foreground shapes, as is recommended by ODF 1.3. Also let SdrObjList::sort() record Undo actions, because earlier Undo actions could expect the previous sort order. Change-Id: Idbecf0a2acd525d42efc0ac92677b1c7987cc6ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112180 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-14tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktopdipanshu1241-1/+0
MacrosTest::loadFromDesktop itself asserts on its return value. Thus, there additional checks in unit tests are redundant. Change-Id: Iec9be2293c6337fa747c78a0963e31aa99b60772 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111810 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-14fix typo in style dialog functionSeth Chaiklin1-3/+3
Change-Id: I88b38a33a1ca50a0165b11679ca28bb092a6eab5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112307 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-14tdf#137494 Add Select Cycle uno commanddipanshu1245-0/+72
Assign F8 for toggling SelWrd > SelSentence > SelPara > Unselect. Reassign Extend Selection to Alt+F8. Change-Id: I2fc03c70a5786a629169178e64a0b0fd85ba2742 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112326 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-03-14tdf#141011: Postpone SwFieldDBPage::Reset to tab activationMike Kaganski2-0/+5
This way, it will only ask for password when dialog is switched to that tab. Change-Id: Ie2a453b0b6867ceb1ef3728a8565de4f6cbf4757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112469 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-14tdf#141012: do not try to expand the node if RequestingChildrenHdl failedMike Kaganski1-1/+12
Just select the database node itself, so that it's still obvious which database is associated with this document. After selecting this node when initializing the tab, another call to SwDBTreeList::Select will be made, so make sure to handle empty table and column names. Change-Id: Ie1d1bd445e18d5900910c780a24102b4dde5c787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112467 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-14tdf#141015: Show Mail Merge toolbar when DBData has data sourceMike Kaganski1-1/+3
Change-Id: I74ea06b47d851d979103599526ae970035854dae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112465 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-14check for quit when calling Yield in loopNoel Grandin1-1/+1
so we don't get stuck threads when the main application quits Change-Id: Id36e99267ceb4154873b6ef8ef494622fff6c19a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112409 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2021-03-14loplugin:unusedmethodsNoel2-11/+0
Change-Id: I851eba4ca80eac9ee5896df53fbcd0f5ad125763 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112433 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-13merge the various SetPointFont via DefaultDevice callsCaolán McNamara2-4/+4
Change-Id: I769bb95c588c7222ff0dc6c4b845dfc3f0d7cbc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112390 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-13tdf#128469 add extended tooltip for "Reset to Parent"Seth Chaiklin1-1/+1
Change-Id: If5aabfc5b677cbeb375745d5c1902848cf48c13f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112414 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-03-13Drop duplicate methodMike Kaganski8-19/+7
Change-Id: Ib9401c695a48673545d0adeac2bad24c7579e424 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112419 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-13add PixelFormat enum that replaces bit count in Bitmap/BitmapExTomaž Vajngerl1-8/+8
Bit count for the image is a numeric value (sal_uInt16) but only a handful of values make sense - namely 1,4,8,24 and 32. This replaces the numeric value with an enum, which only accepts those values and checks the correct values are used at compile time. Change-Id: I0fc137c62bce3b0d021f05019a1648da628521bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112408 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-03-13update pchesJulien Nabet4-22/+41
Change-Id: Id6dfae9fb97fbe3fc89b9f2e083d7a3d5c1d36d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112411 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-13tdf#135774 Char highlight: partial revert tdf#114799Justin Luth1-0/+4
...DOCX import: fix missing numbering highlight from 7.0 commit 315d56582f8a56d8f2d3ea6cda63ea4832249608. If the numbering had a specified w:highlight in numbering.xml, then that character background should apply to the bullet point. However, SetDiffFnt automatically clears the highlight, the same as it does with mxBackColor (fixed in earlier commit). So a special step is needed to check if the font has a highlight, and since that direct formatting has priority, re-apply it after SetDiffFnt has finished. This is slightly different from mxBackColor - which is an optional attribute. Highlight is reset to COL_TRANSPARENT. If a RES_CHRATR_HIGHLIGHT exists explicitly setting a COL_TRANSPARENT, then any overrides should have been removed from pCleanedSet, and so it never needs to SetHighlightColor(AUTO). Change-Id: Id9d88054254563706b9aee90a1d257b467139334 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112410 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 13:59:00 +0000