summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2020-07-01reorder parameters of SvXMLExport::SvXMLExportNoel Grandin1-1/+1
so they all have similar order Change-Id: Id8baef058d52f6cce9d9be41b0341eec8ad648b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97628 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-01tdf#133863 tdf#133864 DOCX shape import: width relative to insideRegényi Balázs3-2/+57
and outside margins. See commit 43d7f4e3640c5e370fd1204739c2b0c7eb5f40e4 (offapi: document the 4 new properties which are no longer read-only). commit b46f4bc9760267ac5e45d43b77b5d2721ee4c386 (tdf#133070 DOCX import: fix shape height relative to bottom page margin) commit 330ed8120e9881656716d70d87b9f49f861f0bfa (tdf#133670 DOCX import: fix shape width relative to right margin) commit 7380905abc0833d9e4c4fe731d76174db8a8724c (tdf#132976 DOCX import: fix shape width relative to left margin) Co-authored-by: Szabolcs Tóth Change-Id: If81b7c80732141be1491ca82770cf6eee99f5656 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97627 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-01weld EditControl for browseboxCaolán McNamara1-7/+7
Change-Id: I8f21c12f7ee10e1b9ba883a8ff01bb5252429f09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01tdf#126504: sw: Add unittestXisco Fauli2-0/+47
Change-Id: Iceca8bc3ae2dcad04040498565200361157f83e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97613 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-01sw doc model xml dump: show SdrModel of embedded chartsMiklos Vajna1-0/+9
Change-Id: Iae9daefb9b2173736c039d6177d7356c27eb7a33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97605 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-07-01Related: tdf#134360 table row/height widgets can get stuck insensitiveCaolán McNamara1-14/+10
Change-Id: I1be53f33f60c510757c67f1da8f863539ecbffdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97547 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01tdf#133070 DOCX import: fix shape height relative to bottom page marginRegényi Balázs6-4/+60
using UNO API RelativeHeightRelation and the associated lo-ext attribute for OpenDocument export. See commit 43d7f4e3640c5e370fd1204739c2b0c7eb5f40e4 (offapi: document the 4 new properties which are no longer read-only). Co-authored-by: Szabolcs Tóth Change-Id: I31db99fac5ad24971fa427671198b47906e9c057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95451 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-01tdf#134404: sw: Add unittestXisco Fauli2-0/+31
Change-Id: I81e46e06ad7964e52b45ce3433a25758cc7d19fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97534 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-01Remove some unused includesMiklos Vajna1-28/+0
Change-Id: I44c9ad2511d484e3c7fb1c33f25fcb343eabd232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97548 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-01change n777345.docx to check bitmap content instead of checksumLuboš Luňák2-8/+6
Bitmap checksums are unreliable, they often depend on underlying implementation and whatnot. Change-Id: Ifc13285d6eb7d6d050a1ec26b270e0533eaae8eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97533 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-30tdf#134043 DOCX import: new unit tests: ComboBox to DropDownSerge Krot2-22/+57
Change-Id: I513933b508ca531e17271a3cc821a6aef2244868 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97531 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-30tdf#134277 sw table: fix lagging shape at page breakBakos Attila3-4/+26
Shapes anchored to characters in table cells didn't follow their cells at page break, resulting lonely shapes at the end of the previous page. Co-authored-by: Attila Bánhegyi (NISZ) Change-Id: I2149ef58696a8f5dc6f41959060d2d57f938d025 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97209 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-30dont (ab-)use typeless GetInfo() interfaceBjoern Michaelsen4-19/+8
Change-Id: I73ab1e0efcb3559dfe37f3f408b3ec4862a408e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97472 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-06-30tdf#134021: sw: Add unittestXisco Fauli2-0/+28
Change-Id: I789adaf699a857e28416132d253c04128def5984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97481 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30tdf#134414 Variables page doesn't need expandersCaolán McNamara1-2/+2
Change-Id: I5a38e1e8052c96970f9701f776f7675fda5f21c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97479 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30tdf#134404 sw: another subtlety with start/end of section (at-para flys)Michael Stahl1-2/+2
fix this problem by comparing the start/end of the selection instead of the anchor position, which always has an index of 0: 1. new document with image anchored to paragraph 2. insert one letter 3. press Enter 4. Backspace -> Image gone (regression from cc4b5091e739116a7ec83513fa1cd856f0130330) Change-Id: I1219a9f58ce19ea88d697c90c862fe9005318177 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97511 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-30tdf#134243: sw: Add UItestXisco Fauli3-0/+30
Change-Id: I59376419048ddddff3e4fbbd6d3eb7436ee87747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97029 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30tdf#126425 Chart: fix missing legend with exceeding textTünde Tóth2-0/+17
Ellipsize legend box contents, if the custom size of the chart legend is too small to contain the text. Change-Id: I91ef913f509b233912a8bfb878a1c80d577e2a88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96437 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-30tdf#134099 sw: fix textbox anchors on copy-paste and undoMiklos Vajna4-0/+50
Regression from commit c7307c77254557646f33017af915f6808a861e29 (fdo#82191 sw::DocumentLayoutManager: copy textbox content of draw formats, 2014-08-15), without which this problem gets hidden, as copy breaks the textbox into 2 pieces, so the textbox codepaths are no longer hit. The direct problem is that SwHistorySetFormat::SetInDoc() uses a raw node index into the nodes array, which is past the end of the nodes array. Root cause is that we have this invariant that actions and their undo has to be in sync, otherwise raw node indexes no longer work. In this case, SwUndoSaveContent::DelContentIndex() did not delete a fly frame format, because it was out of range, as it had a wrong anchor. Fix this in SwTextFlyCnt::SetAnchor(), so that whenever the anchor of a draw format is set via that function, we update its textbox as well. Also fix a related problem when fly formats were copied twice. Change-Id: I0d6c9069544c405eb20c5fed65fb40423b0adc84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97457 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-30tdf#130151 Fix toc pointing to wrong pageSamuel Mehrbrodt1-2/+2
Change-Id: I26c1027722613f751bd39fde97f1e14d3238eefa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97413 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins
2020-06-29OOXML/ODF Support for Shadow blur radiusA_GAN1-2/+2
Adding export support for OOXML. Adding import/export support for ODF Changing some values in test cases as convertEMUtoHmm round the fraction. Add two test functions for OOXML and ODF export. Change-Id: Ie5d862b46b5264ead4954f407fee2837b5151cd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96907 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29tdf#134235 Chart OOXML import: fix long chart titleTünde Tóth2-0/+17
Workaround to handle long (sub)titles which resulted broken charts. See commit 96a29c12a9d8734c9d2a812f38fc6654b5df9c48 (tdf#101322 Chart OOXML Export: fix missing subtitle). Change-Id: I22bb4699bdda8dea5f31c715cc1f439085a0718f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97092 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-29tdf#134247 Chart OOXML import: fix order of legend entriesTünde Tóth2-0/+17
The order of legend entries was reversed in stacked column, line and area charts. Change-Id: Ia4a439aa6cee0619ad323c3fb728ff358cf28537 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96941 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-29tdf#122225 Chart OOXML import: fix missing legend textTünde Tóth2-0/+17
resulted by inaccurate calculation of nMaxTextWidth. Change-Id: Ie41bbc30074c6bbccacbc58adda5d9f2cfdfeba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96926 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-29sw: prefix members of CompareNodeContent, SwDDEFieldType, ...Miklos Vajna7-105/+105
... SwDropDownField and SwRangeRedline See tdf#94879 for motivation. Change-Id: Ic38825413d5725a143a2a7f81f0d464984e231e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97360 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-27tdf#134326 allow 2 decimal places for asian grid point sizesCaolán McNamara1-8/+11
possibly a regression since... commit 1f622157d10b15c7d9496e3887f493de0f0f94c8 Date: Sun Apr 7 18:04:11 2013 -0300 Convert Writer asian text grid page to Widget UI and use the same step increments found before that conversion Change-Id: Ifbbc847a487e0b7d33704e6cac74a6c1c6012ed4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27cid#1401342 Uncaught exceptionCaolán McNamara1-2/+2
Change-Id: Ia22ed8541f1148355d71cd5b90ad13e64c1b50c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97289 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27cid#1464973 & cid#1464975 Resource leakCaolán McNamara2-3/+3
Change-Id: I4df8fefa7f875e0a25585c4fef22f077dcd0b83d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97318 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27cid#1464971 Dereference null return valueCaolán McNamara1-1/+1
Change-Id: Id0f6aec4552e551d3ba697bb4a3c9b0e498fdf24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97315 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27cid#1464968 Logically dead codeCaolán McNamara1-3/+0
added in... commit 99c4fefdbb6129a58421b9c7f4a005f868a0e701 Date: Wed Apr 22 11:43:22 2020 +0300 tdf#98409 doc export: export (non-default) cell margins Change-Id: Ie6bf4f16f73eb4d6b604e7c98ee61b388e9acd27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97312 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27cid#1464963: Null pointer dereferences (sw/wrtww8)Julien Nabet1-2/+2
Change-Id: Iea4b91b440c87a8a193a3c6b683a017d0948399c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97281 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27cid#1464967: RESOURCE_LEAK (sw/wrtww8)Julien Nabet1-1/+1
Change-Id: Ic1aa0d42f174808c7700875cb31f1c726b3160e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97280 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27cid#1464974: Null pointer dereferences (sw/unosett)Julien Nabet1-2/+2
Change-Id: I4ea6de59ce1d1cb3133b0fb57176caee5497878f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97276 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27Colibre: tdf#133538: icons for Show White SpaceRizal Muttaqin3-3/+3
Change-Id: I757696ece0b06cdd91358ea8944ba5cc49a644d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97274 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-26update some pchesCaolán McNamara1-1/+6
Change-Id: I54b734062d94a59c2651827c02349d9562ac6cf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97262 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26UITest_writer_tests7: wait until the child is available (blind fix)Xisco Fauli1-0/+4
it fails spuriously with Traceback (most recent call last): File "sw/qa/uitest/writer_tests7/tdf99711.py", line 43, in test_tdf99711 self.assertEqual(get_state_as_dict(xWriterEdit.getChild('selectwidth'))['Text'], '10.00 mm') uno.com.sun.star.uno.RuntimeException: Could not find child with id: selectwidth Change-Id: If80dac67880a1f4200331a7894ba2ecae4504bb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97184 Tested-by: Jenkins Tested-by: René Engelhard <rene@debian.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26Upcoming improved loplugin:elidestringvar: swStephan Bergmann6-12/+7
Change-Id: I8cfc70f45a1fe8dff6c272ba617e73cf97480092 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97203 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26vcl: split off QueueInfo to own filesChris Sherlock1-0/+1
Change-Id: Ib2904066edd371229c5daa09b81b210e99853895 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96251 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-26tdf#123786 AutoCorrect: fix apostrophe in RussianLászló Németh2-0/+41
and Ukrainian at "Single quotes" replacement outside of second level quotations. For example: „quote' -> „quote‘ but now apostrophe' -> apostrophe’ instead of the bad apostrophe' -> apostrophe“ Change-Id: Iad69b7f88ab9677f25ee0f806d035e16cdebe29b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97096 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-25tdf#133026: Tight integration of extensions - Additions Dialog first iterationYusuf Keten2-0/+14
- Add the uno command .uno:AdditionsDialog - Add the necessary commands to cui makefiles. - Add the dialog AdditionsDialog for only test - Implement the basic functionality to show up when clicked on the menu/toolbar item. Change-Id: I89dd74e49f5ff246ca355d2f8d1397621b26dea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95593 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-06-25UBSan needs SwSidebarItem RTTI outside of Library_swStephan Bergmann1-1/+1
e.g., <https://ci.libreoffice.org/job/lo_ubsan/1672/> > DynamicLibraryManagerException: "Failed to load dynamic library: /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_sw_uiwriter.so /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_sw_uiwriter.so: undefined symbol: _ZTI13SwSidebarItem" after e619d685a4ac4e8a20f047be3fe00f5b492553b8 "sw: make postithelper.hxx self- contained" Change-Id: I42debde887b7cbd64c28efc4421cf076bc34ee38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97109 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-25-Werror=maybe-uninitialized: may be used uninitialized in this functionNoel Grandin1-3/+3
Change-Id: Iae4ca4fb760bd0fae8e26e6c77f20159cfb61388 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97110 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-25UITest_writer_tests7: Wait for async events (blind fix)Xisco Fauli1-0/+4
<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/62483/> failed spuriously with ERROR: test_tdf133348 (tdf133348.tdf133348) ---------------------------------------------------------------------- Traceback (most recent call last): File "sw/qa/uitest/writer_tests7/tdf133348.py", line 44, in test_tdf133348 self.assertEqual(xEnum.nextElement().Author.strip(), 'Known Author') tdf133348.com.sun.star.container.NoSuchElementException: SwXFieldEnumeration::nextElement Change-Id: I5504f6febb20eb174b480f0d38176b1a70407716 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97097 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-25Get the property dump of the text at the cursorShivam Kumar Singh3-13/+196
We need the property dump consisting of 1) Character Properties 2) Paragraph Properties 3) Character Style Properties 4) Paragraph Style Properties This patch gives all the properties related to 'Character Styles' at the cursor. This patch manages inheritance features, which means, it lists any property only at that level in which the property has been redefined for the last time. Change-Id: Ice2ae9ac92aec4af9d395885e06602753e636457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95094 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-25use tools::JsonWriter for dumping property treeNoel Grandin1-1/+1
Change-Id: I8f55af19ba10b71bd621e69b27000ab7cb565309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96677 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-25tdf#125893 DOCX import: fix "half" contextual paragraph spacingLászló Németh3-2/+20
Always ignore own top margin setting of the actual paragraph with contextual spacing, if the previous paragraph is identical. I.e. in that case, too, when the previous paragraph has no contextual spacing, like MSO does. Note: PARA_SPACE_MAX mode hasn't included this modification, yet, so only ODT documents converted from DOCX use it at the default setting. See also commit ba18832ceeda21f047a664b71a4333a54737e6c8 (tdf#75221: make margin collapsing implementation conform OASIS proposal) Change-Id: Ida9d12b2c511fcd5e38ade7eb5f4650387c65813 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97081 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-25sw: handle BackgroundParaOverDrawings when replacing compat optionsMiklos Vajna1-1/+1
This was added in commit 18b3feb8bef06bf7b126fd0bc743e19479cb8026 (n#778133 sw: add BackgroundParaOverDrawings compat flag, 2012-09-12), it's off by default and on for DOCX documents. Change-Id: If584f8eef2672d5d41c249e2b77b20f029587e23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97078 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-25Fix typosAndrea Gelmini1-1/+1
Change-Id: I2bccc7beb2e9dfccd84b118a33a7aee9753a8be1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97040 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-24Remove obsolete comment about LF on old Mac OSStephan Bergmann1-1/+1
(and where sticking to numeric '\x0A' is probably cleaner anyway) Change-Id: I77efcffea7fe246984be0a599f3c403397b8a9c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97043 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-24tdf#124176 Use pragma once instead of include guardsWyatt Turner1-3/+2
Changes include guards in threadmanager.hxx to #pragma once Change-Id: I9cdc391f68389b0e23fa52598f5c2f1281d4e7a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91080 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>