summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2019-11-02New loplugin:conditionalstringStephan Bergmann6-10/+10
Change-Id: I2eab990c15f845b44a3b598571aca361dadf9ff3 Reviewed-on: https://gerrit.libreoffice.org/81946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-02cid#1455216 Dereference before null checkCaolán McNamara1-2/+2
Change-Id: I84752fcd154e2e9c344e3ad397f26c1a0d5184c2 Reviewed-on: https://gerrit.libreoffice.org/81941 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02cid#1452004 silence Explicit null dereferencedCaolán McNamara1-1/+1
Change-Id: I3cfc071f1ae1084801708ae82dc1f1f91402c08c Reviewed-on: https://gerrit.libreoffice.org/81944 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02cid#1455211 Dereference after null checkCaolán McNamara1-2/+2
Change-Id: I73ce64812d4ff88f7b1d0e122c208d64f04b893d Reviewed-on: https://gerrit.libreoffice.org/81937 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02Table panel: Make sure all toolbox buttons has the right initial stateTamás Zolnai2-0/+43
For this we need to add a ControllerItem for all toolbox buttons. See SfxStateCache::SetCachedState(). Change-Id: Id69a92fe5748617e3cd98c3007afbff2885a5d3b Reviewed-on: https://gerrit.libreoffice.org/81899 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Table panel: Make sure Row Height spin button works with the default size typeTamás Zolnai1-0/+2
SwFormatFrameSize() object has ATT_VAR_SIZE size type by default, before we change it to anything else. We will change ATT_VAR_SIZE to ATT_MIN_SIZE when changing the row height on the sidebar panel, similar to the row height dialog. Change-Id: I2520340e023b910549ff2a4b011e9ae3da2b7b11 Reviewed-on: https://gerrit.libreoffice.org/81897 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Table panel: Redesign the panel a bitTamás Zolnai1-149/+79
* Remove some labels. * Move 'Merge Cells' button next to the insert / delete buttons. Change-Id: Ibe0acc8e8825dbaa84464bc7347f7711f8185680 Reviewed-on: https://gerrit.libreoffice.org/81896 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Table panel: Implement functionality of Column Width spinbuttonTamás Zolnai6-12/+115
Change-Id: I809cfe4af82cebabe80c171cdd488ff43d749a86 Reviewed-on: https://gerrit.libreoffice.org/81895 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Table panel: Implement functionality of Row Height spinbuttonTamás Zolnai7-9/+145
Change-Id: Ic3e3ce31fdc74c9cb4c41e1243f10f5977d5bb0c Reviewed-on: https://gerrit.libreoffice.org/81894 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-02Add new 'Table' sidebar panel to WriterTamás Zolnai6-0/+558
This is the initial layout of the panel. It does not functional yet. Change-Id: Idd67ed921b71559bb704ef50cbfa97013fb80d6b Reviewed-on: https://gerrit.libreoffice.org/81893 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-01Resolves: tdf#128476 limit sidebar navigation panel file name combobox widthCaolán McNamara1-0/+1
Change-Id: I81549ada6f6b736ad54e18a4fec6807b8d0412af Reviewed-on: https://gerrit.libreoffice.org/81875 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31Fix typoAndrea Gelmini1-1/+1
Change-Id: Id26980c410f512f711f674af72d070e3b074f13b Reviewed-on: https://gerrit.libreoffice.org/81866 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-31tdf#128431 Box info item is needed by the Border Background dialogJim Raykowski1-0/+14
...so put it back Change-Id: Ie2883410514496c247f840fb2d6755bec362a8b2 Reviewed-on: https://gerrit.libreoffice.org/81815 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-10-31avoid intermediate vcl::WindowsCaolán McNamara3-22/+14
Change-Id: Ie0618107a3aee4a0d35867f3c1cf83715e7bc842 Reviewed-on: https://gerrit.libreoffice.org/81763 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31tdf#125038 DOCX import: better support for linebreaks in IF fieldsMiklos Vajna1-1/+7
IF fields can't contain linebreaks, so instead of just calling finishParagraph() and hoping it does something sane, explicitly handle them: remember the properties and perform the call only once the field is closed. Change-Id: I676aa2c83f12cb600829177a0eb25558822b1d94 Reviewed-on: https://gerrit.libreoffice.org/81847 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-31Fix typosAndrea Gelmini1-2/+2
Change-Id: I917e4cdac3690dd5134e4994a0ee4106ae88ae36 Reviewed-on: https://gerrit.libreoffice.org/81860 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-31jsdialogs: .uno:XFillColor with string argumentSzymon Kłos1-4/+19
Change-Id: I7f078fc66cecacccd4473495f96e4e2dbfd89d14 Reviewed-on: https://gerrit.libreoffice.org/81832 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-31remove some stray random propertiesCaolán McNamara5-15/+0
Change-Id: I0f20e057b97bcb3ab120ae6b211729ea60937bd8 Reviewed-on: https://gerrit.libreoffice.org/81769 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31avoid intermediate vcl::WindowsCaolán McNamara1-1/+1
Change-Id: Iac6bc83265e007a699a8993b89ac2efaa3739d95 Reviewed-on: https://gerrit.libreoffice.org/81761 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31tdf#125038 DOCX import: fix lost MERGEFIELD result inside an IF fieldMiklos Vajna2-0/+10
The problem here was that the IF field result didn't have a plain text string, rather it had a MERGEFIELD in it. Writer's conditional text field expects a plain text string, so just use the result of the MERGEFIELD for an IF parent. Do this in a generic way, it's likely that other parent-child field combinations want to do the same in the future. With this, all lost strings are fixed from the original bugdoc + all unexpected content is hidden in Writer as well. Change-Id: Ic5c03b1df2f08a2cd851647b625e0c303cc5d6c5 Reviewed-on: https://gerrit.libreoffice.org/81825 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-31Insert section is supposed to be a modal dialogCaolán McNamara1-0/+1
Change-Id: Ie67303cbe26313994a89b2057ae673805a38cced Reviewed-on: https://gerrit.libreoffice.org/81806 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31sw: copy bookmarks in SwDoc::CopyPageDescHeaderFooterImpl()Michael Stahl3-7/+21
When importing tdf113521-1.doc, a footer is copied, but the fieldmark in it is not copied, so there are CH_TXT_ATR_FIELD* in the copy without matching fieldmark, and the result is sw/source/filter/ww8/wrtw8nds.cxx:2342: virtual void MSWordExportBase::OutputTextNode(SwTextNode&): Assertion `pFieldmark' failed. Change-Id: I42b005e22b57f181e4e8bc52afb053546db5f741 Reviewed-on: https://gerrit.libreoffice.org/81792 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-31sw: WW8 import: filter control characters in GetFieldResult()Michael Stahl1-1/+30
Triggers the assert in SwSubFont::GetTextSize_() on ooo58234-1.doc, which has a field result with ^G cell separators that is converted to SwInputField, which inserts the field result into SwTextNode. Change-Id: Ibdb93390862a11462d62cf744bac912d6009777e Reviewed-on: https://gerrit.libreoffice.org/81788 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-31jsdialogs: .uno:XLineColor with string argumentSzymon Kłos1-1/+30
Change-Id: Ic06aaef076d101d90bf76461e2b3a97580ad311f Reviewed-on: https://gerrit.libreoffice.org/81821 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-31Fix StringAdd::isCompileTimeConstantStephan Bergmann20-114/+49
...to find StringLiteral on the RHS of +=. Which revealed that the VisitCompoundStmt/checkForCompoundAssign logic needed to be fixed, too, so that s += side_effect(); s += "literal"; s += side_effect(); only gets combined to s += side_effect() + "literal"; s += side_effect(); and not all the way to s += side_effect() + "literal" + side_effect(); Change-Id: I432e3458b933a7d0ad6141c747b675cc8b0f0ba4 Reviewed-on: https://gerrit.libreoffice.org/81804 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-31related tdf#99602 docxoutput: fix incorrect rounding on subscriptsJustin Luth2-5/+19
Adding .5 is a poor mans version of rounding which works fine with unsigned numbers, but not with negative numbers. Perhaps use the exotic round() function instead? In addition, the font size isn't necessarily an integer, so that should have been a float. The result of bad rounding was losing a percentage of the subscript every round-trip. Change-Id: I83e05d8367f059f3266d12a7e134e268fef758bb Reviewed-on: https://gerrit.libreoffice.org/80217 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-31related tdf#99602 ww8/rtfoutput: fix incorrect rounding on subscriptsJustin Luth3-12/+13
Adding .5 is a poor mans version of rounding which works fine with unsigned numbers, but not with negative numbers. Perhaps use the exotic round() function instead? In addition, the font size isn't necessarily an integer, so that should have been a float. The result of bad rounding was losing a percentage of the subscript every round-trip. Change-Id: I9093f7bfcd0b87249b42562668e45480dcb59f53 Reviewed-on: https://gerrit.libreoffice.org/80218 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-31sw layout: remove checks for IsLayoutInCellMiklos Vajna5-14/+4
IsLayoutCell was only set by the DOCX import via an UNO API which is already gone, so this is effectively dead code. Change-Id: Ic2aab85f42a6a6f5c762d7986425b1f7206c9198 Reviewed-on: https://gerrit.libreoffice.org/81808 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-30Related: tdf#125038 DOCX import: fix unexpected linebreak inside IF conditionMiklos Vajna2-0/+17
Writer body text is expected to only contain the result of the field. So in case both the field command and the field result contains a linebreak, we need to make sure that linebreaks are ignored in the field command for field types where the Writer field implementation expects a single string. With this, the number of paragraphs in the bugdoc is now correct. Change-Id: I42f208d6943750ba2e8f88b52c373f6ca9cb2b71 Reviewed-on: https://gerrit.libreoffice.org/81786 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-30sw: document what is an SwLayoutFrameMiklos Vajna1-0/+1
It confused me that we have an SwFrame::GetLower(), but that always returns nullptr for any non-layout frames. Change-Id: I6dd5ddbede852ed6c702a9216439aedf985353db Reviewed-on: https://gerrit.libreoffice.org/81736 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-30sw: SwXFrame::attach(): re-anchoring AS_CHAR flys does not workMichael Stahl1-0/+8
This happens on import of fdo75208-1.docx, where this: 9 writerfilter::dmapper::DomainMapper_Impl::appendTextContent(com::sun::star::uno::Reference<com::sun::star::text::XTextContent> const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x6406be0, xContent=uno::Reference to (SwXTextFrame *) 0x6944030, xPropertyValues=empty uno::Sequence) at writerfilter/source/dmapper/DomainMapper_Impl.cxx:1845 10 writerfilter::dmapper::DomainMapper_Impl::PopShapeContext() (this=0x6406be0) at writerfilter/source/dmapper/DomainMapper_Impl.cxx:2620 11 writerfilter::dmapper::DomainMapper::lcl_endShape() (this=0x6406b10) at writerfilter/source/dmapper/DomainMapper.cxx:2989 ... somehow wants to reanchor it but the result is that the SwFormatAnchor in the SwFrameFormat points to one node and the SwTextFlyCnt hint and its CH_TXTATR dummy char are in a different node, and during text formatting we get sw/source/core/text/txtfrm.cxx:1261: TextFrameIndex SwTextFrame::MapModelToView(const SwTextNode*, sal_Int32) const: Assertion `static_cast<SwTextNode*>(const_cast<SwModify*>(SwFrame::GetDep())) == pNode' failed. If this is really intentional something, perhaps SwFrameFormat::Modify(), would need to move the hint too, but probably this is an accident. Change-Id: I4d2afec275f187a65d18c0bcd0fd17e12c42ed0a Reviewed-on: https://gerrit.libreoffice.org/81702 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-30sw: makeMark(): insert CH_TXT_ATR before inserting into sorted vectorMichael Stahl1-1/+3
... because if the new fieldmark is exactly around an existing fieldmark, we get this on tdf112797-3.docx: sw/source/core/doc/docbm.cxx:481: void {anonymous}::lcl_DebugMarks(const container_t&): Assertion `std::is_sorted(rMarks.begin(), rMarks.end(), lcl_MarkOrderingByStart)' failed. Change-Id: If998c95d4c6c40654936773defc674ee55f736c4 Reviewed-on: https://gerrit.libreoffice.org/81700 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-30sw: UNO API: do not allow inserting control characters into nodesMichael Stahl1-0/+12
Refuse invalid input in DocInsertStringSplitCR(). Change-Id: I097c1b3a1f70b0cf1fa3fc33fc1d965ee6c96280 Reviewed-on: https://gerrit.libreoffice.org/81696 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-30remove some unnecessary includesCaolán McNamara7-7/+1
Change-Id: I5cad1142641587ef4393cbf73384f93540d61038 Reviewed-on: https://gerrit.libreoffice.org/81712 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29tdf#128399 sw btlr: fix clicking to lower rotated cellMiklos Vajna3-6/+34
In case a table has more than 1 btlr cells in multiple rows, the first captured the mouse. This was because SwFrame::GetPaintArea() assumed that left and right edges can be compared directly, without going via the SwRectFnSet abstraction. This works for hozizontal and plain vertical directions, but not for btlr. Change-Id: Ia3bd7623a5d8d9ad3bdfabceb10adc0dbf105059 Reviewed-on: https://gerrit.libreoffice.org/81688 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-29return value from IDocumentLinksAdministration::SetData unusedNoel Grandin4-8/+7
since initial commit Change-Id: If104670adc57501f6712c3c060590251c266118a Reviewed-on: https://gerrit.libreoffice.org/81649 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29remove unnecessary includesCaolán McNamara35-39/+6
Change-Id: Ia4a622b34ff3f71963cff7a1aa8658a4df12f04f Reviewed-on: https://gerrit.libreoffice.org/81676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29sw: makeMark(): check position of point fieldmarksMichael Stahl1-0/+12
A new point fieldmark must have an empty range, which is expanded when the CH_TXT_ATR_FORMELEMENT is inserted. A copied point fieldmark must contain exactly its CH_TXT_ATR_FORMELEMENT. Change-Id: Iaf3cdad058539300199fe159d215b7aa37dae35d Reviewed-on: https://gerrit.libreoffice.org/81672 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-29weld fpicker clusterCaolán McNamara1-1/+1
Change-Id: I6566263809ff0032388a0b56571f0cf7428058d7 Reviewed-on: https://gerrit.libreoffice.org/81334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29tdf#104017 DOC export: be less aggressive with merging page stylesMiklos Vajna3-1/+10
Regression from commit 7146d8bcd96f844dc0239a5b29a6b36c3cb5a2cc (MSWordExportBase::OutputSectionBreaks: avoid fake section breaks, 2014-07-28), the problem was that we merged two separate page styles just because they were similar. This resulted in merging two independent tables into a single one. Fix the problem by merging the first and follow page style only in case the first page style is RES_POOLPAGE_FIRST, this resolves the current problem and keeps the original problem fixed, too. (Long-term, a better fix would be to not split the page styles in writerfilter/, similar to how the DOC import doesn't do that anymore: and then the merging can be avoided unconditionally.) Change-Id: I357f1337cb0abc7fa1d88aa44ff87b4b464af81c Reviewed-on: https://gerrit.libreoffice.org/81630 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-28Related: tdf#125038 DOCX import: fix unexpected MERGEFIELD result inside IFMiklos Vajna2-0/+9
The problem is that DOCX supports nesting MERGEFIELD fields inside IF fields, while SwHiddenTextField only supports a single string as a condition. This means in case there are MERGEFIELD fields inside the IF field, those fields will be inserted to the doc model before the IF field, exposing their value, while Word only uses their value during the evaluation of the IF expression. Fix the problem by inspecting the parent field command before setting the MERGEFIELD result. Change-Id: Ieca098f16f756bab5d23f219fa4ca30d077d4bb7 Reviewed-on: https://gerrit.libreoffice.org/81615 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-28tdf#128418 Fix crash in print previewSamuel Mehrbrodt1-3/+5
Change-Id: I2a8c5511563ac3205722d63f22cde472a8aaddde Reviewed-on: https://gerrit.libreoffice.org/81610 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-28jsdialogs: allow to use transparent highlightSzymon Kłos1-1/+4
Change-Id: Ib19dbbf3c13afd20bee47226704887f899c99b5d Reviewed-on: https://gerrit.libreoffice.org/81597 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-28related tdf#99602 writerfilter TODO: subscript - use CharStyle fontsizeJustin Luth1-1/+1
GetAnyProperty was missing a check for character style properties. This patch depends on commit 875793d841165aaaaefa2c34b855e8f0f8a8c214 related tdf#99602 writerfilter TODO: subscript - use ParaStyle fontsize and on commit 5e97d1a57717f8dbf69b987d2bda8616972eec52 NFC writerfilter: preparation for adding CharProps to GetAnyProperty Change-Id: I4e28589917e41fa545d5aab05f97a67502486136 Reviewed-on: https://gerrit.libreoffice.org/80216 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-28tdf#121441 improve DOCX footnote importJan-Marek Glogowski6-20/+59
ODF represents footnotes by using a fixed string for the label (text:note-citation) and a flexible body (text:note-body) for the representation in the footnote area. The only formatting of the footnote reference is done by changing the character class assigned to the anchor (which is the text range of the label in the text). For most of the setting, the footnote area label just follows the footnote body character formatting. OTOH MS Word has no such "restrictions". It handles the label just as concated, formated text runs with the same style. On top of it, DOCX completely splits the reference from the footnote area part, including its own label, which can easily result in completely different labels for the footnote and the reference, as I happened to repoduce for my test documents. At this point it's quite obvious that for any complex footnotes, LibreOffice won't be able to represent them. IMHO ODF should offer the same flexibility for the label and the body and allow all the normal formatting in the label. I'm not sure that getting footnote area and reference label out of sync is a good idea. So this patch tries to improve the situation in the current constraints set by ODF. 1. It imports all runs of the whole custom DOCX footnote label. 2. If any run contains a symbol, switches the font of the whole label to the referenced symbol font. 3. Completely ignores the label of the footnote area and overrides the font of the footnote area label with the font of the reference. Other problems I found while testing this code: 1. LO edit field correctly gets the font and character set, but displays empty glyphs. So no real way to edit the label. 2. Normally the font of the footnote area label would follow the footnote font. This doesn't work anymore when the font is overridden for the label. Setting the whole font of the label to Symbol doesn't seem like a good solution either. 3. You can't mix multiple fonts, or even symbols and letters, as you can just select one font for the label. 4. You can't change the footnote are label font at all and since it doesn't follow the footnote area anymore, there is basically no way to change it. Change-Id: Iafa16936be81e1866c610ebf0f71ab15e74dd059 Reviewed-on: https://gerrit.libreoffice.org/81370 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-10-28jsdialogs: fix .uno:BackColor commandSzymon Kłos1-5/+5
Change-Id: I628067afa4c3a8d28c5c3635c4e5e46f9febdf94 Reviewed-on: https://gerrit.libreoffice.org/81602 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-28jsdialogs: make possible to set .uno:BackgroundColor in WriterSzymon Kłos1-2/+30
Change-Id: Ifd6a63683ddf36a3c1e8babd9c030ae5f051ed00 Reviewed-on: https://gerrit.libreoffice.org/81596 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-28loplugin:stringadd improve detectionNoel Grandin6-61/+52
if one side of the expression is a compile-time-constant, we don't need to worry about side-effects on the other side Change-Id: Iee71ea51b327ef244bf39f128f921ac325d74e2b Reviewed-on: https://gerrit.libreoffice.org/81589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-28cid#1455157: sw: Memory - illegal accesses (WRAPPER_ESCAPE)Michael Stahl1-1/+1
(regression from b522fc0646915d4da94df38dd249c88b28f25be7) Change-Id: I54f93ac16a2d4ddc687937d44c3aec450e59dd0e Reviewed-on: https://gerrit.libreoffice.org/81588 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-28jsdialogs: make possible to set .uno:BackColorSzymon Kłos2-3/+17
Change-Id: I2fd9a70b54f211dbfe9bb58102e17afd38516d5d Reviewed-on: https://gerrit.libreoffice.org/81587 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 08:36:32 +0000