summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2018-10-18weld SwMMResultEmailDialogCaolán McNamara7-198/+147
Change-Id: Ib12455751074bbd818cc2da0c813fe984d887571 Reviewed-on: https://gerrit.libreoffice.org/61920 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18weld SwMailMergeCreateFromDlgCaolán McNamara7-32/+35
Change-Id: I9885881bfc6baffe1184d52c207d8f5d81a4a3b4 Reviewed-on: https://gerrit.libreoffice.org/61919 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18weld SwMailMergeOutputTypePageCaolán McNamara3-34/+26
Change-Id: I4177bfd48b6af1cfc526e5ff43f00f1405ea647f Reviewed-on: https://gerrit.libreoffice.org/61911 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18weld SwMailMergeDocSelectPageCaolán McNamara4-72/+58
Change-Id: I0a319624656eb1305522ebd4ae3ff63d5106db3b Reviewed-on: https://gerrit.libreoffice.org/61910 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18editeng: do not throw from QueryValue implementationMichael Stahl1-0/+6
None of the other QueryValue throw; in case of a problem they return false without initialising the Any. On the one hand, it would be useful to throw an exception for this special property that has now become Write-Only, so that API users get a better hint what is going wrong; on the other hand, it breaks various other things like the various multi-property interfaces that call QueryValue for multiple items (there are 3 such loops in SwAccessibleParagraph alone). (throw was introduced in 7a8ed362eb163ac15a000ba1cfc74b58315800a1) It turns out there is even a test for the exception on ToX. Change-Id: Id60ff43544f7399ce869227bfd6fb933dbaea3be Reviewed-on: https://gerrit.libreoffice.org/61719 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-18weld SwMailMergeAddressBlockPageCaolán McNamara3-104/+103
Change-Id: I0344e3c408f07f97caa34a87ce9e1559b6a76892 Reviewed-on: https://gerrit.libreoffice.org/61889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18weld SwMailMergeGreetingsPage and SwMailBodyDialogCaolán McNamara8-463/+697
Change-Id: I7ac171654ec0a5095c05d1b54bec423b8eb9247b Reviewed-on: https://gerrit.libreoffice.org/61888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-18clang-tidy readability-simplify-boolean-exprNoel Grandin3-30/+9
Change-Id: I78fa01a6c803dec782488490b730af3a11814d64 Reviewed-on: https://gerrit.libreoffice.org/61902 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-18tdf#37778 ww8import: protect section only if protEnabledJustin Luth3-1/+13
Protection is not related to fReadOnlyRecommended In Word, documentProtection enforcement is a document level setting which is required for the section protection setting to be enforced. formprot: "The enforcement of this property is determined by the documentProtection element (§17.15.1.29), as it is possible to specify protection without turning it on." In LO, section protection is honored if it is simply enabled, so only enable a section's protection if the enforcement variable is set. Round-tripping will lose the fact that sections are marked as protected if the enforcement is off. patch initially developed to support tdf#120499 where the focus is on sections, not on read-only and the fake section that was being created. Change-Id: I08c37ea6a9cc8fd1bdf7f36771b2d719bf9c93d6 Reviewed-on: https://gerrit.libreoffice.org/61899 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-10-17Resolves: tdf#120003 missing prefix to link url in .doc importCaolán McNamara1-4/+30
regression from... commit 9b77f8142bf665a47c3a179e3fe3f82623a99f8a Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Apr 6 15:08:45 2017 +0100 ditch ReadRawUniString three argument lclGetString32 variant mistaken for two argument lclGetString32 variant Change-Id: I163aad0de7873487d9f9c8b6c28d162159fe7ad4 Reviewed-on: https://gerrit.libreoffice.org/61884 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-17tdf#120395 - Rename Page numbers in Fields dialogheiko tietze1-1/+1
Change-Id: I47c52fbda3692178ad6c02fea7615463eeb4dcc8 Reviewed-on: https://gerrit.libreoffice.org/61876 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-17Limit variable scopeMike Kaganski1-1/+1
Change-Id: I42d2e59297a70c977ec2f7782b403c1f79c434de Reviewed-on: https://gerrit.libreoffice.org/61875 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-17weld SwMailMergeFieldConnectionsDlgCaolán McNamara7-36/+36
Change-Id: I15ee027db596c98eef878e2e174429c532789dad Reviewed-on: https://gerrit.libreoffice.org/61871 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-17sw, writerfilter: avoid some unnecessary value parametersMiklos Vajna2-2/+2
Change-Id: I409eb644bdf519e097c87911b90f83c5ecd913ee Reviewed-on: https://gerrit.libreoffice.org/61853 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-17clang-tidy readability-redundant-smartptr-getNoel Grandin46-130/+133
redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17loplugin:singlevalfieldsNoel Grandin1-7/+2
tighten up the handling of binary operators Change-Id: I262ec57bf7142fa094d240738150a94d83fd15ee Reviewed-on: https://gerrit.libreoffice.org/61777 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17Notebookbar: sync tabbedbarandreas kainz1-31/+20
Change-Id: I6441f66f7cd078dae0c81cb1a5c62b5130187536 Reviewed-on: https://gerrit.libreoffice.org/61858 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-16tdf#119885: OOXML import: try to get cell paddings as Word doesMike Kaganski3-11/+13
Change-Id: I7abd715b6bb71d6e2e01939c4cf849d94eb6a103 Reviewed-on: https://gerrit.libreoffice.org/61843 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-16Related: tdf#120612 help response missing from other help buttonsCaolán McNamara1-0/+3
Change-Id: I982b4190f5af2715f797ecd9bf798e4b4af0ecda Reviewed-on: https://gerrit.libreoffice.org/61828 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16Notebookbar: update tabbed toolbar for calcandreas kainz1-158/+5
remove separator in other tabbedbars Change-Id: I99c83cd09e5fa8bde2809680d5ef138c4ef499de Reviewed-on: https://gerrit.libreoffice.org/61803 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-16loplugin:singlevalfields in vclNoel Grandin1-2/+1
Change-Id: I159f94fba64acc0e0599b64be02c7864b1ed02c3 Reviewed-on: https://gerrit.libreoffice.org/61813 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-16ofz#10994 move the reset of trailing fly paras to before redline processingCaolán McNamara1-3/+3
Change-Id: I906c29848acc3917f76cb8c21e0bd581e0ded421 Reviewed-on: https://gerrit.libreoffice.org/61819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16sw: merge test suites sw_unoapi and sw_unowriterVasily Melenchuk5-311/+217
Both test suites have the same propose "Test to assert UNO API call results of Writer" so better to keep them together. Change-Id: I0ef7c28856a374dca3edcec73fd98a96c5067527 Reviewed-on: https://gerrit.libreoffice.org/61794 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16tdf#112520 RTF export: write ZOrder only for toplevel shapesMiklos Vajna4-3/+32
RTF export at the moment exports children of group shapes as a flat shape list. This means that the order inside the group shape is not relevant for the toplevel ZOrder, so just don't write it. Change-Id: I870707cb28c2f177c0e5d9cf5328260e76b661f3 Reviewed-on: https://gerrit.libreoffice.org/61805 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-15tdf#118049 tdf#118833 tdf#118725: Fix some SwDepend regressionsBjoern Michaelsen1-1/+3
(partial revert/fix of 83243003b46dfb258c2b41049b0e1cb82a2d7ddb) Change-Id: I96213a41b026ee6496516ad1d0a416c5708a2300 Reviewed-on: https://gerrit.libreoffice.org/61769 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-10-15loplugin:staticconstfield improvementsNoel Grandin5-37/+27
And fix ScXMLCachedRowAttrAccess::Cache which was never setting its mnTab field, and hence would never be hit. And fix oox::xls::CellBlockBuffer, which was never setting mnCurrRow. Change-Id: I2c46aa050b9ebe3c2dc2e52579555f97945dd61c Reviewed-on: https://gerrit.libreoffice.org/61772 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15Notebookbar: update writer context tabsandreas kainz1-2074/+2179
Change-Id: I0806c86b8dc98aac6211cac09a7f4c25eb716007 Reviewed-on: https://gerrit.libreoffice.org/61770 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-15clang-tidy misc-redundant-expressionNoel Grandin3-3/+3
Change-Id: I708b0b486a233071f95592ccdb97f27fc35a23c4 Reviewed-on: https://gerrit.libreoffice.org/61783 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15tdf#120429 - Functions Insert Columns Exist Two Timesheiko tietze6-12/+12
Legacy UNO commands InsertRows and InsertCols hidden from customization Commands are still accessible via macro Also fixed terminology in Draw/Impress for Insert Columns from Left/Right to Before/After Change-Id: I29a6b2fdb7481db43ad1a8ad25be5e9107558bd6 Reviewed-on: https://gerrit.libreoffice.org/61579 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-15sw: prefix members of SwTableRepMiklos Vajna2-68/+68
Change-Id: Ib5c35ba6e53f70df8fe6dbcaf189590c754bb3cb Reviewed-on: https://gerrit.libreoffice.org/61773 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-15tdf#42949 Fix IWYU warnings in include/basegfx/*Gabor Kelemen2-0/+3
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ifd59a5d93cfe7dc232891a681002014cd825035a Reviewed-on: https://gerrit.libreoffice.org/61546 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-15add SvStream::TellEndNoel Grandin12-67/+28
and simplify callsites to use it instead of the current "seek to end, find pos, seek back to original pos" pattern Change-Id: Ib5828868f73c341891efc759af8bd4695ae2f33c Reviewed-on: https://gerrit.libreoffice.org/61738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-14drop unnecessary vcl/group.hxx includesCaolán McNamara17-17/+0
Change-Id: I09d86ee7e156ac71d7c1f9fd58d43751037d2629 Reviewed-on: https://gerrit.libreoffice.org/61761 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-14weld SwFrameAddPageCaolán McNamara7-228/+181
Change-Id: Ia63e22d01c6bcc08f50d3e1b12943094660c7fd0 Reviewed-on: https://gerrit.libreoffice.org/61758 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-13weld SwGrfExtPageCaolán McNamara4-161/+166
Change-Id: Iffcefbcef92d278803112635b0d3e98606c820b9 Reviewed-on: https://gerrit.libreoffice.org/61744 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-13move fallback image out of .uiCaolán McNamara3-45/+13
Change-Id: Id46f1c2a06e6c32b60e6308a01dc4ee5e75e20ba Reviewed-on: https://gerrit.libreoffice.org/61743 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12tdf#119992 sw: compare sub-strings in SwTextGlyphsKey comparisonMiklos Vajna1-3/+10
Time till the layout reaches idle, before: 77.412 seconds After: 26.221 seconds (33% of baseline) for me. Change-Id: Idd0c5255070c836fde2fb048b02c851f5f2321e4 Reviewed-on: https://gerrit.libreoffice.org/61724 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-12Fix typoAndrea Gelmini1-1/+1
Change-Id: I89ce64cfb8ea6777ac70583942d76dbc59eaf65b Reviewed-on: https://gerrit.libreoffice.org/61717 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-12tdf#118621 - Optionally disable floating header/footer menuheiko tietze10-4/+64
UNO command UseHeaderFooterMenu introduced Change-Id: I4be009e08bc66dc675c7c903552c6376e22639f1 Reviewed-on: https://gerrit.libreoffice.org/61706 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-12sw: new unit test for XTextContentVasily Melenchuk3-0/+81
Change-Id: Ic5f6740b145a473f69052489ce6c48894f33c74d Reviewed-on: https://gerrit.libreoffice.org/61351 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-12sw: create DocxExport instances with an uno constructorMiklos Vajna2-37/+8
Change-Id: I34e674e4f3225e724fd9ed6d513fb66c2d5ebdd9 Reviewed-on: https://gerrit.libreoffice.org/61696 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-12uitest for bug tdf#118208Zdeněk Crhonek1-0/+95
Change-Id: Ibe9a09dae281ea1bcd1da17bfaa9dfef051ddab8 Reviewed-on: https://gerrit.libreoffice.org/61692 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-10-12tdf120224 docx export: don't double up field bookmarksJustin Luth1-3/+9
fields are internal bookmarks. When the exporter runs through the bookmarks, it will already write out a bookmark entry, so don't output a separate one for the fieldmark. Change-Id: I84af2989035507ac745d028f1585d60d8823ff8b Reviewed-on: https://gerrit.libreoffice.org/61616 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-12tdf120224 writerfilter: consume excess bookmark from fieldsJustin Luth2-0/+39
Although this follows a very different code path, copy the ww8 import idea of "consuming" the bookmark of a BOOK_FIELD. This is particularly important for textcontrols, especially since LO keeps duplicating bookmarks as it adds another bookmark for the field name at each save. Existing unit tests that this matches are fdo53985.docx and tdf111964.docx. I expected more, but apparently most fields don't contain or represent any bookmarks. This patch is for import only. A followup patch stops the creation of duplicate bookmarks during export. Change-Id: I1e11980e52dc523393fd6d621191228d676e9a17 Reviewed-on: https://gerrit.libreoffice.org/61615 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-12tdf#64242 sw optimal column width, not minimizeJustin Luth5-28/+42
Optimize column width: Adjusts the width of the selected columns to fit the entire column's content, without changing the width of the table. Any leftover space is distributed proportionately, with thin columns growing slightly, and wide columns growing much wider. Change-Id: I9b8436814fc103d52fdd5ce3d88c6442dbb72d50 Reviewed-on: https://gerrit.libreoffice.org/60905 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-11ofz#10853 no config available during fuzzingCaolán McNamara1-1/+2
Change-Id: Ice48111756d2e5950093fabc28359f7a4e490220 Reviewed-on: https://gerrit.libreoffice.org/61693 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11loplugin:simplifyboolTor Lillqvist1-1/+1
Change-Id: Icb25fd00296f0584fdd503ad0e840870f8bc6774
2018-10-11Resolves: tdf#120487 postit losing focus triggering recreation of postitCaolán McNamara1-1/+4
Change-Id: Idde6b740bc94de62bbd528b656841ab37e3f3786 Reviewed-on: https://gerrit.libreoffice.org/61681 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11Don't use GetDBManager() without checking it for nullnessTor Lillqvist1-1/+2
Change-Id: Idb7b16a6976df62a1beea8a01c812206a0b8b85a
2018-10-11Initialise m_pDBManager to nullptr in the !HAVE_FEATURE_DBCONNECTIVITY caseTor Lillqvist1-0/+2
Change-Id: Id18bafaaf8f5315a0590687d98ea97952bdf883b
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 15:35:15 +0000