summaryrefslogtreecommitdiff
path: root/sw
AgeCommit message (Collapse)AuthorFilesLines
2015-11-04tdf#83910 Formatting of lines which consist of a single dummy line onlyTobias Lippert1-1/+8
The document which is attached to the ticket runs into an infinite loop because GetLineNr() does not increase since only dummy lines are added during formatting. Change-Id: I92689c776fe69bb6f62af26b577989db7f34de43 Reviewed-on: https://gerrit.libreoffice.org/18896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-04Make number recognition work in writer tables againNiklas Johansson2-1/+71
It seems that number recognition in tables are not working properly enter 10-10-10 and it should be converted to a date but it is not. I tracked it down to the fix of bug fdo#32082. It looks like bSetNumFmt was changed to false by mistake. Since then it has changed name to bSetNumFormat. From what I can tell fdo#32082 still works after this patch, but I might have missed some nuance of that bug report. Added two tests, one for the bug mentioned above and one to check that number recognition is working. At least with a simple date. Change-Id: Id58849a223eb602054c66c7379cd56a68a93dea2 Reviewed-on: https://gerrit.libreoffice.org/19563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2015-11-04loplugin:stringconstantNoel Grandin20-72/+68
Change-Id: Ic135382652966e80c288f3407508bdaf0c60316e
2015-11-04tdf#95077 Check Index != 0ccsheller1-1/+1
follow code: ScVbaCollectionBase::getItemByIntIndex .... return createCollectionObject( m_xIndexAccess->getByIndex( nIndex - 1 ) ); .... my test code of vba: Application.ActiveWindow.Panes(1).View Change-Id: I5229142377364f374e4bbc24bd3b8dfd5d351f56 Reviewed-on: https://gerrit.libreoffice.org/19239 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-11-04sw: fix non-dbgutil buildMiklos Vajna1-2/+2
Change-Id: I2b521c516caf85892dafe782da79364a534d55a2
2015-11-04sw: prefix members of SwCacheObjMiklos Vajna3-24/+24
Change-Id: I416c43f5f6819029e279bc2f5fb696b59917ef06
2015-11-04sw: prefix members of SwOrderIterMiklos Vajna2-34/+34
Change-Id: I9bea22d07a95eb521d9c3729b2aba1694cf02def
2015-11-04sw: prefix members of SwRegionRectsMiklos Vajna2-6/+6
Change-Id: Ib59572c45a1404840c379318e4987f5223edca15
2015-11-04sw: prefix members of SwSelUnionMiklos Vajna1-7/+7
Change-Id: I636454036f007dbf568f74b17e1c4c79fb36f40b
2015-11-04Don't dereference null pointerStephan Bergmann1-1/+4
Change-Id: If35672fae14541d5aa5f28e117bd63b69013d418
2015-11-03tdf#81144 Chinese full-width punctuation does not align properlyMark Hung3-12/+27
Ideographic fullstop and comma in most Chinese fonts are centered, while those in Japanese fonts align closer to the left. Original compression algorithm trimed right side of the punctuation, making fullwidth fullstop or comma in Chinese font visually unbalanced. In worst case, it crowds together with the followed compressed punctuation. This patch fix the situation in the folowing way 1) make compression less stronger. 2) Trim space according to glyph bearing to font height ratio. 3) fix a memory access violation issue Change-Id: Icff215064e6c442fd36eac8e01b01fb6acb27594 Reviewed-on: https://gerrit.libreoffice.org/19517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-11-03Smart pointers for SwBorderAttrAccessAshod Nakashian4-43/+32
The short-lived SwBorderAttrAccess is manually deleted which is not exception safe and can potentially leak. This wraps it in unique_ptr. Change-Id: Ib45c1c36214583e0bf205231f9f793e023d106c7 Reviewed-on: https://gerrit.libreoffice.org/19701 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-03sw: indentation fixesMiklos Vajna2-5/+5
Change-Id: I00bb0a4390524b569609d36d97120bdd2b55496e
2015-11-03sw: prefix members of SwFrmNotifyMiklos Vajna2-82/+82
Change-Id: Idc0290d82bb51fec0fcc1db003bd48f3cc402a0f
2015-11-03sw: prefix members of SwAttrSetMiklos Vajna2-23/+23
Change-Id: I0f38c87d46f913a3bbb5f3e40b6ae71c515a8c9c
2015-11-03sw: prefix members of SwAttrPoolMiklos Vajna2-4/+4
Change-Id: I3f55c4b8b12832b82e071d8cf62b2aa55f8913e7
2015-11-02tdf#89088 DOCX import: fix missing text due to throwing ShapeContextHandlerMiklos Vajna1-0/+0
Regression from commit 866a4436d3cfac1ff42d7996250bf96fb703aeaa (oox: handle textboxes in ShapeContextHandler::endFastElement(), 2014-06-04), the problem was that code in ShapeContextHandler::endFastElement() assumed that all the XShape implementation it may see provides a TextBox UNO property (which is specific to Writer) of type bool, but this is not true. Fix the problem by assuming false in case it has an other type. Testcase can be a simple "does it load" one, as in the meantime exceptions such as trying to read a bool from an uno::Any make the DOCX XFilter::filter() implementation return false, unlike in the originally reported LibreOffice 4.4 version that just silently discarded the remaining content of the document. Change-Id: I81781a7ec28d085ceee50d386b8eda023f83c29f
2015-11-02sw: prefix members of SwViewOptionMiklos Vajna2-217/+217
Also rename nPagePrevRow/Col to nPagePreviewRow/Col, so that it's more clear that they are about the page preview row/col, not about some previous row/col. Change-Id: I5f1f47edde3dbe6bcce14a654398f8a0be2fa79f
2015-11-02sw: prefix members of SwCollConditionMiklos Vajna2-27/+27
Change-Id: Idf7956c2178093bcaba3ad1093b8d0a54e46aaca
2015-11-02sw: prefix members of SwContentNodeMiklos Vajna2-13/+13
Change-Id: Iecb7cd82d88bd1ee82f074e17319e5ce095e2690
2015-11-02sw: prefix members of SwDrawFrameFormatMiklos Vajna2-8/+8
Change-Id: I0d00ca7727e0756030830cd732655b2a22b900d6
2015-11-01crashtesting: failure on tdf89191-1.odtCaolán McNamara2-12/+13
crash since commit 664197d95becd516c3dac25a50439078ba61e051 Author: Justin Luth <justin_luth@sil.org> Date: Thu Sep 10 11:41:11 2015 +0300 tdf#36117 .docx preserve page vertical alignment after RT Change-Id: I225fa4dc0a7ea2eab6ef748f7c72bfad361257dd
2015-11-01tdf#80657 Adding new field to jump to specific page.Gulsah Kose13-1/+138
This patch is not completed. It adds a dropdown field to toolbar. When you click it, the page preview focuses third page (hard coded). This patch's purpose is getting information from developers how to add numbers to dropdown field. -- v2: Removed unnecessary MV_SPECIFIC_PAGE case. v3: Added dropdown field and defined new controller for new field. v4: Implemented page focus who user want. v5: Used NumericField instead of Combobox and added page count control v6: Used nSlotId instead of SID_JUMP_TO_SPECIFIC_PAGE in order to fix macOs build error. Change-Id: I722fbffcc72a1bcee70065e2e9369b73ab27f100 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/19335 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-01no need to use OUString constructor in call to createInstanceNoel Grandin3-6/+3
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296 Reviewed-on: https://gerrit.libreoffice.org/19704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30Correct typo in commentAndrzej Hunt1-1/+1
Change-Id: I61a372e297eeeb67f1dcadbfc5017b0cc157d065
2015-10-30sw: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl5-15/+13
Change-Id: I95ce84f7e82dc03233878de4324f2cb5c282a8aa
2015-10-30UNO: no need to use OUString constructor when calling createInstanceNoel Grandin5-13/+11
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526 Reviewed-on: https://gerrit.libreoffice.org/19682 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30sw: prefix members of SwFindNearestNodeMiklos Vajna2-7/+7
Change-Id: Iea2094f736837f5aecde2d9ff810dffb062d2315
2015-10-30sw: prefix members of SwFormMiklos Vajna2-41/+41
Change-Id: I91c1aa5149bff9c6489ad6f1a68818b502d95966
2015-10-30sw: prefix members of SwModifyMiklos Vajna2-8/+8
Change-Id: Ia8d44e5c8a987aa1c0cc38e885eadd595b70a898
2015-10-30sw: prefix members of SwNodeMiklos Vajna10-135/+135
Change-Id: I3ce33c8ea0c09948785621785d199ece6eda128a
2015-10-30convert Sequence<XInterface> constructions to use initializer listsNoel Grandin2-6/+3
Change-Id: I66475190cc0f18465c56b94af7bc0d5a1ca81242
2015-10-29tdf#93509: Commit at the right timeStephan Bergmann2-1/+1
when the change is made, not during exit (as did 4aab13f77e5dc218d067ca7efe3622f4ea780bf9 "tdf#93509: crash on storing auto correction config fixed," which caused PythonTest_sw_python to crash during exit) Change-Id: I0e9c264ae3fee7fdb732d36f42ebbb477557a644
2015-10-29tdf#94835: crash while loading RTF with \dppolygon token fixedOliver Specht2-1/+73
RTF token \dppolygon now creates a PolyPolygonShape test included Change-Id: I065eaac0ca1b8a59f02c3198363180ab244a3942 Reviewed-on: https://gerrit.libreoffice.org/19665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-10-29sw: prefix members of SwNodesMiklos Vajna5-81/+81
Change-Id: I51a8161eeaa781ccace08605b97a0092f972b3bf
2015-10-29sw: prefix members of SwNumFormatMiklos Vajna2-15/+15
Change-Id: I71c2004b411831ce869331ab7251683f78428b2b
2015-10-29sw: prefix members of SwPosFlyFrmMiklos Vajna2-14/+14
Change-Id: I08a2c2bb8ebd8cb2adf25b23fa57a5c5441fcfea
2015-10-29sw: prefix members of SwStartNodeMiklos Vajna4-17/+17
Change-Id: Ibb3b33681f4c33794e07b40989709e8f292f2084
2015-10-29tdf#89337: Fixing crash in edit/index dialog, againOliver Specht2-1/+7
the fix of tdf#92732 moved the crash from pressing Close/OK to pressing the window closer. Now the CareWindow is set in dispose and this works for all Change-Id: Id9c272acec48890556a5042c0f5310e69c0a67da Reviewed-on: https://gerrit.libreoffice.org/19645 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-10-29tdf#93509: crash on storing auto correction config fixedOliver Specht1-0/+1
fix of tdf#86494 removed the pAutoCorrect which is required to store the config committing the config before fixes the crash Change-Id: If049d5ad1e62711d4ec66ec6cca15940f7edba90 Reviewed-on: https://gerrit.libreoffice.org/19640 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-10-29evil error description is misleadingBjoern Michaelsen1-3/+3
Change-Id: I2b8332e8346fbbbb3270e53102e5e3a51cbd6df7
2015-10-29sw: fix "long" overflow in lcl_CalcWishMichael Stahl1-1/+2
0 + (1 * 32768 * 65536 / 65537) evaluates to -32767 with 32-bit MSVC whereas with 64-bit GCC the result is +32767. The multiplication overflows to 0x80000000 - so do that in 64 bits. This fixes the JunitTest_sw_unoapi_4 failure in SwXTextTable on the TableBorder property, where the wrong result caused MakeSelUnions() to believe that the last cell is not visible and hence setting the TableBorder property failed. Change-Id: Idb10535ce5342cd83d7ab6aea07782a2034469eb
2015-10-28tdf#91270 fix crash on exit (Windows)Andras Timar2-8/+15
dynamic atexit destructor and const static variables reportedly cause crash, let's avoid this. Change-Id: I24234084f810854606dde9914bee1c98ebc2e3dd Reviewed-on: https://gerrit.libreoffice.org/19656 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-10-28tdf#95354 - pad AltX to 4 charactersJustin Luth2-1/+1
Change-Id: I552f305e78427bdbd37e48013f5cc4b78024e8ff Reviewed-on: https://gerrit.libreoffice.org/19631 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-10-28sw: surely that should be !=, not <Michael Stahl1-1/+1
Change-Id: Id733fd3a53fe2023be20fcf7c9d93823d1697a7d
2015-10-28sw: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl5-15/+19
Change-Id: I1d9aa200734d264e3bc65ea39f8c2a2d03782f7b
2015-10-28tdf#94871: sw: fix a frame formatting regression that affects helpMichael Stahl1-6/+8
The early return must also be taken if the anchor is neither AT_CHAR nor AT_PARA. (regression from a219bbb62f974020fac0799143fbc51c385bb460) Change-Id: I4eccb1f80401ba620ef87342f40c1a896918f3d3
2015-10-28sw: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl1-14/+10
Change-Id: I85409838a5c44f8e76c60ff88e41c01d2bb71987
2015-10-28sw: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl3-18/+15
Change-Id: I2bb543ce1678140e8a6e086171a8f6b4529771d3
2015-10-28sw: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl3-16/+21
Change-Id: I32edfa929aa81431a1e20180f3fd8a539ad43274