summaryrefslogtreecommitdiff
path: root/solenv
AgeCommit message (Collapse)AuthorFilesLines
2016-11-16new loplugin finalprotectedNoel Grandin1-0/+1
look for final classes, and make sure they don't have protected members Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4 Reviewed-on: https://gerrit.libreoffice.org/30895 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15New compilerplugins/clang unit testsStephan Bergmann8-7/+91
...to check that loplugin produces warnings/errors as expected: * Clang has a -verify switch that makes it easy to write test input .cxx files that list in comments all the warnings/errors that are expected, and let Clang check those expectations instead of generating object code. See include/clang/Frontend/VerifyDiagnosticConsumer.h in the Clang source tree for documentation. * Introduce a CompilerTest gbuild class that uses the existing LinkTarget class as much as possible. Checking the input files is implicitly phony, as the compilation step doesn't generate any object files, and the link step does nothing because there is no gb_LinkTarget_set_targettype for CompilerTest. The setup at least works for Clang on Linux (will need adaptions for Clang on Windows; compilers other than Clang are not relevant for now given this is used to check compilerplugins). * Definition of gb_CFLAGS_WERROR in solenv/gbuild/platform/com_GCC_defs.mk needs to be lazy ('=' vs. ':=') so that CompilerTest can override it: The Clang -verify mode wants the input files to specify whether the loplugin diagnostics are warnings or errros, so they consistently need to be errors independent of --enable-werror configuration. * A first (example) test is in compilerplugins/clang/test/salbool.cxx. The corresponding gbuild CompilerTest instance is in solenv/CompilerTest_compilerplugins_clang.mk for now. The reason for that odd split across compilerplugins/ and solenv/ is that there is no compilerplugins/Modules_compilerplugins.mk file, so this setup is the easiest hack for now (to be cleaned up). (Another area that could be improved is that all test files need to be listed explicitly in the CompilerTest_*.mk file, instead of, say, using all .c/.cxx/.m/.mm files in a specified directory.) * The test is run somewhat late during a top-level 'make', after loplugin has already been used in compilation. But it can be run manually (e.g., 'make solenv') when making changes to loplugin during development. Change-Id: I01e12fb84887d264ac03ef2484807458c2075af4
2016-11-08typo fix: ressource -> resourceAndras Timar1-3/+3
Change-Id: Id8d1c01b17e711a057a9f3f20e1d0f955b2ea6c8 Reviewed-on: https://gerrit.libreoffice.org/30690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-07Fix typos (also in the code)Andrea Gelmini1-1/+1
Change-Id: I45d45513b102f4fdcb55e8de20b95b37f66ea463 Reviewed-on: https://gerrit.libreoffice.org/30658 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-11-04Allow including/packaging help-specific imagesKatarina Behrens1-6/+24
from other than icon-themes folder Change-Id: Iba1808e642fde8d0370b59550c7bdac1a3e4ac79 Reviewed-on: https://gerrit.libreoffice.org/28513 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2016-11-03Disable gbuildtoide test on macOS, tooTor Lillqvist1-0/+2
Change-Id: I630fd447992ada459190acd1ee310bd2d38820b9
2016-11-02disable gbuildtoide test on Windows as CI builders are unstableBjoern Michaelsen1-0/+2
Change-Id: Ib5eb4fece2bae3e04089f2389198df800620e6f8 Reviewed-on: https://gerrit.libreoffice.org/30483 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-10-31also stubify generated object addersBjoern Michaelsen1-0/+2
- This should unbreak vcl when configured with KDE/TDE CustomTargets Change-Id: I239e97b90174f3daef39e4a806a126cafba9d8e0 Reviewed-on: https://gerrit.libreoffice.org/30436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-10-31populate library path to gbuildtojson in testsBjoern Michaelsen2-0/+2
the test environment clears LD_LIBRARY_PATH as it seems to cause trouble for make in ASAN. "make gbuildtoide" only runs the gbuildtojson exe, so make sure it gets the LD_LIBRARY_PATH that was filtered out from the make that starts it. Change-Id: I69ee0024232092aebcd1e8e11b002d6f7eb55c84 Reviewed-on: https://gerrit.libreoffice.org/30433 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-10-26for now, use a limited subset for testing on windows as it is so slowBjoern Michaelsen1-0/+3
Change-Id: I06f77d8aa0a82bd3bb065095a64849d07d11c6a3 Reviewed-on: https://gerrit.libreoffice.org/30311 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-10-26add test for running gbuildtoide on non-build modulesBjoern Michaelsen7-41/+295
- do concat for json in C++, everything else seems fragile on Windows - have APPEND vars separately - check that gbuildtoide work on modules without a full build (modulo some blacklisted "creative" ones) Change-Id: I6fe267fee7d1b77d758072303729387dfeb8e6c8 Reviewed-on: https://gerrit.libreoffice.org/30293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-10-26normalize existing emacs/vim mode-lines in python filesMichael Stahl1-1/+2
Bunch of these were setting C++ or Make modes and icky tabs... Also, reportedly Emacs can figure out to enable python-mode automatically. Change-Id: I50072488fb92cb4d27aa3f74f717a28ae3967543
2016-10-26gbuild: missing emacs mode-linesMichael Stahl8-3/+7
Change-Id: Id767a98be85a7f3f4abb28891d0a5cac2057b0e0
2016-10-26fix "TabError: inconsistent use of tabs and spaces in indentation"Michael Stahl1-1/+1
Change-Id: Iff27ff4a01dc8c20b01a6247554b6cc7195a2306
2016-10-26solenv: fix Windows buildMiklos Vajna1-1/+4
Traceback (most recent call last): File "C:cygwinhometdflodejenkinsworkspacelo_gerritConfigwindows_msc_dbgutil_32solenvqapythongbuildtoide.py", line 32, in test_gbuildtoide del(os.environ['LD_LIBRARY_PATH']) # built with ASAN; prevent that File "C:cygwinhometdflodejenkinsworkspacelo_gerritConfigwindows_msc_dbgutil_32instdirprogram\python-core-3.3.0libos.py", line 692, in __delitem__ raise KeyError(key) from None KeyError: 'LD_LIBRARY_PATH' Change-Id: I1575caf90cafffd71dd28fedc46b5e3570848be8 Reviewed-on: https://gerrit.libreoffice.org/30304 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-10-26solenv: don't run make with LD_LIBRARY_PATH setMichael Stahl1-0/+2
In a build with -fsanitize=address, this fails with: Change-Id: Ida0d4445d7f829545b493e9dd4c2c4ef33960850 make: symbol lookup error: instdir/program/libfreebl3.so: undefined symbol: __asan_option_detect_stack_use_after_return
2016-10-26i18nlangtag must presumably be dropped from Library_merged.mkStephan Bergmann1-1/+0
...after 475e4b477c6d7ae114c3ae51ba4872882af67a68 "Move i18nlangtag lib to URELIB"? Change-Id: I45c5d997ed30757157109c67f30b91c4073c6b0a
2016-10-25bail out on use of unknown install moduleDavid Tardon1-0/+2
Change-Id: Ic6ba34e1ea6aff49f308f41e5692e08edc5b77c2 Reviewed-on: https://gerrit.libreoffice.org/30270 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-10-24solenv: force gbuildtoide test to use the same "make" as the callerMichael Stahl4-4/+13
Possibly mis-matching make binaries could be the reason behind failures that have been observed on Jenkins: make[3]: Entering directory '/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/windows_msc_dbgutil_32/solenv/qa/python/selftest' make[3]: *** internal error: invalid --jobserver-fds string 'gmake_semaphore_5488'. Stop. Also, to enable this: Revert "Revert "prep WinResTarget for WNT in testdir"" This reverts commit 6e261cb19e5751eb0553ad0c5b357b1a5747518c. Change-Id: Idb858b5eeced91f19c9dd5600c4fdc5370b73cc5 Reviewed-on: https://gerrit.libreoffice.org/30226 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-10-23Fix typosAndrea Gelmini1-1/+1
Change-Id: Ib7b17f85c7b6a1937c3f6e1617ceec58074643b4 Reviewed-on: https://gerrit.libreoffice.org/30040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-20Revert "prep WinResTarget for WNT in testdir"Giuseppe Castagno3-7/+4
Still random failures in Gerrit Windows builds. This reverts commit f5c54089b50718abf7c35aa81b150c509809d5c4. Change-Id: Iec48d2388691577ccd675b9a73941cedceebd527 Reviewed-on: https://gerrit.libreoffice.org/30103 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu> Tested-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-18prep WinResTarget for WNT in testdirBjoern Michaelsen3-4/+7
Change-Id: I04c050dca1212d247c9b11a996ba8f37c0a6492f Reviewed-on: https://gerrit.libreoffice.org/29825 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-10-16help packimages.pl be compatible with Perl versions before 5.12Douglas Mencken1-2/+2
configure.ac doesn’t check for the version of Perl at all so you can’t suppose that it is guaranteed to be 5.12 or beyond before this patch in the case you use perl < 5.12 at build time you would get Can't locate object method "newdir" via package "File::Temp" at solenv/bin/packimages.pl the commit 4e3dc8c141c2efd037c1f214b5edff071812b6a8 introduced such incompatibility Change-Id: Icd9281e0065ed67d69d07ac921b054deed052764 Reviewed-on: https://gerrit.libreoffice.org/29907 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-15clang-cl loplugin: solenvStephan Bergmann2-10/+9
Change-Id: I0a1075b92e787fc8bab7cfab5c3f24ad918a9181 Reviewed-on: https://gerrit.libreoffice.org/29850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14Disable PythonTest_solenv_python on Windows for nowStephan Bergmann1-0/+2
...causes all gerrit/jenkins Windows builds to fail in test_gbuildtoide; Björn to investigate... Change-Id: I90f95e4a91f40835d2b2d9c67a6473b95fb81597
2016-10-14tearDown/clean up solenv test tempdirBjoern Michaelsen1-6/+10
Change-Id: I2fc5497b0aeadbc43e967f338a3b8718995f2a5c
2016-10-14fix license, this is entirely new contentBjoern Michaelsen1-10/+1
Change-Id: Icf1818fb894d039eeb4e7f1306a53ac4322fa075
2016-10-14add gbuildtoide support for exesBjoern Michaelsen5-3/+33
Change-Id: I320ee341651dd0c92de5176c10aa5290afea1d38
2016-10-13Don't hard-code Library directory because of ExtensionLibraryMichael Stahl1-2/+1
Change-Id: I71a2e87279611a1a8f65ec86c47d26bbd5bd5f3b Reviewed-on: https://gerrit.libreoffice.org/29800 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-10-13use tempdir for testBjoern Michaelsen1-3/+5
Change-Id: Ie218f87dc2f1c1b6031cc08f2027cfcf392c6c21
2016-10-13gbuildtoide does not need depsBjoern Michaelsen1-0/+2
Change-Id: I806b8f445fad02e7dceff6263828fe9d8667341e
2016-10-13remove needless cascaded definesBjoern Michaelsen1-24/+23
Change-Id: Ie76dd70a6a0960ee49df6e31a171761fdaf88f53
2016-10-13installoffice{,_impress}.oxt seem to be long dead codeBjoern Michaelsen2-0/+0
Change-Id: Idf11c19d861a95e0f4a0a2d9c7c7cd8739e71282 Reviewed-on: https://gerrit.libreoffice.org/29745 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-10-13add initial json export for gbuild dataBjoern Michaelsen4-0/+128
- also add gbuild selftest to test this (and possibly more later) Change-Id: Ia4ef41095613e596f39d107df700e929579ba45f Reviewed-on: https://gerrit.libreoffice.org/29744 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-10-13add a testbed for gbuildBjoern Michaelsen6-0/+90
Change-Id: Ie6e54c291f92dfede113a1d0fa20771482d93605 Reviewed-on: https://gerrit.libreoffice.org/29743 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-10-07tdf#100302: gbuild: always use $(LFS_CFLAGS)Michael Stahl5-2/+7
Currently LFS_CFLAGS are only used in a handful of libraries but there's no obvious reason why it can't just be set everywhere. Also set it in windows.mk, i have no idea if it's needed for MinGW (certainly not for MSVC). Change-Id: I5f62e3011c2089abbf5539fc54c7ff10e07b1599
2016-10-02cppcheck invalidPrintfArgTypeJochen Nitschke1-1/+1
signedness and long vs int corrections Change-Id: I67c6b9e05b16f5d8d4693879f1656db50dc7ec48 Reviewed-on: https://gerrit.libreoffice.org/29355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-01Fix typosAndrea Gelmini1-2/+2
Change-Id: I1e0e6f1b99090f26a6cd657ee9019bf2fa906dd9 Reviewed-on: https://gerrit.libreoffice.org/29436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-29gbuild: try to avoid invoking gdb with LD_LIBRARY_PATH setMichael Stahl1-2/+2
Commit b078e0d638514b298616838fae090b8294bac32f introduced the problem that gdb will load via LD_LIBRARY_PATH the libpython3.5m.so.1.0 from INSTDIR instead of the one from the system, which makes it unhappy (at least on Fedora 24). Try to hack around that by detecting that the user wants to run gdb, and passing in a command "set environment LD_LIBRARY_PATH ..." so that "run" inside gdb uses the custom LD_LIBRARY_PATH but gdb itself does not. Change-Id: I1d29d2af1a77ffab3e718a876c17c29de444c6d9 Reviewed-on: https://gerrit.libreoffice.org/29349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-09-26LLDB remove pretty-printing of long obsolete String classMichael Stahl1-16/+0
Change-Id: I8574c0b731efecb174370d09cfea2c89c27ab974
2016-09-26LLDB pretty print rtl_String / OString tooMichael Stahl1-0/+40
Change-Id: Iaf77d03d8116273054ae3efca88f44fd926bf211
2016-09-24show correct command to execute the testMarkus Mohrhard1-1/+1
Change-Id: Ic7515c1d43737fb6864228d37be1b356acecfdc3 Reviewed-on: https://gerrit.libreoffice.org/29253 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-22gbuild: remove gb_CFLAGS/gb_CXXFLAGS += -fno-omit-frame-pointerMichael Stahl8-16/+0
This did not take effect anyway because unxgcc.mk unconditionally overwrites it; see https://lists.freedesktop.org/archives/libreoffice/2016-September/075218.html Nobody knows why it was added so just remove it. Change-Id: Ib1a6d06ed8e380e63c588a72b6a65bfbeaacb924
2016-09-22gbuild: remove gb_CXXFLAGS += -mminimal-toc on PPC64Michael Stahl1-1/+0
This did not take effect anyway because unxgcc.mk unconditionally overwrites it; see https://lists.freedesktop.org/archives/libreoffice/2016-September/075218.html Change-Id: I33a2ae9aae44d974d6b5466a2d7dae61ae5cc92c
2016-09-22gbuild: gb_COMPILERDEFAULTOPTFLAGS doesn't existMichael Stahl1-1/+1
... since commit 8541943b8d08f62217e99c9d47a5f222e1fba86e Change-Id: I56b12ebd59b8387878f20d625381d3f743558a43
2016-09-22Use 'with open(file) as f:' to avoid 'ResourceWarning: unclosed file'Mike Kaganski1-5/+11
Removes 220 warnings from build log (at least under Windows). Requires Python 2.5+ Change-Id: I06b18b14a08f2c27528fcb009faddff081ffd54e Reviewed-on: https://gerrit.libreoffice.org/29172 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-09-22Fix sh quoting of ; and \ (the latter in the cygpath -w output)Stephan Bergmann1-1/+1
Change-Id: Iec52b93746b2fd9bbd6ad67667092717f39222d7
2016-09-22Make workdir/UnpackedTarball/langtag/data/.libs/lt-reg2xml find its libsStephan Bergmann1-0/+10
...after ecd5d49dc30d11845ccc1a14e26bf37d73959463 "liblangtag: prevent libtool from adding annoying stuff to RPATH". "Outsmarting" libtool in the way described in 1d028d4783da69c5c0e6e0b59e0f8ac55eb9d2b1 "Fix Linux RPATH of various external modules" only works if there's no utility applications in the outsmarted module, that are run while building the outsmarted module (cf. the redland case in 1d028d4783da69c5c0e6e0b59e0f8ac55eb9d2b1). To work around that, pass in an LD_LIBRARY_PATH (or equivalent) that finds the relevant libs as built in that module. (And gb_Helper_extend_ld_path was until now only available in com_GCC_defs.mk. There, it accepts any number of paths separated by ":". When used in a platform-independend way like it is used here, it will only support a single path.) Change-Id: Ic615e436b19b8b9aa7daa019c8f5287de90c3abc
2016-09-20Remove HAVE_GCC_VISIBILITY_BROKEN, never trueStephan Bergmann1-2/+0
The check for broken -fvisiblity-inlines-hidden doesn't mention a specific bug. Its roots date back to 072e89cf68dcf9b6713945e402dd7a9fe5cea48d "INTEGRATION: CWS newportstl" of the --with(out)-stlport area. Lets assume whatever failure is long since fixed. Make this a fatal configure error for now. The check should be removed completely after LO 5.3 branch-off. Change-Id: I7c64c2e8b9bd342beec9b84ff71f5712a6155b7d Reviewed-on: https://gerrit.libreoffice.org/29075 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-20[API CHANGE] Remove HAVE_GCC_VISIBILITY_FEATURE, always trueStephan Bergmann1-6/+2
* GCC documents -fvisibility at least as far back as the GCC 4.0 online documentation at <https://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Code-Gen-Options.html>. * For external code, odk/settings/settings.mk unconditionally set HAVE_GCC_VISIBILITY_FEATURE for all platforms other than Windows. Make this a fatal configure error for now. The check should be removed completely after LO 5.3 branch-off. Change-Id: I1de415b6ed1591e0a7b6640ece861b6f0ef74112 Reviewed-on: https://gerrit.libreoffice.org/29073 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-22 03:35:48 +0000