summaryrefslogtreecommitdiff
path: root/solenv
AgeCommit message (Collapse)AuthorFilesLines
11 hoursdrop some unused suppressionsCaolán McNamara1-2/+0
Change-Id: Ie11e2ac56fc8a4f1b10f801824764322052bb124 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102975 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
18 hoursxmloff: remove dead com.sun.star.comp.Draw.XMLSettingsExporterMiklos Vajna1-1/+0
And test com.sun.star.comp.Draw.XMLOasisSettingsExporter instead in JunitTest_xmloff_unoapi. Note that the test code is also dead at the moment, because xmloff/qa/unoapi/xmloff.sce disables the xmloff.Draw.XMLSettingsExporter line, but let's not regress even more in that code. Change-Id: I2152f32fd798b7a7df7086b125e77fe804185157 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102973 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
26 hoursResolves tdf#97918 - Individual UNO commands for distribution optionsHeiko Tietze1-2/+0
New UNO commands added, SID_DISTRIBUTE_DLG bend to dropdown, ui removed Menus and toolbars adjusted Change-Id: Ic0a3cc299f745a1a0cd18edead1f410ff57a1f1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102272 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
41 hoursReport each value of LO_TEST_LOCALE in localized CppunitTestStephan Bergmann1-1/+2
Change-Id: I7ad091ec163f2324f2b8481e4caa6beb12188ea4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102896 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2 daysWIN bridges: unify exception handlingJan-Marek Glogowski1-2/+0
This is almost just refactoring, but with classes like type_info_ and __type_info, just following the code became tendious. I tried to come up with better names... and in the end included some minor code changes described below. This patch moves the "common" code for MSVC exception handling into msvc_shared/except.cxx. Still it contains a few small ifdefs, so it doesn't feel like clean separation, but a lot of duplicate code is dropped this way. The "major" code change for amd64 is the drop of the duplicate static RTTInfo object originally used by mscx_getRTTI and mscx_getRTTI_len, by merging of both functions into the single, new get() function to use a single std::find call. Change-Id: Ib07d40e2794cde79156be3324c80ccf21a6aa8ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102864 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2 daysconfigure + gbuild: handle Windows Arm64Jan-Marek Glogowski3-1/+29
Change-Id: Idfc20c1234d693d6b402158b8bc782bd17cd3f4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102850 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2 daysTurn OUStringLiteral into a consteval'ed, static-refcound rtl_uStringStephan Bergmann1-2/+0
...from which an OUString can cheaply be instantiated. This is the OUString equivalent of 4b9e440c51be3e40326bc90c33ae69885bfb51e4 "Turn OStringLiteral into a consteval'ed, static-refcound rtl_String". Most remarks about that commit apply here too (this commit is just substantially bigger and a bit more complicated because there were so much more uses of OUStringLiteral than of OStringLiteral): The one downside is that OUStringLiteral now needs to be a template abstracting over the string length. But any uses for which that is a problem (e.g., as the element type of a container that would no longer be homogeneous, or in the signature of a function that shall not be turned into a template for one reason or another) can be replaced with std::u16string_view, without loss of efficiency compared to the original OUStringLiteral, and without loss of expressivity. The new OUStringLiteral ctor code would probably not be very efficient if it were ever executed at runtime, but it is intended to be only executed at compile time. Where available, C++20 "consteval" is used to statically ensure that. The intended use of the new OUStringLiteral is in all cases where an object that shall itself not be an OUString (e.g., because it shall be a global static variable for which the OUString ctor/dtor would be detrimental at library load/unload) must be converted to an OUString instance in at least one place. Other string literal abstractions could use std::u16string_view (or just plain char16_t const[N]), but interestingly OUStringLiteral might be more efficient than constexpr std::u16string_view even for such cases, as it should not need any relocations at library load time. For now, no existing uses of OUStringLiteral have been changed to some other abstraction (unless technically necessary as discussed above), and no additional places that would benefit from OUStringLiteral have been changed to use it. Global constexpr OUStringLiteral variables defined in an included file would be somewhat suboptimal, as each translation unit that uses them would create its own, unshared instance. The envisioned solution is to turn them into static data members of some class (and there may be a loplugin coming to find and fix affected places). Another approach that has been taken here in a few cases where such variables were only used in one .cxx anyway is to move their definitions from the .hxx into that one .cxx (in turn causing some files to become empty and get removed completely)---which also silenced some GCC -Werror=unused-variable if a variable from a .hxx was not used in some .cxx including it. To keep individual commits reasonably manageable, some consumers of OUStringLiteral in rtl/ustrbuf.hxx and rtl/ustring.hxx are left in a somewhat odd state for now, where they don't take advantage of OUStringLiteral's equivalence to rtl_uString, but just keep extracting its contents and copy it elsewhere. In follow-up commits, those consumers should be changed appropriately, making them treat OUStringLiteral like an rtl_uString or dropping the OUStringLiteral overload in favor of an existing (and cheap to use now) OUString overload, etc. In a similar vein, comparison operators between OUString and std::u16string_view have been added to the existing plethora of comparison operator overloads. It would be nice to eventually consolidate them, esp. with the overloads taking OUStringLiteral and/or char16_t const[N] string literals, but that appears tricky to get right without introducing new ambiguities. Also, a handful of places across the code base use comparisons between OUString and OUStringNumber, which are now ambiguous (converting the OUStringNumber to either OUString or std::u16string_view). For simplicity, those few places have manually been fixed for now by adding explicit conversion to std::u16string_view. Also some compilerplugins code needed to be adapted, and some of the compilerplugins/test cases have become irrelevant (and have been removed), as the tested code would no longer compile in the first place. sal/qa/rtl/strings/test_oustring_concat.cxx documents a workaround for GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96878> "Failed class template argument deduction in unevaluated, parenthesized context". That place, as well as uses of OUStringLiteral in extensions/source/abpilot/fieldmappingimpl.cxx and i18npool/source/localedata/localedata.cxx, which have been replaced with OUString::Concat (and which is arguably a better choice, anyway), also caused failures with at least Clang 5.0.2 (but would not have caused failures with at least recent Clang 12 trunk, so appear to be bugs in Clang that have meanwhile been fixed). Change-Id: I34174462a28f2000cfeb2d219ffd533a767920b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102222 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
3 daysexternal: update pdfium to 4260Miklos Vajna1-3/+3
Change-Id: I1b6c7e9991b2e35921f7f849380d940c6662b174 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102787 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
4 daysDon't use argparse to open control_fileMike Kaganski1-2/+3
Use idiomatic 'with' instead This avoids the warnings: Exception ignored in: <_io.FileIO name='C:/lo/src/core/postprocess/packimages/image-sort.lst' mode='rb' closefd=True> ResourceWarning: unclosed file <_io.TextIOWrapper name='C:/lo/src/core/postprocess/packimages/image-sort.lst' mode='r' encoding='cp1251'> Change-Id: I1cf8248cdab8dd9fd585545c64de2aebcbfe5365 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102647 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
4 daysWIN add and apply default msbuild platform+configJan-Marek Glogowski1-0/+10
Adds three Windows gb_* variables: - gb_MSBUILD_CONFIG_AND_PLATFORM can be passed as msbuild flags - gb_MSBUILD_PLATFORM maps debug / release settings - gb_MSBUILD_CONFIG maps the CPUTYPE to the default msbuild names and converts the users in external projects. Change-Id: Ie9b817721180d78d104db11c44241e4b3e46bba9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102701 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
4 daysdrop some unused UI suppresionsCaolán McNamara1-6/+0
Change-Id: Ib175531149338cddd27b9959a9c8fc287392d8b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102658 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
5 daysdrop some unused UI suppresionsCaolán McNamara1-2/+0
Change-Id: I65d2398d7b5d8011e1f079b6a40dfd5ca579d0e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102657 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
5 daysfix attachnamedialog mnemonicsCaolán McNamara1-2/+0
Change-Id: Ibdc7e7432d7ce48473e16298fdb8eddea5241938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102541 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
5 daysfix alreadyexistsdialog mnemonicsCaolán McNamara1-2/+0
Change-Id: Id9c326d28cf7049e692108cdeccef6714c142e2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102540 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
6 daysdrop some unused suppressionsCaolán McNamara1-49/+0
Change-Id: I44422004b8ad2b6e848f6ed5b7cca649fbfdf5ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102522 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
6 daysTry fix multiple assignments of gidsMike Kaganski1-1/+1
************************************************ WARNING: multiple assignments of gids: ************************************************ GID: gid_Dir_Shlxthdl Assignments: 2 Change-Id: I4c2f53d8b996fc750465219f320fd8538a4d23f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102494 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
6 daysFlatpack: update to liborcus 0.16.0Julien Nabet1-3/+3
Change-Id: I9268a254cf74c3effa7852cd0936399d8c28aa6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102509 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
7 daysReplace remaining uses of sal_CharJulien Nabet3-3/+3
+ remove sal_Char check on compilerplugins Change-Id: I0f7da14e620f0c3d031d038aa8345ba4080fb3e9 Change-Id: Ia6dba4f27b47bc9e0c89159182ad80a5aee17166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
7 dayscross-build: fix Java NI linkingJan-Marek Glogowski2-2/+2
LibreOffice has a JNI component on Windows and Linux, the officebean. Therefore we need a host JDK for linkage to the jawt, and a build JDK to compile the Java code. Change-Id: I4138628ab3ea2ef5900a5b4e9281050ae84e4eb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102483 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
7 daysWIN cross: fix gpg-related library buildsJan-Marek Glogowski7-25/+81
Cross compiling these libraries requires to supply the cross- compiler via the CC_FOR_BUILD environment variable. Since we have to use the gcc-wrappers, we now need two different invocations with different inclues and libraries, but just have fixed environment variables. Also, the CC_FOR_BUILD clashes with LO's own variant, but that is easy to fix. So this change includes: - gcc-wrappers: new option --wrapper-env-prefix to add a prefix to the environment variable names - gcc-wrappers: new option --wrapper-print-cmdline to dump the real command called, when a verbose build is executed - gcc-wrappers: default to exe, if the output has no extension - unify build flags for gpg related libraries Change-Id: I4e6a6ba3c6e09237c8ffefa40ce61131290a3852 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102482 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
7 daysFix the minimal build-tools targetJan-Marek Glogowski2-6/+9
The revert commits change the build-tools target for a DESKTOP build to build the complete LO. This restores the original, minimal one and also adds a whitelist of allowd build types. OpenCL needs a configure switch, as it's status is also stored in a config header, so preventing the build is not enough. This also reverts: - commit 802161a505272732566210e9ebbd8fe1b23fb86d - commit 02d931a59e2966d0c2736db8dee7be3e3dcd6bae Change-Id: Ibfcb0c54e72da1b7c2e63c082ea6586520a787fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102480 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
7 daysWIN drop --enable-64bit to select Windows targetJan-Marek Glogowski1-16/+7
This changes the Windows build to use the default configure switch to select the target / host of the compiled binaries to get the possibility to cross compile on Windows the "default" way. Note that selecting i686-pc-cygwin on x86_64 doesn't do a cross- compilation, as no special build tools are needed, because x86_64 can run x86 binaries just fine. A consequence of the change is the default target host, which is now the same then the build system, instead of the previous x86 default. Change-Id: I5584f34f665573ebac40d5d7753d96addeb84dbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102479 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
7 daysimage-sort: add --quiet option for build-toolsJan-Marek Glogowski1-19/+24
Otherwise you'll get many warnings for missing images, because the cross-toolset target just builds some small part of LO. This also converts the program to use argparse. Change-Id: I22adda23ab3a25bced871a87d38373543cd5ae72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102478 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
8 daysUse { ... } for grouping that does not need a sub-shellStephan Bergmann1-2/+2
...in case that makes ever so small a difference, esp. on Windows (where spawning processes is known to be expensinve; but note that at least Bash seems to not spawn a sub-shell anyway when what is enclosed in ( ... ) is just a simple single process, which is commonly the case for these cppunittester invocations) Change-Id: Ie9200270743754e02fbfdb2b17239e9873031dab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102407 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
8 daysxmloff: remove dead com.sun.star.comp.Draw.XMLContentExporterMiklos Vajna1-1/+0
And test com.sun.star.comp.Draw.XMLOasisContentExporter instead in JunitTest_xmloff_unoapi. Change-Id: I22bf816d08bcd04b277e461a5055883b730811b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102401 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
9 daysAdapt solenv/flatpak-manifest.in to eaf4f6d3b1e64bc7b057e70cffe0bda0ed42c49fStephan Bergmann1-3/+3
..."update Skia to chrome/m86 snapshot" Change-Id: I3c1cc7a357a89d7763513f92bca5771d56b17884 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102352 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
9 daysFlatpack: update to mdds 1.7.0Julien Nabet1-3/+3
Change-Id: I441768999a005f99cad19b7a5e68809214e9ee10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102354 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
9 daystdf#119931 fix a11y warnings in cui/uiconfig/ui/aboutdialog.uiGabor Kelemen2-5/+4
Images and long descriptions are display-only Change-Id: I4b0031ae6f94bb2edaaaf90039a39170bfb27a62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100349 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
9 daysUpdate one mention of pdfium-4137.tar.bz2Stephan Bergmann1-1/+1
...left behind by 4488be8a9279be0bd0aebd476589a49d2b95da6e "external: update pdfium to 4203" Change-Id: I5e092f6351281c99a5a3f8b6865d5166805a5c46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102351 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
9 daysUpdate Flatpak to org.freedesktop.Platform//20.08Stephan Bergmann1-1/+1
...see <https://github.com/flathub/org.libreoffice.LibreOffice/issues/129> "Update runtime to 20.08" Change-Id: I3eb60e7c020857209f30cbed24c60f6a0627f938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102353 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
10 daysimprove loplugin:unusedvarsglobalNoel Grandin1-0/+1
to find any global variable, was checking the wrong property of VarDecl Change-Id: I454b4e0c1701bb0771768a1ee10cd738c4ab0726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
13 daysfix macOS malloc debuggingNoel Grandin1-1/+1
which was introduced with insufficient testing in commit 302d85a931586313e04f82d206970dbc3bce9a47 add macOS malloc debugging env vars And this fix also avoids the potential problem of turning on malloc debugging for lldb itself. Change-Id: I0d65cefbd3ce8aea7223c6f0a3470b7ecbc8da89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102082 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
14 daysAvoid warnings about use of uninitialized valueMike Kaganski1-2/+2
Like these: Use of uninitialized value $feature{"Description"} in substitution (s///) at C:/lo/src/core/solenv/bin/modules/installer/windows/feature.pm line 362. Use of uninitialized value $feature{"Title"} in concatenation (.) or string at C:/lo/src/core/solenv/bin/modules/installer/windows/feature.pm line 370. Use of uninitialized value $feature{"Description"} in concatenation (.) or string at C:/lo/src/core/solenv/bin/modules/installer/windows/feature.pm line 370. gm_o_OGLTrans has no Title nor Description Change-Id: Ica247e071f252023e4cdec6f8ff15f0e0d3cedd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102059 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-04Avoid warnings about use of uninitialized valueMike Kaganski1-0/+3
Use of uninitialized value $microversion in int at C:/lo/src/core/solenv/bin/modules/installer/windows/file.pm line 568. Use of uninitialized value $vervariant in int at C:/lo/src/core/solenv/bin/modules/installer/windows/file.pm line 568. Change-Id: I916861a34d39a796d2941f9a8d972e7a082e3b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102058 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-04Avoid warnings about use of uninitialized valueMike Kaganski1-1/+2
Like these: Use of uninitialized value in exists at C:/lo/src/core/solenv/bin/modules/installer/scriptitems.pm line 402. Debugging the failing values, these are: element 113 Dir => gid_Dir_Autotext_Language HostName => LibreOfficeDev 7/share/autotext/qtz modules => gid_Module_Langpack_Basis_qtz specificlanguage => qtz Styles => (CREATE) element 512 Dir => gid_Brand_Dir_Share_Uno_Packages HostName => LibreOfficeDev 7/share/uno_packages modules => gid_Module_Root,gid_Module_Root_Brand specificlanguage => Styles => (CREATE) element 513 Dir => gid_Brand_Dir_Share_Uno_Packages_Cache HostName => LibreOfficeDev 7/share/uno_packages/cache modules => gid_Module_Root,gid_Module_Root_Brand specificlanguage => Styles => (CREATE) element 514 Dir => gid_Brand_Dir_Share_Uno_Packages_Cache_Uno_Packages HostName => LibreOfficeDev 7/share/uno_packages/cache/uno_packages modules => gid_Module_Root specificlanguage => Styles => (CREATE) Change-Id: I9c91e2fa9bbaab4c15e96dbbdc710141e500c482 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102053 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-04revert the macos part of..Noel Grandin1-1/+1
commit 217122387f6e0ef657b8ba85eae082b448901cec Date: Tue Aug 25 12:23:13 2020 +0200 dont turn on malloc debugging for gdb itself because it doesn't work Change-Id: If6f1ac2ddc1683dab9d57df742c647083304af07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-09-04Drop duplicating is_empty_dirMike Kaganski1-32/+0
This version was introduced in b173b425a1c1478ab3c4b43e58e09b751e3e3387, then in cabadfc288e5e7324723c62f36b918a80db90323, another copy was added so that now install.phony.log had this line: Subroutine is_empty_dir redefined at C:/lo/src/core/solenv/bin/modules/installer/systemactions.pm line 475. Let's keep the newer version, that is at line 280. Change-Id: I50f3668e47d4ea8f9c309abde8abe233cff12af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102046 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-09-04xmloff: remove dead com.sun.star.comp.Draw.XMLStylesExporterMiklos Vajna1-1/+0
And test com.sun.star.comp.Draw.XMLOasisSettingsExporter instead in JunitTest_xmloff_unoapi. Note that the test code is also dead at the moment, because xmloff/qa/unoapi/xmloff.sce disables the xmloff.Draw.XMLSettingsExporter line, but let's not regress even more in that code. Change-Id: I04eb38aad193dfbfde5df42f3e367aa47dfd12ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102019 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-03restore m_aModelChangeListenerCaolán McNamara1-0/+2
which disappeared, apparently by accident with... commit 56e1133f724896aec3f5b5c409fb5917a3b13eb4 Date: Sun Dec 8 19:33:42 2013 -0200 Convert chart 3D scene illumination to .ui and then a bunch of cleanups removed the unused code Change-Id: I53fe4f6878dda4f7b8d76a04213b5c6d1366a165 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101917 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02move Edit into toolkit only headersCaolán McNamara1-1/+1
Change-Id: If51bf7143116721e8f16272cf8aff797651d5ed1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101880 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02weld TabBarEditCaolán McNamara1-0/+1
Change-Id: I513c81faa9b93fbcb7eb93ac60152dcc97b41481 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101585 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-01tdf#134923 missing mnemonic widget target for labelsCaolán McNamara1-2/+0
presumably since... commit beeef93480fae65840646e4e36aa888efe92579a Date: Tue Mar 8 19:54:57 2016 +0530 tdf#98417, tdf#98539: DIALOG: Improvements to the Find & Replace dialog. Change-Id: Id59d573e1005e10be34994c8cc66c352b2cf500c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-01unused suppressionCaolán McNamara1-1/+0
Change-Id: Id1cc5313269e7a5d7ae53c2450a8ef7a33e3b367 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101764 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-31Fix typo in codeAndrea Gelmini1-2/+2
Move "grahic" to "graphic" It passed "make check" on Linux + Use "#pragma once" in include/svx/svxgraphicitem.hxx. Change-Id: Ia8a42afd1a822e19093ecee7b0b8791f96de2867 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101623 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-28drop newly unused VertSplitViewCaolán McNamara1-2/+0
Change-Id: Ib70905dd22ddd7a5f529501be10bdbfb9164a65f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101549 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-28move ScrollableWindow to beside its only consumerCaolán McNamara1-2/+2
Change-Id: I9c73dba293cd831834a560e9fd8e8c2d135e2358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101494 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-27Remove tempfile againStephan Bergmann1-1/+1
Apparently missing from 941b567a41569260fef14a7337511e8f42337323 "tdf#131572 Add java 9 module info for libreoffice.jar". Change-Id: I6c87c79846a1711f78716410a5939e4b88a4f298 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101490 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-08-27SvtIconChoiceCtrl can move into toolkit only headersCaolán McNamara1-1/+1
Change-Id: Ice3c01019d3e961c0ef1dce7d3eaf4f602269fff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25unused suppressionsCaolán McNamara1-11/+0
Change-Id: I6dcedc63bbca7e93ffbda135e4d596a2f709abf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101339 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-25dont turn on malloc debugging for gdb itselfNoel Grandin3-5/+9
fix the command such that, when we insert the malloc debugging env vars, we only do it for the executable itself, not for gdb, or some gdb operations will be very very slow. Before this fix, if I did a make Cppunit... CPPUNITRACE=... ran the program, then ran it again, the second time would take 5 min to get going. Now the second time it runs in seconds. Change-Id: Id08c3a82679164588b88af65a6a7b5f7dd19ff05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101318 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>