Age | Commit message (Collapse) | Author | Files | Lines |
|
(such redundant std::unique_ptr copies could happen when changing parts of the
code base to make use of std::unique_ptr individually)
Change-Id: Ib48a45a212f9426a775c7f379bc5d3c92230218a
|
|
It has ~no users, can't even be built on modern Linuxes, and it annoys
folks who want to refactor VCL.
Per ESC decision from 2017-06-08, remove --enable-tde and --enable-tdeab.
Change-Id: I51ce4786f29f8fcac2e2bb2a654c41fbfbbd8afd
Reviewed-on: https://gerrit.libreoffice.org/38718
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
This reverts commit dc141130cde07e6fd2664972d214f2cbbf859f06.
moggi/cloph insist on that it should be en_US.UTF-8 and people should
either just use that or use locale-gen. Will give problems in chroot,
but... *shrugs*
|
|
since the first does exist just with pure chroots wihout (generated)
locales, the latter not.
Change-Id: I67c9e4652ee69e0c1edd3da631d65cfcd7a5dc35
|
|
Change-Id: If4726804c2b967582cbf1a4e816c1c7bee01aeeb
Reviewed-on: https://gerrit.libreoffice.org/38626
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
It's called ENABLE_BREAKPAD now.
Change-Id: I757c4da415fb895d7cc24f13e201329111246367
|
|
...in favor of gb_LinkTarget_add_generated_exception_objects. The former would
have needed any flags to be passed in explicitly (but no call sites did), so
e.g. StaticLibrary_graphite didn't have any debug information (when building
with --enable-debug). I guess there is no downside to having C++ exception
support enabled in these places, and using _add_generated_cxxobjects instead was
likely an oversight in the first place (at least in the case of
external/graphite/StaticLibrary_graphite.mk, it was that way ever since
1ceb47d96da9e7977c96241f49ad291ff0466970 "graphite: convert to gbuild", but for
no apparent reason).
Change-Id: I9986a6c5ec30a521095dbe5315e5ca649741a790
|
|
... and add BUILD_X64 conditional.
Change-Id: Id512368dfd9dece583ead5aae1924db96f8a2a40
Reviewed-on: https://gerrit.libreoffice.org/38366
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I390b97bbacfc123b952be2b54cf1333b4d5c24a7
|
|
set literal syntax was introduced in python 3
and backported to 2.7 later
Change-Id: I4ddf76729de425ba93daf5c287969dacabcee01d
Reviewed-on: https://gerrit.libreoffice.org/38393
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
|
|
Change-Id: I446826c9f0b07b2d44321c1a1e68ea29c6d68daa
|
|
This style was only handled in the installer code for registry items,
but in scp2 it was only set for files, so effectively it was unused.
Change-Id: I197eeded29648aee2489e302f7b5e48bf13a545c
|
|
Add new PACKAGE_FILELIST_FONT
The DONT_DELETE style has no effect for files.
The FONT_WARN_IF_EXISTS style has no effect.
Change-Id: Id062ada0a680341c01827e457b1166d625afe8cc
|
|
Change-Id: I3632c618e385d3f9963637c26d94b8395d5b8cb5
|
|
Change-Id: I83404709ae7bd3f4683ea9dab8d3f0e0875bc10f
|
|
...(for LIBO_INTERNAL_ONLY), now that the status of Android has been clarified,
see <https://lists.freedesktop.org/archives/libreoffice/2017-June/077827.html>
"Re: Some baseline thoughts"
Change-Id: Ie9d5444df84c23d48c24b68d9d2ab5322c619858
|
|
Change-Id: I07605c132432cb9454614368200e9c85695bea26
|
|
Change-Id: Iba0cf3345655a8ca61a4d55b9f045c713683f97b
|
|
as ls output is now prefixed with ./ since
commit 027d661ef7e2490f1182d3e5003ae4da4135e0ca
Date: Fri May 19 18:03:04 2017 +0300
Change-Id: Ifd2b6405cb4670a7ae4e21228d29fae5b7408112
|
|
Change-Id: Ic8eee967269b3666b15795f20ee62817dadfb0ff
|
|
And rely on implicitly derived
_WIN32_IE = _WIN32_IE_WIN7 = _WIN32_IE_IE80
Change-Id: I94717e2ed66387bdc76f9047c02c0820d4adc1f9
|
|
...after 027d661ef7e2490f1182d3e5003ae4da4135e0ca "tdf#105204 fix shellcheck
warnings in solenv/bin/create-ids" broke it
Change-Id: I03e8b5bbda228bfdcb36599b8c13b530395e9e62
|
|
Change-Id: Ib15458b3d90d5ae8c91afde0d8136e76c4bd3804
Reviewed-on: https://gerrit.libreoffice.org/38142
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
Change-Id: Id497d8032668823c6db07eb179ad4484241b7285
|
|
The sal module is a bit of a special case in that it actually takes
headers from three locations: include/sal/, include/osl/ and
include/rtl. We need to cater for this in the mkdocs.sh script.
Change-Id: I846dbfe948d86a6ad719bba263165ac251dbf9bc
Reviewed-on: https://gerrit.libreoffice.org/38099
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I0c66717c0fac6d4d1bb6a33b8a196066f0f880d1
|
|
teach it to look for the following sequence in a destructor:
delete m_pfoo;
m_pfoo = nullptr;
Change-Id: Icd6271a63a024e32b53cc9e599f8f59952160380
Reviewed-on: https://gerrit.libreoffice.org/37900
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I438b6719817e0bbb47370ec54561eed2bc402cba
Reviewed-on: https://gerrit.libreoffice.org/37783
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I1c212966f9dc9157fd23ef6c71924d4d96af7e9f
SC2086: Double quote to prevent globbing and word splitting.
Reviewed-on: https://gerrit.libreoffice.org/37831
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I9257e43f18945f18c7ef738621dcb2f117246934
SC2038: Use -print0/-0 or find -exec + to allow for non-alphanumeric filenames.
Reviewed-on: https://gerrit.libreoffice.org/37658
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: I4d9a9f52d72b789d60e541193fa06dbfb8236ead
SC2155: Declare and assign separately to avoid masking return values.
Reviewed-on: https://gerrit.libreoffice.org/37551
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Change-Id: Iab3855cdd8fb1ae3719dd7267b1592eea0ef1e22
SC2006: Use $(..) instead of legacy `..`.
SC2035: Use ./*/* so names with dashes won't become options.
SC2086: Double quote to prevent globbing and word splitting.
SC2046: Quote this to prevent word splitting.
Reviewed-on: https://gerrit.libreoffice.org/37832
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
|
|
Otherwise being flexible during checking of required commands
is a bit pointless.
Change-Id: I9a6e283c816a87f35ce7913c294eaacb7da9a95b
|
|
Change-Id: Ib3f79dd53e96c8f6d40c9c6614db5c672f24ba97
|
|
Now you can author a module README file in markdown format. To
distinguish it from the existing format, you need to save it as
README.md then it'll be treated as a markdown file.
Change-Id: Iebf3ae32608d348768b2da7157d122954a7b72f7
|
|
Change-Id: I4c718740bebbde123aa0aa0cbae53778d840055b
|
|
Change-Id: Ib04ef019996888166c25ad140b7c718a173a782a
|
|
Change-Id: I682dcc9c366efea2be00b738f630a82b4cf9d636
|
|
This reverts commit 26a67002fcb9381b54de6cae1aaa37120d49066a. "Iff" is not a
typo, see 2a65bf32ec270484dcea4d22d3c93552dc0c24dd "Revert 'Typo: iff->if'".
|
|
Only replaced "iff" with "if"
Change-Id: Ib9dfa5c12b05500043147fe3b65f923b1b12a581
Reviewed-on: https://gerrit.libreoffice.org/37782
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
When COMPILER_PLUGIN_TOOL is set, solenv/gbuild/LinkTarget.mk uses the (plaform-
generic) gb_*__tool_command which don't know about the COMPILER_TEST flag (as
gb_CObject__command_pattern in solenv/gbuild/platform/com_GCC_class.mk does), so
a top-level Clang
make COMPILER_PLUGIN_TOOL=...
will generate spurious warnings from CompilerTest_compilerplugins_clang's
compilations done without the -Xclang -verify switch. This solution is a bit
hacky (e.g., it would be better to handle this more centrally in
solenv/gbuild/CompilerTest.mk), but effective.
Change-Id: I58e9a76207065d9f6050a1ace6fc85c5a26882f8
|
|
Change-Id: I327e1e2ac9c54e0cb7009e206018d82b71134747
Reviewed-on: https://gerrit.libreoffice.org/31952
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: Ia19b3eb122b66c0a6c2304f09faa83345f90892c
|
|
For the c-char in the u'...' literal, the preceding commits consistently use:
* a simple-escape-sequence if the original code already used one
* \0 for U+0000
* the (\ escaped, for ' and \) source character matching U+0020..7E (even if it
is not a basic source character)
* a consistently four-digit hexadecimal-escape-sequence otherwise, \xNNNN
For non-surrogate code points, the last case could probably also use \uNNNN
universal-character-names. However, for one, it isn't quite clear to me whether
conversion of such to members of the execution chacacter set in character
literals (in translation phase 5) is implementation-specific. And for another,
the current C++ standard references the dated (no pun intended) ISO/IEC
10646-1:1993 specification, rather than the current ISO/IEC 10646:2014, and
requires that a universal-characrer-name designate a character with a specific
"character short name in ISO/IEC 10646", but I do not find a specification of a
"short name" in ISO/IEC 10646:2014 and don't have access to ISO/IEC
10646-1:1993, so am not sure whether that would e.g. cover noncharacters like
U+FFFF.
(The only exception is one occurrence of u'\x6C' in bestFitOpenSymbolToMSFont,
filter/source/msfilter/util.cxx, where it is clear from the context that the
value denotes neither a Unicode code point nor a UTF-16 code unit, but rather an
index into the Wingdings font glyph table.)
Change-Id: If36b94168428ba1e05977c370aceaa7e90131e90
|
|
* 994e38e336beeacbd983faafac480afc94d3947e "loplugin: use TypeCheck instead of
getQualifiedNameAsString" had effectively disabled this plugin (Asserter is a
struct, not a namespace). Fixed that.
* Also improved the checks, for one removing the---expensive---use of
Plugin::parentStmt, for another making the plugin look into (...), !..., and
...&&... expressions.
* However, as the plugin had effectively already been disabled (see above) when
it was switched on generally with 839e53b933322b739a7f534af58c63a2c69af7bd
"compilerplugins: enable loplugin:cppunitassertequals by default", it now hit
way more places than I had initially anticipated. To keep the amount of work
manageable, midway-through I disabled looking into ...&&... expressions for
now. That will be enabled (and resulting warnings fixed) in follow-up
commits.
* Checks like
CPPUNIT_ASSERT(a == b)
that actually want to check a specific overloaded operator == implementation,
rather than using such an operator == to actually check that a and b are
equal, can be rewritten as
CPPUNIT_ASSERT(operator ==(a, b))
to avoid false warnings from this plugin.
Change-Id: If3501020e2d150ad0f2454a65a39081e31470c0f
|
|
Change-Id: I1d53ca095829b13818e58c1da1f0ed4c79a11e91
|
|
Change-Id: Ia525e2a3bdb9a7342fbb0982f637d926c5de9a38
|
|
Change-Id: Ie020a7f0be616fa72b1d4fd2c2874bf61b11336b
Reviewed-on: https://gerrit.libreoffice.org/37049
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I476ff9f55c264983419d5410035c1dfe6e07d5a3
Reviewed-on: https://gerrit.libreoffice.org/37035
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
- register the VCLGenericClipboard as the SystemClipboard
- enable vcl.android component in Rdb services as this wasn't done
- choose VclGenericClipboard as the android implementation
Change-Id: I067dcf4d9cdfc4b7d7a941a1c86f545263d1abad
|