summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2020-05-09compact namespace in scNoel Grandin168-433/+374
Change-Id: I05ffad6b92883d3eb6d337fe75f5fc7864485861 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93860 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-09tdf#132783: sc: Add UItestXisco Fauli2-0/+39
Change-Id: I51745010d2be39ca0510213cda54031f8a0c6a05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93815 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-09xmloff: ODF export: adapt all checks of ODFSVER_012 etc.Michael Stahl2-18/+18
Most of these actually want to check ODFSVER_EXTENDED because the extension didn't get into ODF 1.3. Change-Id: I1b625a329f7a3d146c616c62c15b56e2c314c2c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92872 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-09sc,xmloff: ODF 1.3: adapt XMLPropertyMapEntryMichael Stahl1-3/+6
Map the following property attributes to ODFSVER_013: * OFFICE-2173 table:tab-color * OFFICE-3767 text:contextual-spacing * OFFICE-3857 table:scale-to-X/table:scale-to-Y Change-Id: I3585560a3654c71353bbcaf66da20eacba8ebd1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92861 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-08Revert "lok: remove sum and equal buttons from the formula bar"Andras Timar1-26/+16
This reverts commit c35aef260feda34eae5e4b8a39f1baaa716b717d. Reason for revert: patch applied in the wrong order, pre-requsite was not merged Change-Id: Id3ce6dbac6d9b7589b8d4dd21932b8dee8356c43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93790 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-08xmloff: ODF export: rework version checks in SvXMLExportPropertyMapperMichael Stahl1-2/+2
There's some issues with the version checks here: * The requirement is to retain support for ODF 1.2 extended, but some attributes are in ODF 1.3, while others require ODF 1.3 extended, so a single version number can't be used to compare * A recurring problem is that new extension attributes are erroneously exported to standard namespaces; there is the pre-existing buggy case of style:hyperlink to consider... * Currently it's possible to distinguish multiple extended version but the only minimum version that's actually used is the minimum one ODFSVER_012_EXT_COMPAT Rework this to use a different check, by: * distinguishing extension attributes from standard attributes via their namespace, to avoid such bugs by construction * interpreting the version number always as a standard ODF version number: if the attribute is in extension namespace: if the minimum standard version is met, ignore else: if the minimum standard version is met, export * adapting all XMLPropertyMapEntry to use ODFSVER_FUTURE_EXTENDED for extension attributes (TODO: check which of these should be ODFSVER_013) This should have an effect on the drawext:fontwork* attributes, which need ODFSVER_FUTURE_EXTENDED to be exported now. Change-Id: I986c8064e578a61d69ed5fdb261f23e7582a7d75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92856 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-08sc: ODF export: table:name extension element, step 1Michael Stahl2-0/+6
3119de050ef5e3561e01badeb6307ae2538d215a introduced an attribute table:name on table:source-cell-range, but it should be in loext namespace. Allow import from LO_EXT namespace, but keep export to TABLE for now because existing LO releases expect that. Change-Id: Ic0e8737218473338d18b00150209bcc16678fee9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92863 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-08sc: ODF export: style:hyperlink extension element, step 1Michael Stahl2-2/+4
Commit 066bdb31f7ff801b7a36c79c43ecbd527ffb2a88 introduced style:hyperlink element but it should be in loext namespace. Allow import from LO_EXT namespace, but keep export to STYLE for now because existing LO releases expect that. Thanks to vmiklos for discovering that such link can be inserted via: ThisComponent.Sheets(0).getCellByPosition(0, 0).Hyperlink = "http://libreoffice.org/" Change-Id: Id951f4a657fefe1e4af5e1635acca7a96f90ce28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92800 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-08lok: remove sum and equal buttons from the formula barMarco Cecchetti1-16/+26
This patch removes sum and equal buttons from the formula bar in the lok case. A tentative to limit that to the mobile case has been done however the formula input bar is created before than the client view so we are not able to use the LibreOfficeKit::isMobile check. Change-Id: Icb820a0d77eb9295046997d2f3690d7f8b39680d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89453 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93342 Tested-by: Jenkins
2020-05-08replace ODFDefaultVersion usage with ODFSaneDefaultVersion...Michael Stahl1-4/+4
... in SvXMLExportPropertyMapper. The condition nCurrentVersion == SvtSaveOptions::ODFVER_UNKNOWN is impossible since d571a509aa324db9a425110a67ea142d157256b2. ODFVER_UNKNOWN isn't a value of ODFSaneDefaultVersion so use std::optional to handle the remaining usage. Change-Id: I1e33cb707c289224664a385b4e4425e6788b2943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92728 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-05-08remove TriStateBox classCaolán McNamara2-2/+4
Change-Id: Ia6c76a9f0fc0be7790d0c801cbca4a7b8d478976 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93680 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-07fix use after std::moveNoel Grandin1-1/+1
regression from commit 5efd34eabcbd374f0f06cac12b7b25f955db7965 loplugin:makeshared in sc Change-Id: I1ec603f6ea01aca86cb478f2bf3a6d5d37f235af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93639 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-07replace ODFDefaultVersion usage with ODFSaneDefaultVersionMichael Stahl2-25/+25
Compare with ODFSVER_012 mostly works the same, except for places where namespaces are defined where the ODFSVER_EXTENDED bit should be checked. Change-Id: I86469b763bc2f903632976bc9d6ec04d543d705e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92727 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-07sanitize properly Calc search bounds (tdf#132097)Luboš Luňák1-4/+6
The row/col handling seems really weird to me here in some places (like starting actually at startcol+1 in some cases). But at least properly limit the values to prevent out-of-bounds accesses. This also reverts 2670e980c7dbadbdc20ff23d57ad892951edc254. Change-Id: I5eb94f3841f3defa763046d5d5bec805abd97c62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93634 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-07tdf#132796: use LO language settings to set default XLS languageMike Kaganski3-10/+6
This partially reverts fixes for i#63105 and i#71033, i.e. parts of commits 6ca96e7aee937affef218e0bb892e6904f4ef358 and 35777f0b401ba7bee21a24c32739e86598ba608b. Instead of using hard-coded Win-1252 for Excel files by default, use LibreOffice locale language or default document language (as used for old WMF, DXF and RTF files - see 20f6a6b159c69771dc0e087f63b6c701908e32e2, 1a9a77f84cac68bd5374df3e9ee4df88dc87a0ac, and f26bbdb386f9e66b1a154d0589b1a446ea2dd8d5). When a font in XLS specifies ANSI_CHARSET (0), allow using the default encoding, not the corresponding Win-1252. This mimics Excel behaviour for such fonts. Do not use first font's encoding as file default encoding, as Excel doesn't do that. Do not consider font-specified encoding in ImportExcel::Rstring to mimic Excel behaviour for cell number formats (but keep using it in ImportExcel::ReadLabel for cell content). Change-Id: I9860013a1244dc12f06f30c81a67909012c04913 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93612 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-07tdf#118418 implement scrollSubstringTo() for gtkColomban Wendling2-0/+8
Define & use new accessibility scroll type compatible with IAccessible2 and extend the XAccessibleText interface to require scrollSubstringTo(). Co-authored-by: Martin Pieuchot <mpi@grenadille.net> Change-Id: Id3b2e8616892d7dcbfb41a14b72a8a457fd1dbf6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89851 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-07fix memory leak of xmlDoc objectsNoel Grandin5-106/+107
in unit tests Change-Id: Id16731bbbe2f1b0e3642722d77aba04fc98db4cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93508 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-07update notebookbar for visible=falseandreas kainz2-0/+4
Change-Id: Iad68574a0a9133f106c001dbb2dd5b7886c1ee28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93597 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-06tdf#131536: sc: Add unittestXisco Fauli2-0/+19
Change-Id: I6ef8ef3f469b744a8be9d92c65201d75f8711831 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93582 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-06tdf#79998 FILESAVE: XLSX export with long sheet names (length > 31 characters)Serge Krot4-0/+154
Change-Id: If18e3b751486144f3477b6e0c2615751f57e5565 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92372 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-05-06tdf#127889 NB use .uno:ToggleMergeCells instead MergeCellsandreas kainz2-2/+2
Change-Id: I495619c0b4f7dfd65b8105c657ea2156ca10550c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93593 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-06tdf#101181: support for transparency attribute of glow effectMike Kaganski1-0/+1
Read/write support for ODF and OOXML (in ODF, loext:glow-transparency attribute of style:graphic-properties has been added). Added UI on glow sidebar panel. Not used in actual painting yet. Change-Id: I21b25d9c52c8611cd796f056374377ebf13cc2f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93565 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-05Resolves: tdf#131536 TEXT() support empty format string mimicking ExcelEike Rathke1-0/+12
Change-Id: Iffc37179cafb8b8bcfa1232e7aa54ae119ab5846 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93504 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-05-05remove unused nSearchFamily and nMask membersCaolán McNamara3-5/+0
and so SetSearchMask which doesn't have any effect anymore Change-Id: I0b7f402ce0317971d5196fc448fe2945a6a292f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93393 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05help states that SfxNewStyleDlg lists SfxStyleSearchBits::UserDefined stylesCaolán McNamara1-1/+1
Change-Id: Ibf89d0ff1154b943a5650ac6cd6aa64a084c15cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93491 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05ScOrcusStyles::commit_cell_style creates SfxStyleFamily::Para stylesCaolán McNamara4-5/+5
and setAllStandard is only called on the results of that so rename it to setAllParaStandard and we can safely assume that the mask should be ::All Change-Id: I087b40ed919c1b8724d5d36bae2f94180148cec2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93470 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05tdf#131230: Sidebar: Can't set Automatic colorPranam Lashkari1-1/+1
This also solved the issue in sidebar with some controls when selecting an item it selects the item below Change-Id: I607b8bc44402b57b5c4833f918fb41b23ddf48c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93099 Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> (cherry picked from commit 756bbe3f94fe1736406b7fd16ce62a67e7e62769) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93380 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2020-05-05make the family and mask explicit in SfxStyleSheetBasePool::FirstCaolán McNamara3-4/+4
Change-Id: I36655b65ca00e5f7b8779a28d4a1778c8e35dc4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93461 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05IdleCalcTextWidthScope uses SfxStyleSheetBasePool::FindCaolán McNamara1-10/+0
with a SfxStyleFamily::Page arg so there no need to call SetSearchMask(SfxStyleFamily::Page) on the SfxStyleSheetBasePool so then there's no need to save and restore the family and mask because we don't change it and don't need to use it. Change-Id: I6677731d680a72554a1c02b3008b62d47aa8b568 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93454 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05Related: tdf#130108 ensure we don't reuse the last SetSearchMask settingCaolán McNamara1-1/+1
Conditional style formats can only be SfxStyleFamily::Para formats as far as I see, and presumably we don't want to reuse any previous SetSearchMask settings here in xml export, so this looks like a dup of the same problem of commit 454a3c945fdc02d706b0a5ad49ca13e0443fa8e5 Date: Sun May 3 16:43:06 2020 +0100 Resolves: tdf#130108 ensure we don't reuse the last SetSearchMask setting Change-Id: Ic26b450068bd1e13a3c82b1c1466630402498787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93453 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-04related: tdf#130108: sc: Add unittestXisco Fauli2-0/+18
The issue per se can't be tested in ScExportTest because it's not happening when using the commandline, but the gui. See: https://bugs.documentfoundation.org/show_bug.cgi?id=130108#c13 Still, there is no existing test for x:dxfs elements so I think this test is still useful Change-Id: I5fc650aedfa06416732941367b31cc18199e2cc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93411 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-04make Search family and mask explicit for SfxNewStyleDlgCaolán McNamara1-1/+1
Change-Id: Ib3e5765d37474188d6505f1d9965969ee6c24f0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93358 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-04default CreateIterator mask to SfxStyleSearchBits::AllCaolán McNamara3-3/+3
Change-Id: Ie79eff57646853613e8c6060adbce92dd388df5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93357 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-03Related: tdf#130108 expand single arg SfxStyleSheetBasePool::Find usesCaolán McNamara1-1/+2
remove it and expand its uses to explicitly show what it does Change-Id: I2d4511c58b51003c327a2c70e3cc4f60751f520d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93352 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-03Resolves: tdf#130108 ensure we don't reuse the last SetSearchMask settingCaolán McNamara1-1/+1
Change-Id: Iddc4438b8bd30576be4531d47b6be0ac70847a9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93350 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-03Related tdf#131125: Improperly used ampersandJulien Nabet1-1/+1
Really search all occurences of Find & Replace Change-Id: I1c1301451afa4d339902a275594ecb4cd46030db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93331 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-05-02cid#1401342 silence Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: I961d68bc02ed22ab446dabbc6073df8ddf6730f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93312 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-01tdf#124176: Use pragma once instead of include guardsYusuf Keten1-3/+1
Change-Id: I72c978c9d392d1aba1ca99feeacee021835adf52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93098 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-05-01tdf#66668: sc: Add unittestXisco Fauli2-0/+14
Change-Id: Iccc60a5847987f3dc0b4a47e55d0886ada63e4d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93236 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-01Revert "lokit: scale the validation dropdown with client zoom"Dennis Francis1-20/+3
The scaling of the float window containg the listbox is unfortunately far from ideal at certain zoom levels and entry sizes. There are issues like too much extra spaces around the entries and around scrollbar if present. These issues need more work to fix. Until then lets revert this. Another issue is that we don't really want to zoom adjust any popups in mobile or android as this does not match the design of jsdialogs. This reverts the commit : 7787bac16cbe63698f56a9a70d9b1b217f3ea860 (master) a87e78df635d4a8e745bfffcf33d022d2a498afa (cp62) Change-Id: Ic31040b491e25b5113dfc8e70d3f73de204862e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93239 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 84200fc5e1b807629de2d975acaa3ffb81640d1f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93137 Tested-by: Jenkins
2020-04-30loplugin:makeshared in scNoel Grandin25-345/+344
Change-Id: I512d05ea24c519c25f03a35842e362bf23f05693 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93198 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-29lokit: scale the validation dropdown with client zoomDennis Francis1-5/+22
For zoom > 2.0 and zoom < 0.5 the scaled dropdown looks either too oversized or tiny and makes the ui look unpolished, so the zoom factor is trimmed between this range and then used to scale the validation window. Change-Id: Ic69383f273cb32670b6012f59715250dbfcf627c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92915 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit a87e78df635d4a8e745bfffcf33d022d2a498afa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93067 Tested-by: Jenkins
2020-04-29lokit: trim validation dropdown height to contentDennis Francis1-1/+5
The validation dropdown looks ugly for lists with small number of items as its height is hardcoded to SC_FILTERLISTBOX_LINES(=12) * TextHeight Instead lets use the number of entries in the list to determine the height if this count is less than SC_FILTERLISTBOX_LINES Change-Id: If026140044e6665159cd616c13a2eb57356ae53f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92914 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit adf10bae8aecd8b765a21660b31056292276bdb2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93066 Tested-by: Jenkins
2020-04-29lokit: fix validation dropdown's wrong positionDennis Francis1-0/+16
Reverse the zoom scale on the position of the dropdown before letting the vcl::FloatingWindow convert this to twips without any scale information. Without this reverse scaling, the dropdown will be incorrect due to double application of the same zoom (one in core and one in client). Change-Id: I73de12593b13e1bc9fb0514bec23c20d440d8923 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92913 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit a68bfe87f6c720dd2b4721edf869c6801fa2d967) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93008 Tested-by: Jenkins
2020-04-29simplify handling of comparing XML_NAMESPACE valuesNoel Grandin1-1/+1
Change-Id: I18bbf1ee206285842250891ce556d523489855b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-29tdf#130770 apply autofilter to data regardless of autofilter changesscito3-22/+88
Add a unit test Apply autofilter to data if there are no changes from the user for AutoFilterMode::Normal mode The condition eMode == AutoFilterMode::Normal at that position is equivalent to eMode != AutoFilterMode::Top10 && eMode != AutoFilterMode::Empty && eMode != AutoFilterMode::NonEmpty because - Top10: Excluded in if() - Custom: Already handled before - Empty: Excluded in if() - NonEmpty: Excluded in if() - SortAscending: Already handled before - SortDescending: Already handled before - Normal: The remaining condition Delete dead code: The condition if (mpAutoFilterPopup->isAllSelected()) will never be true since eMode == AutoFilterMode::Normal && mpAutoFilterPopup->isAllSelected() is excluded in the "outer if condition" !(eMode == AutoFilterMode::Normal && mpAutoFilterPopup->isAllSelected()) Moreover aParam.RemoveAllEntriesByField(rPos.Col()); has already been called before. Change-Id: I1a5362f6edf6d28b3e049977d761cef83897e63e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91645 Tested-by: Jenkins Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de>
2020-04-29weld SfxTemplatePanelControlCaolán McNamara4-2/+5
Change-Id: Ib3f6d01ddec37afc3987423dc15ab84ad6475f37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92942 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-29Fix typo in codeEike Rathke2-13/+37
... and provide a compatibility mechanism for supported service names, as the typo was long standing since the beginning and existing extensions may rely on it. Co-authored-by: Andrea Gelmini <andrea.gelmini@gelma.net> Change-Id: I289ec8a17b131bd013dd4b69327aed41e488d4f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92938 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-04-28move the castToFastAttributeList functionNoel Grandin23-186/+121
to the slightly higher namespace, to make it easy and more readable to use directly in a for-loop-range expression. And make it return a reference rather than a pointer, since it is never allowed to be nullptr. Change-Id: I15d0b32493ef65cfc601b247c272b318f1eadfd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-28Resolves: tdf#127831 implement RAND.NV() and RANDBETWEEN.NV() non-volatileEike Rathke11-9/+73
Same as RAND() and RANDBETWEEN() but not recalculating on every change, just the normal expression recalculation. Change-Id: I8ba7099125e487a78bd3d91db8b666c2f36b22fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92994 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-22 18:45:12 +0000