summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2017-05-19loplugin:stringcopy: scStephan Bergmann31-60/+60
Change-Id: Ic6cb5406d20e7e07b8e34514df71adf1c3a4e727
2017-05-19make string translation loading more uniformCaolán McNamara60-235/+233
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-19Removed unneccessary ASCII-Art and commentsThomas Beck10-311/+12
Change-Id: I455d7aa7c6e6313a0d24137e02b7bf04ede9aae9 Reviewed-on: https://gerrit.libreoffice.org/37752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-05-18Revert "Fix typos"Stephan Bergmann2-2/+2
This reverts commit 26a67002fcb9381b54de6cae1aaa37120d49066a. "Iff" is not a typo, see 2a65bf32ec270484dcea4d22d3c93552dc0c24dd "Revert 'Typo: iff->if'".
2017-05-18Fix typosAndrea Gelmini2-2/+2
Only replaced "iff" with "if" Change-Id: Ib9dfa5c12b05500043147fe3b65f923b1b12a581 Reviewed-on: https://gerrit.libreoffice.org/37782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-18tdf#107862 ignore subtotals in outline mode and empty rowsTomaž Vajngerl1-40/+63
Change-Id: Ifb469193d4f7b3a5f48ab1ef15ae9f5996bfa608 Reviewed-on: https://gerrit.libreoffice.org/37740 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-05-18Replace macro with functionStephan Bergmann1-1/+7
Change-Id: I005622c607a5a3dcd31b46f6e819546b7ece630b
2017-05-18Pass grammar to ScCompiler ctor instead of subsequent SetGrammar()Eike Rathke40-140/+71
Not only to have more concise code but also to avoid setting grammar twice if the actual grammar differs from the document's default one. Change-Id: I7bfd151c22c48a40aea05f5f983fa0370d9fd9ae
2017-05-18Always set a grammar when constructing ScCompilerEike Rathke2-4/+20
Otherwise mxSymbols is null, which is rather unexpected as the past has shown, see commit 63843a97262ccfa38d838a9cbbc3faadba8290a6 Change-Id: Id4c13a5f50e711513a71a7d6cd6f87b4112b1f1d
2017-05-18assert instead of OSL_ENSURE if grammar is GRAM_UNSPECIFIEDEike Rathke1-1/+1
Change-Id: Ie23a5a98e9bc6dfbd5d685c482fb358ac3822845
2017-05-18tdf#107920: Crash when using ScCompiler in condformatJulien Nabet1-0/+2
Just call SetGrammar from ScCompiler object with grammar of document See bt in https://bugs.documentfoundation.org/attachment.cgi?id=133382 Change-Id: Iedf4b88f2821bbcf728e4b1c023041fd6f10e5f3 Reviewed-on: https://gerrit.libreoffice.org/37739 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-18Add comment about precedence of Wildcards over RegexEike Rathke1-0/+3
Change-Id: I053c8ebb328aaa3b577283af17b6540b997e3dcc
2017-05-18New HintId and unit test for hidden rows and SUBTOTAL, tdf#93171 follow-upArul Michael6-6/+51
Adding new Hintid for HideRows so that we notify only formulas with subtotal and aggregate function for recalculation. Added unit testing. Change-Id: I44f2e45acaf697f91744bc8202f27b218faa5b43
2017-05-18Respect read-only config items in Options/Calc/Calculate dialogAron Budea2-0/+19
Read-only state is now read except for settings in General Calculations (except Decimal places). Change-Id: Ia947f6657ae5638c414bf4e82fac314b5993f4c5 Reviewed-on: https://gerrit.libreoffice.org/37546 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-18sc lok: fix wrong assignment aEnd.X()Henry Castro1-2/+3
In tiled rendering case, the window size is small and the end point will be cut, then result wrong invalidation area Conflicts: sc/source/ui/view/tabview3.cxx Change-Id: Ief49c5f47bbc69485354ab396c7508db9548f82a Reviewed-on: https://gerrit.libreoffice.org/37737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-05-18loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: I1c50d176e793397a1f9625f797a3750cf191a61c Reviewed-on: https://gerrit.libreoffice.org/37679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-18Clean up a set of RTL-related commentsTor Lillqvist2-2/+2
It is fairly pointless to have a comment like "--- RTL --- (mirror mouse pos)" in front of code that obviously is related to RTL anyway, like "if( AllSettings::GetLayoutRTL() )". Also, the fact that many comment were exactly the same indicates that they has been added as an in-line version control change marker. In other places, comments were informational, but no need for them to include yet another metasyntax, "--- RTL ---". Just "RTL:" works fine. Change-Id: I20feef308ed8ac9d32a8bf440fc20b442753c4ff
2017-05-17sc lok: Don't crash on comment undo.Jan Holesovsky2-1/+3
Change-Id: I3b8686e2d52359de2d99413e63d4a424ba1439d1 Reviewed-on: https://gerrit.libreoffice.org/37710 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-17tdf#107892: fix negative values case with maxifsJulien Nabet2-2/+2
std::numeric_limits<double>::min() returns positive value for float/double so use std::numeric_limits<double>::lowest() (see http://stackoverflow.com/questions/17070351/why-does-numeric-limitsmin-return-a-negative-value-for-int-but-positive-values) Change-Id: I0afce2d38c6936aeff26923182bcafd2f0008d9e Reviewed-on: https://gerrit.libreoffice.org/37693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-17Unit test to ensure that calculating with the intersection works, tdf#96426Eike Rathke1-0/+6
Change-Id: Ia447c91d80b51f183d591a89a103ba68173a9d85
2017-05-17add unit test for Excel whitespace operator intersection, tdf#96426Eike Rathke2-0/+30
Change-Id: I8cc5d9fbb6a92545379288dc1648a6c68ad4ccb1
2017-05-17tdf#43535: add unit test for this.Kohei Yoshida2-0/+157
Change-Id: I4e6b27f82d1344ac77b02867e1e717c510a133b6 Reviewed-on: https://gerrit.libreoffice.org/37696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-05-17tdf#43535: support additional sheet protection options.Kohei Yoshida18-10/+357
New options are: * insert columns. * insert rows. * delete columns. * delete rows. Change-Id: I076b0d01bee0fff0623e2f1137c09938a6110939 Reviewed-on: https://gerrit.libreoffice.org/37695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-05-16ExternalZoom and ExternalScroll are unusedCaolán McNamara1-12/+5
which leads to CommandWheelMode::ZOOM_SCALE becoming unused and so touch/touch.h is unnecessary Change-Id: I7cb9a4f6af2719deb0d768e35d514b59010daf79 Reviewed-on: https://gerrit.libreoffice.org/37671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-16lok: sc: invalidate col/row header on undo row/col operationsMarco Cecchetti2-1/+23
Change-Id: Ia0b2174cfcc3f2b3075e8f6eee1eb0f56b64db44 Reviewed-on: https://gerrit.libreoffice.org/37686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-05-16lok: sc: make row/col header updating, on row/col operations, tab-awareMarco Cecchetti3-9/+34
Now, on inserting/removing or resizing a row/col, the row/col header invalidation callback is notified to another view only if it is displaying the same tab of the view where the row/col operation is occurring. Conflicts: sc/source/ui/view/tabvwshc.cxx Change-Id: Ic65fd82b2e3009420c7b481e7e8c1ff8bb11bcce Reviewed-on: https://gerrit.libreoffice.org/37241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-05-16Revert "lok: sc: invalidate col/row header on undo row/col operations"Stephan Bergmann2-23/+1
This reverts commit 76d47e6f63e11d3509339ade6203757d63582d21, breaks the build.
2017-05-16lok: sc: selection overlay was not updated on document size changedMarco Cecchetti1-0/+2
Change-Id: I193f37d50ac3ff0ccbf7e39caab4bf25ed3c9a9c Reviewed-on: https://gerrit.libreoffice.org/37402 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-05-16lok: sc: invalidate col/row header on undo row/col operationsMarco Cecchetti2-1/+23
Change-Id: Ifabce9941541a615840163168af6fedaf54575cd Reviewed-on: https://gerrit.libreoffice.org/37243 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2017-05-16lok: sc: fix for row/col header updating on changing tabMarco Cecchetti1-0/+2
When you switch tab the current row/col header needs to be invalidated. Change-Id: I26ef6f9990726f3c96ddfc9ac45472fafc8e8507 Reviewed-on: https://gerrit.libreoffice.org/37242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-05-16lok: sc: misplaced comment mark on inserting/deleting/resizing row/colMarco Cecchetti8-44/+125
A unique id has been introduced, in a similar way of what occurs in Writer. Change-Id: I7b2ef694867fb4184c4cfc616fe1c8f12da3b676 Reviewed-on: https://gerrit.libreoffice.org/36962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-05-16lok: sc: address and formula text field empty on creating a new viewMarco Cecchetti2-0/+7
When the client starts the address and formula text field were empty because the updating callbacks occurred before the view callback handler had been registered. So a new method `afterCallbackRegistered` has been added in order to perform any needed updating/initialization soon after the view callback handler has been registered. Change-Id: Ia47234e32796f7e4bc1a8408736102054b4666e2
2017-05-16loplugin:unusedfields improve write-only analysisNoel Grandin5-21/+5
by whitelisting a couple of methods we know only write to their parameters Change-Id: Id7aef9c03c23d10c27707b21eb9a0db4a6c2757c Reviewed-on: https://gerrit.libreoffice.org/37647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-16loplugin:checkunusedparams in sc(part5)Noel Grandin21-72/+63
Change-Id: If969b989ed16e58fba26ae0fec06759da855a5ad Reviewed-on: https://gerrit.libreoffice.org/37646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-15Fix typosAndrea Gelmini2-2/+2
Change-Id: If4b3d3e0f5f57ffe646cae032a2968e0e7dbe1aa Reviewed-on: https://gerrit.libreoffice.org/37605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-15SAL_WARN_IF is more appropriate hereEike Rathke1-1/+1
Change-Id: Iab1b444ba26307e2eec758dffc1374d3cd925626
2017-05-15replace 'if ( ) SAL_INFO' with 'SAL_INFO_IF'Jochen Nitschke1-5/+1
Change-Id: If45b57a3dc6d7ed088fde8835e14abe4bf7378f8 Reviewed-on: https://gerrit.libreoffice.org/37554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-15tdf#82326 calc 32bits unable to open files with a lot of cond formattingfrederic vroman1-2/+2
The code to build and compute formulas is using an fixed size array. The size of this array has been changed from 512 to 8192 by commit 9c1ca6dca3b553c302a635357e33591605343b99 Since then, LO consumes a LOT of memory while opening scalc files which are making extensive use of conditional formatting. This is a silent issue when working with a 64bits versions of LO because the memory is immediately released at the end of the load phase. However, with 32bits versions, some files can not be opened anymore as it can consume the full process memory space (2GB on windows). The parser is creating ScCondtionEntry objects to store conditional formatting expressions which are immediately compiled in the constructor. However the compile method did not return a flattened token array. Change-Id: Id290bc1f5838c246d4c2322b297b13307defaf88 Reviewed-on: https://gerrit.libreoffice.org/37527 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-15tdf#39468 translate German commentsThomas Beck12-100/+38
Translated comments in sc/source/ui/drawfunc/. There were still some left that bin/find-german-comments did not find. Removed unneccessary comments. Change-Id: I61c1cadea259bb2a4b14721a25da85e9a9c0753e Reviewed-on: https://gerrit.libreoffice.org/37530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-05-15Typo: s/threashold/thresholdTor Lillqvist3-4/+4
Change-Id: I42af7f4c27084e41c63b8d3c8c3111dd814eb74d
2017-05-15remove some unnecessary lockingNoel Grandin3-5/+0
Change-Id: I7da9e82930d3fe8f927c495aeca270b8bb5cf65c Reviewed-on: https://gerrit.libreoffice.org/37602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-14Remove more %20 from style commandsMaxim Monastirsky1-5/+5
And fix a typo found in H5/H6 commands in Writer's style toolbar. Change-Id: Ieb8f701d055870040010da66a9a108bbd089bc0a
2017-05-14handle test that apparently depends on our additional fontsMarkus Mohrhard1-0/+3
Change-Id: Ia2db679ee3e974da0f38d24257795d8c4b0ba1f9 Reviewed-on: https://gerrit.libreoffice.org/37560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-13add basic universal content test, tdf#107828Markus Mohrhard4-2/+18
Change-Id: Ifb2a867cf2168a5ebf51d4a408d2e2a29032a764 Reviewed-on: https://gerrit.libreoffice.org/37580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-13use empty document in orcus gnumeric import, tdf#107828Markus Mohrhard3-0/+11
Change-Id: Ia7ee2de6f9b14a132a29c01f8d863889477c0a8d Reviewed-on: https://gerrit.libreoffice.org/37579 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-13import stream on the LibreOffice side, tdf#107827Markus Mohrhard1-3/+13
This adds support for all LibreOffice content providers and non-ascii file names. Change-Id: I0a0fd0ab0c78ef039679516e7a3e880929e8f725 Reviewed-on: https://gerrit.libreoffice.org/37578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-13Kill some code duplication, move shared code into private funcKatarina Behrens2-28/+15
Change-Id: I4898f49c5bc6d68e73b283bc5b4abbfa0b000a40 Reviewed-on: https://gerrit.libreoffice.org/37541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-12update comments and remove TODOJochen Nitschke2-3/+2
TODO was addressed in commit 58c5a9de2a0b985ef81557271db39c56ceb624f9 when API version of importBiff12Formula was replaced with one using ScAddress Change-Id: I65629c80f8d5667c083602a87585d467d4c7dc60 Reviewed-on: https://gerrit.libreoffice.org/37555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-05-12tdf#106051 Notify listeners on top and bottom of split formula groupArul Michael1-0/+6
Change-Id: Icecb59a476f57cee0c04c3e21d60e6c7fa12f65a Reviewed-on: https://gerrit.libreoffice.org/37011 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-12Use ScTokenArray::AssignXMLString() and ScTokenArray stack objectEike Rathke1-5/+4
Change-Id: I75477b3e9b5f71384084212b634faeaae3dddefa
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 08:12:02 +0000