summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2020-04-07Fix typoAndrea Gelmini1-1/+1
Change-Id: Iaeafd85b5d1becbafba644bb873dd7f676707cb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91805 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-07Resolves: tdf#131170 columns tagged as delimiter not columnCaolán McNamara1-1/+1
Change-Id: I889c3ba38776a63587a68c7827956b6747c08e38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91784 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-06loplugin:unusedvariableplus in scNoel Grandin3-4/+1
Change-Id: I163b0cd5a8dc381322b0113aca23faae29b1b859 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91755 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-06unset dest dnd row highlight after dropCaolán McNamara1-0/+1
Change-Id: Id9b70b247351a5c12b6540c828e2c34f9fb31c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91750 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-06lok: introduce QueryControlState functionHenry Castro3-0/+12
The sidebar usually executes UNO commands to the core framework, however the controls already have formatted the text that is useful in Online client side. For example the units conversion. The QueryControlState method will retrieve the current formatted text of the sidebar control to be used in Client Side. Change-Id: I0b3e3a1462d4391ac911352f35808a5e5d9f9ffb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91237 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91577 Tested-by: Jenkins
2020-04-03split up polypolygonprimitive2d.hxx into separate filesTomaž Vajngerl2-2/+2
This patch splits the polypolygonprimitive2d.hxx into: - PolyPolygonColorPrimitive2D.hxx - PolyPolygonGradientPrimitive2D.hxx - PolyPolygonGraphicPrimitive2D.hxx - PolyPolygonHairlinePrimitive2D.hxx - PolyPolygonHatchPrimitive2D.hxx - PolyPolygonMarkerPrimitive2D.hxx - PolyPolygonSelectionPrimitive2D.hxx - PolyPolygonStrokePrimitive2D.hxx ... and fixes the include files and pre-compiled headers Change-Id: I23982e0c81e8992f69e14cbac8e86858266b9999 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91603 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-04-03uicalc: no need to use an empty documentXisco Fauli2-1/+3
Change-Id: Id1c42b7c4f0f406d2979334d7b71fc20d7ff8620 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91615 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-03use mdds position hint (tdf#131716)Luboš Luňák1-1/+4
Otherwise this is the usual case of possible quadratic mdds slowness. Change-Id: I5b33df65e127702c011517d79b9cd41a7e820ca0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91553 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-03Turn defines into constexprsMike Kaganski1-102/+120
This allows to see actual values of the WhichIds in IDE easier Change-Id: I31106459cd262000444175d082eb349ff937488d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91513 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-02cid#1460967 Division or modulo by float zeroCaolán McNamara1-1/+1
Change-Id: I2322ac1abec040d14fbffaf495c83cf3303fee92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91547 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-31tdf#131372: Add unittestXisco Fauli2-0/+18
Change-Id: I7dbed0c28206ffd6a95ecedec74fdac044fe79cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91432 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-31convert enum to scoped in SvBaseLinkNoel Grandin10-11/+11
Change-Id: Ief399381ac27764fce95ee053c322571a07b671c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91366 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-31Resolves: tdf#131372 Write "error cell" formula to OOXMLEike Rathke3-5/+23
Change-Id: Iedbe0912ff28e6203bec0104c59b1102cf97daf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91382 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-30FrameLineColor - add Color parameter, and share code for color params.Michael Meeks1-27/+32
Change-Id: I50483228221e817eb1a1d049d3c1ddf55a9c91d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91354 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-03-29tdf#130981:Simplify uses of sal_math_Doublejames1-20/+9
Change-Id: I2cac5d7c2efc9dbf4c4fc7ca5d88e9044d875edc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91203 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-27Resolves: tdf#131096 Handle argument error and propagateEike Rathke1-10/+31
For etsPIAdd and etsPIMult also check if the fPILevel parameter was actually specified (explicitly or missing/omitted) and do not pop the 3rd parameter if not. GetDoubleWithDefault() can't handle that as apparently was erroneously assumed. Use IllegalArgument error instead of IllegalParameter in most cases (the parameter is fine but the argument value is not). Actually propagate ScETSForecastCalculation::mnErrorValue if set as PushMatrix() does not, on purpose. Change-Id: Ia2db5b0a7a388f0f40b73c6a4f66debbedec41e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91232 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-27tdf#131380: Add unittestXisco Fauli2-0/+22
Change-Id: I9111c82919b9e30200fbb265143e072f7f3b3363 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91205 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-27tdf#43157 Clean up OSL_ASSERTJens Carl2-2/+2
Change-Id: I23da49e2395a76eaa97c98757db16289e200a828 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89407 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2020-03-26tdf#131380 crash on loading specific xlsx documentCaolán McNamara1-3/+4
mpPerIdx is null, because bEDS is true, assume 0 in this case Change-Id: I44c2433b0de57a28cece6b9b01ba543bdc3cb8d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91145 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-26Fix one more get_url_for_data_fileStephan Bergmann1-2/+3
Change-Id: I07e11cd83443f40fd520088c18647f0992ccae82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91139 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-26tdf#131593 ScOutputData::GetMergeOrigin: Handle cells outside own areaMichael Weghorn1-7/+21
Rendering the bugdoc had regressed at commit 9113f17e65b1dafbc178fd269e2967c1e2632f0e ("LOK: fast tile rendering (text only)", 2016-06-04), which had changed the area covered by the ScTableInfo in use from the document's whole rendering area to that covered by the bounding rows and columns for the tile being rendered. For the bug doc, it was e.g. no longer detected that cell A10 (nX=0, nY=9) is merged to A1 when processing the "second tile in the second row of tiles" in ScOutputData::DrawEdit. Change-Id: I60c3ad43ad816d2186547486116f63e27ed3a166 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91094 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-26Extend loplugin:cstylecast to certain function-style castsStephan Bergmann1-1/+1
...that are equivalent to const_cast or reinterpret_cast, and should arguably better be written that way for clarity. Drawing inspiration from <https://reviews.llvm.org/D76572> "Replace `T(x)` with `reinterpret_cast<T>(x)` everywhere it means reinterpret_cast. No functional change". Change-Id: I27b8f70d324d32ecba658db4d1c2db03e10d5d3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91086 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-25tdf#127113: Allow to fill any two numeric fields in Fill Series dialogSarper Akdemir6-55/+54
Added m_nSelectHeight and m_nSelectWidth to ScFillSeriesDlg class for deriving missing box if other two boxes are full. CheckValues() mimics behaviour of previous check functions with added functionality of calculating missing start or increment values (end value was already handled in previous check functions) in linear fill mode if it is possible to calculate them from other two values. Change-Id: If30d96f1b5f7e1bb88f473d7c0c5c2802ba6f225 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87841 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-03-25tdf#101181: add sidebar panel for Glow effectMike Kaganski2-0/+13
... in Writer, Calc, Draw and Impress for CustomShapes. The artifacts that become apparent using the controls, e.g. remnants of the effect when decreasing radius (in Impress), or glow not drawn until reload after enabled or radius set to 0, should be fixed in a separate commit. Change-Id: I6107597161bc67ae8c3e62c260ef6ad241c7dedf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91056 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-25lokit: Mark document as modified on chart insert/edit...Dennis Francis1-0/+2
immediately at least in the case when LOKit is active. This is to allow prompt emission of .uno:ModifiedStatus=true statechange message from lokit to the client. Without this, in online the chart insert/modify related changes may not get saved on client exit. Change-Id: I8c38a37cc455f74a70d43b6aaa3e5035b283d47f (cherry picked from commit 75adb624dfff4659e6f3099a1720fbd697560f9c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91036 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-03-25Remove unused using declarations in oox...xmlsecurityGabor Kelemen21-25/+0
Found by: run-clang-tidy-10 -checks=-*,misc-unused-using-decls Change-Id: I3e95791e223ef01e140a6217e29a9efae428a784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90876 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-24weld writer navigatorCaolán McNamara3-7/+7
GtkToggleToolButton are much wider than vcl equivalents. Split the bottom toolbar into two toolbars. Rearrange their contents so the layout of each level visually match. Notes: Master documents have two modes, master content tree and the normal content tree. You can drag entries from the content tree into the document, drag mode drop down controls whether its a link or a copy etc that's dropped in. Documents can be dropped into the content and global trees. If outline tracking isn't active, then when content changes the tree is cleared and refilled, typically an effort is made to reselect the same entry that was previously selected. Additionally, if the amount of content didn't change an effort is made to scroll back to the location the scrollbar was at before the clear. Change-Id: I00c015145eac5b1acc3398d3c40861d830e4264a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-24tdf#131296: get numeric value with its data type in StepLOADNCAndreas Heinisch3-0/+83
In order to load numeric values, generate SbiOpcode::NUMBER_ opcodes including the numeric value and its data type instead of SbiOpcode::CONST_. The numeric value and its data type will be restored in SbiRuntime::StepLOADNC. When the new compiled code is stored in documents, e.g. password-protected libraries, leagcy LO versions will just read up to non-numeric characters, thus correctly obtaining number value and ignoring the type, so the change is backward-compatible. To interpret legacy compiled code, old treatment of SbiRuntime::StepLOADI is restored, reverting commit 0b4f8bf571baf2ccd5a8aafdc4deb41867420be3. This change reimplements the fix for tdf#129596. Change-Id: I46ebfc77f9bea69479968950c0fb7264e4a7ab27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90858 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-20The idl __attribute__((__weak__)) hack doesn't seem necessary for --enable-ltoStephan Bergmann2-4/+0
dbfc495a9ace0865d764dad7404633a12cda2873 "Add config option used when we try to link one huge object file" had added it for the --enable-lto case, but without documenting exactly what it should help with. And at least my local Linux --enable-lto --enable-dbgutil etc. build successfully does `make check && make screenshot` without it. This removes the only use of STATIC_LINKING, so remove it completely. (And basctl/source/basicide/basidesh.cxx still needs to include config_options.h for ENABLE_MERGELIBS.) Change-Id: I3820e1cacccc92f5ac0c9c7fcc539c29a6864694 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90804 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-20Rename isMobile to isMobilePhone and introduce a separate isTabletTor Lillqvist6-7/+8
The intended semantics of isMobile() has been to say whether the device is a mobile phone ot not. Not whether it is a mobile device in general. So make that explicit. Adjust call sites as necessary. Also, in a couple of places where it is likely that what is relevant is whether it is a mobile device in general, not just whether it is a mobile phone, check both isMobile() and isTablet(). For stable interoperability with current Online, keep accepting also the .uno:LOKSetMobile "command" (and .uno:LOKUnSetMobile, except that Online never sends that). Online will eventually be changed to use .uno:LOKSetMobilePhone or .uno:LOGSetTablet only (and never the UnSet variants). Also drop the default value for the bool parameter to setMobilePhone(). Default bool parameters can be quite confusing, and it was especially silly in this case as there is one (1) call site. This is a work in progress and will be improved. Currently there are undefined corner cases. Change-Id: I2a71c37323ee151cbc671bd8e714e1dee10f8b1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90560 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90778 Tested-by: Jenkins
2020-03-19loplugin:redundantpointerops add some more smart pointer typesNoel Grandin1-1/+1
Change-Id: Ia7f3441404d8d2e5de501e70da496b6fdc6c9a4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90728 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-17sc lok: Implement execution of SID_SPELLCHECK_APPLY_SUGGESTIONTamás Zolnai2-0/+25
Used by online spellchecking context menu. Change-Id: Id065d366d5ef2ddb3ecf78d202a7264b6962ec8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90601 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-17sc lok: Implement execution of SID_LANGUAGE_STATUS...Tamás Zolnai1-1/+52
Also for selection and paragraph which is used by the spellchecking context menu. Change-Id: I583caf48b9176ef4d6971cfe3b445080d01dc531 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90599 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-17sc lok: Implement execution of SID_SPELLCHECK_IGNORE_ALLTamás Zolnai2-0/+25
Used by online spellchecking context menu. Change-Id: I31779a38f467838d3719a0d32cbf37e335432d38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90600 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-16uitest: chartWall.py: assert changes in chartXisco Fauli1-3/+42
Change-Id: I8c9f4614a76015b0032347290f6b92b2892ddd10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90588 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-16remove unnecessary Window::Update() calls, which immediately follow InvalidateNoel Grandin1-1/+0
Update() is effectively "paint immediately". Rather just let the invalidate do it's thing and have the widget paint on the next paint loop, along with the rest of the stuff. This is probably mostly cargo-cult, from the days when our invalidate/paint timer could take a long time to kick in. Change-Id: Idff06526e9a2892244cfd8ce6947916032b0d1a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90567 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2020-03-16tdf#129985: Add unittestXisco Fauli2-0/+15
Change-Id: I9a8b923da6ca20fef9a61b9e478267d8c91ace58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90573 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-16tdf#130371: Add UItestXisco Fauli3-1/+74
Change-Id: Ia1bd884d3aa4210e777ea59aece50940d3aa6f68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90571 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-16-Werror,-Wunused-private-fieldStephan Bergmann2-3/+0
Appears to be a mis-merge of 9d4c36d7914e2746a751a56de01063c9159f0f99 "Revert 'loplugin:constfields in sc'". Change-Id: I69a51cdc95fe0a2741b469d2400af51713c6afe3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90553 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-03-15Fix typoAndrea Gelmini1-1/+1
Change-Id: I9715f320bbf35ceafc2d0f2eb9a69c02821779d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90528 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-03-15cid#1460665 Division or modulo by float zeroCaolán McNamara1-0/+6
Change-Id: Iea166a3d152b5b38665691bfa16f3022d684771c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-15Resolves: tdf#129985 OOXML import: do not force a fixed-locale number formatEike Rathke1-1/+1
... instead of system locale. Change-Id: Ie7b4c6a560468f142df6916f50bfda9daaf7c379 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90538 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-15cid#1460666 Unchecked return valueCaolán McNamara1-31/+35
Change-Id: I47298fdb780ac546ad1c795ba5aea54b6a71758c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90530 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-15Resolves: tdf#130371 Undo of sheet-local named expressionsEike Rathke1-0/+24
... created during paste (and maybe other operations). Change-Id: I75d668f717b7336a1a65a9e02c75bf2aefe860b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90497 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-15tdf#131273: fix crash when pasting quotes with fixed widthJulien Nabet1-1/+1
See bt https://bugs.documentfoundation.org/show_bug.cgi?id=131273#c2 Change-Id: I78f592bb2ee59b50e7301fe4e6f282e53c4eeb7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90438 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-14tdf#130975 replace `rtl::math::isNan` with `std::isnan`.Yukio Siraichi5-20/+20
Change-Id: I5d53e6369d35093445b2efd8936bbf8c6775ff47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90451 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-14tdf#130974 replace `rtl::math::isSignBitSet` with `std::signbit`.Yukio Siraichi3-4/+4
Change-Id: I91235eee8c6a9d4a59c1933527b49141f64cd91b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90478 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-13uitest: select child instead of moving downXisco Fauli1-2/+1
Change-Id: I2df86546eb617c67b889382e2e968c2476375ff8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90471 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13uitest: chartDataLabels.py: assert changes in chartXisco Fauli1-23/+54
Also removed commented code. The new asserts also check the changes done are not overwritten after reopening the dialog Change-Id: Icc7d1950ace395b88647658b3eab1b5ec35e467c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90429 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-13uitest: import missing LocaleXisco Fauli1-0/+2
Change-Id: I5021b9b207e2cbbe402abbae69a714c813078a32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90472 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>