summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2013-03-13bnc#798309 inherit group style from parentNoel Power1-1/+1
Change-Id: I8acba22750b8b06b9c20607884629899ad180425 Reviewed-on: https://gerrit.libreoffice.org/2702 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-07resolved rhbz#916936 allow also input line for read-onlyEike Rathke1-4/+6
Allow activation of input line and cell activation in read-only documents regardless whether it's part of an array or not. Change-Id: Id2dc9de9e60b58f4b471fb232e899c9ea75e83f1 (cherry picked from commit 9c51646541846317777b00dc6ad2e30cb1c07950) Reviewed-on: https://gerrit.libreoffice.org/2548 Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com> Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-02-25support new attribute also in 3.6, fdo#60760Markus Mohrhard3-1/+6
Change-Id: I8beab492a3b9b42b323d7d6d9cebfbda1eae0ce1 Reviewed-on: https://gerrit.libreoffice.org/2159 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Fridrich Strba <fridrich@documentfoundation.org> Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-02-09fdo#39135: Prevent integer overflow & update the character during loop.Kohei Yoshida1-0/+5
These two errors in the code contributed to the reported bug. Let's fix them. Change-Id: If82a1bd4d1e27145b48e722b30388cc9dc4a8a6e Reviewed-on: https://gerrit.libreoffice.org/2008 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-02-06resolved fdo#60366 make MATCH() accept a single cell referenceEike Rathke1-0/+6
Change-Id: I7059abdb6232b95e0b940b34f74bf87182510146 (cherry picked from commit c0fdab890086c2cb749c348db42eb760e31539de) Reviewed-on: https://gerrit.libreoffice.org/2019 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com> Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2013-01-21resolved fdo#59583 prevent inappropriate column/row label detectionEike Rathke1-1/+3
If followed by '(' (with or without space inbetween) an identifier can not be a column/row label. Prevent arbitrary content detection in case a macro function of the same name is meant (fdo#59583) or if it wouldn't resolve to a known function name at all, that earlier resulted in #REF! instead of #NAME? in the case of unknown function but label found. (cherry picked from commit aa2b8bde171bf9562536dc14b2cf81d81e31b438) Change-Id: I28d2e2492bddc02c07e139edbc69595a4f3f4a63 Reviewed-on: https://gerrit.libreoffice.org/1797 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-01-19reset one of the sort containers before refilling, fdo#57465Markus Mohrhard1-0/+2
Change-Id: I758af67efec980a56ec83d8e5e6f5f60a0523ac5 Reviewed-on: https://gerrit.libreoffice.org/1753 Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com> Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2013-01-15one more improvement around cond format rendering, fdo#57896Markus Mohrhard1-1/+4
Change-Id: I5eb267ec2d1666edd53f5b9d58fd2a0cec044aa1 Reviewed-on: https://gerrit.libreoffice.org/1684 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-01-14Fix fdo#51121 OWA misbehaviour with uncompressed meta.xmlThorsten Behrens2-9/+7
Change Calc to save ODF with compressed meta.xml as well, since there's no reason not to. Change-Id: Ib591b0e771a6f394d955f2ea9b43d6fb7c30ecdf Signed-off-by: Michael Meeks <michael.meeks@suse.com>
2013-01-12Let's not return here to prevent memory leak.Kohei Yoshida1-2/+1
There are several heap objects that are deleted at the end of the method. Returning prematurely would leak those objects. Change-Id: If70cb3c9c02e47229d10b30f1542f7b25534d593 Reviewed-on: https://gerrit.libreoffice.org/1654 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-01-11fdo#59084: Sync dimension members after reloading the group data.Kohei Yoshida1-2/+2
Else the syncing would end up syncing to the older version of the group data before the reload, which (as you can see in the bug report) may lead to a crash. Change-Id: Ibd674a97a59205e5e28efd007f8857731e8df4d3 Reviewed-on: https://gerrit.libreoffice.org/1635 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/1651 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-01-02fdo#47466 FORMATTING: Autoformat empty rows causes app to crashJulien Nabet1-0/+2
Thank you John LeMoyne Castle for your support http://nabble.documentfoundation.org/Wrong-indentation-which-leads-to-segfault-in-sc-source-ui-docshell-docfunc-cxx-td4026726.html However, the weird thing is I reproduced the crash with master sources but didn't with 4.0 branch nor with 3.5.4.2 Debian packages Change-Id: Ia5366f479a1066106551b77b5a6315fb78e1bf7d
2012-12-18adapt cond format range when copying sheets, fdo#56742Markus Mohrhard1-1/+5
Change-Id: I9b28ac161f326ebeeaf0fa22e0a96915187d7c94 (cherry picked from commit 1c60abfdb617039cedc53982c7c8eca640e28cac) Signed-off-by: Eike Rathke <erack@redhat.com>
2012-12-18fdo#56937 - mac a11y hang related to traversing vast, broken hierarchies.Michael Meeks2-5/+17
Change-Id: Iff0537a69b2c6ae929da6a05f26c0d55415d6d8a Signed-off-by: Tor Lillqvist <tml@iki.fi>
2012-12-18finalize pivot *before* scenario sheet to ensure table numbers are correctNoel Power1-5/+6
Change-Id: I15cf378b51b1ecfbd05c7013e5a5b69fb87fdafb Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-12-18fix sometimes data corruption with xlsx import ( with scenario sheets )Noel Power1-5/+2
formula import is buffered 'till the end of import. The processing of the formula data need to happen before the scenario import happens. This is necessary because sheet numbers stored in the formula addresses can become invalid as scenario import insertes new hidden sheets upsetting the previous table order Change-Id: I9357f028f31bec1b1504ca991f5534f80d79c9bc Reviewed-on: https://gerrit.libreoffice.org/1338 Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com> Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-12-18fix fdo#58237 import hyperlinks for shapes in xlsx documentsNoel Power3-1/+43
Change-Id: Ib0c661dbb3ce9a2f8c8d29707a1cf0c65aadc81f Reviewed-on: https://gerrit.libreoffice.org/1337 Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com> Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-12-15Do extra check on source range to make sure no funny things happen.Kohei Yoshida2-0/+13
Like a crash in the pivot layout dialog... :-/ Change-Id: I9a330ee3f39ebacb7299d24868bb13ee2a9c3ec5 Reviewed-on: https://gerrit.libreoffice.org/1345 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-12-08fdo#57497: Remove group table data when all group dimensions are gone.Kohei Yoshida5-37/+86
Otherwise ungrouping date grouped dimension may crash, or produce incorrect results. Change-Id: I3634e3c0bf8336fc1221f5d234cb7e01eb1f07c6 Reviewed-on: https://gerrit.libreoffice.org/1247 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-11-24we need to catch the exception here, fdo#57451Markus Mohrhard1-1/+8
Change-Id: I203aa640e7d4373f3a090a4988c28c6059b93064 Signed-off-by: Michael Meeks <michael.meeks@suse.com>
2012-11-21fdo#56584: delete also note caption.Markus Mohrhard1-1/+1
Change-Id: I1d792082e79d6bb68004a84c172cc3bb5c194826 Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-15resolved fdo#56278 broadcast deletion to dependent formula cellsEike Rathke1-32/+35
Consolidated changes for fdo#56278 fdo#54074 fdo#53364 fdo#55059 (and earlier i#99844 and i#101869). The replacement cell for the broadcaster to inform listeners, if any, is transferred the broadcaster and owns it, the remembered formula cell never does. When broadcasting the change use the replacement cell instead of the remembered formula cell. Don't fiddle around with ReleaseBroadcaster() at the remembered cell, we don't delete twice and now also don't leak. (cherry picked from commit 8165bfa2afbe828caf37df57b83cb31bef2559cb) Change-Id: Ia11b6d3d751c784af64aaed05f8508887f869a80 Reviewed-on: https://gerrit.libreoffice.org/1069 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-11-13fdo#56776: Change in formula options should cause repaint.Kohei Yoshida1-0/+5
Else Calc would fail to update the column headers due to A1 to R1C1 change (and vise versa). Change-Id: I2c403212f5bc539aea92370e60da96f480549d6d Reviewed-on: https://gerrit.libreoffice.org/1049 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2012-11-13remove conditional formats withiout range after import, related fdo#56983Markus Mohrhard3-4/+29
(cherry picked from commit eb240530443b964ea45bf80a5e3711e11a3f09c5) Change-Id: I9a8c02369c3e5a12310a46229bdc1671f75593ad
2012-11-12only set entries for existing sort entries, related fdo#56958Markus Mohrhard1-1/+1
Change-Id: Ib48606402fb90b259f705badeac294d7c336cb9c (cherry picked from commit c45b6496e87fe74570a41821bc5f4fbdb3d3cf8e) Signed-off-by: David Tardon <dtardon@redhat.com>
2012-11-12make sure that the sort vector is large enough, fdo#56958Markus Mohrhard1-0/+3
Change-Id: I7099e984a8b05ccd3324f3b9231c193e716eaf83 (cherry picked from commit cd545dcf511daedd548c11159b8c244f272e9cb6) Signed-off-by: David Tardon <dtardon@redhat.com>
2012-11-11fix for fdo#55875 numbers as text converted strangelyNoel Power1-1/+8
old code used to use XCell->setString, new code uses rDoc.SetString which by default tries to detect number formats. The ScColumn::SetString that eventually gets called seems to do lots of additional checks ( and apparently even if an ScSetStringParam instance with mbDetectNumberFormat ( false ) was passed it seems that it will still try to detect decimal number formats. With that in mind I restore and un-unoified version of what XCell->setString used do Change-Id: Ifaef74c78b198f492a390a3d5dc1721622a01ea4 Reviewed-on: https://gerrit.libreoffice.org/1020 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-11-09fdo#54898: Test equality by order index (integer) which is more stable.Kohei Yoshida1-3/+3
At the point where std::unique is called, we can use order indices to determine whether the two items are equal. This should be more stable than using CaseInsEqual() to assess equality. Change-Id: I88310fc7beede19fb1c629b9b7e3cb9a069b2b23 Reviewed-on: https://gerrit.libreoffice.org/1013 Reviewed-by: Tor Lillqvist <tml@iki.fi> Tested-by: Tor Lillqvist <tml@iki.fi>
2012-11-07Minor enhancements on the autofilter popup window.Kohei Yoshida1-1/+15
1) Launch pop-up right-aligned in case the cell is wider than the popup. Launching it always left-aligned will look weird especially when the column is very wide. 2) Allow type-ahead search when launching the autofilter via keyboard. This is achieved by making two small changes to the popup; first, the focus is set on the check list box upon launching, and second, the type-ahead search is enabled on the check list box control. Change-Id: I8a33a52afc6005b4a7428d5f7046eff986da80d2 Reviewed-on: https://gerrit.libreoffice.org/997 Reviewed-by: Radek Doulík <rodo@novell.com> Tested-by: Radek Doulík <rodo@novell.com>
2012-11-05fix ooxml color exportMarkus Mohrhard1-1/+1
Change-Id: I4b94883f594e13e9923bdd05593447a152fa8b0a Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-05export dxfs at the correct placeMarkus Mohrhard1-1/+1
Change-Id: I2ab31904169adad4f173d4655d0511855de77464 Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-06fdo#53531: Time field can be represented with an extended time field type.Kohei Yoshida1-0/+2
And Calc's header footer currently don't distinguish between time and extended time. Time fields in the header / footer are always dynamic and never static. Change-Id: If628d179968c270a63d38cdc3bf6018c01241ac1 Reviewed-on: https://gerrit.libreoffice.org/992 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-11-05halt corrupted styles with multi-saved xlsx document fdo#55418Noel Power1-1/+4
Change-Id: I2d53c88ab121edeec2bf53f7fd177a0edcc05a25 Reviewed-on: https://gerrit.libreoffice.org/958 Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com> Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-05fix xlsx export missing alignment attributes with cellstyle fdo#55417Noel Power1-1/+7
Change-Id: I510d0f399c58b5a9b192f3566e093c636cae2c0a Reviewed-on: https://gerrit.libreoffice.org/959 Reviewed-by: Kohei Yoshida <kohei.yoshida@gmail.com> Tested-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-05fix copy paste error, fdo#55673Markus Mohrhard1-1/+1
Change-Id: I1e31fe05e00ed7e298642da9c0e35ae834dfa74f Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-05only delete cond formats if the correct attributes are passed, fdo#56316Markus Mohrhard1-1/+2
Change-Id: If9859b5021c532daacccfaf386e0489c134e4afb Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-11-04Correctly handle cell note shifting when immediate row/column is deleted.Kohei Yoshida1-4/+12
Currently, having a note e.g. at D5, and deleting cell D4 and shifting the cells below upward will remove the note at D5. But the correct behavior is to shift that note up to D4. This change fixes it. Change-Id: Ia37f1ce67a003deab424f2b805a2ce333fc10ed4 (cherry picked from commit d3344dd85ee31b195a3709d16e734245e1d0a4b6) Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-11-04Fix incorrect shifting of cell notes upon cell insertion / deletion.Kohei Yoshida1-2/+8
Steps to reproduce: 1) Insert a comment at D5. 2) Move cursor to C4. 3) Right-click and select Insert. 4) Choose shift cells down. 5) The comment gets shifted down but it shouldn't. The same thing happens when deleting a cell and shifting content. Change-Id: I5a71845cca6abde6b7c940e152e155da26343cef Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-11-02Remove the correct range, or else maItems would end up with invalid pointer.Kohei Yoshida1-1/+1
nStopPos is non-inclusive, and STL's erase() method also expects a non-inclusive end position (like any other STL methods do). It's wrong to -1 here which would end up not erasing the last element containing a pointer to the deleted cell instance. Change-Id: Ic09ab4a6bb03d0f56bb854a91bf93a99be867116
2012-10-31fdo#56325: Don't forget to build_tree() in fillTable().Kohei Yoshida1-6/+10
Else you'll get the wrong answer in isRowActive(), which always search flag via tree. Change-Id: I3fa92d06f7ba3040eca061d5424afefe362703de Signed-off-by: David Tardon <dtardon@redhat.com>
2012-10-25fdo#44657 Remove hack that "simulates" a mirrored horizontal scrollbar.Jan Holesovsky3-47/+18
We are able to paint mirrored scrolbars with the 'gen' plugin, so just fix the rendering of the scroolbar with the Gtk+ plugin. Change-Id: I5dbd13420c6290e165ed2f5827769979298abf37 (cherry picked from commit bfa21ce5fa08f2c634ccb6162914be55aef9f3c2) Signed-off-by: Lior Kaplan <kaplanlior@gmail.com>
2012-10-19write the custom sort list info into the item set, fdo#53870Markus Mohrhard2-0/+5
Change-Id: I9c7f62b47f83b7798a8efdbf3896503918929f03 (cherry picked from commit 4302eb0a6c4e28ab675de9d59e73cac345ba30c7) Signed-off-by: David Tardon <dtardon@redhat.com>
2012-10-19only use non blank cells in the visible data methods, fdo#54552Markus Mohrhard1-3/+7
Change-Id: I2a0914fbaff3e3f707a9c06f693079aed2b89ba4 (cherry picked from commit 40377a6e26aa61a1c0788cad1c97a10911d38da8) Signed-off-by: David Tardon <dtardon@redhat.com>
2012-10-19ignore broadcaster cells to fill autofilter dialog, fdo#55712Markus Mohrhard1-0/+4
Change-Id: Iacd3f8cfc26bb147eaf3b6957338be212b448226 (cherry picked from commit 622f7751b78fd8584e34f5fa96a04ed6e8bb98f5) Signed-off-by: David Tardon <dtardon@redhat.com>
2012-10-18Resolves: fdo#44925 list box contents should be same direction as sheetManal Alhassoun1-1/+2
list box contents should be same direction/alignment as sheet, not the interface Change-Id: I0b4944c6658fb27dfa7d0c67dd26a7b592329be8 (cherry picked from commit 78414991b20d0eac6703e8e3c3e429b747891367) Signed-off-by: Lior Kaplan <kaplanlior@gmail.com>
2012-10-17exchange sort settings between the two tab pages, fdo#53482Noel Power2-10/+10
Change-Id: I540481585bec2479db541025755c2a5a670da9ed
2012-10-13don't insert notes from deleted cells, fdo#55885Markus Mohrhard1-4/+14
Change-Id: I036f0531dc2290c5eb480258bc70ec13b810e6bc Signed-off-by: Kohei Yoshida <kohei.yoshida@gmail.com>
2012-10-13Check for null object. The OLE name may not always be set.Kohei Yoshida1-1/+1
Change-Id: Ib3e55af8870b41a5b76179d2215fc5125ceda5af (cherry picked from commit fb1d9cc99e026ba9cf15ab49b2251cecfbbf6d10) Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-10-12WaE: calm android tinderboxenMichael Meeks1-3/+3
Change-Id: Iaeb809770acec4b3c38e42038fe2820b2da2051d (cherry picked from commit 0edc04d2d659456f5c22406a79901d54c530a979) Signed-off-by: Eike Rathke <erack@redhat.com>
2012-10-11only access first element if vector is not empty, fdo#55734Markus Mohrhard1-1/+3
Change-Id: I60db486195e7216968dc8c7c7c0c79fb7e8c1b88
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-03 09:17:52 +0000