summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2016-06-14do not use OUString::number() to "format" numeric valuesEike Rathke1-39/+9
Change-Id: Ie35a34152556e19eff1f196ddd0ddd51a6da1a23
2016-06-14intern SharedStringEike Rathke1-5/+3
Change-Id: I192b1bb8f2c93002d2c2d22ae8f7c865c75bd9b4
2016-06-14intern SharedStringEike Rathke2-6/+6
Change-Id: Ic8e6d3595002094792462b585d427f58c5c84156
2016-06-14tdf#94205: Some remaining new+std::move -> o3tl::make_uniqueStephan Bergmann3-19/+13
Change-Id: I6a9a46d37bf09f6b497d591498c40103f4c96f59
2016-06-14allow text as dates in inline array of holidays for NETWORKDAYS()Eike Rathke1-1/+1
Change-Id: I0c5438a0ee23a5974495a9f782b3f22ef7472c87
2016-06-14sc: implement per-view resetSelection()Miklos Vajna1-1/+5
Fixes the following crash: - start gtktiledviewer with a Calc document - enter edit mode - create a text selection (selection of multiple cells e.g.) - leave edit mode -> assert fails Change-Id: Ic8a65a692679afe1e293f7467f7a72cadcf9f083 Reviewed-on: https://gerrit.libreoffice.org/26266 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-14sc: implement per-view LOK_CALLBACK_HYPERLINK_CLICKEDMiklos Vajna1-3/+14
The last place that crashed when clicking on hyperlinks. Change-Id: Ia114d98ada6cf8a3be56a25e48f3e84471c37e66 Reviewed-on: https://gerrit.libreoffice.org/26265 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-14tdf#100342 fix order of weekdays in NETWORKDAYSWinfried Donkers1-1/+2
For the definition of working/weekend days, ODFF1.2 uses 0..6 for Sunday..Saturday. NETWORKDAYS used ISO ordering (Monday..Sunday), but now complies with ODFF1.2. Change-Id: I169433adfac5d66af979181c328658040d7ab77f Reviewed-on: https://gerrit.libreoffice.org/26246 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-14sc: implement per-view LOK_CALLBACK_DOCUMENT_SIZE_CHANGEDMiklos Vajna2-7/+69
Need to notify all the views when inserting or deleting a sheet. Change-Id: Ifadf6af4a307d555eacfa4623eed84400d06c293 Reviewed-on: https://gerrit.libreoffice.org/26264 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-14sc: implement per-view LOK_CALLBACK_SEARCH_RESULT_SELECTIONMiklos Vajna3-8/+41
One view doesn't crash the other one now when the search is performed. Change-Id: I9ba0a07a76d9c11c4cec279305efb4e5025ec12d Reviewed-on: https://gerrit.libreoffice.org/26263 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-14PopExternalSingleRef() guarantees nGlobalError is setEike Rathke4-25/+26
... if token could not be obtained. So no need to check if(pToken) and we can simplify the error handling at some places. Change-Id: Ie741a46efd6f33b5be48e8e4ff9bca2bbbc95b04
2016-06-14sc: implement per-view LOK_CALLBACK_CELL_FORMULAMiklos Vajna2-4/+20
With this, one view can edit one cell while the other view edits an other cell within the same sheet (without a failing assert). Change-Id: I355caea69daa17fcd4b4813d0f31ff2072f9c847 Reviewed-on: https://gerrit.libreoffice.org/26260 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-14check ExternalSingleRef token for svDouble typeEike Rathke1-1/+6
... before accessing GetDouble(). Else convert the string. The new assert() introduced in FormulaToken::GetDouble() virtual dummy was hit by loading gnome334723-1.sxc Change-Id: I144b0cabee3aac44d206d76a83b1c4d81ab4a02e
2016-06-14add YEAR test caseZdeněk Crhonek1-0/+1008
Change-Id: I44dc868a78f5a366e1bfc7c7e6f18502fbdfff31 Reviewed-on: https://gerrit.libreoffice.org/26128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-14sc: implement per-view LOK_CALLBACK_INVALIDATE_TILESMiklos Vajna5-12/+68
Port enough callbacks to the view callback, so that gtktiledviewer doesn't crash on opening a file. Change-Id: Iec39608ce3cdf7dcf5a7272f8c9a3415483a8e76 Reviewed-on: https://gerrit.libreoffice.org/26251 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-14explicit svl::SharedString(const OUString&) ctorEike Rathke13-37/+50
... to prevent accidental surprises. Not interned shared strings constructed from OUString have mpDataIgnoreCase=nullptr so can't be used for case insensitive comparison. Change-Id: I03323354298a73e93b18d2796ec447c072fdefa5
2016-06-14add TIME test caseZdeněk Crhonek1-0/+1098
Change-Id: Ica82485f3e86c5b64753f01897210c54eccbd844 Reviewed-on: https://gerrit.libreoffice.org/26230 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-14add SECOND test caseZdeněk Crhonek1-0/+1037
Change-Id: Ib19f76c0decce64afd70f059670b870cf53a1943 Reviewed-on: https://gerrit.libreoffice.org/26228 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-13fix obtaining ScRefCellValue results, tdf#97831 follow-upEike Rathke2-172/+202
ScRefCellValue in interpreter context has to be used with GetCellValue() and GetCellString(), using raw ScRefCellValue getString() and getValue() is not enough. This also changes behavior with referenced empty cells that sc/qa/unit/data/functions/fods/Functions_Excel_2016.fods tests for, but I assume that tested our implementation, not what Excel does in these cases. Needs checking. Change-Id: I16194ad59cce3d15271e7610e8ed90ac1786bcaa
2016-06-13Resolves: tdf#100048 we can rearrange the hidden child to allow tab traversalCaolán McNamara1-47/+59
the problem is the hidden window used to be the temp parent for the ref edit and button when this dialog is in shrink-ed to reference mode from the cell-range option on the criteria page Change-Id: Ic11299aae159b4f58f2158442b0a787fb0607c03
2016-06-13Give unique, comprehensible names to timers tdf#97087emahaldar/em1-2/+2
Change-Id: I9f2be193b995d43d4e3440e55a025629fe5bcaed Reviewed-on: https://gerrit.libreoffice.org/26222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-13notebookbar: reduced paddingSzymon Kłos1-47/+32
Change-Id: I43df4ba611d7b377829ac3b5f17ff26077e9f13d
2016-06-13Resolves: tdf#90419 diminish precision error in Series FillEike Rathke1-4/+39
There may be more elegant ways to accomplish this, go and find one.. Change-Id: Iceaa0783db9cf3d3e1aa20f075fe7e0618a1feb6
2016-06-13tdf#42949: clean up includes in include/vbahelper with iwyuJorenz Paragas24-0/+29
Change-Id: Iaf93ff58229e9362b03b3e810611e969ef8baf38 Reviewed-on: https://gerrit.libreoffice.org/26206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-13coverity#1362685 Uninitialized scalar variable (UNINIT)Eike Rathke1-1/+1
Change-Id: I5da1a04d2fce6583fad0934d06dcba452181f256
2016-06-13coverity#1362684 Uninitialized scalar variable (UNINIT)Eike Rathke1-1/+1
Change-Id: I19ba749ae4cca43602330834f155eca89638c711
2016-06-13fix buildDavid Tardon2-6/+6
Change-Id: I01a111160d43e2f398ff4c560810b737b62b6ba3
2016-06-13Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic3efae53430fbb2c1eb7962c3cf69bf99315e55b Reviewed-on: https://gerrit.libreoffice.org/26202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-12tdf#92218 tweaks to single toolbar mode toolbarsYousuf Philips1-3/+3
Change-Id: Ia8311c48dfa116b4557880a48a7299659a10cb0e Reviewed-on: https://gerrit.libreoffice.org/26131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2016-06-12convert DBG_ASSERT(false, to SAL_WARN(Noel Grandin1-1/+1
Change-Id: I400d728c5d99228c5ca52e369037395b4da2af5c Reviewed-on: https://gerrit.libreoffice.org/26187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-12remove some unnecessary castingNoel Grandin2-5/+5
Change-Id: I451df09db58256fed68ce8537b2d8eb4b6ab6942 Reviewed-on: https://gerrit.libreoffice.org/26184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-11add ISLEAPYEAR test caseZdeněk Crhonek1-0/+993
Change-Id: I439fc530250598b201d99ef20f64604ebbdf7263 Reviewed-on: https://gerrit.libreoffice.org/26126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-11add EOMONTH test caseZdeněk Crhonek1-0/+998
Change-Id: Ia0dfb7ad1b2aebb604b7ed62a197fdb8dcd9f5ad Reviewed-on: https://gerrit.libreoffice.org/26124 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-11add DAYS test case - repairedZdeněk Crhonek1-0/+802
Change-Id: I84a18d9494e74d70b03885fb66caf527e718b090
2016-06-11add DAYSINYEAR test caseZdeněk Crhonek1-0/+838
Change-Id: I5475b2d77f0db9bddc70ab64c3d191aac12a04f6
2016-06-11add DAYSINMONTH test caseZdeněk Crhonek1-0/+853
Change-Id: I770ced8c1073d6dba99eed46b6b3b5be38e27932
2016-06-11add ISOWEEKNUM test caseZdeněk Crhonek1-0/+1171
Change-Id: If881524e0006a32320cccdff944d169e203380f0 Reviewed-on: https://gerrit.libreoffice.org/26176 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-11add MINUTE test caseZdeněk Crhonek1-0/+1035
Change-Id: I28a4df341a69641735870ead5afbd72bbfbed5b8 Reviewed-on: https://gerrit.libreoffice.org/26175 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-10Clean up uses of Any::getValue() in scStephan Bergmann5-24/+17
Change-Id: Ic272f616533021ee2148adaf28eed68301aa4602
2016-06-10Move accessibility relations to .ui files, Part 8: tdf#87026Muhammet Kara2-36/+18
By removing unnecessary variables/strings/function calls, and making proper changes in the related .ui files. Change-Id: I04244b360b4bb32ccbbe5bde4756a9166ae1fcaf Reviewed-on: https://gerrit.libreoffice.org/26018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-09sc: eeek, a boost::ptr_vector! take it off! take it off!Michael Stahl2-9/+10
Change-Id: I3fffecd295577cc8eaa521e819b3c922f8c3f56e
2016-06-09tdf#100257 - Data : XML Source does not workNoel Grandin2-6/+15
Revert "sc: boost::ptr_vector->std::vector" This reverts commit 280553e30f4ddc932838f98a9efaac03a988a0df. Change-Id: Ia50c9cf7902e2e830c6e7f7a13c8f04341556e6c Reviewed-on: https://gerrit.libreoffice.org/26106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-09Resolves: tdf#100285 EASTERSUNDAY() check valid year between 1583 and 9956Eike Rathke1-0/+6
Change-Id: I4b25f1eb8e3cf0236b69607bb9ab9b4c57ae918a
2016-06-09change number format for formula results if of different typeEike Rathke2-4/+84
... so =IF(B1,B1) changes from FALSE to the content of B1 instead of TRUE if B1 was empty or 0 on the first run but another value on the next run, with some logic to not override user applied formats. Change-Id: I0207adf0d71844f7bc2bb0f51ff308cca65aec52
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko31-125/+32
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-08make SvNumberFormatter::IsCompatible() staticEike Rathke1-1/+1
Change-Id: Ic40d0852c8e0a8f0957fc782c85c1084c7fe265f
2016-06-08tdf#48140 Remove unused headers from xlsx import to improve build performanceBartosz Kosiorek5-11/+0
Change-Id: Ie22dc56cceddcb91e946083c6bcf4c041545e75b Reviewed-on: https://gerrit.libreoffice.org/26001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-06-08Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann5-7/+7
Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
2016-06-08PushCellResultToken() with final FormulaDoubleTokenEike Rathke2-10/+28
Change-Id: I3c628527c3e5bb676be791e3a31d617c4cc917ae
2016-06-08convert the final double result to FormulaDoubleTokenEike Rathke1-3/+17
... if it was a FormulaTypedDoubleToken, and set type information. Change-Id: I2debcda4650d621311d5d7670ffdedecb2e25a04