summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2014-02-03fdo#74325: Ensure that all note objects have an sdr object before exporting.Kohei Yoshida8-0/+57
Otherwise, if a note hasn't been displayed at least once before saving that note would not get saved. In the future, we should modify the export code to not rely on SdrObject to check the presence of note. Change-Id: Ib7ca3ac00a0c9cdd3a01facda7af479ef172afbe (cherry picked from commit 018500a73f3b1082b6662b7c123dfe5158ae5752) Reviewed-on: https://gerrit.libreoffice.org/7782 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-31guard against null pointer access on LRU function list, fdo#60036Eike Rathke1-4/+4
... which may have happened if the config's LRU contained enums of non-existing functions, i.e. if they were shifted by an update. Change-Id: I9a005f41cc74c530cf37d1782ce8c53b8f5dce6e (cherry picked from commit a94f0f92e8b09f6cd3989b646500ff5814274621) Reviewed-on: https://gerrit.libreoffice.org/7750 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-31fdo#74194 Revert "Resolves: #i121136# Improve Spreadsheet performance ..."Eike Rathke2-8/+4
This reverts commit 6a62557d8632290ae7150f3922dece65f51af4bc. pPageRows[] is a member array, so when not allocating MAXROWCOUNT entries but nRealCnt instead it also needs some tracking mechanism to reallocate in case a subsequent call needs more elements than the first call. Change-Id: Iadb7d2ceadcb8bd99d57c6188571d295c6b99fba (cherry picked from commit 41a859234eac6126693393ff64efc7bfcdec9c54) Reviewed-on: https://gerrit.libreoffice.org/7751 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-30fdo#74014: Broadcast changes during undo and redo after paste.Kohei Yoshida8-18/+27
Change-Id: I271bbba5e5eb70e48274a4a062d125456af8ff6c (cherry picked from commit f5d8029a456c2c708cbc2b67f2d7875540dff1ab) Reviewed-on: https://gerrit.libreoffice.org/7728 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-30fdo#74014: More on broadcasting at appropriate places.Kohei Yoshida6-23/+45
Also, call PostDataChanged() to re-paint re-calculated formula cells, and brodcast only when pasting, not during file import. (cherry picked from commit 8a36879eaf0977448b113c2239014d2e2b7ab258) (cherry picked from commit 3d869cda8db03820dea8c4ba463eb155d05e933b) Conflicts: sc/source/core/data/documen7.cxx sc/source/ui/undo/undobase.cxx sc/qa/unit/ucalc.cxx Change-Id: I63161329d4bfe937f754773fd68c37e3836c4950 Reviewed-on: https://gerrit.libreoffice.org/7727 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-29fdo#73487, fdo#73886: Overhaul cell borders to make them look sane.Kohei Yoshida5-32/+33
Change-Id: Ie563f272b60ec8b6b8a4ff0df7256902997610c1 Reviewed-on: https://gerrit.libreoffice.org/7597 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-01-29Presumably "eType ==" is missing hereStephan Bergmann1-1/+1
Change-Id: I7af8cabac09369a9be605413b799289d48cb3f57 (cherry picked from commit d18827e266d1bf44b0bac02ed486d2cdccba9c8a) Reviewed-on: https://gerrit.libreoffice.org/7723 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-01-29fdo#74014: Broadcast cells on undoing of "cut".Kohei Yoshida1-0/+2
(cherry picked from commit 3032d08226f77505e7105fb7cfb7f4b4741fd3ca) (cherry picked from commit 67cab8548356109d52317c797649ab31585db5ae) Change-Id: I0fdf518078c86f259e72307f8011a988555a9235 Reviewed-on: https://gerrit.libreoffice.org/7709 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-28give MSVC a hint to not break the build, fdo#74042 relatedEike Rathke1-1/+1
... and be explicit about std::min() types. Change-Id: I6a0dd499d1a29d389ee9da31b71639e3c7c1a6ae (cherry picked from commit 0b3c6203f87f72684ad018963674a10e1c6f7c36)
2014-01-28fdo#74042 Don't attempt to copy more than a string has to offerMaxim Monastirsky1-1/+1
Change-Id: I5898efeaecce2cf2ee7d4ac581a21761533138bd Reviewed-on: https://gerrit.libreoffice.org/7715 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-28fdo#69244: Avoid putting these cells in formula tree prematurely.Kohei Yoshida1-1/+1
Marking the cell dirty alone appears to be sufficient to trigger resetting of number format. SetDirty() would mark it dirty *and* put the cell into formula tree, which would prevent proper value propagation as seen in the bug report. Change-Id: Ie68f996112938fe286a9bd50c38404f9df6f4ca1 (cherry picked from commit f571104ef38ba9f7f6073e22c2374add7aa73887) Reviewed-on: https://gerrit.libreoffice.org/7707 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-27Stop leaking all ScPostIt instances.Kohei Yoshida2-12/+9
And re-implement correct swapping of two ScPostIt instances during sort. (cherry picked from commit ab05317c79f665bcf9d5cff7b8312ce6963ff969) Change-Id: Ifbf120aae594342ae0b7c5760f771c53092c8022 Reviewed-on: https://gerrit.libreoffice.org/7641 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-27only put bounds in vector if range is outside of copy range, fdo#74041Markus Mohrhard1-18/+17
There are 4 cases of which only two need an entry in the vector. If the start is before the copy range and if the end is past the end of the copy range. Change-Id: Ia88f6891e03257c3321dbfb271be559378e39625 Reviewed-on: https://gerrit.libreoffice.org/7683 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-27we need to check that the content is equal as well, fdo#74077Markus Mohrhard1-0/+24
There are a few more tokens that need to be inspected. Change-Id: I59b5046ddde5eb8b638ad8f17b00bc7eb6966467 Reviewed-on: https://gerrit.libreoffice.org/7674 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-01-27resolved fdo#71598 postpone SetDirty during Insert/DeleteEike Rathke7-38/+51
... until after all listeners are re-established. Change-Id: I9f6036d4bcc9206191959a88ed5439b9860ca268 (cherry picked from commit 20b7476142f75b49d10a75e48429a94cff0cec32) Reviewed-on: https://gerrit.libreoffice.org/7623 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-24resolved fdo#73235 initialize reference flagsEike Rathke1-0/+1
References initialized via ScSingleRefData::InitAddressRel() and ScComplexRefData::InitRangeRel() didn't have their flags memory initialized, leading to tab/col/row reference may had been flagged as deleted or other quirks. This also fixes fdo#72605 Change-Id: If5e9f4c3a9171f068f7986d2bd6b4b312df3c37e (cherry picked from commit 70abaf45eac49405aee70bbad13bcda75d8a9c15) Reviewed-on: https://gerrit.libreoffice.org/7634 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-01-23fdo#73986: Don't forget to receive returned object from for_each.Kohei Yoshida1-1/+1
Change-Id: Ia4ccb83c45ea3ce72a8e5c62a560ab1802bb2441 (cherry picked from commit 9ce7ba209d28cd284ab5ea584bc130d7a081b0f9) Reviewed-on: https://gerrit.libreoffice.org/7620 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-21Fix bogus mass-conversion equalsAsciiL -> startsWithStephan Bergmann8-17/+17
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to startsWith calls" should rather have converted to oprator ==. (cherry picked from commit a3f32769fc4bb23c64168b412dd10ec769a3854d) Conflicts: sc/source/ui/unoobj/nameuno.cxx sc/source/ui/unoobj/styleuno.cxx sfx2/source/appl/sfxhelp.cxx stoc/source/security/permissions.cxx sw/source/core/unocore/unocrsrhelper.cxx (None of those bogus startsWith calls seem problematic enough to warrant backporting also to libreoffice-4-2-0.) Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21 Reviewed-on: https://gerrit.libreoffice.org/7578 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-20resolved fdo#73836 do not apply format twice to stringEike Rathke1-4/+6
ScDocument::GetString() already returns the formatted string that then was formatted through number formatter. Format raw string instead. Change-Id: I806b4fc904d04169a6c1dbd4a3d00e2556eda7bd (cherry picked from commit f6b9b73a1f87d1815ed8ab8f2494e5526a710bb9) Reviewed-on: https://gerrit.libreoffice.org/7549 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-01-20fdo#73655: Don't adjust formula tokens on non-top shared formula cells.Kohei Yoshida1-0/+17
Only adjust tokens for non-shared formula cells and shared formuls cells that are the top of their respective shared groups. Change-Id: I9cd57653602c97504a802001947a28c4d03368a5 (cherry picked from commit 982a03d4e2baf4ca7e78c79014389d9b23e200d1) Reviewed-on: https://gerrit.libreoffice.org/7482 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-20WaE: variable 'itResEnd' set but not usedTor Lillqvist1-1/+1
Change-Id: I6594472b1e93c083fdc52133a6b120c031dff64a (cherry picked from commit 49ce8c126c962d75e2fefd5b4a578c213ff6a9bf) Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-01-19make strings localizable in *.ui (bin/ui-translatable.sh)Andras Timar2-43/+43
Change-Id: I60b74cecc17352681fac7dfa0e41114515dbd6f5 Reviewed-on: https://gerrit.libreoffice.org/7536 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-01-19fdo#73799: Make some items in the filter dialogs translatable.Kohei Yoshida1-40/+40
Change-Id: I67c54ae9cee0a57baf900c80f50b28572bc9465b (cherry picked from commit 6d7a4e5744c6ce5f1362b659464fb94465c2cb67) Reviewed-on: https://gerrit.libreoffice.org/7535 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-01-17ellipsize incorrectly set here for some reasonCaolán McNamara1-2/+1
Change-Id: I85b89c59c3545aef538da47a3d3727110cff4a82 (cherry picked from commit 251f21699ef786557134fc00ff1293acb57e4158)
2014-01-16resolved fdo#73555 compile statistics templates using English grammarEike Rathke7-11/+21
The statistics templates' formula expressions are setup using English function names, so compile the resulting expressions using an English grammar merged with the current address conventions. (cherry picked from commit 9570a27d3e2f56e9046a8bfacaafe9e3c9744ac5) Conflicts: sc/source/ui/StatisticsDialogs/TTestDialog.cxx sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx Change-Id: I7c782a42d007daeaaf99463beb8aa580c05c7363 Reviewed-on: https://gerrit.libreoffice.org/7412 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-01-16resolved fdo#72293 correctly split grouped formulas and regroupEike Rathke2-5/+14
Grouped formulas need to be split at both edges of the deleted area, regroup _after_ rows have been deleted. Change-Id: I840806f30cef592e17b4cd3a33c81fd2a8309055 (cherry picked from commit 42f551d524a1df46f6a311d5897ac30bd8fc1aaf) Reviewed-on: https://gerrit.libreoffice.org/7452 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-01-15fdo#73606: Avoid calling MarkDataChanged() when nothing is selected.Kohei Yoshida1-3/+9
MarkDataChanged() is quite expensive & in theory unnecessary when no selection is present. Change-Id: I6967b914735462403a77568010532b37a1d8f333 (cherry picked from commit 31533d47b24680f76e769949874d41f0fe27134f) Reviewed-on: https://gerrit.libreoffice.org/7426 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-15fdo#73606: Avoid excessive and unnecessary heap allocation of array objects.Kohei Yoshida8-28/+59
This is a leftover from the 1 million row conversion we did years ago. Change-Id: Ib50819ed51c7017bcc559bfc8b6062ff46615d09 (cherry picked from commit df9243626b39742a9a148bea95796f8824fee68a) Reviewed-on: https://gerrit.libreoffice.org/7425 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-13Related: rhbz#1047871 conditional formatting doesn't fit on screenCaolán McNamara1-9/+9
Change-Id: I886030c056fe802279f9e16c6f85736b0c4587c6 (cherry picked from commit 6d2ffbaeced98769912f2b4769fc23093b3d8d7f) Reviewed-on: https://gerrit.libreoffice.org/7406 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-11correct loops in UpdateNoteCaptions for notesLaurent Godard1-2/+2
Change-Id: Icec072eea61a194d72ce00c58dfbd85b1ec85abb Reviewed-on: https://gerrit.libreoffice.org/7390 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 20ecc5b59d757307fbc9c3222af2a34ab8fb5bde) Reviewed-on: https://gerrit.libreoffice.org/7391
2014-01-11fdo#73484: Ensure that we import all tab settings from Excel.Kohei Yoshida3-0/+23
The old code would not import settings of the last sheet if maTabData was not large enough before the loop begins. Enlarge maTabData ahead of time to ensure we load all tab settings. Change-Id: I9093a93ef26ccba9fef06a8929d1d86311f5c55d (cherry picked from commit 3e87471b6815a3cad48cab2ef81073bad5453c56) Reviewed-on: https://gerrit.libreoffice.org/7382 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-10fdo#68961: Check visible range during scrolling, and re-paint if necessary.Kohei Yoshida4-9/+24
Change-Id: I47383cc0c4cf0ec48ce621ba5acac33db44ba313 (cherry picked from commit e36c8a674845ab19577fc06d44b780549757e1e7) Reviewed-on: https://gerrit.libreoffice.org/7352 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-01-09GPU Calc: mask formulae that aren't supported well on some OpenCL platformshaochen1-30/+32
Change-Id: I67849c6339ecfa5940285f1921d9b8fd4959ba63 Signed-off-by: haochen <haochen@multicorewareinc.com> Signed-off-by: I-Jui (Ray) Sung <ray@multicorewareinc.com> Reviewed-on: https://gerrit.libreoffice.org/7344 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-01-09GPU Calc: support reduction kernel in AVERAGEhaochen2-44/+247
Change-Id: I0ae0fb279d6d14637d23c682d546a8cc95bc371d Signed-off-by: haochen <haochen@multicorewareinc.com> Signed-off-by: I-Jui (Ray) Sung <ray@multicorewareinc.com>
2014-01-09Oops. We don't want to leak here.Kohei Yoshida2-0/+6
(cherry picked from commit 51bce89dbd620d3ed59279d0ae80e5587d723bef) Conflicts: sc/inc/documentlinkmgr.hxx Change-Id: I8bcca7d743d4be7038a4c2eb1436a6470774d40d
2014-01-09specify that grid color listbox can shrink...Caolán McNamara1-380/+367
in calc->view options and that the checkbox entries cannot when options pane isn't wide enough to fit everything in (fr). Necessitates swapping columns so the stretching/shrinking column can be centered horizontally for e.g. en to remain pretty. Change-Id: I1402183b6ad0989af676a3472c8bf4d2b9c94ea8 (cherry picked from commit 8b6823e0bae689519839f18031e9c59a94dfbec8)
2014-01-09fdo#73408: Make the software interpreter selection stick in the UI.Kohei Yoshida3-7/+15
Change-Id: I136a98fadbde82a7a585df9a5691f884c0362699 (cherry picked from commit 4b5a98942cd3ebcdacd4d66fb2bd61211fcfe7bc) Reviewed-on: https://gerrit.libreoffice.org/7323 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-08stretch label to fill vertically for long textCaolán McNamara1-3/+6
calc compatibility page (e.g. de) Change-Id: Ieab742900747808a4c27205b190e416b391b7a39 (cherry picked from commit 3466f403470c192d24b9d7859b8a6a6ae5c94a2b)
2014-01-08resolved fdo#72929 buffer jump matrix' result matrix blocksEike Rathke5-42/+269
Update mdds to 0.10.1, set it as the required baseline. Patch mdds to make available a method to empty multiple elements in one call. This is for multi_type_matrix. (cherry picked from commit 47a7565315dcfc4271c2b2c205225d914a1a5094) Update mdds to 0.10.1, set it as the required baseline. This update will obsolete two patches that were previously applied. (cherry picked from commit 12890dd7adfc70bc562bb2760084515cc1269a38) Conflicts: download.lst resolved fdo#72929 buffer jump matrix' result matrix blocks (cherry picked from commit ae4dc8e0ea3b78d804d1022905501a56030073c0) Change-Id: I7b1fcf6b16b5addbb76078506536542cddede25f Reviewed-on: https://gerrit.libreoffice.org/7320 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-01-08designate which elements should shrink when limited widthCaolán McNamara1-35/+9
Calc general page (e.g. .de) Change-Id: Ifc5c230040c9b59f8570a64deda0121ac93ed0e9 (cherry picked from commit 7fb178343eb121ff5e262a16aa601f7be23edc69)
2014-01-08designate which elements should shrink when limited widthCaolán McNamara1-14/+13
Change-Id: I46c5290ab411ac133ef8ea1e461197b00d837068 (cherry picked from commit 6cdf269a93685d5dfd7811faabb55acd2d7b2561)
2014-01-08fdo#72774: Ensure that all the group fields are in cache upon file load.Kohei Yoshida1-0/+3
This resolves the originally reported issue in that bug (in Comment 1). Change-Id: I6fb85cff1eafb78d784605aa08e7d992a1ac36e0 (cherry picked from commit 256e4ccba8a331f2d30c6b5da9dca70206deadae) Reviewed-on: https://gerrit.libreoffice.org/7301 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-08fdo#72774: Generate correct group items for the year group.Kohei Yoshida4-9/+12
This changes bring it back to the same algorithm used in 3.5. Change-Id: I16855cef1de133a1f886baa823d5b0d2b148e781 (cherry picked from commit c2e88a32314012afb799e321ec1d658f99f71781) Reviewed-on: https://gerrit.libreoffice.org/7305 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-01-07Drop the check of the SC_BACKGROUND_COMPILATION env varTor Lillqvist2-13/+8
Change-Id: Ia33002819023c79160d921fbc1cca7a5c12d143a
2014-01-07Add some more loggingTor Lillqvist1-8/+11
Change-Id: I637c365626242142a0f6fc0ac002fa9dd5f1340a
2014-01-07Avoid assertion failure if group has been disabledTor Lillqvist1-1/+3
Change-Id: I918f2716778ddd9ede56b5df731a531f97a3b24d
2014-01-07Background OpenCL compilation re-factoringTor Lillqvist7-39/+112
Don't use a mutex and condition in each ScFormulaCellGroup. Not sure at all if this crack works, and I hate every moment spent on it, but at least it is still behind an environment variable. Change-Id: I70c917d47112e3a2ed010de4d123a4155f71c004
2014-01-07fdo#72645: Case-insensitive string comparison in GETPIVOTDATA.Kohei Yoshida4-13/+47
(cherry picked from commit 17b00767948f7add229ec589c06cd8c898032ffa) Conflicts: sc/qa/unit/subsequent_filters-test.cxx Change-Id: Ibdb2b7ab2bae03875a3462816e860f58d9076457
2014-01-07fdo#72645: Allow GETPIVOTDATA to get result from leaf node of result tree.Kohei Yoshida6-9/+174
Change-Id: I0fc1fd069440ed6fee378fc2dfd2ed761afbdeab (cherry picked from commit 8728f8e8705cfb6875a315aef85ec6004604e702)
2014-01-06fdo#73001: Simplify the selection function logic & calculate correct results.Kohei Yoshida7-133/+218
Fixing a bug and cleaning up the code all at the same time. And don't forget to write test for it as well. Change-Id: Ia0322c4bebd4c5debcbfa4bb0902afbe581208b2 (cherry picked from commit 4a7a6b46c0dc779581f271b9e6c13c365eca7ab8)