summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2018-03-16use more TypedWhichId in sfxsidsNoel Grandin6-15/+10
Change-Id: I136427319ce2f1117501517efec2f03019bbf71e Reviewed-on: https://gerrit.libreoffice.org/51339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-16weld SvxObjectNameDialogCaolán McNamara1-1/+2
Change-Id: I588bdc61cce9a7b4e709fcac612b229c02e734c0 Reviewed-on: https://gerrit.libreoffice.org/51375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-15loplugin:unused-returns in scNoel Grandin10-22/+19
Change-Id: Ic1d6cbf883fcfeb013c3a82d31c177a1a14bb7c8 Reviewed-on: https://gerrit.libreoffice.org/48193 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-15Check return of ScFlatBoolRowSegments::ForwardIterator::getValue()Eike Rathke2-7/+14
And if it is only an assert() where code (probably rightly) assumed there is a value.. if there wasn't then we'll have to handle it. Change-Id: Icbdb4a7727ca4cf8a6372c03e02d3bffa6156b6c Reviewed-on: https://gerrit.libreoffice.org/51374 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-15Use return value of ScTable::GetDataEntries()Eike Rathke1-3/+5
It's unnecessary to insert an empty set and sort it.. Change-Id: I01b7ce926747083dc9b5a82304c8ab182cd5a1bd
2018-03-15tdf#97977 related : make MODE.SNGL comply with Excel.Winfried Donkers4-14/+151
MODE.SNGL is to return the first occurrence of the number that has the most occurences in the array of numbers in case of multiple numbers having the same amount of (maximum) occurrences. Change-Id: If76115ddc6b84367cbcb75de611f29076a538476 Reviewed-on: https://gerrit.libreoffice.org/50593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-15tdf#50916 Refactor of the table7.cxx to allow dynamic column sizeBartosz Kosiorek5-56/+74
Change-Id: I60ea249ca621e25b3585e1d2f75bdf15d96f6dcc Reviewed-on: https://gerrit.libreoffice.org/48205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-15loplugin:useuniqueptr in ScBroadcastAreaSlotMachineNoel Grandin2-17/+11
Change-Id: Ib1f54ad7eeae5ea66ad7f8f789e86cd89c4b32d4 Reviewed-on: https://gerrit.libreoffice.org/51316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-15don't use heap for elements in ScRangePairListNoel Grandin8-96/+88
no need to store small objects like this out of line. And use std::array for ScRangePair, so we get range checking in debug mode. Change-Id: Ie4690edbb4c3fdc4e08206cb016b8167a399d95a Reviewed-on: https://gerrit.libreoffice.org/51268 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-14Moving XSAXDocumentBuilder2 to use XFastDocumentHandler:Mohammed Abdul Azeem2-80/+20
This is used in parsing of meta Contexts across different modules. This also involved moving to XFastParser for parsing xml filters in sw, sd, starmath. Change-Id: Ic663aaac6cb20ee8ce5b97cae87c93220f5a2929 Reviewed-on: https://gerrit.libreoffice.org/42989 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-14modernize ScRangePairList::CreateNameSortedArrayNoel Grandin3-101/+88
we have this STL thingy now, pretty cool Change-Id: Id96010dda59736bd0c143312424018b6ea5621f1 Reviewed-on: https://gerrit.libreoffice.org/51230 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-13ofz#6845 use of "deleted" ScRangeEike Rathke1-1/+5
If nOverPos<i and i was last element, the next pOver=&rRange was invalid, though not deleted because std::vector::erase() does not reallocate. Change-Id: I22d9302e2d45403dd47ac1947d2cf003b3a4f291
2018-03-13set welded enties to activates-defaultCaolán McNamara1-1/+1
cause the vcl ones are equivalent to this so less change Change-Id: I60d9ba5faab6c133242b002b81fa8e4747a92383 Reviewed-on: https://gerrit.libreoffice.org/51220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-13tdf#114552 Also reduce the anchor offset when shrinking imagesSamuel Mehrbrodt1-2/+9
Else the image will get larger than its current cell. Follow-up for 4f29ce6a67b81e7f28e1c86d60ff15ec1d180661 Change-Id: If2fb1087961a1b20f5a408ca3061956e96330e91 Reviewed-on: https://gerrit.libreoffice.org/51209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-13SDI: don't #define/#undef names of actual classes for slot headersMike Kaganski17-20/+20
Visual Studio 2015/2017 cannot handle that correctly, and emits a lot of intellisense errors. So, just prepend the define with "ShellClass_" Change-Id: I473ceb7e0a88e114b92e6342fd4ae63015cafd3e Reviewed-on: https://gerrit.libreoffice.org/51135 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-13loplugin:useuniqueptr in ScPageHFItemNoel Grandin2-31/+22
Change-Id: I430ee7ff6dc5357593b152f9fe0f73d4b69ccf6a Reviewed-on: https://gerrit.libreoffice.org/51204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-13loplugin:useuniqueptr in ScConditionEntryNoel Grandin2-55/+50
Change-Id: Ifcb2949fd932de249b71322ec9827e1ba3b1fe1b Reviewed-on: https://gerrit.libreoffice.org/51206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-13loplugin:useuniqueptr in ScDocumentPoolNoel Grandin2-100/+96
Change-Id: Ia43710711b517e72d7758fea5603c1f3bf6e093f Reviewed-on: https://gerrit.libreoffice.org/51205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-13tdf#114552 Convert anchor toggle to anchor menuSamuel Mehrbrodt6-5/+6
Since we now have three, not two anchor types. Change-Id: I9654de574a9d546d2191093cba9c192fac3cd3d7 Reviewed-on: https://gerrit.libreoffice.org/50987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-13tdf#114552 Improve image scaling in CalcSamuel Mehrbrodt8-53/+167
When anchor type "To cell (resize with cell)" is selected, we do now:: 1. Consider aspect ratio when scaling graphic objects with cell This only works when the image fits into one cell. When the image is over multiple cells, we need to respect the end anchor, so we need to keep the existing behavior (no aspect ratio considered). 2. Always scale images if anchor type is "resize with cell" Previously it would only scale if the image is larger than the cell. Now we always enlarge the image if the cell is enlarged, and shrink the image if the cell is shrinked _and_ the image no longer fits into the shrinked cell Change-Id: Ib2a24819d0058bcebce73ea97bbf70a963d74584 Reviewed-on: https://gerrit.libreoffice.org/50451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-12forcepoint #26 check input against max valid enum valuesCaolán McNamara2-8/+8
Change-Id: Ide72884c77904ae9495b5189cde086e43923e4bd Reviewed-on: https://gerrit.libreoffice.org/51136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-12-Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
Change-Id: I9272b14c7760f2880983e198ff98b54cf37e1d30
2018-03-12tdf#103175: Initialize DrawLayer if requiredMike Kaganski1-2/+3
Change-Id: Ia99dd1e349e807d339dce0ead518a72a31e0fc02 Reviewed-on: https://gerrit.libreoffice.org/51096 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-12loplugin:redundantfcast look for redundant copies in return statementsNoel Grandin5-13/+13
Change-Id: I5f416c865dfe1c36018784246a8007452eb42008 Reviewed-on: https://gerrit.libreoffice.org/50996 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-12lokdialog: convert the show sheet dialog to async execHenry Castro1-11/+17
Change-Id: I501d9444ef9798a26b4db06ab51e4fb691144b17 Reviewed-on: https://gerrit.libreoffice.org/51094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-03-11extract common components to one place for sc unoapi testsTomaž Vajngerl52-1728/+103
The declared components in a test of uno api don't change much or at all, so instead of duplicating this in every test, define it in a common file use when needed. Some more common things could be extracted in a similar way. Change-Id: I07ae641afca55ffaf3c5c93624bfaa2143590886 Reviewed-on: https://gerrit.libreoffice.org/51079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-11Move (and rename) graphic stuff from svtools to vclTomaž Vajngerl85-10/+88
This is preparing to change how GraphicManager works where it won't base itself around GraphicObject anymore but Graphic. No functional or cosmetic change was made to the classes, only changes that were needed because of the move and rename. The only thing that wasn't moved is the GraphicRenderer as it is not needed in vcl for now (but makes sense to move it in the future to keep graphic stuff together). grfmgr was renamed to GraphicObject as the GraphicManager will be changed a lot and most likely moved out, so the name grfmgr won't make any sense anymore. All the UNO implementations were renamed with a prefix Uno and used the same name as the class name. This is made to be more specific which are the Uno objects (for example graphic.cxx contained the implementation of XGraphic, which is similar to graph.cxx contains Graphic). Change-Id: I54a2fa6c7e997469aaa7770db05244adb9f64137 Reviewed-on: https://gerrit.libreoffice.org/51068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-10Rename ScMatrix::IsString() to IsStringOrEmpty()Eike Rathke12-76/+82
... to prevent further confusion what it acually returns. Follow-up inspection of places where used might be necessary, and whether an IsEmpty() is used and necessary or an IsAnyEmpty() or some such would be needed. Change-Id: I7975a97f0d16442cf195956d148bfb7fbdf89c6a Reviewed-on: https://gerrit.libreoffice.org/51055 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-10Unit test tdf#116324Eike Rathke1-0/+7
Change-Id: Ib1f0f8fe2308c075477903d4f981046a939d4b79
2018-03-10Resolves: tdf#116324 treat jump empty path as 0 when nestedEike Rathke1-2/+4
Apparently a fallout from commit 0f45ac20cd2ab2a64c40c7d6850f333cc33feeb0 AuthorDate: Mon Jun 28 11:40:39 2010 -0400 CommitDate: Sat Nov 6 23:40:00 2010 -0400 More on fixing build by eliminating use of ScMatrixValue. or other commits related to ScMatrix handling. Change-Id: I10e8b58aed51cd707b1503dbbc0b369aea4a2805
2018-03-10don't use heap for elements in ScRangeListNoel Grandin117-1180/+1077
no need to store small objects like this out of line. Also - add move constructor and move assignment operator - drop Assign method since it now has the same signature as push_back Change-Id: I9a8647d3a11f24166a83d399a358a2bce3b2cb79 Reviewed-on: https://gerrit.libreoffice.org/50899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-10escherex: export graphic without GraphicObject uniqueIDTomaž Vajngerl1-3/+4
Change-Id: Ibf8858ca890b82d5a3ddb8b026a0a4dd03bc9072 Reviewed-on: https://gerrit.libreoffice.org/51021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-10remove references to {Header,Footer,Para}GraphicURLTomaž Vajngerl2-4/+0
Change-Id: I559f25ee99f7b8b49545390479cbb06d3c601d3c Reviewed-on: https://gerrit.libreoffice.org/50982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09Remove unused HIDsGabor Kelemen1-6/+0
These were no longer used in the code. This should help me in identifying obsolete and missing HIDs in helpcontent. Found by this somewhat sophisticated method: for mod in $(find -name helpids.h) ; do echo $mod; for i in $(grep ^#define "$mod" | cut -d " " -f2 ) ; do if [ $(git grep -c "$i" $(echo "$mod" | cut -d "/" -f 2 ) | wc -l) -eq 1 ] ; then echo "$i"; fi ; done done Change-Id: Iaf8179322419ce51175bc5a42fedec0add8c5241 Reviewed-on: https://gerrit.libreoffice.org/50680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-03-09tdf#45904 Move _SheetLink Java tests to C++Jens Carl3-0/+209
Change-Id: I33813be65bcb44c11a35bc97d963057418a28d9e Reviewed-on: https://gerrit.libreoffice.org/50984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-09Use std::arrayStephan Bergmann1-7/+10
...so standard libraries in debug mode can catch out-of-bounds element acces Change-Id: I519795f5fcb51f243312e5d0247998eff6ceb151 Reviewed-on: https://gerrit.libreoffice.org/51008 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-09inherit welded dialogs from a common ancestorCaolán McNamara8-21/+15
Change-Id: Ifa6c871a134cf89bfba71b1049a115cf7c953c42 Reviewed-on: https://gerrit.libreoffice.org/50936 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-09completely remove MID_GRAFURL, replace with MID_BITMAPTomaž Vajngerl1-1/+1
Change-Id: I39b055760320abb2575958d525b4db3185a11d4a Reviewed-on: https://gerrit.libreoffice.org/50990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09remove MID_GRAPHIC_URL and related mappings, implementationTomaž Vajngerl2-4/+0
Change-Id: I752a2f036791720d12fb04b95f53d4127d605c7e Reviewed-on: https://gerrit.libreoffice.org/50979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09Remove warning "No DrawLayer available"Samuel Mehrbrodt1-2/+0
This warning appears very often in unit tests. We have similiar checks all over the place and don't emit a warning either. Change-Id: Ic1667fa51ce39e72c9a940023cc12a72458bd490 Reviewed-on: https://gerrit.libreoffice.org/50968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-09loplugin:redundantfcast look for unnecessary temporariesNoel Grandin5-9/+9
when calling methods that take a const& Change-Id: Idf45dfd9fea0de6fae0b1f89550f2f7fc302aa15 Reviewed-on: https://gerrit.libreoffice.org/50970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-09drop getColor() method of ColorNoel Grandin2-7/+7
no longer necessary Change-Id: I9e0fcea1134e8c5e27f9effbb5eb79fe5446e33d Reviewed-on: https://gerrit.libreoffice.org/50925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-09svx: removing GraphicURL and OWN_ATTR_GRAFURL, fix writerfilterTomaž Vajngerl1-30/+17
Change-Id: I5b84788a324cc68e3c4561e9a7376fcb1cfeeb67 Reviewed-on: https://gerrit.libreoffice.org/50933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-08tdf#116283 oox customXml: Don't write the Relationship to DOCX files twice.Jan Holesovsky2-1/+6
Change-Id: Id3da40138e86c142707e377aa897df372aacb704 Reviewed-on: https://gerrit.libreoffice.org/50947 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-03-08Load arguments in array in the order of the arguments.Winfried Donkers1-0/+1
Change-Id: I1a47018d626848e6d07c7e637ee6e04ff7750ac8 Reviewed-on: https://gerrit.libreoffice.org/50904 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-08loplugin:constantparam in linguistic..sfx2Noel Grandin1-1/+1
Change-Id: I0e8c506df0beb0b05d9c32723876b11b6577280a Reviewed-on: https://gerrit.libreoffice.org/50938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08oox: unit-tests for custom package preservationAshod Nakashian4-1/+29
Change-Id: I69d0d7d6bdc8804d0e56be19cd86a699200fc85f Reviewed-on: https://gerrit.libreoffice.org/50855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-03-07make all the .ui message dialogs explicitly modalCaolán McNamara4-0/+7
Change-Id: I1e197fbec92d5369394f036171af9018afea7f15 Reviewed-on: https://gerrit.libreoffice.org/50910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-07sc lok: Let the tiled rendering draw the List Validation dropdowns.Jan Holesovsky1-1/+3
Change-Id: I84530cdda296dc51ceb0fd695af19211631508df Reviewed-on: https://gerrit.libreoffice.org/50909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2018-03-07tdf#116108 Add option to fit images into their cellSamuel Mehrbrodt15-0/+87
Change-Id: I2e9a4f567049f11985e4bf914c2fa5bd1f181823 Reviewed-on: https://gerrit.libreoffice.org/50569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-15 09:54:22 +0000