summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2020-06-27cid#1464973: RESOURCE_LEAK (sc/excel)Julien Nabet1-1/+1
Change-Id: I923788f57e022c99a89a6406cf3ed02066efd022 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97279 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26tdf#103734: sc: Add unittestXisco Fauli2-0/+14
Change-Id: Iffc31232e58e0beb6c24f09ef2406c72fa502c00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97261 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26tdf#118624: sc: Add unittestXisco Fauli2-0/+15
Change-Id: I377d64258d1bd93af99284eb7b74e16d7924effd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97260 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26tdf#127982: sc: Add unittestXisco Fauli2-0/+25
Change-Id: I6fc4299012db9094ceec3c8146bfef317c93e3cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97259 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26tdf#129681: sc: Add unittestXisco Fauli2-0/+30
Change-Id: I160774b1b3d32fb5521d3f7a184f33922839bb1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97239 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26tdf#130583: sc: Add unittestXisco Fauli2-0/+22
Change-Id: I74f2d90f4f9eb17d1833ceedd1598c1439489354 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97222 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26Upcoming improved loplugin:elidestringvar: scStephan Bergmann2-3/+2
Change-Id: Ic53ec0c5ffd661073742151c6c012a1dc1b88f9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97202 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26Related: tdf#134280 set max limits for solver options that show max valuesCaolán McNamara2-0/+20
just simply clip to the claimed max Change-Id: Ie64da80204c9c817c85724abd1fee8c6594967b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97185 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-25tdf#133026: Tight integration of extensions - Additions Dialog first iterationYusuf Keten2-0/+10
- Add the uno command .uno:AdditionsDialog - Add the necessary commands to cui makefiles. - Add the dialog AdditionsDialog for only test - Implement the basic functionality to show up when clicked on the menu/toolbar item. Change-Id: I89dd74e49f5ff246ca355d2f8d1397621b26dea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95593 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-06-25tdf#133326: sc: Add unittestXisco Fauli2-0/+57
Change-Id: I2436822fa289ae1bf10643cfc5232f4db6df2e29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97150 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-25tdf#134234: sc: Add unittestXisco Fauli2-0/+15
Change-Id: Ie49cabb8ba10aaa8ec4453f6284b86617e98d490 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97103 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-25use tools::JsonWriter for dumping property treeNoel Grandin2-5/+5
Change-Id: I8f55af19ba10b71bd621e69b27000ab7cb565309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96677 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-25Revert "tdf#133858 opening spreadsheet with large array formula takes 10 ↵Noel Grandin1-9/+0
mins" (tdf#134234) This reverts commit 9a5f2961b085ce2f23ecdf0a03d1114bacac8e2c. Reason for revert: causes regression, see tdf#134234 Change-Id: I1cc3e6daa0e65231e8a4d7c1ae4a60cfdf106457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97054 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-25loplugin:unusedfieldsNoel Grandin2-12/+2
Change-Id: I7d8cd41c6b4b97a6d33764a8580f08413e584a69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-24loplugin:unusedmethodsNoel Grandin7-172/+0
Change-Id: Ib724da1f07be9e8f4d0d505f7f2886990cab661f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-24tdf#134280 set legal range for Epsilon levelCaolán McNamara2-0/+8
Change-Id: If544da13913ab6ce84e934e351e4e2d78b6e1466 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-24Fix sending reference marks for current selectionSzymon Kłos1-5/+11
When selecting range on mobile in validation dialog the message wasn't sent due to missing ViewShell Change-Id: Iaab543368469cd363b54b1a89f6983b8c01877ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94693 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96933 Tested-by: Jenkins
2020-06-24tdf#133326 Crash after redoNoel Grandin1-2/+3
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa tdf#50916 Makes numbers of columns dynamic. Change-Id: I6a3d6b35dbd442014c84785d97cbd7eae19244cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96958 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-24use more std::container::insert instead of std::copyNoel Grandin2-2/+2
which is both more compact code, and more efficient, since the insert method can do smarter resizing Change-Id: I17f226660f87cdf002edccc29b4af8fd59a25f91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-23tdf#133629 calc, crash on format borders on multiple sheetsNoel Grandin1-0/+1
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa tdf#50916 Makes numbers of columns dynamic. Change-Id: Ie862ec4a29d495c71aa3a21a1941f801fa3a789e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96957 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-23remove JSON node erasingNoel Grandin2-46/+0
as a step towards using tools::JsonWriter for DumpAsPropertyTree Since this method is only used by the LOK stuff, we can just remove the node down at the generation site in vcl::Window Change-Id: I1b3b9a0732dcdb18267cb56e545a30c8f56b4ae2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96839 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-23tdf#133699 Slow sorting of a columnNoel Grandin1-2/+1
reserve inside a loop is a pessimization, since it breaks the logarithmic resizing of the std::vector data area. Also use the std::vector::insert method, instead of std::copy, since the insert method will perform less resizing operations. On my machine, this takes the sort operation from 25s to less than 1s. Change-Id: I30b99d42c56abc5a4ad5c133c7579fac3952173c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96929 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-23jsdialog: weld SpinButton and CheckButtonSzymon Kłos1-2/+2
Change-Id: I0dfa163b8a52594cde9e3529df8f433dc93bc459 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94432 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96845 Tested-by: Jenkins
2020-06-22tdf#133855: sc: Add UItestXisco Fauli2-0/+53
Change-Id: I135865b3a47c2da07340471b8c2bb5b6c768c00c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96732 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-22tdf#128502: Avoid potential crash in mobile app with multiple open documentsTor Lillqvist1-1/+1
Not sure if actually needed, but can hardly harm. Change-Id: Ibb819818db40b2f086e5c1f2330a7f8f2fcc1727 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95148 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-06-22jsdialog: use for message dialogs on mobileSzymon Kłos1-1/+6
Change-Id: Ib172dc264d7f55fef08dc474f7e6f4d1b3108085 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94431 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96836 Tested-by: Jenkins
2020-06-22failed cell dependency check should not set invalid values (tdf#132451)Luboš Luňák5-4/+95
Calc's dependency check done before parallel formula cell group calculation tries to ensure valid cell values for all the dependencies of the group's cell, and if it detects a problem such as a cycle it bails out. But since ScFormulaCell::Interpret() simply bailed out without doing anything, other cells could use that cell's possibly incorrect value for their calculation and get their dirty flag reset. This fix adds a flag to mark that bailing out is in progress, which ensures the bail-out is short-circuited and no cell values are set. Change-Id: Ia93c70d456682e19ce533abd2cf65ce35ffed9ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96838 Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Tested-by: Jenkins
2020-06-22tdf#97177 speedup loading of large ODS fileNoel Grandin10-329/+173
drop ScSimpleRangeList and just use ScRangeList, which saves us a conversion step. Then teach ScRangeList to do a simple merge, since we are loading in row order, and can just check the last few entries. Then fix a case of optimisation doing the wrong thing in ScAttrArray::SetPatternAreaImpl where std::vector::reserve repeatedly resizes the data array and breaks the normal doubling-resizing inside vector. On my machine the time goes from 5.4s to 4.8s Change-Id: I68a2204e0c02b673bbfe8aa0fdbe126e53ddbb41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96516 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-21uitest : Add support for Dropdown items in grid windowAhmed ElShreif2-2/+108
This patch add support for test cases that test Dropdown list of cells in Calc that can be created using: Data -> Validity -> List. You can select items from the list by it's id or it's text . This may help in tdf#133855 . Change-Id: I830149fd5520df72f07540fd4eebd3f3bad48616 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96670 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-06-21Fix typoAndrea Gelmini1-1/+1
Change-Id: I2d832758bc79bd5c1a1e18eee1097f4325a7ec86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96563 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-20use JsonWriter for the rest of ITiledRenderableNoel Grandin5-148/+145
and fix bug in buffer reallacotion where mPos pointing at the beginning of the new buffer instead of at the correct index inside it. Change-Id: Ie1ffaa176f6165e2cec85c93adc945312eff38e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96650 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-18distinguish active dnd-operation case from simple query caseCaolán McNamara1-2/+2
Change-Id: I1d8e95e46b45c71c0c83316ab4f19ba85eddcf75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96598 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-18delay and batch calls to StartListeningFormulaCells() (tdf#132165)Luboš Luňák2-0/+22
This is pretty much the same as tdf#133302. Change-Id: I5325b90601f503e572faefc455a38e0f5b055bbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96560 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-18new json writer for LOKNoel Grandin4-27/+16
we shave about 3 memory copies off in the process, and make the class play nicely with our string types. Change-Id: I1f614fb35b1de499ac99e3b33ac638ad81054bed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96393 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-17tdf#133807 re-present search dialog after a short timeoutCaolán McNamara1-1/+1
Change-Id: Icc6016b3a9e3f25fd4c9e065e9f2d9570ad040c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96524 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17tdf#133692: Spacing within Calc formulabar reworkedThorsten Wagner1-7/+10
Change-Id: I4f590589fdc390bfa11f7db86e65ccab3dd084fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96403 Tested-by: Jenkins Tested-by: Andreas Kainz <kainz.a@gmail.com> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-17inline typedefNoel Grandin2-6/+4
Change-Id: Ib3c11a59d155e308caa3f11f43bb2c6552569889 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96515 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-16tdf#134038 use mnCheckWidthReq to avoid text width calculationCaolán McNamara1-1/+2
when mnCheckWidthReq is available Change-Id: I9964b1df9e025ab737d0d306148930c34b7d7148 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96474 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-16tdf#134038 insert in optimal orderCaolán McNamara2-29/+52
Change-Id: I7b3d2b7bb37f4a7de118b4654f63bcc18a24b855 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96473 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-16tdf#133268: Update non cmd icons, update Glue point iconsRizal Muttaqin1-1/+1
- Update some menubar visibility Change-Id: I7a464691b8608d01f0a8b3924c37e0fd510df45c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96468 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-16size width request to fit column hintCaolán McNamara4-14/+18
Change-Id: I1439984e4ff52bebb1c1e777c1cdffcc5820c169 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96472 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-16use hover-selection for filterlist dropdownCaolán McNamara1-0/+1
like writer's form drop down which makes it a more natural menu-alike thing Change-Id: I526e0d8efe166596ecb91576ebf9b359b3239526 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96365 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-16Use SvNumberformat::GetMaskedType()Eike Rathke1-8/+2
... instead of testing SvNumFormatType::DEFINED for each type individually. Change-Id: I539ad1c9a6b17ed788c26b75b7e673aaae3a6a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96389 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-06-15tdf#103414 Add/Delete decimal for 100th secondLaurent BP3-10/+12
Use Add/Delete decimal to change precision of time and duration Apply only to 100th second Change-Id: I2ff1b01db7ee67645511fcf7ea6bf65055e92a8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94765 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-06-15consume tab key press in single-widget dropdownCaolán McNamara1-0/+4
Change-Id: Ie23fa35d29c20910514f3aaad095521f1588702b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96367 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-15ReleaseMouse so focus can be grabbed by the FilterFloatCaolán McNamara2-11/+25
otherwise the keyboard events don't get to the dropdown Change-Id: I6cbaea5e3cef16a39edb12fecdf1d08ab29cbd5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96366 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-15rhbz#1847031 null-derefCaolán McNamara1-1/+1
Change-Id: Ic9327788ebf49ac1ab0d3463f2f1e4d87ef14cb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96364 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-15WinBits are always the same for ScFilterFloatingWindowCaolán McNamara1-6/+7
Change-Id: Icb43adb273f44014499c25ae8b6ab535f2a7d6d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96300 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-15Resolves: tdf#133985 make ok the defaultCaolán McNamara1-1/+0
Change-Id: I5fa0db660c03fb85a6a661b70fa9c14014c92579 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96292 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-14tdf#133971 hold self-ref until we returnCaolán McNamara1-1/+4
Change-Id: Iac1b79152c07915675a7dc562aaad9b4c465faa2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96294 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-17 13:32:44 +0000