summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
2019-08-08tdf#125288 Databar dialog's entry color was changed to RYB BlueKovács László Zoltán2-2/+2
Change-Id: I9ac6df07078d60bf439babc46384fa96267fb4cd Reviewed-on: https://gerrit.libreoffice.org/77119 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-08tdf#126634 Move uno:Grid back to Form controls toolbarRoman Kuznetsov1-0/+1
Change-Id: Ic13da0d0295a9ceb30e605dfb634bc86c6390ec9 Reviewed-on: https://gerrit.libreoffice.org/77065 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-07tdf#126748: temporary hack to avoid crash when several pivot tables ...Mike Kaganski1-0/+10
... reference a single cache, and have different sets of group fields. The problem is getting group field names from the tables referencing the cache; so when a table referencing not all group fields happens to be first in the reference list, the returned name is empty. The hack just stops writing group fields as soon as it finds an empty name; this naturally leaves bad cache data behind, but at least doen't crash. The retrieval of the names should be reimplemented using a different source, to not depend on tables referencing the cache. Regression after commit b082998401e37e6c7534906601bc481423a6ded0. Change-Id: Ib2e92f8acf93a801861c6ba5c68fab3bebe3672c Reviewed-on: https://gerrit.libreoffice.org/77110 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-07tdf#126673 Auto-fit column and auto-fit row don't work with line breakNoel Grandin5-7/+10
Revert "tdf#94677 Calc is slow opening large CSV, avoid reset SetUpdateMode" This reverts commit c47d0174f2c6c3ebcb3b33276d0277e7aceac330. Change-Id: I38e065d44dfb9d08498176b8231aff14ff51d91c Reviewed-on: https://gerrit.libreoffice.org/77109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-07tdf#126685 CRASH: selecting all in sheetNoel Grandin1-2/+1
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. We need to clamp the columns whenever we change sheet/table Change-Id: I5cf22b2a7cf2f6473b8340289bcddd75ed0ad70b Reviewed-on: https://gerrit.libreoffice.org/77105 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-06Select shape even when clicking on a hyperlinkSamuel Mehrbrodt1-1/+1
and the hyperlink isn't being opened anyway (no ctrl clicked e.g.) Change-Id: I262a32b0f295ed66339c0a12a551f68d9d63c978 Reviewed-on: https://gerrit.libreoffice.org/77032 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-06Add "Copy hyperlink location" to sc context menusSamuel Mehrbrodt6-0/+32
Change-Id: I93840c7a7e6bbbba0c5dedb6fa460a46d1785e80 Reviewed-on: https://gerrit.libreoffice.org/77018 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-06Improve hyperlink selection in scSamuel Mehrbrodt2-60/+16
Change-Id: Ia8c6b9f9994cbe3e503061b4762dbd8648a4b857 Reviewed-on: https://gerrit.libreoffice.org/76598 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-03tdf#39593 Drop lcl_GetIndexFromNameArkadiy Illarionov1-13/+3
Use comphelper::findValue instead Change-Id: Id8490034b0f957084680fef18ba07974b5373fb2 Reviewed-on: https://gerrit.libreoffice.org/76896 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-08-03tdf#39593 extract getting max row length to template functionArkadiy Illarionov1-24/+18
Change-Id: I23c81ac7dbd8785b12620aaf8ae2c090ae1785f8 Reviewed-on: https://gerrit.libreoffice.org/76894 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-08-03Fix typosAndrea Gelmini1-2/+2
Change-Id: I5c95e180681220fc592400435d90e4d46603d41c Reviewed-on: https://gerrit.libreoffice.org/76883 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-02calc: simplify getDocumentSize calculation.Michael Meeks1-9/+1
Change-Id: Iee2ebf2c6ed74651556647264f519caa9c59dad7 Reviewed-on: https://gerrit.libreoffice.org/76492 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-08-02lok: minimal implementation of isComplex for calc for now.Michael Meeks4-33/+64
Change-Id: Ic4141d30a0ff48a9ec5ecc8e6119d9d779c4a0fc
2019-08-02lok: disable calc char-set dialog for HTML when pasting.Michael Meeks1-1/+2
Change-Id: I3ec9e98549d06ae3e6b4ede89215a5137d01ccab
2019-08-01Make QR Code callable in calc and writerShubham Goyal5-0/+56
Change-Id: I73793100478c34a7721821cec1f8ccec0174d20c Reviewed-on: https://gerrit.libreoffice.org/74598 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-01Resolves: tdf#126496 - "Page Fields" in pivot table unclearHeiko Tietze1-1/+1
Renamed to Filters Change-Id: I512a06830635a8b6c62ca8a0ad64683f9824b9e0 Reviewed-on: https://gerrit.libreoffice.org/76777 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-01clean up ViewCallback nicelyNoel Grandin1-152/+103
Change-Id: Idb882460092642bc77804560cd8fd6432a590323 Reviewed-on: https://gerrit.libreoffice.org/76776 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): scStephan Bergmann123-216/+216
Change-Id: I1bfd2bb623aac5ac457a0b719da64ab393ccd0ba Reviewed-on: https://gerrit.libreoffice.org/76654 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-30tdf#125800: accessing cond format props in UNO throws errorAron Budea2-2/+2
These conditions were always evaluated to true: OR should become AND when negated. Regression from 8c637b47d9de4b3a64c33a9c2ffe7ed220be2467 Change-Id: I87038319ed27eff2bed2412da49e01f73ec0a79c Reviewed-on: https://gerrit.libreoffice.org/76493 Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2019-07-30tdf#126306: Add UItestXisco Fauli1-0/+140
this is possible after Jim Raykowski added accessible support to the autofilter popup ( tdf#122774 ) Change-Id: I9b503f8260fd914e7b5794b837d2661c63c7d21b Reviewed-on: https://gerrit.libreoffice.org/76563 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-29sfx2: Re-enable the sidebars for LOKAshod Nakashian1-1/+6
This re-enables the sidebars for LOK, which were disabled to avoid overheads. Also, fixes a regression where editing stopped when loading a new view because the sidebar window creation killed the edit view. Revert "Avoid various desktop GUI elements when used from LibreOfficeKit" This reverts commit c0b70ec34d5e056bb92a66cbf83838923cb41fee. Also (added by Noel to the above commit) (1) Comment out parts DesktopLOKTest::testPaintPartTile test that trigger a crash. We are installing a callback that points to something on the stack, and then not removing that callback, resulting in calls to random stack memory. There is a further problem in the LOK code in that we cannot uninstall a callback when we have multiple views because the uninstall code in doc_registerCallback can only remove a callback for the __current__ view, which I do not fix here. (2) prevent code from accidentally creating empty entries in the mpCallbackFlushHandlers map, which is what happens when you use the index operator on map, which results in a crash in doc_registerCallback because the std::shared_ptr is empty. (3) In SdTiledRenderingTest, only turn off LOK via LibreOfficeKit::setActive(false) once the document has been torn down. Otherwise, we don't remove entries from the statically allocated s_pLOKWindowsMap map in vcl/source/window/window.cxx, which means that at process exit, we have dangling Window objects. Reviewed-on: https://gerrit.libreoffice.org/71165 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 88565c3662c6fde240c98a9b4f2ce6dfbcf4094e) Change-Id: I06b06a990f05c06b1889fa89b698dff6f494e09c Reviewed-on: https://gerrit.libreoffice.org/76466 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-29weld ScRedlineOptionsTabPageCaolán McNamara3-33/+48
Change-Id: I80151384f5e75eac08665f45ce87468e10fb987e Reviewed-on: https://gerrit.libreoffice.org/76553 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld ScTpContentOptionsCaolán McNamara3-226/+200
Change-Id: Ia0ad05337ae3195e565e4b913cdf34e9a32e9cea Reviewed-on: https://gerrit.libreoffice.org/76552 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld ScTpFormulaOptionsCaolán McNamara3-142/+119
Change-Id: I8d45dfc745dbb7f90346028eb29a432309db0845 Reviewed-on: https://gerrit.libreoffice.org/76547 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29rename DoubleField back to ScDoubleFieldCaolán McNamara6-17/+17
Change-Id: I3d3923f3131e13abde145f96468ade0d0c8cc142 Reviewed-on: https://gerrit.libreoffice.org/76546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29drop newly unused ScDoubleFieldCaolán McNamara2-42/+0
Change-Id: I2105306d1d865512a5fa2f8c862e7a21c384ee39 Reviewed-on: https://gerrit.libreoffice.org/76545 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld ScTpCalcOptionsCaolán McNamara4-159/+128
Change-Id: I4b5bd08a9ed04b9bceb08640a275dee02d6e9b36 Reviewed-on: https://gerrit.libreoffice.org/76544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29Drop ScDataPilotFieldObj::HasStringArkadiy Illarionov2-17/+1
Use comphelper::findValue instead Change-Id: I59a3ef2781643dfdb7ecbfe578fb9e1faebb0c42 Reviewed-on: https://gerrit.libreoffice.org/76502 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-29weld ScTpLayoutOptionsCaolán McNamara3-160/+128
Change-Id: I02f36b18d3803a7539a66b95cfc5e485d30344d7 Reviewed-on: https://gerrit.libreoffice.org/76539 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29revert bits of "loplugin:sequentialassign"Noel Grandin1-1/+2
from commit 0d36b32755ac662299e6a8165e9fa57311b74a2f Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sun Jul 28 12:03:35 2019 +0200 loplugin:sequentialassign which were false positives and not meant to be committed Change-Id: I6f2f185bd3564c9329f5a0c78c9020f3ddb52d34 Reviewed-on: https://gerrit.libreoffice.org/76518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-29loplugin:sequentialassignNoel Grandin1-2/+1
Change-Id: I56a9bf698b60bd278c71cc632aacef2bd2f4c13f Reviewed-on: https://gerrit.libreoffice.org/76501 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-28weld ScTpCompatOptionsCaolán McNamara3-27/+15
Change-Id: Id67570b53604489fa0b2194a0f9ad0b67d535f0e Reviewed-on: https://gerrit.libreoffice.org/76487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-28weld ScTpDefaultsOptionsCaolán McNamara3-62/+47
Change-Id: I2a4a053b38229b971fbf6fc8205680ce02132234 Reviewed-on: https://gerrit.libreoffice.org/76486 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-28loplugin:oncevarNoel Grandin1-2/+1
Change-Id: I3c014f53607a849c743a2fd1aa47d03d5af978fb Reviewed-on: https://gerrit.libreoffice.org/76495 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-28lok: send cell selection rectangle and cell area fill rectangleTomaž Vajngerl1-14/+36
Instead of text selection start/end for cell selection we send a cell selection rectangle event. This is needed so we're able to differentiate when to draw cell selection and text selection markers. In addition send cell fill area rectangle, which is the area where we need to hit to trigger area fill functionality in Calc. Change-Id: I54af958932815818a1a4d48364192ba43f1df7de Reviewed-on: https://gerrit.libreoffice.org/76491 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-07-27cid#1401328 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I1c4bdd4afec30d7d52054d8c9bd4958191c480f8 Reviewed-on: https://gerrit.libreoffice.org/76470 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-26cid#1401334 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I6eaf41e5a2761c7c2d9f44c908720bebc53178a5 Reviewed-on: https://gerrit.libreoffice.org/76353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-26UI test for #tdf121949Artur Neumann3-0/+51
Test if calc crashes when copying a noncoherent range to the clipboard Change-Id: I64d436ffb01775df9d50eb966ea2a12040482517 Reviewed-on: https://gerrit.libreoffice.org/76348 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-07-26tdf#42949 Fix IWYU warnings in sc/source/ui/vba/*cxxGabor Kelemen48-205/+44
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I888a8f7269c03d9d4d066032f90564f92c4af2e4 Reviewed-on: https://gerrit.libreoffice.org/75596 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-26UI tests opening all dialogs in writer and see if it crashesArtur Neumann3-29/+7
Open a dialog, close it by the given button e.g. "cancel" or "close". If the dialog has an enabled "OK" button open the dialog again and try to close it also using the OK button. For every dialog a complete new document is opened to ensure test-separation, otherwise one action could hamper the next action. For dialogs that already have other tests a "cancel/close" test was added to the previous test. As far as possible opening new documents was avoided in those cases. And in some cases a simple check was added to check if the "cancel" button does not change anything. Simmilar tests for calc have been renamed and code dublication has been removed by moving main part of the code to a helper file Change-Id: I01f197cae8bc6fe0345661fe042b655f16229485 Reviewed-on: https://gerrit.libreoffice.org/75124 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-07-25LOK: sc: Issue DOCUMENT_SIZE_CHANGED only when size changesAshod Nakashian1-6/+10
Issuing DOCUMENT_SIZE_CHANGED triggers document-loaded event. This is accidental and historic, but the end result is that the client assumes everything is invalidated and fires initialization handlers, which are normally invoked the first time a document is loaded. Undesirable when really nothing has changed. Change-Id: Ia4fa4479ca627b0f605e4ff5009f7e631a26f6d7 Reviewed-on: https://gerrit.libreoffice.org/76313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25lok sc: Fix the formula input bar and address bar notifications.Jan Holesovsky1-8/+5
Apparently we did not have the pInputWin living in the background; but now we have. There is no reason to treat it in an 'else' branch, these checks should be separate either way. Change-Id: Ibb8d92fb1e2803942460d2063847917d082fcb2e Reviewed-on: https://gerrit.libreoffice.org/71863 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/76292 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-25tdf#107394 sc ui: fix lack of row height update on undo of pasteMiklos Vajna3-4/+65
This is a problem since commit df9243626b39742a9a148bea95796f8824fee68a (fdo#73606: Avoid excessive and unnecessary heap allocation of array objects., 2014-01-14), though it seems this uncovered a problem that was introduced earlier. Reading ScViewFunc::AdjustBlockHeight(), commit 64a36fd4f4085ed05e4c0ee40ac109452ff81a78 (ScUndoPaste to handle multiple ranges., 2011-09-09) changed ScUndoPaste::DoChange(), so that AdjustBlockHeight() is invoked in a loop, but always with the same arguments. In case AdjustBlockHeight() doesn't get a mark data, the function takes the mark data from the view data, which is empty in the "undo of paste" case, so no row height gets updated. Fix the problem by explicitly providing the mark data to AdjustBlockHeight(), probably that was the intention in the second commit. [ Testing this from CppunitTest_sc_copypaste means ScImportExport has to be dllpublic, but that seems still better than having a view shell in CppunitTest_sc_ucalc. ] Change-Id: I140b53588d59d231772152c0e820e5fdedf6894c Reviewed-on: https://gerrit.libreoffice.org/76265 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-25Fix typosAndrea Gelmini3-3/+3
Change-Id: I59a0fd175fa5185c15d093d2d9bed9f95bb4cfd5 Reviewed-on: https://gerrit.libreoffice.org/76280 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-24Fix typoAndrea Gelmini1-2/+2
"an URI", to complete: https://gerrit.libreoffice.org/#/c/75985/ Change-Id: I57489b05117fd12ae6aa22544437ab5bc6b5154f Reviewed-on: https://gerrit.libreoffice.org/76037 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-24cid#1448321 Dereference after null checkCaolán McNamara1-1/+1
Change-Id: I724e4c19df9aa446f496b21ea5f3918e2def28da Reviewed-on: https://gerrit.libreoffice.org/76249 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-24loplugin:unusedenumconstantsNoel Grandin1-2/+1
Change-Id: I484b39d1060e6a563dabdde03867989b8ba067f9 Reviewed-on: https://gerrit.libreoffice.org/76237 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24convert AreaOverlapType to scoped enumNoel Grandin5-25/+19
and remove unused AreaPartialOverlap Change-Id: I21e94d8d15c59485c1287e99dcc6558e0570a8eb Reviewed-on: https://gerrit.libreoffice.org/76234 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24cid#1451636 silence Division or modulo by zeroCaolán McNamara1-1/+1
Change-Id: Ibe9ee3d5f555d153fd208a03ba2e3ae68d263ab3 Reviewed-on: https://gerrit.libreoffice.org/76224 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-23Don't draw gridlines and document background in Online server processMike Kaganski1-3/+6
... see https://gerrit.libreoffice.org/72417 They will be drawn client-side. Borders and explicit cell background are still drawn in core. This mode is activated using "sc_no_grid_bg" option in SAL_LOK_OPTIONS environment variable. Change-Id: Ie10e7770b8168ec648d44ae5af0a0a0602d89ee6 Reviewed-on: https://gerrit.libreoffice.org/75484 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-21 09:53:29 +0000