summaryrefslogtreecommitdiff
path: root/sc/source/core/data
AgeCommit message (Collapse)AuthorFilesLines
2014-12-15sc: Use appropriate OUString functions on string constantsStephan Bergmann1-55/+55
Change-Id: Ib4c0df8d7637bff7d7a45d24482fff4342169fae
2014-12-12Resolves: fdo#87245 crash because clip doc doesn't own DocumentPoolCaolán McNamara1-1/+1
multiple documents sharing the same doc pool so can't unset its secondary here. Here the assumption is that SharePooledResources has always been called on Clip or Undo docs (otherwise persumably need a flag which SharePooledResources toggles on) Change-Id: Ibcdbe5f698102dc683c290d3bd581c31e214765f
2014-12-11coverity#1257741 Uninitialized scalar fieldCaolán McNamara1-2/+6
Change-Id: I8b977766e694ab449d612322138f5baa23fef29b
2014-12-11coverity#703983 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: I83fe85a50e6e98da02a7c46a9e0c07a043244d56
2014-12-11fdo#81286 : Instant updates in SUM/AVERAGE in status barDeena Francis1-1/+1
Change-Id: I86ec7c73090b93cf080ced2bd5e24d98e2b3ac0e
2014-12-10Deteremine the script type of source cell during paste replication.Kohei Yoshida7-14/+58
Doing this ahead of time eliminates the need to update script types of all replicated cells after the paste. This makes significant performance impact. Change-Id: Ic4f7d7b2fe152bd5640ddb1dae01cc2ed757657e
2014-12-11fdo#86215 pool new ScPatternAttr if source and destination are different docsEike Rathke1-3/+5
Change-Id: Icdb68af83a0b208f9a427ee61ae18020c8835a41
2014-12-10Typo: postion(s)=>position(s)Julien Nabet2-2/+2
Change-Id: Id2957f1cb68fc4b2fef9966abeb6745b548bcb75
2014-12-09remove now unused BROADCAST_ALL_POSITIONS caseEike Rathke1-13/+0
Change-Id: I4e6b362f31d93964567fe9ca394cd96568981746
2014-12-09introduce BroadcastBroadcasters() to speedup BroadcastCells()Eike Rathke3-27/+33
Iterating over a range and attempting to get a broadcaster for each cell position is a performance bottle neck. Take advantage of the column's existing maBroadcasters structure instead. Change-Id: I5467a64ee3c0b5f430be1f0c4b940d3f71874827
2014-12-09add a comment about side effects and whether we want them or notEike Rathke1-0/+4
Change-Id: I9cebe8f7979fd0b502fb23e7048b24a5b9ceb5d4
2014-12-09fdo#39468 Translate German Comments - sc/source/core/data/documen2.cxxChristian M. Heller1-2/+2
Change-Id: I9a426f40f8cdce1f1ebe207dd9ada8154d8fde46 Reviewed-on: https://gerrit.libreoffice.org/12195 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> merge fixes Change-Id: Ibca73c7099739790e1659a24841f168a2c06b71e
2014-12-09changed timers to idleJennifer Liebel1-2/+2
Change-Id: I5846940cc45781f4a0264047107dbb568604d543
2014-12-09changed timers to idleJennifer Liebel1-1/+1
Change-Id: I5846940cc45781f4a0264047107dbb568604d543
2014-12-09fdo#39468 Translate German Comments - sc/source/core/data/documen2.cxxChristian M. Heller1-1/+1
Change-Id: I9a426f40f8cdce1f1ebe207dd9ada8154d8fde46 Reviewed-on: https://gerrit.libreoffice.org/12195 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-12-09fdo#39468 Translate German Comments - sc/source/core/data/documen2.cxxChristian M. Heller1-1/+1
Change-Id: I9a426f40f8cdce1f1ebe207dd9ada8154d8fde46 Reviewed-on: https://gerrit.libreoffice.org/12195 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-12-09changed timers to idleJennifer Liebel1-5/+5
Change-Id: I5846940cc45781f4a0264047107dbb568604d543
2014-12-09activate BROADCAST_BROADCASTERS to speedup SetDirty with rangeEike Rathke2-18/+24
No need to iterate through all cell positions and attempt a broadcast if no one is listening. Instead, broadcast only the cell broadcasters and use AreaBroadcast for the area listeners. Change-Id: I1e666e8ff19ac0715f73d73f54da2e4c8d523173
2014-12-09Don't use of the broken "Software" group interpreterTor Lillqvist1-1/+3
FormulaGroupInterpreterSoftware is known to be broken, says moggi. We should not use it as a fallback to OpenCL. Not sure whether it makes sense, but let's keep it in the code for now. Make using it conditional on setting the environment variable SC_ALLOW_BROKEN_SOFTWARE_INTERPRETER (to any value). Only a developer who wants to work on it should set that. sc::FormulaGroupInterpreter::getStatic() can now return NULL, adapt callers accordingly. This might fix fdo#87119, but I am not able to check, as the document from that bug causes an unrelated assertion for me. Change-Id: I24454f46332014cbcbf696252059b9743f3c84d6
2014-12-09assert the "impossible"Eike Rathke1-10/+34
Change-Id: I5fd2c7635f204bda982f1df58b4c19fe9b12464a
2014-12-09in ScFormulaCell dtor remove cell also from FormulaTrackEike Rathke1-0/+1
It could happen that during a SetDirty/Notify cycle a formula cell is appended to the formula track but not tracked yet so doesn't end up in the formula tree. If it was deleted then without removing it from the track the cell pointer shortly after was moved into the tree, possibly setting pFormulaTree (and/or pEOFormulaTree) to that cell if it was the last cell, and if immediately after that a new ScFormulaCell was allocated at exactly the same memory location it virtually ended up as a successor of itself in the formula tree ... leading to a crash if pCode was accessed in a subsequent RemoveFromFormulaTree because the cell was assumed to be already in the tree. Change-Id: I9d1885a26b85c2331a084b5f89a2d7373cf2df0f
2014-12-09prepare ScColumn::SetDirty() to handle BROADCAST_BROADCASTERSEike Rathke1-6/+43
Change-Id: I61b6912da303b9d71eed142535f3aa0cac1681eb
2014-12-09introduce ScColumn::BroadcastMode instead of bBroadcast, bIncludeEmptyCellsEike Rathke4-18/+23
Not only are multiple boolean parameters ugly, but prepare also for the new broadcasters-only mode yet to be implemented. Change-Id: Ie6383826e76a771b88e7b4b29e5de9a58c598ad5
2014-12-08coverity#735379 annotate to dismiss Copy-paste errorCaolán McNamara1-1/+2
on the basis that it doesn't look obviously wrong to the original author after a once-over Change-Id: If333a17a2a9954d33ebefc6846e40e0e1e29c857
2014-12-08coverity#1257111 Uninitialized pointer fieldCaolán McNamara1-0/+1
Change-Id: I82c771f0ca7d2593a6f34dd84689cf055f9cf3f3
2014-12-08we need the SdrPage for deleting the notes, fdo#86166Markus Mohrhard2-0/+10
The SdrPage that contains the shapes for the note captions is deleted before the notes. Prevent that case by deleting the notes before deleting the SdrPage. Change-Id: I13727cea7df0b033fb386a6a8e20dcadec743335
2014-12-07add ReorderParam.mbHasHeaders to include in Undo range markEike Rathke1-0/+1
Undo Sort did not select/mark the original range if it included header row/column. Change-Id: Ie4c800e7a44fd910c871731673093400c6400e4a
2014-12-07coverity#707985 Uninitialized scalar fieldCaolán McNamara1-0/+1
Change-Id: I1847b2900b513cc9b7b47767a15fb7e11d0abf26
2014-12-07handle all fill cases correctly, fdo#86754Markus Mohrhard1-1/+1
That special case only works if the whole source range contains formula cells. For now we just limit it to the special case of a single source cell. Change-Id: I71ccfde06edd97e5a9c78da22053583d05aac411
2014-12-07improve formattingMarkus Mohrhard1-2/+6
Change-Id: Id652ff18023965cb2bcc7c10520f95a51e8ac15d
2014-12-07we need the original context that contains the data, fdo#85856Markus Mohrhard1-2/+1
Change-Id: I107201ab736b548f010d813540e0a9cec7402e79
2014-12-05Fix incorrect adjustment of range references during sort.Kohei Yoshida4-4/+202
... as a result of the introduction of range-based area listeners. With this change, the insertRangeData() function for ucalc no longer needs the additional bGroupListening flag. All tests pass with group listening enabled at all times. Change-Id: I9b9fb9443c727ff62badbd60ec9cd94094eb5a45
2014-12-05Ctrl+A and Data Sort took ages to broadcast ALL cellsEike Rathke2-12/+13
... now that also empty cells are to be broadcasted. Set dirty and broadcast only the effective data range as determined by Sort. This is more a workaround, a cleaner solution would be to refactor the SetDirty() algorithm to iterate only through broadcasters and use AreaBroadcast() to notify area listeners. However, this can also be easily backported to 4-3. Change-Id: I6d68ca0088cec6a8328a3e93364ac928ef69babe
2014-12-05trim also empty leading column ranges, fdo#81501 follow-upEike Rathke1-1/+4
Change-Id: Ieaeea85149e4b6d263b112205bb17c155e2d12be
2014-12-05actually use identical code for both byRow and byCol, fdo#81501 follow-upEike Rathke1-7/+4
Change-Id: I982e03a12dd80be0787f22dce4495065775e7de0
2014-12-05loplugin:cstylecast, involving pointer to incomplete typeStephan Bergmann2-10/+12
Change-Id: Ib256ed35a9ecb59a07ed31edec9bd8abb31a4610
2014-12-05Fix high memory usage when sorting cells in Calc. (fdo#81501)Supreme Aryal1-0/+2
Empty columns were being unnecessarily included in the sorting range which caused extra allocation. This happens when you select the entire sheet to sort. There was already code to skip empty trailing cells in rows but not to skip empty columns. Change-Id: Ieac22647bb13165cbf66cb1a93f567e5169fff6a Reviewed-on: https://gerrit.libreoffice.org/13294 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-12-05loplugin:unusedvariablecheckStephan Bergmann1-3/+0
Change-Id: I48c2421598152b64d40237eb0e917a680a27b643
2014-12-05-Werror,-WshadowStephan Bergmann1-6/+8
Change-Id: Ia03dc71a3d4e4380258e7f8d2ebc3c9f32d83493
2014-12-05Create 2 variants of SortReorderByRow.Kohei Yoshida1-107/+211
One for IsUpdateRefs() true, the other for IsUpdateRefs() false. Change-Id: I2b18e2b8a9770fd9499dd9fc0d26397e67c1e8ae
2014-12-05Extract this code block into an own function.Kohei Yoshida1-100/+126
This code block is sufficiently self-contained. Change-Id: I0eb2d3ee8175af60394ff4c408a9c245f77044d8
2014-12-05I got the terms 'union' and 'intersection' mixed up.Kohei Yoshida1-6/+6
When I said 'Union' originally, I meant 'Intersection'. Let's fix that. Change-Id: Iaef5035bb1dbb676c63bd17b3650266605104181
2014-12-04impl. Clone for all subclasses of SdrPageDavid Tardon1-0/+23
Change-Id: Ie370161e51ff83cb605bc57d317ff945404e5611
2014-12-04Revert "introduce bool bBroadcast parameter for ScTable::SetDirty()"Eike Rathke2-3/+3
This reverts commit b8a7c39cf26f6d417efc34acdf6f4c2a6762052d. Bah, this was a leftover of an idea I didn't follow..
2014-12-03do not construct an ScAddress on each iterationEike Rathke1-1/+6
Change-Id: I3c89e649c289cd50035929d4025d0c18968b36f9
2014-12-03slightly speed-up things by using ScTable accessEike Rathke1-5/+11
Change-Id: I378cd0e1eaa0f41799e4e18d1daae813540da77d
2014-12-03introduce bool bBroadcast parameter for ScTable::SetDirty()Eike Rathke2-3/+3
Change-Id: I62c3714c8036fe8d4b70ee188546c7d69ece1ea5
2014-12-03remove boolean parameter default from ScDocument::SetDirtyEike Rathke2-5/+5
... and force the caller to make a decision. In fact some needed to include empty cells. Change-Id: I82b6ef72f7ecda6543b3cafc70f475519870b471
2014-12-03get rid of defaulted boolean parameters in ScColumn::SetDirty()Eike Rathke1-1/+1
Change-Id: Iba030c1a4fd3dad34bdd61377b73fa76a062b5f8
2014-12-02Double blank lines...Kohei Yoshida1-1/+0
Change-Id: I826db178ceea4a409ad9e14ff73b5edaf136e435
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-04 16:52:12 +0000