summaryrefslogtreecommitdiff
path: root/sc/source/core/data
AgeCommit message (Collapse)AuthorFilesLines
9 daysSimplify vector initializationsJulien Nabet1-3/+1
Change-Id: Icf8972be204799e9b3b3824ab18d8584911fe1c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117061 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
9 daysSimplify Sequences initializations (sc)Julien Nabet1-5/+3
Change-Id: I0c581b3a900a6b89c0f4e203310d65600545987f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116929 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-04loplugin:unusedmethodsNoel Grandin1-5/+0
Change-Id: I79bd2f0eaa7287f0568366ee5627e11a65d2aec2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116717 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-04tdf#68976 fix paste transposed regression for notes/patternsscito1-19/+20
Starting position was not correctly taken into account for notes/patterns in the initial fix. It worked only for source range starting in A1 (0/0), i.e. a special case. The unit tests tested only this special case. The unit tests are generalized: Starting in B2 instead of A1, i.e. the source range was shifted. The paste destination results remain the same, except absolute references. Change-Id: I2f7bfa9e559d99b173ff833fed3cff21658e0e31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116501 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-06-02no need to allocate these on the heapNoel Grandin3-25/+25
Change-Id: Ie11353c8711e970cc20059227d8283c79e4b126d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116586 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-01no need to allocate these on the heapNoel Grandin5-27/+25
Change-Id: I912b1aafcc615efb87455fa9ba02caf7bef044cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116480 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-31tdf#142402 sc UI: store formatted values in standard filterBalazs Varga2-3/+3
value list and filter by formatted values later, just like we do in the autofilter. Follow-up to commit 4fd1333ba4bb4f2311e9098291154772bd310429 "tdf#140968 tdf#140978 XLSX import: fix lost rounded filters". Change-Id: If26f4c0abd54de05b497861f2c278972bd8072de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116115 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-30crashtesting: on export of fdo84621-4.ods to xlsCaolán McNamara1-0/+6
Change-Id: I0553a7584347e0fc3ebcba6f99e974b9b1d341a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116412 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-29tdf#142201 tdf#142065 fix cut paste transpose references, incl. undoscito4-4/+30
For cut paste transposed, references are not anymore updated during UpdateReference(), but all these references will be updated during UpdateTranspose(). In previous implementation, some references were moved (i.e. updated). This caused problems in UpdateTranspose(). A transposed flag is added to the clipparam. This flag is checked during UpdateReference(). UpdateTranspose() must only operate on (i.e. transpose) references pointing to the source area. That's why updates must not be made during UpdateReference(). Otherwise references pointing to the destination range will be transposed wrongly during UpdateTranspose(). References in formulas as well as in named ranges are fixed and tested. I've added unit tests for all these cases and I've enhanced my previous copy/paste test framework (6491c205acb3c166d93ef6a41199d344e21d98ac) for cut/paste tests, incl. undo. Before LibreOffice 7.2, adjusting of references in cut paste transposed was completely broken (tdf#71058, tdf#68976, tdf#142065 and tdf#142201). Change-Id: I8a8d295f1cc683572905ae9633e16d010cfb8792 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116073 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2021-05-28no need to allocate these on the heapNoel Grandin1-32/+29
Change-Id: I55ecf6b8d9df2078f9bc81f54dbabf425c300643 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116320 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-28tdf#138438 sc: fix "Top 10" autoFilter in multiple columnsBalazs Varga1-51/+54
Check all QueryItems instead of just the first one. Now top 10 values are visible (except the values hidden by the filters of the previous columns). Change-Id: I317d0c6843e568f8645b744968352a0e895a42dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115267 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-24Teach ScOutlineCollection to return an iterator when calling erase, then use itJulien Nabet1-19/+5
Hoping C++11 erase method std::map which returns an iterator is now known for compiler of every env. Change-Id: Ie4f87ce234228209257f7025e197fdf53ea7e69d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116066 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-05-24fix leak in conditional formatNoel Grandin1-1/+1
Change-Id: If44615016ab22f4d9e57845c4b0c9fc90b6d91c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116032 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-21tdf#68976 cut paste transposed: fix wrong position in clipdocscito3-25/+32
The transposed cells were written always in A1 of the transposed clip. This is no problem for copy paste transposed. However, this is an issue for cut paste transposed as references of formulas pointing to cut cells are adjusted according to position changes. The solution is to write the transposed cells in the same top left corner of the transposed clipdoc as in the original non-transposed clipdoc. There are still issues with cut paste transposed: Formula references are not updated correctly in some cases (tdf#142065, tdf#142201). Comprehensive unit tests will follow with fixes for tdf#142065 and tdf#142201. Change-Id: Id691fabf89d7f25e05182b20bd379299fc18fbb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115535 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-21tdf#116413 after Paste Special with ADD and As Link attach dest cellsscito1-0/+6
Change-Id: Icc039a4ea1c02d81d282cb43e7cf40279bea3342 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114641 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-21tdf#71058 cut paste transposed: use correct clipdocscito1-1/+1
ScDocument: :UpdateTranspose() operated on the wrong clipdoc Change-Id: I10fb010c7b6a1d523a1af92d67fc127957f9d17f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115901 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-20tdf#76258 Skip automatic colors in color filter popupSamuel Mehrbrodt1-2/+4
Change-Id: Ic8ed4b2a503c347895668b18744c9fee02d92e81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115815 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-05-18loplugin:unusedfieldsNoel Grandin1-3/+1
Change-Id: Ib574403a7f7f8b11c6263c9c19ec6b65c8374ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115753 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-18loplugin:unusedmethodsNoel Grandin3-46/+0
Change-Id: I8191f4a9eb25b12242354813303fb7d30489d2c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115752 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-17small perf improvement in checking for noteNoel Grandin2-0/+46
Change-Id: Ib92e04da47d910662eb765c9c68b561647570ecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115673 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-16fix leak in ScSubTotalParamNoel Grandin2-19/+12
Change-Id: If839585931fc90b9910f6b95338d59ba48a1a78f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115676 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-13tdf#142214: autoinput: remove search/entry count limitsDennis Francis3-43/+23
Change-Id: Ib41f7c04b9a3802982105cbbfef3ae638bdb286f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115345 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115545 Tested-by: Jenkins
2021-05-13tdf#142214: autocomplete: do not search across empty blocksDennis Francis1-8/+20
Change-Id: Ia5b0be1eed2bf645fa1e53d71abc7b2e67dfaa0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115458 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-05-11change usage of boost::hash_combine to o3tl::hash_combineTomaž Vajngerl1-3/+3
Change-Id: I840518a36ac43d36c95f38e09c7bfcfe1a25a525 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114984 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-11tdf#76258 Various fixes for color filterSamuel Mehrbrodt2-16/+12
Change-Id: Ifb4114597efcb7a957d2e42867d1bdc8abfe7730 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115340 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-05-08ref-count SfxItemPoolNoel Grandin4-10/+12
so we can remove SfxItemPoolUser, which is a right performance hog when we have large calc spreadsheets Change-Id: I344002f536f6eead5cf98c6647dd1667fd9c8874 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115247 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-06add SfxItemPoolDeleter utilityNoel Grandin1-10/+8
add use so we can hold the pool with std::unique_ptr Change-Id: I685fbc37c0ae145a5b48a66a88eab9fb29a0fc0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115174 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-04Related: tdf#140968 avoid duplicated filter valuesBalazs Varga1-2/+4
Group and filter based on the actual cell format, like MSO does, to simplify filtering of values rounded by the cell format (e.g. selecting the single AutoFilter condition "1.0" to filter both 1.01 and 0.99). Followed up of 4fd1333ba4bb4f2311e9098291154772bd310429 (tdf#140968 tdf#140978 XLSX import: fix lost rounded filters) tdf#141916: odf export: Indicating the formatted filter values, by export the XML_DATA_TYPE with XML_TEXT, to avoid bad filtering of formatted filter values. tdf#141775: fix regression of 4fd1333ba4bb4f2311e9098291154772bd310429 (tdf#140968 tdf#140978 XLSX import: fix lost rounded filters) tdf#141915: fix OOXML import of 0.0 filter values of filter conditions by setting it byValue filtering in datauno.cxx. Change-Id: I1c840249ee1ef95aff33a4740b8bf2ebc47f2325 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113314 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-03tdf#76258 Filter by colorsSamuel Mehrbrodt2-6/+58
UI/Logic implementation Change-Id: If7b48219caa466d8a3341bdc4e104d696e8988c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114385 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-05-02tdf#79049 speed up OOXML workbook load (5)Noel Grandin1-0/+21
Sc::NumUtil::isLatinScript is pretty hot, so add a small cache to ScDocumentImport. This takes my load time from 27s to 18s. Change-Id: I51fa891836d678f0d8700653e3a3a095297aeae7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114987 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-02tdf#79049 speed up OOXML workbook load (4)Noel Grandin1-1/+1
Optimise LocaleDataWrapper for reads by initialising the data we in the constructor, so we don't need any kind of locking Reduces load time from 34s to 28s. Change-Id: I4bd3bddb30b70ba015fe5b1372534f9507762b74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114960 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-30tdf#79049 speed up OOXML workbook load (3)Noel Grandin1-4/+8
Exit this loop early if we aren't going to make progress anyhow. This takes the load time from 40s to 34s for me. Change-Id: I31887442cde6e3fc05f1fce10bb3dde9c2b88bf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29loplugin:stringadd simplify some *StringBuffer operationsNoel Grandin3-23/+9
pulled from a larger patch which I created with a more permissive variant of this plugin Change-Id: I7abf1f3f09e84703b6e0e52fe9587dff691b2187 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114875 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29tdf#141970 Revert "tdf#129606: Round the mean of the two subtractions"Mike Kaganski1-2/+1
This reverts commit d5ebe7c3089ab9f4d3fe0707169fc1ce024cdb70, and brings number of inexact values in testing back to lower numbers (see test document in the bug). Change-Id: I5cfb34b7260fc6e4866585af6a2a50e79696eea2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114861 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-29remove support for BITMASK in vcl backendsNoel Grandin1-1/+1
Rather use a proper alpha channel if we need transparency. This is another small step towards merged alpha in our vcl layer. I suspect the intent in a lot of this code was to save memory. Which have been a thing way back then, but these days our backends mostly end up doing a copy-and-convert to a real alpha channel anyway, so the existing code is actually now a pessimisation. Change-Id: I4a2bcbb2f76b841f05bc00580f364492829c69de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114808 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-28tdf#137679 Use Kahan summation for scmatrix operationsdante1-21/+0
May also want implement Kahan sum in there: sc/source/core/tool/arraysumSSE2.cxx sc/source/core/inc/arraysumfunctor.hxx Under some conditions the sum of a pointer type vector may be perforemed by arraysumfunctor on NumericCellAccumulator. arraysumSSE2 implements part of it. This code has been left unmodified. Why the test has been modified: The error was: 238.89000000000001 != 238.89 | 17 th digit IEEE 754 double-precision has 53 log10(2) ≈ 15.955 digits. So it's just noise. Change-Id: I6f84826bf3875be4f444f5eb61854bc1f95769bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114627 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-04-27loplugin:stringadd convert chained append to +Noel Grandin1-1/+1
which can use the more efficient *StringConcat Also fix a crash in stringview plugin which started happening while I working on this. Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-24cid#1477317 Logically dead codeCaolán McNamara1-3/+3
bIsMultiRangeRowFilteredTranspose can only be true if bIncludeFiltered is false so nRowCountInRange is always set from nRowCountNonFiltered, and nRowCountAll is then unused Change-Id: I6b15a9d84b5db475a2ba2e230acc5d09d588dfce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114588 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-24Removed executable permission on C++ fileAndrea Gelmini1-0/+0
Change-Id: Ifaff6a048b9d174a9aa3fc9dabf62c1f8c509eb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114572 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-04-24Removed executable bits on source filesAndrea Gelmini3-0/+0
Change-Id: Ic52623ac8ca6e0758578b7ae57332f0e9c184b5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114573 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-04-24Fix typosAndrea Gelmini1-2/+2
Change-Id: I0a8279429c9e0d884a5e8fbb8f22617832385a53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114574 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-04-23tdf#95554 fix ScDocument::GetClipArea() for rows: use > instead of <scito1-1/+1
I did not write any tests, as the multi range copying to system clipboard has another issue, see tdf#141847 Change-Id: I3af58d68370038274a07d753809fb4ceca9016f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114534 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-04-22tdf#107348 tdf#45958 tdf#141215 tdf#141683 fix filtered/transpose pastescito4-113/+341
Row filtering, Special Paste transposing and multi range selections had various issues. Since the same methods are used in different code paths, I made a unified fix for these issues. Moreover, Special Paste dialog allows the combination of options. There are about 50 test cases for these various combinations of filtering, selection, transposing and pasting options. The following cases are supported and checked in test combinations: * Transposing * Filtering * Multi range column and row selection * All cell types: number, string, formula, rich text, empty * Notes * Formatting patterns (e.g. cell backgrounds and borders) * Empty cell skipping * Special Paste as link * Merged cells * Formula references: * Relative and absolute references * References to rows before and after filtered row * References to filtered row * Double references (e.g. A1:A3) Notably the following cases are fixed and tested: * Transposing of filtered data (tdf#107348) * Copy/Paste of filtered multi range selections (tdf#45958) * Transposing of filtered multi range selections (tdf#107348, tdf#45958) * Notes at different position (tdf#141215 ^) * Transposed multi range selection pasted as link (tdf#141683 ^) ^ = discovered during tests Due to the unit tests, I refactored some code. Mainly, I extracted methods to improve the readability and to avoid code duplication. Change-Id: Iccccd17d3b4deee29ac5fc7c11e17244da0d4054 Change-Id: I43cf630890e0081e55fd04cf2f8e5afdb6d9bebe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114450 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2021-04-21Fix indentationSamuel Mehrbrodt1-1/+1
Change-Id: Ie7190aa94fc62e8e53c06b5edc8b6ecaf43a5531 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114384 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-04-21loplugin:stringadd replace OUStringLiteral temporaries with OUString::ConcatNoel Grandin1-2/+2
Change-Id: I656f06a74d9f0180ae460264563d6a935c7d2c60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114377 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-19use more string_view in comphelper::stringNoel Grandin2-2/+2
Change-Id: I5d27824694e38de540e5f1fcd8704f8777f65140 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114261 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-14tdf#126678 - Consider "Include formats" option during sortAndreas Heinisch3-15/+38
Change-Id: Ib972ad6c5042bde6b0c79bf10bace6baab1e935e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111234 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-04-13tdf#130326 speed up row height calculatedNoel Grandin2-11/+23
for scaled rows. Teach the ForwardIterator to use the slightly faster normal search, and make getRangeData cache the resulting iterator even when doing a tree search. The combination of tree search for the first item, and then using a cached iterator to step through the row data is fairly fast. Take my load time from 23s to 22.3s Change-Id: Icd1aa3d3a8022a073b125dfc05a670b75da1837e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-12tdf#130326 speed up XLSX load in ScFlatSegmentsImplNoel Grandin1-27/+80
since we are iterating over the tree, use an iterator to speed up subsequent lookups. Takes my load time from 26.2s to 24.3s Change-Id: Iac86c9f60d447cb7679913a0585c9631f845c3e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-11ofz#32908 avoid TimeoutCaolán McNamara1-2/+3
Change-Id: I560a5ff4caf204cc46d6cfb5f7680328295020fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113949 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>