summaryrefslogtreecommitdiff
path: root/filter
AgeCommit message (Collapse)AuthorFilesLines
2019-08-23Mark move ctors/assignments noexceptMike Kaganski1-1/+1
This should enable using move semantics where possible e.g. in standard containers. According to https://en.cppreference.com/w/cpp/language/move_constructor: To make strong exception guarantee possible, user-defined move constructors should not throw exceptions. For example, std::vector relies on std::move_if_noexcept to choose between move and copy when the elements need to be relocated. Change-Id: I6e1e1cdd5cd430b139ffa2fa7031fb0bb625decb Reviewed-on: https://gerrit.libreoffice.org/77957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-21tdf#126761 add missing underline of hyperlink when showing ppt documentnd1011-0/+4
For ppt document opened in Impress, the familiar underline property is missing. This is to fix that. Underline property is added when ppt document is being opened and saved to exported odp document. Change-Id: I8ba02da8ffa1c8e7833645f850cddef84f0fa476 Reviewed-on: https://gerrit.libreoffice.org/77141 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-20loplugin:constvars in drawinglayer..frameworkNoel Grandin4-9/+9
Change-Id: I6e62229fdc38f49f766a306f5264afafe9acefa5 Reviewed-on: https://gerrit.libreoffice.org/77774 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-19Fix typosAndrea Gelmini1-1/+1
Change-Id: I5e7cbd49e8bd7d9d6957508f8c8534653854cb3c Reviewed-on: https://gerrit.libreoffice.org/77679 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-17Fix typosAndrea Gelmini3-3/+3
Change-Id: I3f7feca68e10e53ac1a6bce2b3920fa0a142a5ef Reviewed-on: https://gerrit.libreoffice.org/77628 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-17tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorJulien Nabet5-26/+6
in embeddedobj and filter Change-Id: I2da3fa1df8782e449852358d1c86f5e4bc79ea1a Reviewed-on: https://gerrit.libreoffice.org/77627 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-16use more TOOLS_WARN_EXCEPTIONNoel Grandin3-6/+3
Change-Id: Ic21ea11ff106e0732bb8fa600ef39a549d7bda86 Reviewed-on: https://gerrit.libreoffice.org/77569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-16new loplugin:sequenceloopNoel Grandin2-4/+4
look for places we should be using std::as_const on for-range loops over uno::Sequence, to avoid triggering a copy Change-Id: I7efb641bf09d37c87946f03428ee4eec90298c8a Reviewed-on: https://gerrit.libreoffice.org/77441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15replace ".get->" with "->"Noel Grandin1-7/+7
Change-Id: I327a6fda1fe0170da33e06b735f09a39421c8a58 Reviewed-on: https://gerrit.libreoffice.org/77469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-12Fix typosAndrea Gelmini1-4/+4
Change-Id: Id20e239b8a5a2dababe9284dc30d4d155ffecfc5 Reviewed-on: https://gerrit.libreoffice.org/77322 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-12Fix typosAndrea Gelmini3-6/+6
Change-Id: Ibd802e81649373fd9ad6d0309276b8e6ae43dd24 Reviewed-on: https://gerrit.libreoffice.org/77261 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini1-2/+2
Change-Id: Id465a50e53b35d259a3fde91bfad35cebf1ce064 Reviewed-on: https://gerrit.libreoffice.org/77263 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini1-2/+2
Change-Id: I94d0e85c731801b8b0ec844ae2a8f268b2f1022e Reviewed-on: https://gerrit.libreoffice.org/77256 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini1-1/+1
"its" Change-Id: I02c660e46964270376a66210fdb5f1b1985ce5b6 Reviewed-on: https://gerrit.libreoffice.org/77255 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typosAndrea Gelmini1-1/+1
Change-Id: I4bd004af206813b9dc01c50ab20f2e8b954b8dca Reviewed-on: https://gerrit.libreoffice.org/77323 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-10Fix typosAndrea Gelmini1-1/+1
Information is always singular Change-Id: I55275d7c2fd76c3ec0ae4a98aa952777feb90460 Reviewed-on: https://gerrit.libreoffice.org/75645 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-09Fix typosAndrea Gelmini1-1/+1
"its really" Change-Id: Ic0b41597c83be6c1c66b9cdf6ccbf80b0c2bc9ef Reviewed-on: https://gerrit.libreoffice.org/77204 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-09Fix typoAndrea Gelmini2-2/+2
"Inherting" Change-Id: Ib9b1fcfd9ef585149de5018ce650707c71d412c8 Reviewed-on: https://gerrit.libreoffice.org/77127 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-08tdf#74702: use OutputDevice::GetBackgroundColor()Chris Sherlock1-1/+1
Apply the Liskov substitution principle to OutputDevice::GetBackgroundColor(). This helps in SmTmpDevice::Impl_GetColor() because it no longer needs to know about what type of OutputDevice it is calling to get the background color. This forced a rename of basctl::ModulWindowLayout::GetBackgroundColor() to be GetSyntaxBackgroundColor(), but this is a happy coincidence as it makes the function intent clearer anyway. Change-Id: I11298a63cb01c187f3a8a4a2c9e90eacda6c3e6b Reviewed-on: https://gerrit.libreoffice.org/75521 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-08-07tdf#126642 always allow PDF/A form exportJan-Marek Glogowski3-76/+56
This generally enables form export for PDF/A. A major problem was the saved user setting for UseTaggedPDF, which was overridden by the PDF/A export and used to be stored in the user config. At this point it was impossible to actually restore the user config for the next export, because it contained the overwritten PDF/A value. So this now guarantees that the user selection is stored, which means the underlying filter reading the config has to ignore the users UseTaggedPDF setting for PDF/A, which is happening in any way. That way it is possible to correctly restore the previous user selection after unchecking the PDF/A option. And the "Create form" frame is kept sensitive, just based on the "Create form" checkbox. Change-Id: I29162b423b2d8de77f549fdaabf0aefebcefa124 Reviewed-on: https://gerrit.libreoffice.org/76765 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-08-05Make "PDF/A" strings untranslatableSamuel Mehrbrodt1-2/+2
Change-Id: I76c83ef7b4f7fe8f8eeb61e27df198694d821cff Reviewed-on: https://gerrit.libreoffice.org/76861 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-05CppCheck: solve 'redundantAssignment' in msdffimp.cxxRegina Henschel1-1/+0
Change-Id: I6b1549e3033187b44e3225f17fc4fdba4e52fa0c Reviewed-on: https://gerrit.libreoffice.org/76962 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-08-02Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic7b6014e09e3ee1a1b4917008a267b8fa2dbc1f5 Reviewed-on: https://gerrit.libreoffice.org/76814 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-31Fix typosAndrea Gelmini1-1/+1
Change-Id: I3a877a8eb0babb9d04ac9750494576869481c8db Reviewed-on: https://gerrit.libreoffice.org/76763 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-31tdf#54908 Make selection active if there's a selection (Writer)Daniel Silva1-3/+9
If the user make a selection in Writer and then opens print dialog or PDF export dialog, Print Selection is the default option. Change-Id: I46ba90cfeabafef1c05dd3e5008ecf55f177a146 Reviewed-on: https://gerrit.libreoffice.org/64804 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): filterStephan Bergmann24-75/+75
Change-Id: I469205ac250bb78c626c8d237b6eea9445617f04 Reviewed-on: https://gerrit.libreoffice.org/76677 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-25Fix typosAndrea Gelmini1-1/+1
Change-Id: I1efccb8b926e4aa10e9ccee7e8e36919e38c05fc Reviewed-on: https://gerrit.libreoffice.org/76339 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-25Make pdf export watermarks look like watermarks on onlinemerttumer1-13/+42
Change-Id: Ib5af8c61dd9a539c63594a91b8ec17ff07327feb Signed-off-by: merttumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/69317 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/76289 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24cid#1448519 Untrusted loop boundCaolán McNamara1-4/+13
Change-Id: I92952fdef3e1066082d7ba8c3befebfcb7f9adc1 Reviewed-on: https://gerrit.libreoffice.org/76242 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-23Resolves: tdf#126460 implement reading grayscale+alpha tiff formatCaolán McNamara1-13/+40
Change-Id: I3300ae21c74f5a25c767ce643e93d2232f3b9381 Reviewed-on: https://gerrit.libreoffice.org/76123 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-21ofz#15993 TimeoutCaolán McNamara1-0/+4
massive nSamplesPerPixel value, tiff spec says samples-per-pixel is supposed to be SHORT so don't accept beyond that as legal Change-Id: I3e6d3550e3b07a8d27ec4d72ecc4549dd52e50bc Reviewed-on: https://gerrit.libreoffice.org/76075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-20cid#1448337 Unchecked return value from libraryCaolán McNamara1-4/+0
Change-Id: Idac1d04e725f3e6e96d0ec6e83fcba3086c7a5fc Reviewed-on: https://gerrit.libreoffice.org/76007 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19loplugin:referencecasting in filterNoel Grandin12-41/+28
Change-Id: Ia437fa8f18052afa2b70dfedc1b4badcfd165d6a Reviewed-on: https://gerrit.libreoffice.org/75956 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19cid#1448509 Unchecked return value from libraryCaolán McNamara1-1/+1
Change-Id: Idda609ca8f1cad0e2a703b0b6ba3b0a2b661874b Reviewed-on: https://gerrit.libreoffice.org/75901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448337 Unchecked return value from libraryCaolán McNamara1-4/+0
Change-Id: Ie43cc1888179340318ddefb7fa4ba5f0bc1dc896 Reviewed-on: https://gerrit.libreoffice.org/75879 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448237 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: Ic53196270ececf407d75c2f76998253adf396c64 Reviewed-on: https://gerrit.libreoffice.org/75848 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#703960 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: I679e9e91261d468f2f2ee08f840ac3043d87817c Reviewed-on: https://gerrit.libreoffice.org/75839 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#703956 Unchecked return valueCaolán McNamara1-5/+5
Change-Id: Ide2d83962c0a03e410443164f80522b2913ab998 Reviewed-on: https://gerrit.libreoffice.org/75838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448499 less obscure comparison against endCaolán McNamara1-1/+1
Change-Id: I6eda7d9ec8d7781cbea191eb2fd2429722a4823a Reviewed-on: https://gerrit.libreoffice.org/75830 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18Resolves: tdf#126147 relax sanity check and allow truncated tiffsCaolán McNamara1-5/+6
now the start of the row of data must still exist, but the full length of the row doesn't have to exist Change-Id: I5ed8ffef2cab19f040ba789a5d82560ca6847f26 Reviewed-on: https://gerrit.libreoffice.org/75793 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17Fix typoAndrea Gelmini1-1/+1
since... commit a570bbbf2e9ba3dbbcbb77ec7b469162c02edddf Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Jun 13 09:49:04 2011 +0100 mpCommentOut never set, strip it out Change-Id: I9c056119f1d060cfacd9872e74b41e2fb490caa4 Reviewed-on: https://gerrit.libreoffice.org/73014 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-16write out empty state explicitly in writeRectangleNoel Grandin1-2/+2
this is purely an internal XML format, so we can change it Change-Id: I9e2a4350c6c3f51031742e94823ea052dd73c8df Reviewed-on: https://gerrit.libreoffice.org/75639 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-08use BitmapEx in OS2METReaderNoel Grandin1-3/+3
Change-Id: I03750087174488f1debb2c33e55effe956a59e1d Reviewed-on: https://gerrit.libreoffice.org/75213 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-04remove some unneede vcl/bitmap.hxx includesNoel Grandin2-2/+0
Change-Id: Ibdc79538276992193e61f6dc16ddd3fd1ab80b82 Reviewed-on: https://gerrit.libreoffice.org/75069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-01tdf#62728 Provide both A/1 and A/2 in PDF export dialogThorsten Behrens3-34/+110
Followup commit to ed4a0eed82e2f, adding back the A/1 option. Change-Id: I9f509cb77f045de260bc22fc494fe4ecaac29bbc Reviewed-on: https://gerrit.libreoffice.org/74941 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-06-25improve loplugin:simplifyconstructNoel Grandin2-4/+3
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-24Don't convert from double to sal_Int32 when target is longStephan Bergmann1-1/+1
...which avoids, at least for platforms where long is larger than sal_Int32, some -fsanitize=float-cast-overflow when loading caolan/sw_ww8graf_mungetextintodrawbox_null_ptr_deref.sample (from the crashtestdata files), which reads huge (crafted?) values for some of l, o, r, u. (The casts to sal_Int32 had been there ever since at least d2000efb31f864e912c6cf52760eea0e602b6893 "#i106421#: move msfilter to filter", but there appears to be no good reason for that.) Change-Id: I1c8a874af6f0a0db7707612fe22bf06dfe832877 Reviewed-on: https://gerrit.libreoffice.org/74638 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-23Fix typoAndrea Gelmini1-1/+1
Change-Id: I1586aa67c51a54e5a244126763be0a549a2fe7a6 Reviewed-on: https://gerrit.libreoffice.org/73135 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-06-23Fix typoAndrea Gelmini1-12/+12
Change-Id: If1f6d73088e87db6e91916ba338725054f63b5ac Reviewed-on: https://gerrit.libreoffice.org/73231 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-21Drop INetURLObject::GetName and INetURLObject::GetExtensionMike Kaganski2-6/+6
They are just synonyms for GetLastName and GetFileExtension resp. Change-Id: Ic498c7025cc421b830394ed94d64529fd74fe7dd Reviewed-on: https://gerrit.libreoffice.org/74448 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-20 10:02:49 +0000