summaryrefslogtreecommitdiff
path: root/filter
AgeCommit message (Collapse)AuthorFilesLines
2019-06-25improve loplugin:simplifyconstructNoel Grandin2-4/+3
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-24Don't convert from double to sal_Int32 when target is longStephan Bergmann1-1/+1
...which avoids, at least for platforms where long is larger than sal_Int32, some -fsanitize=float-cast-overflow when loading caolan/sw_ww8graf_mungetextintodrawbox_null_ptr_deref.sample (from the crashtestdata files), which reads huge (crafted?) values for some of l, o, r, u. (The casts to sal_Int32 had been there ever since at least d2000efb31f864e912c6cf52760eea0e602b6893 "#i106421#: move msfilter to filter", but there appears to be no good reason for that.) Change-Id: I1c8a874af6f0a0db7707612fe22bf06dfe832877 Reviewed-on: https://gerrit.libreoffice.org/74638 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-23Fix typoAndrea Gelmini1-1/+1
Change-Id: I1586aa67c51a54e5a244126763be0a549a2fe7a6 Reviewed-on: https://gerrit.libreoffice.org/73135 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-06-23Fix typoAndrea Gelmini1-12/+12
Change-Id: If1f6d73088e87db6e91916ba338725054f63b5ac Reviewed-on: https://gerrit.libreoffice.org/73231 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-21Drop INetURLObject::GetName and INetURLObject::GetExtensionMike Kaganski2-6/+6
They are just synonyms for GetLastName and GetFileExtension resp. Change-Id: Ic498c7025cc421b830394ed94d64529fd74fe7dd Reviewed-on: https://gerrit.libreoffice.org/74448 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-20Demote from std::unique_lock to std::scoped_lock where applicableStephan Bergmann2-4/+4
Change-Id: I53a019f05978bab62ad0da3d0eb08f37f8ec1e18 Reviewed-on: https://gerrit.libreoffice.org/74414 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-18tdf#42949 Fix IWYU warnings in include/svx/[t-v]*Gabor Kelemen2-0/+2
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I345b8c54890b5bc27f51addd2e6e73ba68b6b327 Reviewed-on: https://gerrit.libreoffice.org/73977 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-17Add comphelper::getUnoTunnelImplementation templateArkadiy Illarionov3-7/+7
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_* Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596 Reviewed-on: https://gerrit.libreoffice.org/74107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-16loplugin:logexceptionnicely in filter..frameworkNoel Grandin7-21/+21
Change-Id: I8cf70ee278c641767e3fcfcfd151d99d791b3468 Reviewed-on: https://gerrit.libreoffice.org/74098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-14Fix typoAndrea Gelmini1-1/+1
Change-Id: I679707594b40e35ea5c503c0c0a6f37520eedce6 Reviewed-on: https://gerrit.libreoffice.org/74000 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-12Fix typoAndrea Gelmini1-1/+1
Change-Id: Iea68ab62c463bace3a625059193ef84980e18b65 Reviewed-on: https://gerrit.libreoffice.org/73854 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-12Fix typoAndrea Gelmini1-1/+1
Change-Id: I414eb13f1ef44df828f68ee8624139a3ee31789b Reviewed-on: https://gerrit.libreoffice.org/73853 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-11tdf#125591 DOC import: lazy-load metafiles with explicit sizeMiklos Vajna1-3/+5
Regression from commit 69b62cfcbd364d7f62142149c2f690104b217ca1 (tdf#125281 DOC import: fix size of lazy-loaded metafiles, 2019-05-27), the problem is that setting the preferred size of a Graphic swaps it in. Avoid this by extending ImportUnloadedGraphic(): if a size hint is provided, then that will be used instead of info from the graphic descriptor (which is usually only meaningful for bitmaps). This way we maintain the correct size and we're back to lazy-loading metafiles from binary MSO files as well. Change-Id: Ide12d12166110e98ea47b5347dd24fb203b22da3 Reviewed-on: https://gerrit.libreoffice.org/73798 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-11tdf#42949 Fix IWYU warnings in include/svx/[sS][v-Z]*Gabor Kelemen3-0/+6
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie2a4122d67d2d40732e6fd00b584f33edd802c5b Reviewed-on: https://gerrit.libreoffice.org/73476 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-07tdf#42949 Fix IWYU warnings in svl/Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Except source/svdde/* which is WIN-specific Also recheck include/svl Change-Id: I32d3bcb6b14665c56c07a2f10526329b08c64cbe Reviewed-on: https://gerrit.libreoffice.org/73630 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-04Fix typoAndrea Gelmini1-1/+1
Change-Id: Ia6977b47c3011e18827e173a2f95e5caa04ba774 Reviewed-on: https://gerrit.libreoffice.org/73418 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-03Fix typoAndrea Gelmini1-1/+1
Change-Id: I9814df646801d2ffd7075aaa18b3682dbc0d86ab Reviewed-on: https://gerrit.libreoffice.org/73359 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-03Fix typoAndrea Gelmini1-1/+1
Change-Id: I026989d991cdc7d114e37a5eecc4b34f1926ba45 Reviewed-on: https://gerrit.libreoffice.org/73360 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-03Fix typoAndrea Gelmini1-4/+4
Change-Id: I5598ed9aca8c985b1783928f74a143ef08e2c369 Reviewed-on: https://gerrit.libreoffice.org/73357 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-02Fix typoAndrea Gelmini1-1/+1
Change-Id: I5980ec748c24f7ee7bade6990b7cd1fbda031ca2 Reviewed-on: https://gerrit.libreoffice.org/73332 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-02Fix typoAndrea Gelmini1-5/+5
Change-Id: I130dc6e40ea5a36d9f4ed3ed7d320d54ec079ea0 Reviewed-on: https://gerrit.libreoffice.org/73334 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-02Fix typoAndrea Gelmini1-5/+5
Change-Id: I21ca20fcdcf01575bf0d9c8820233674381ff1dd Reviewed-on: https://gerrit.libreoffice.org/73338 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-02Fix typoAndrea Gelmini1-1/+1
Change-Id: Ib6d7fd321e69a34a074d12c2b5ec729443123bd7 Reviewed-on: https://gerrit.libreoffice.org/73346 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-02Fix typoAndrea Gelmini1-7/+7
Change-Id: I2d98e82f281d30d5d9e069a62d0876f64a1f5074 Reviewed-on: https://gerrit.libreoffice.org/73347 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-02Fix typoAndrea Gelmini1-2/+2
Change-Id: Idce24d0e177d3c1c13e2ff10471c35fc5d8fad61 Reviewed-on: https://gerrit.libreoffice.org/73341 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-02Fix typoAndrea Gelmini1-1/+1
Change-Id: Iac47302dcdc7bb0ee09b0f0c7ed2ef92c02bb1bc Reviewed-on: https://gerrit.libreoffice.org/73348 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-02Fix typoAndrea Gelmini1-1/+1
Change-Id: If98e6c89866902c4064c47ef513ca2e759f2b471 Reviewed-on: https://gerrit.libreoffice.org/73329 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-02Fix typoAndrea Gelmini1-2/+2
Change-Id: Ied4c82e2ad27667eec20bbb072b3649360473841 Reviewed-on: https://gerrit.libreoffice.org/73327 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-31Switch Office filters to mention “perpetual” Office 365 instead of ↵Adolfo Jayme Barrientos20-20/+20
one-off 2019 Change-Id: I5fdb85679d869e75fc4bf583f53f15fb933c289d
2019-05-31Use hasElements to check Sequence emptiness in [e-i]*Arkadiy Illarionov6-12/+11
Similar to clang-tidy readability-container-size-empty Change-Id: I79e31919db8f4132216f09a7868d18835eeb154b Reviewed-on: https://gerrit.libreoffice.org/71795 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-31Fix typoAndrea Gelmini1-8/+8
Change-Id: Idc95790ec29502c65db8b2f4cf1eda24a167a924 Reviewed-on: https://gerrit.libreoffice.org/73236 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-31Fix typoAndrea Gelmini1-3/+3
Change-Id: I117ada6da2e61bea269e513d3f46c63a88316ad7 Reviewed-on: https://gerrit.libreoffice.org/73234 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-31Fix typoAndrea Gelmini1-2/+2
Change-Id: I5f7e6e52bb0826fc46ca842417e946633359dff8 Reviewed-on: https://gerrit.libreoffice.org/73237 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-31Fix typoAndrea Gelmini1-1/+1
Change-Id: Ie3774885344241983e3b6fd952b59cb01fe18ad3 Reviewed-on: https://gerrit.libreoffice.org/73230 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-31Fix typoAndrea Gelmini1-1/+1
Change-Id: Iac448f27693b428011074c83af7c2164bc0d1a31 Reviewed-on: https://gerrit.libreoffice.org/73233 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-31Fix typoAndrea Gelmini1-3/+3
Change-Id: Ie0dfc53d2de8e4eb48eb55b5b32d8c2eb55df0d3 Reviewed-on: https://gerrit.libreoffice.org/73229 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-31Fix typoAndrea Gelmini1-1/+1
Change-Id: I8f4b9cbeee814b4b464f72e11ca5bf5ada78c344 Reviewed-on: https://gerrit.libreoffice.org/73235 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-31Fix typoAndrea Gelmini1-2/+2
Change-Id: Ic53f1f1aacff2b91c987c18258d904ea24114216 Reviewed-on: https://gerrit.libreoffice.org/73232 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-31Fix typoAndrea Gelmini1-7/+7
Change-Id: I562f3e1d952e1b882643535b4ebb6b0067df5fc1 Reviewed-on: https://gerrit.libreoffice.org/73224 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-31Fix typoAndrea Gelmini1-1/+1
Change-Id: I27d457eb2af8ff8ef297dd97923acf4978eac2d7 Reviewed-on: https://gerrit.libreoffice.org/73228 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-29Fix typoAndrea Gelmini1-1/+1
Change-Id: Ib504a5243edd5df96a0f4ff8f7f846e83d384a7b Reviewed-on: https://gerrit.libreoffice.org/73130 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-29Fix typoAndrea Gelmini1-2/+2
Change-Id: Ic94aaada392b197e3fa955ec5b51ca8106347a38 Reviewed-on: https://gerrit.libreoffice.org/73133 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-29Fix typoAndrea Gelmini1-1/+1
Change-Id: Ibfaba910db1ef59af68f57e52a683b5ef147e5a6 Reviewed-on: https://gerrit.libreoffice.org/73132 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-29Fix typoAndrea Gelmini1-1/+1
Change-Id: I217ece9296e5e5d8db264a3590e5af1f8ab0cfcb Reviewed-on: https://gerrit.libreoffice.org/73134 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-29Fix typoAndrea Gelmini1-1/+1
Change-Id: I3414f8badfbab89d0cab72e51fb4dcafc85b35e4 Reviewed-on: https://gerrit.libreoffice.org/73136 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-29Fix typoAndrea Gelmini1-1/+1
Change-Id: I5ce7f422fc6d26eb451ba43fe7bc6f8a540e7d8a Reviewed-on: https://gerrit.libreoffice.org/73131 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-29Fix typoAndrea Gelmini1-1/+1
Change-Id: Ib1af986d52bbc4ea7e2ee7dc5964da81e6508265 Reviewed-on: https://gerrit.libreoffice.org/73137 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-28Fix typos (including sequenze->sequence)Andrea Gelmini1-4/+4
Change-Id: Icfd6c5cbc405bad51a0d7f10cdb55c70a1fe5b00 Reviewed-on: https://gerrit.libreoffice.org/73078 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-05-28tdf#125281 DOC import: fix size of lazy-loaded metafilesMiklos Vajna1-0/+5
Metafiles may have an external header, so once graphic data is read, we need to set the size explicitly. Otherwise the width of the EMF image in the bugdoc will be too small. Change-Id: I2441eda61278b0f4973db5d9aa14618ccd17c397 Reviewed-on: https://gerrit.libreoffice.org/73064 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-27Fix typoAndrea Gelmini1-3/+3
Change-Id: I15300dc1055ccea72766a71cfa2397f0332e2806 Reviewed-on: https://gerrit.libreoffice.org/73007 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>