summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)AuthorFilesLines
2014-03-07coverity#735418 Logically dead codeCaolán McNamara1-4/+3
Change-Id: Iad5d984cd923758daee8d5d6d76694586a34b9e0
2014-03-07coverity#982456 Dereference after null checkCaolán McNamara1-3/+3
Change-Id: I7222d394c47b73b8a84cd069fed3eb268090a70b
2014-03-06coverity#1190356 Dereference null return valueCaolán McNamara1-4/+14
Change-Id: I9a857423cd190b2da9f535e8897a9c9baba40b73
2014-03-05Simplify DrawWaveKeith Curtis1-13/+3
This patch simplifies the DrawWave logic. Callers of that code would try to figure out what size wave to draw and pass down a style integer to DrawWaveLine, but DrawWaveLine already has logic which trims the height of the wave so it doesn't need the hint. This doesn't change the UNO API (::com::sun::star::awt::FontUnderline::SMALLWAVE), but it does get rid of internal usages and maps those small waves to normal. Note that changing the zoom in Calc right now causes spelling underlines to disappear. That bug is not related to these changes. Conflicts: editeng/source/editeng/impedit3.cxx Change-Id: I3caa2a74a0f5228b924d4e1b0a77f96eaef5fa00 Reviewed-on: https://gerrit.libreoffice.org/8168 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-03-05made ListBox handle more than 64k elements, fdo#61520 relatedEike Rathke1-3/+3
ListBox and related now handle up to sal_Int32 elements correctly. sal_Int32 instead of sal_Size or size_t because of UNO and a11y API. Also disentangled some of the mess of SvTreeList and other containers regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures. Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a Reviewed-on: https://gerrit.libreoffice.org/8460 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05remove unused code SvxNumRule::Create(SvStream&)Noel Grandin1-5/+0
Change-Id: I82205010e613a07df24f22071eec74f53578671d
2014-03-05remove unused code SvxNumberFormat::Create(SvStream&)Noel Grandin1-5/+0
Change-Id: If8cfea11552bf008ab4381ecec50aadf58a98a45
2014-03-05remove unused code accessibility::AccessibleParaManager::Release(int)Noel Grandin1-14/+0
Change-Id: I1f3bbd1baf16c27fb5c01055295ccabb3d6eb3d7
2014-03-05remove unused code editeng::MisspellRange::MisspellRange()Noel Grandin1-1/+0
Change-Id: Id137b4789652ca54290106a33d2c230723834a52
2014-03-05remove unused code editeng::Section::Section()Noel Grandin1-2/+0
Change-Id: I1201ebf5f97f95690835d343be8d1b6f5382dbe6
2014-03-04fdo#75260: Correctly draw double lines for both Writer and Calc.Kohei Yoshida2-1/+6
Fix all sorts of incorrect double line handling in drawinglayer in order to draw thick-thin double line types correctly. Also change handling of border lines in writer tables. There are still some outstanding issues but it's much better than how it was before. Also realized that Word and Excel handle simple thin double lines differently; Word varies widths of all of the lines and the gap whereas Excel only has one fixed size for its double line. For this reason I decided to add a separate double line type (DOUBLE_THIN) to handle Excel's double line. Change-Id: Iaaa353b6e4f998b524262bea59260b4333e0cdb4
2014-03-04fdo#54938: Convert some places to use cppu::supportsServiceMarcos Paulo de Souza1-21/+3
The last cases are non obvious, so it's pratically done Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547 Reviewed-on: https://gerrit.libreoffice.org/8445 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-03-03editeng: sal_Bool->boolNoel Grandin4-12/+12
Change-Id: I51b4ae54c2c440d38879439f74d4fea39d243004
2014-03-03editeng: sal_Bool->boolNoel Grandin1-5/+5
Change-Id: Icfda5e8e774b9b5a6c3d99b636e4ce772b93139d
2014-03-03editeng: sal_Bool->boolNoel Grandin2-28/+28
Change-Id: I767aa3d25f6d18e8a6e23b4d3f8d038d581ac292
2014-03-03editeng: sal_Bool->boolNoel Grandin2-17/+17
Change-Id: I4fc276e320294d57eb667b6db8e5eff078bc28b3
2014-03-03editeng: sal_Bool->boolNoel Grandin3-5/+5
Change-Id: I26b1fe14023737b85bcf23628e4881c8be79f071
2014-03-03editeng: sal_Bool->boolNoel Grandin1-2/+2
Change-Id: I0aa375d35c796cfa1929f9c0e735eaaa05561ee4
2014-03-03editeng: sal_Bool->boolNoel Grandin5-95/+81
this had to be done in conjunction with changing include/svx/unoshtxt.hxx because there are two virtual methods "bool IsValid" in two different base classes and some subclasses are overriding both base-class methods at once. Change-Id: Ib43fc5000b443057caaa513b4efeaa6fd16e4260
2014-03-02WaE sign/unsigned compNorbert Thiebaud1-2/+2
Change-Id: I12cb5aa89caa3670101f4632701e33851885c1db
2014-03-02Fix editeng missing spellchecking redline on loadNorbert Thiebaud4-41/+37
Change-Id: I16bfbff85978702c93932d723180a7f9166bd39e
2014-03-02Add EditPaM::operator !() and simplify EditSelection::IsInvalidMatteo Casalin2-8/+2
Change-Id: Id47d77e63eff2267f5e4112b88dfb90c3ec95bd8
2014-03-02sal_Bool to bool and some optimizationsMatteo Casalin2-10/+4
Change-Id: I6a42b78caaff962368b83def8e291d6b6c50abb1
2014-03-02Return value of EditSelection::Adjust is never usedMatteo Casalin2-9/+5
Change-Id: I32770f34819cf737beeef4d22a26538d9ac357a5
2014-03-02sal_Bool to bool, with some optimizationsMatteo Casalin2-33/+17
Change-Id: Ia1c73cf97e93a999147ce82ebb18767743adf2fc
2014-03-02Use EditSelection::HasRangeMatteo Casalin1-2/+2
Change-Id: I6be00dc99e40bb190647cd5007431d4cca750024
2014-03-02Avoid temporaries just used as return valueMatteo Casalin1-4/+2
Change-Id: I4b7fc7103cac3acd5561754fc15b7f7b40c041fe
2014-03-02Use existing method instead of hand-writingMatteo Casalin1-5/+1
Change-Id: If28620d1e0c8b719e2d0de41831e52b238113308
2014-03-02EditLine::CalcTextSize - nIndex is updated but never readMatteo Casalin1-3/+0
Change-Id: Iec96535e154e0467fe5e89264782efa30837bff9
2014-03-02Avoid a check and use plain arithmeticMatteo Casalin1-5/+2
Change-Id: Ie475a6f7d523d5aa6c0ef1952adce56caeac347b
2014-03-02Use OUStringBuffer instead of rtl_uString in EditDoc::GetTextMatteo Casalin1-17/+12
Change-Id: I292c2b726de3e6c27f05fdf7612fe057ae9f94ad
2014-02-28fdo#63154 Remove unused solar.hAlexandre Vicenzi1-2/+0
Removed from dbaccess. editeng, filter, framwork, formula, lotuswordpro, reportdesing, rsc, uui Conflicts: framework/source/uielement/menubarwrapper.cxx reportdesign/inc/RptDef.hxx uui/source/iahndl.hxx Change-Id: Ia6f1d8679736c3de99bd8060d8a7f76975268273 Reviewed-on: https://gerrit.libreoffice.org/8118 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-28sal_Bool -> bool in mostly vcl moduleChris Sherlock2-2/+2
Conflicts: include/vcl/settings.hxx svtools/source/table/tablecontrol_impl.cxx sw/source/core/frmedt/fecopy.cxx vcl/inc/canvasbitmap.hxx vcl/inc/headless/svpframe.hxx vcl/inc/unx/salframe.h vcl/inc/win/salframe.h vcl/inc/win/salprn.h vcl/inc/win/salvd.h vcl/osx/DragSource.cxx vcl/osx/DragSource.hxx vcl/osx/DropTarget.cxx vcl/osx/DropTarget.hxx vcl/osx/OSXTransferable.cxx vcl/osx/OSXTransferable.hxx vcl/osx/clipboard.cxx vcl/osx/clipboard.hxx vcl/osx/salprn.cxx vcl/qa/cppunit/canvasbitmaptest.cxx vcl/source/components/fontident.cxx vcl/source/control/edit.cxx vcl/source/control/spinfld.cxx vcl/source/gdi/gdimtf.cxx vcl/source/gdi/virdev.cxx vcl/source/helper/canvasbitmap.cxx vcl/source/window/dockwin.cxx vcl/unx/generic/dtrans/X11_selection.hxx vcl/unx/kde/UnxFilePicker.cxx vcl/unx/kde/UnxFilePicker.hxx vcl/unx/kde4/KDE4FilePicker.cxx vcl/unx/kde4/KDE4FilePicker.hxx vcl/unx/kde4/KDESalFrame.hxx Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0 Reviewed-on: https://gerrit.libreoffice.org/8219 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28remove unused code EditTextObjectImpl::SetParaAttribs(int, SfxItemSet const&)Noel Grandin2-11/+0
Change-Id: I7a021c6e33161b09707d3bbdfbf4b3eb2d941f45
2014-02-27Remove visual noise from editengAlexander Wilms33-271/+271
Change-Id: Id7582119a5628cb7f54347678580ce7e47f6d703 Reviewed-on: https://gerrit.libreoffice.org/8255 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27editeng: sal_Bool->boolNoel Grandin6-14/+14
Change-Id: Ic59e48341f69b8c6e6fe77b05eeebac56a2c53e7
2014-02-27editeng: sal_Bool->boolNoel Grandin4-6/+6
Change-Id: I9e27453f0b77a23ae3d811f0a50a85d3fdf80978
2014-02-27editeng: sal_Bool->boolNoel Grandin5-11/+11
Change-Id: I7da10ad3ba8017d64c723b53795348edf0e7dd6d
2014-02-27editeng: sal_Bool->boolNoel Grandin3-51/+51
Change-Id: I659497b79fe809865639429f2744d815f2a1f3e2
2014-02-27editeng: sal_Bool->boolNoel Grandin5-190/+190
Change-Id: Ice3b0a4ccf7a6d25311ff65a23efa9082cd501de
2014-02-27editeng: sal_Bool->boolNoel Grandin1-1/+1
Change-Id: Iede0a8ea3e28d1a77069e61c5a9b9d5bccc69adb
2014-02-27editeng: sal_Bool->boolNoel Grandin2-36/+36
Change-Id: I69c210b79f4d1b64863ac0ab2b012f033f40fe10
2014-02-27editeng: sal_Bool->boolNoel Grandin1-3/+3
Change-Id: I3827611dc887985484aec7fa5506e15298ac916e
2014-02-27editeng: sal_Bool->boolNoel Grandin1-1/+1
Change-Id: Ibce9442e46dffbfb21873bb64fbc851ad761b4dc
2014-02-27editeng: sal_Bool->boolNoel Grandin1-2/+2
Change-Id: Ic4dec17e879e6e16c7d6c5e184288a629872ce84
2014-02-27editeng: sal_Bool->boolNoel Grandin1-1/+1
Change-Id: Icaab3bcf646611ebb31415c54e0ce350817d8fc8
2014-02-27editeng: sal_Bool->boolNoel Grandin1-2/+2
Change-Id: I977aa9d3cf18da00c69bfd777b51299613e01d1d
2014-02-27editeng: sal_Bool->boolNoel Grandin1-2/+2
Change-Id: I1c1d16e5b9690a5f61a04ed78d6e4be296800ebb
2014-02-27editeng: sal_Bool->boolNoel Grandin6-239/+239
Change-Id: Id4174904487fc153d8e80471da7c829c52092f78
2014-02-27editeng: sal_Bool->boolNoel Grandin1-1/+1
Change-Id: Id309a574831dd46bce47009eb8c4879d26c3a332