summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)AuthorFilesLines
2017-03-03Resolves: tdf#106123 store and restore the PaM around the menu ExecuteCaolán McNamara1-0/+11
because the loss of focus in the current editeng causes writer annotations to save their contents, making the pContent of the current EditMaps invalid (cherry picked from commit 71a84b69ae30458a941f38869aa994118051a063) Change-Id: Ic01379291fa66dd58246d33287b18801f5da49c0 Reviewed-on: https://gerrit.libreoffice.org/34614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-02-01tdf#103927: Share single standard VirtualDevice instance.Kohei Yoshida4-25/+25
To avoid creating excessive amounts of VirtualDevice instances. Also, since we now have VclPtr, we shouldn't need this bOwnerOfRefDev flag. This fixes tdf#102688 as well as other GDI-Limit related issues. See tdf#105469 for other bugs this may fix. (cherry picked from commit b41186a2fc49e440890b8c86e5367352ffaf9cd6) (cherry picked from commit fab2f546d1fb3ceaf5ee5d4d728f1728a8f1e7f3) (cherry picked from commit bac2baa785ffc75160de2d15da60901152da33de) Conflicts: editeng/source/editeng/eerdll2.hxx editeng/source/editeng/impedit2.cxx Change-Id: Ieda242786c6376c7ac249a9f6d469b670f1ac177 Reviewed-on: https://gerrit.libreoffice.org/33641 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jean-Sébastien B. Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-19tdf#96354 correct broken autocorrect INitial CApitalsYossi Zahn1-3/+3
Change-Id: If65ec7814c3aed5e4c17294ae57c34550373469d Reviewed-on: https://gerrit.libreoffice.org/31317 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit c6db0e064959ec154db9471a8e1f1e2716bb3523) Reviewed-on: https://gerrit.libreoffice.org/33266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-12-19tdf#104488 editeng,svx: throw less Accessible exceptionsMichael Stahl1-15/+0
For some of these functions it doesn't make sense to throw DisposedException as they can return a sensible default value. Particularly AccessibleShape::getAccessibleChildCount() was throwing an exception that was never caught. (cherry picked from commit 5a3b2111172f106378cbf78aba0fde1db3642275) loplugin:unnecessaryoverride (cherry picked from commit 10bf49c18d56f198e63514953a1c6e2ea17fcc9c) Reviewed-on: https://gerrit.libreoffice.org/32187 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 0dd9e51abc5705b7ae253d3f9b284136cf1597d6) Change-Id: I000149cf9bb0fd13f69650ad8224a8daf26f7bee Reviewed-on: https://gerrit.libreoffice.org/32201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-01Resolves: tdf#104152 suppress notifications from EditEngine during PasteEike Rathke1-0/+5
Broadcast once at the end instead to notify a11y. (cherry picked from commit 7c20d0174c59d46b11fc5029fe3fc0c00f5dc6d0) Conflicts: editeng/source/editeng/impedit.cxx Change-Id: I12383b6efbbb2b149f0d73c67d8576fcc050b253 Reviewed-on: https://gerrit.libreoffice.org/31425 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-11-21tdf#103334 - EDITING: Undo on bullet point styleNoel Grandin4-5/+9
I have checked the normal model and the editing model after UNDO, and all seems to be well, this is purely a rendering/lack-of-invalidation issue. The extra invalidation I add here is restricted to the UNDO case to prevent tripping up a LOK unit test (SdTiledRenderingTest::testCursorViews). I confess to not having followed the invalidation logic all the way to see why exactly it makes the bug go away. Reviewed-on: https://gerrit.libreoffice.org/30225 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit ee33745ced5ae12f9ae7735fac16a7298ccae474) Change-Id: I34f7d84526462665b1ec09aba966c98cd4e8795f Reviewed-on: https://gerrit.libreoffice.org/30425 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-07tdf#90070 don't clip flys with bordersJustin Luth1-2/+10
regression from commit e598ab04476a32a08f18e8f0662fafa5f78f1a4a very aggressively forced a new frame size via compat setting CLIPPED_PICTURES on any fly - not just images. This only affects MS-format documents, EXCEPT that it is a document property, so if the file every spent any part of it's life in MS-format, it will always retain that compatibility setting. That explains why the problem was intermittent for me - and was hard to reproduce in a clean document, even though I'd seen it in .ODTs. bIgnoreLine (ignore the fact that there is no visible line) was a confusing word choice for "if there is no line, then return a spacing size of zero". bEvenIfNoLine=false is better. Change-Id: I50a3bdef3a67339ae517ee6319920651bc56f9be Reviewed-on: https://gerrit.libreoffice.org/30585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit d034f273cb24ebe4fde20ad9089ac11cccf316d0) Reviewed-on: https://gerrit.libreoffice.org/30595
2016-09-27Resolves: tdf#83037 <--> corrected into ← → instead of ↔Caolán McNamara1-7/+11
don't use - as a word separator except for breaking up a compound word for the purposes of tdf#55693, e.g. TEst-TEst autocorrected to Test-Test) Change-Id: Ie52a16af0b5838d1ba0de9c5f9c30dcab05c3bc7 (cherry picked from commit 0bfefc0b396bd61cc5f508bf86afc12cfadaa483) Reviewed-on: https://gerrit.libreoffice.org/29190 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-09-06editeng: don't let wild-card auto-correct leave current wordMichael Stahl1-0/+5
If a paragraph has e.g. multiple -> in it then auto-correct of the first one will create via the .*->.* rule a new auto-correct entry that has as long-word the word that contains the first -> until the last -> and everything in between. This will be somewhat irritating when it is eventually applied. Avoid it by limiting the wild-card loop to the current word, which is apparently the intent anyway. (regression from a07425892205ff8951027ea20459b97370d01de6) Change-Id: I294bae863c44eb460627b61b4383133131fe4b3a Reviewed-on: https://gerrit.libreoffice.org/28608 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 9670f0d17ffed1ff07cb1deddcabc26c756e4bc1) Reviewed-on: https://gerrit.libreoffice.org/28633 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-02Resolves: tdf#96369 don't superscript ordinals for mixed text and numbersCaolán McNamara1-2/+1
e.g. 5th is ok, but foo5th is not this is basically a regression from commit 17e6b8fd05af8fff86847c0ef1e8cc9ad013a1bd Date: Thu Apr 7 13:33:48 2011 +0200 where the older code would only do the conversion if the string before the number was comprised of non-letters, so go back to that logic. Change-Id: I928c365eb11891e78331bbd165dbdb9541ac0361 (cherry picked from commit 776e2e2635487523cd1757f382f54487b36b5ad3) Reviewed-on: https://gerrit.libreoffice.org/28495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-08-03masses of MessBoxes not being disposed promptlyCaolán McNamara3-3/+3
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X (cherry picked from commit a860df25dd7bf62ecb6b3d3ed38803b981f56d52) Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f Reviewed-on: https://gerrit.libreoffice.org/27537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-21Resolves: tdf#97404 outline space wrong on second levelCaolán McNamara1-24/+1
Revert "tdf#42788: FORMATTING - Numbering/ordered list" This reverts commit 6517141b6233c5f9667031bc92f66109fddf5b76. https://gerrit.libreoffice.org/#/c/23006/ was apparently intended to revert this, but it never was Then there was https://gerrit.libreoffice.org/#/c/23427/ which was an attempt to improve it but it was abandoned Then there was https://gerrit.libreoffice.org/#/c/23542/ whichw as another attempt to improve it, but it was too abandoned. all of which leaves us worse than when we started with a pile of unhappy abandoned efforts and cruddy indent Change-Id: I8b3666a957339030d5a946a2b387f452e7fb0099 (cherry picked from commit 8617010b851e000f336cf647f207557b5eeab8b7) Reviewed-on: https://gerrit.libreoffice.org/27328 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-15tdf#100880 editeng spellchecking doesn't work sometimes...Caolán McNamara1-3/+3
believe to be a regression from commit 73f0b3bd5553c5d023d0a1dbfdc00836e2937961 Author: Matteo Casalin <matteo.casalin@yahoo.com> Date: Sat Dec 28 13:37:26 2013 +0100 xub_StrLen to sal_Int32 + some const and lets fix it the same way commit 9705fbc1119da91e73c00a2ec848565929eeb483 Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Sun Mar 2 12:19:16 2014 -0600 Fix editeng missing spellchecking redline on load (probably) fixed some other regression caused by that Change-Id: I52775aff50dcc634fd2f08eb685cc4ad9850c82c (cherry picked from commit 71ab1ee978a6da8edeabc7c65e9a34e679ec8e43) Reviewed-on: https://gerrit.libreoffice.org/27197 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-15tdf#100734: Update bullet of paragraph on UNDOMike Kaganski1-0/+2
Change-Id: I1afe0b4ca537eea752d3bced8bbc8944380c3514 Reviewed-on: https://gerrit.libreoffice.org/26874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 3a9c151e6eeb3c81902fab2644522a8df9e7161d) Reviewed-on: https://gerrit.libreoffice.org/26893 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-25sw: replace boost::shared_array with std::shared_ptrMichael Stahl1-1/+0
Change-Id: I99eec60db7f6d586b3b424661e03a7891422ab2e
2016-05-25Fix typosAndrea Gelmini1-1/+1
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266 Reviewed-on: https://gerrit.libreoffice.org/25420 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25tdf#89329: use unique_ptr for pImpl in xmlcnitmXisco Fauli1-10/+8
Change-Id: Iec37e509b78e58e90591bad26735ff31462eaf5c Reviewed-on: https://gerrit.libreoffice.org/25328 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Revert "remove some manual ref-counting"Noel Grandin2-8/+28
until I have a better understanding of the UNO reference counting. This reverts commit 111de438ea3e512a541281dc0716cc728ea8d152.
2016-05-24remove some manual ref-countingNoel Grandin2-28/+8
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f Reviewed-on: https://gerrit.libreoffice.org/25363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-21fix bad index/assertion failure with line ending autocorrect patternsLászló Németh1-2/+5
Test case: type "->" and press Enter in a new en-US text document. Result: crash or missing replacement of the arrow. Change-Id: I052ae868b6fe0b1e5557c40471d31a20bd1e5ca9
2016-05-19clang-tidy modernize-make-uniqueNoel Grandin1-1/+2
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b Reviewed-on: https://gerrit.libreoffice.org/25138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18Resolves: tdf#99930 SetReplaceLeadingSingleQuotationMark(false) for CalcEike Rathke3-1/+21
Change-Id: I29906de6a4075b7de82bd6e16560b56b9b648e91
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin4-20/+0
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11convert EXTTEXTINPUT_ATTR to scoped enumNoel Grandin3-17/+17
Change-Id: I94706bdea91d367fc8c2bbd482f6b4d8f55449d7 Reviewed-on: https://gerrit.libreoffice.org/24821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Fix typosAndrea Gelmini1-1/+1
Change-Id: I1c1894fcf533291b34a662b6efb96dcfa75b92b3 Reviewed-on: https://gerrit.libreoffice.org/24760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2-2/+3
Change-Id: I005943a7c7bc4f8bfc647b2cf44f143a66a7e997
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann5-15/+19
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Insert explicit "break" when falling through to empty next caseStephan Bergmann1-0/+1
...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
2016-05-09convert OUTLINER_MODE to scoped enumNoel Grandin5-36/+39
Change-Id: I7ac45d7fbd5e77a105cbe942c6d4fd6cfc8ff909 Reviewed-on: https://gerrit.libreoffice.org/24789 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09convert FONT_EMPHASIS_MARK to scoped enumNoel Grandin6-33/+35
Change-Id: I137c78b337e57d3442db08334128e79d186b278f Reviewed-on: https://gerrit.libreoffice.org/24753 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09convert SfxStyleFamily to scoped enumNoel Grandin6-12/+12
and update the RSC compiler to accept such In the process fix some confusion in SD where it was confusing SfxStyleFamily and the index of the relevant family (which other parts of the code in SVL use) Change-Id: I1efc9f85fbed8ab76eafe8f6e1ada411753ae5f9
2016-05-08Translate German commentJulien Nabet1-1/+1
Change-Id: I7a6481370cacd1c33510654d17b20d254e753476 Reviewed-on: https://gerrit.libreoffice.org/24754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-04use Any constructor instead of temporariesNoel Grandin1-9/+3
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann2-32/+15
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-03Prevent Any::setValue from reinterpreting bool* as sal_Bool*Stephan Bergmann1-35/+33
...which only happens ot work in environments where sizeof (bool) == 1. The simpler alternative is to use the operator <<= template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
2016-05-01Replace '||' with '&&'Rosemary Sebastian1-1/+1
so that the condition doesn't always evaluate to true Change-Id: I66ba3d4c7985e1fad60f12836e44167f19216588 Reviewed-on: https://gerrit.libreoffice.org/24548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01Fix typo in codeAndrea Gelmini2-3/+3
Change-Id: Ia1ec84da61aa353d481ada98c41cbebaca623c0e Reviewed-on: https://gerrit.libreoffice.org/24532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin1-5/+0
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-27todo odd warnings being printedMichael Stahl1-0/+1
Change-Id: I227ba7063827952525a4b190f864b4c7ffb3a6d8
2016-04-27-Werror,-WvarargsStephan Bergmann2-5/+5
"passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]" just replace the variadic function with one taking an initializer list Change-Id: Ied3dfe835dcebef48cf35374ec4d8835f98e6779
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin2-6/+6
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-26clang-tidy modernize-loop-convert in e*Noel Grandin18-103/+88
Change-Id: If56abefa81b41479e3ea9890dee1c43f006086de Reviewed-on: https://gerrit.libreoffice.org/24384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-21new plugin stylepoliceNoel Grandin1-3/+3
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann13-31/+31
Change-Id: I626b79e1450d78aec96c206db82bf64a47305d08
2016-04-20Use IsRightToLeft()Stephan Bergmann2-7/+5
...instead of computing this from GetRightToLeftLevel() Change-Id: If0068c8aae581b6f097ba3897b4a3031db8d9afd
2016-04-19So this is apparently about right-to-left levels, not a boolean flagStephan Bergmann4-21/+21
Although the cases where GetRightToLeftLevel() is contextually converted to bool look fishy, and might have been intended to use IsRightToLeft() instead? Change-Id: I741b90cb6f1ccdac0886c451d05f4cfac79dbd5f
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin3-22/+16
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke1-1/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14-Werror=logical-op (GCC 6)Stephan Bergmann1-1/+1
"logical ‘and’ of mutually exclusive tests is always false" <sberg> alg, in editeng/source/uno/unoipset.cxx:208 (wid < START && wid > END), is what's actually wanted to check for contained or for not contained in the START..END range? You touched the code last, in b0c2ec72ff171d8b4303d39f11f67497e88e2d8c, 15+ years ago (although the line itself was already like that in the initial import, fd069bee7e57ad529c3c0974559fd2d84ec3151a) <alg> sberg: sorry cannot remember - but looks correct. All values outside OWN_ATTR_VALUE_START/_END are answered with defaut. The renge should be the one from ditEngine <sberg> alg, the code as is is clearly incorrect, as the condition is always false <alg> sberg: Ah, yes! Should probably be an '||' <sberg> alg, OK, thanks, I'll give that a "make check" try (a bit scary to thus enable code that had effectively been disabled since at least the turn of the century) <alg> sberg: Yes - scary is the right word. Looking further, eState == SfxItemState::DEFAULT should result when outside, thus pItem->QueryValue would be taken which *should* get the default from the pool when not in the local ItemSet range. In theory, the same *should* happen Change-Id: I906361272dfe3f6af0e1ed3cb4e245ead7eabaec
2016-04-14-Werror=logical-op (GCC 6)Stephan Bergmann1-1/+1
"logical ‘or’ of collectively exhaustive tests is always true"; apparently a typo in 63114e6d863de32e2d93f0da54caca928916d9c2 "Create SvxFieldData instance directly from the UNO textfield object" Change-Id: I9e504ccb5ebad5a42a8c07d7f16d7c316dd82cf1
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 21:21:51 +0000