summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2020-02-21Drop o3tl::optional wrapperStephan Bergmann3-3/+3
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-21tdf#130598 improve a tip-of-the-daySeth Chaiklin1-1/+1
- tip about updating software - also added link to relevant help page Change-Id: I44ce2a17de311aa31a7b525510dcb8525cbf3dbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89131 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-20loplugin:unusedfieldsNoel Grandin1-0/+1
Change-Id: Ic036265f4e0b41108c5b72f0142b0aaf88d10713 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89118 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-19Proper alignment for labelHeiko Tietze1-0/+1
Amends I321c7e0e3cb2d67a07724523c885d50577a116a5 Change-Id: Ib89bddf36c81dbfaa4c6562a342cf3f8a423eaa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89017 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-18uitest: test tab navigationXisco Fauli1-0/+43
Change-Id: I6be30cf419b5a7752ca168e4817efcb6981f803a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88966 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-18tdf#130384 cui: fix automatic color showing up as white in the char dlgMiklos Vajna2-1/+22
Regression from commit b4554b8eddd048532269df610e89ae739c46fab7 (cui: add UI for semi-transparent shape text, 2019-11-22), the problem was that COL_AUTO has the alpha channel set to 0xff, and we should not clear that, otherwise the color list box will present the automatic color as white. Change-Id: I6eae788606b003eec014c0c4a22b40053ff534d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88884 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-18Area Hatch dialog alignment fix compare to other area fill tabsandreas kainz1-2/+0
Change-Id: I39787941aa98b3623ef989e81c4dce0b402ef38c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88895 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-17Image Property Dialog Crop and Image Tab updateandreas kainz1-87/+84
Change-Id: I5b60f8359b8ca27e3517b2422a5d53868584ab2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88415 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-17Resolves: tdf#130123 let the expert config columns be resizableCaolán McNamara1-0/+4
Change-Id: I08572bfe92c99d6e2e6b8ea27856817a6dddf1f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88879 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17remove some unnecessary includesCaolán McNamara1-2/+1
Change-Id: I15c3a2b0696661de4ca6454b3ef047af3871eed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88858 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17Resolves tdf#129032 - Missing warning when renaming pageHeiko Tietze4-2/+35
Edit field has type normal or error now Edit field and okay button return feedback per tooltip Change-Id: Ib2caf3280227cb00af25889ed111503745b471dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85101 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-02-14remove MetricField use from cuiCaolán McNamara3-11/+97
Change-Id: I10729db9ae465a714657b58cbfa67bed47a6c7f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88726 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14Resolves: tdf#130658 there isn't a second column in non-exception modeCaolán McNamara1-1/+4
Change-Id: I35edf263251c087976aa9a2506bb23c083e1f7c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88718 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14split out MetricField value conversion functionsCaolán McNamara3-8/+10
Change-Id: I67a33bd2a5cb06dc66e471918b5c378044a2eff2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14drop need to include vcl/edit.hxx in cuiCaolán McNamara1-3/+7
Change-Id: I9479a7e8fc5b3897e48efc47dbae979137718bc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88618 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13Revert "Related tdf#130428: let's add some asserts"Armin Le Grand (Collabora)1-26/+18
This reverts commit 9811796aba7360fc5b7230a8b314a56fbf6ab27a. Revert "tdf#130428 SfxItemState::UNKNOWN replacements" This reverts commit cf4e87469baf13fb2766d0f2593fcc2b9b33bc9b. Change-Id: I976ade5e25db09e18297e46a5c92f8bc578399e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88610 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-02-12tdf#43157 Clean up DBG_ASSERTShubham Goyal1-14/+13
Change-Id: Ie41f91f873d7cada5e738d758ad6b677adcee989 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87428 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-11tdf#114694: Make default value in language settings the first elementYusuf Keten3-28/+66
For Languages, to make the default value ​​the first element in the list, I've added 3 parameters to SvxLanguageBox::SetLanguageList(). With this parameters, function adds default value according to its existence before other values. For sorting User Interface and Currency, I removed the make_sorted function. I added std::sort with lambda expressions for both of them. Change-Id: Iae37bfe09aaac4d8ecde1caad7a14e11df551eae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87926 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-11cui: Compare by full module idMaxim Monastirsky3-27/+6
Otherwise Master Document is detected as Writer, causing crash when opening the customization dialog, as the notebookbar tab isn't prepared to handle the Master Document variant. Change-Id: I872255c42517b4223fb31e2074e4d5d083c76e93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88344 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-10Always checking for Master document command labels makes no senseMaxim Monastirsky1-17/+2
Change-Id: I33d04da63c5e30d166bd22f9fc7ffb5aa4da5c6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88343 Tested-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-10Resolves: tdf#130548 click is sent to the other member of the groupCaolán McNamara1-0/+8
when toggling one the other gets a click signal, but its too early and the page size isn't set yet, making the dialog thing the margins won't fit in the page Change-Id: I5b51f2d91c69558d47f43b3f05eca3fd87a24125 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88383 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10in case of Skia problems force raster mode, don't disable it allLuboš Luňák3-4/+62
Skia's CPU-based raster mode should be safe (at least from driver problems), so it should be enough to make the failsafe mechanism just disable Vulkan use. Also add UI option controlling forced raster rendering. Change-Id: I6be1745782816e5468e55635ae5613b6a6afded6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88206 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-09Resolves: tdf#130486 setting distributed results that justified cannot be setCaolán McNamara1-4/+7
Change-Id: If80c935b7e33b5c7146eb562daf2303688160653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88270 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07tdf#130478 Enhance Dashed line drawing on all systemsArmin Le Grand (Collabora)1-0/+1
For more info and explanation including state of process information and discussion(s) see task please. Adding corrections for gerrit build Change-Id: Ie10fb8093a86459dee80db5ab4355b47e46c1f8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88130 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-02-07rename URLBox back to SvtURLBoxCaolán McNamara4-4/+4
Change-Id: Icd90eeb492002c45ddd8ff562a6da411abead122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88185 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07clang-format cui with under 5-percent lines of changeMuhammet Kara8-28/+28
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: I2886b6da85043218505ff9f3e40a8e28289c6f37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88152 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-06fix "Use data for document properties" checkbuttonCaolán McNamara1-1/+1
regression since... commit 3a15c034be9f557f350d0ba1f3a842151066eaae Date: Tue Mar 12 09:59:35 2019 +0000 weld SvxGeneralTabPage Change-Id: I7c4624255f70c3f0c4ccd4b79ebae7750ed2bbe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88108 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06Resolves: tdf#130340 null deref when nothing selectedCaolán McNamara1-1/+1
Change-Id: Ie406006cbcca566ddd32fd86a7e88f0c754dd02e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88047 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06merge FillTypeLB with SvxFillTypeBoxCaolán McNamara4-13/+10
Change-Id: Ia6229e8cc04c88e6740a12648c50cf5efca3bbd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06rename SvtFontSizeBox back to FontSizeBoxCaolán McNamara2-12/+12
Change-Id: I2ec0c6dd376f3a192a62dc97f7454af946e2a5ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06drop newly unused FontSizeBoxCaolán McNamara3-4/+3
Change-Id: I8a84ce74888e1d3c468251ddd3633aedf6339a11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-05Related tdf#130428: let's add some assertsJulien Nabet1-0/+7
to avoid potential future wrong code Change-Id: Ib5a10039ce95ed5d9bf6f5905bc58af5182d5c0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87995 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-04tdf#129720: Populate the Description box of the Customize dialog...Onur Yilmaz2-23/+18
Change-Id: Id294458e0b380ceedc199a9c642f29ecfbeef10e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87920 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-04rename Get/SetPropTextFirstLineOfst -> Get/SetPropTextFirstLineOffsetNoel Grandin1-2/+2
Change-Id: Ib963dccf0f803534c741eacc31a44dc5c90889fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87958 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-04tdf#130428 SfxItemState::UNKNOWN replacementsArmin Le Grand1-18/+19
It's possible to remove seven usages in align.cxx which cannot happen due to AlignmentTabPage forcing used ItemIDs to be member of the used ItemSet. Checked that in the debugger. Safe, is all set and ceated when the Dialog and the TabPage gets created (see AlignmentTabPage::GetRange()) Change-Id: If8e7285b46792fb9035555a4fcd2ac6ec94a45ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87975 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-02-04rename SetFirstLineOfst->SetFirstLineOffsetNoel Grandin1-1/+1
Change-Id: Ie83747b90b420c6de677d243665d7a22290236a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87959 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-04rename Set/GetTextFirstLineOfst->Set/GetTextFirstLineOffsetNoel Grandin2-7/+7
Change-Id: Iaeb3c17fe157dec82cd70991122c08ee1e215752 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87955 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-03Resolves: tdf#130364 let font treeview fit to available dialog spaceCaolán McNamara3-74/+95
Change-Id: Ia000f4cfa041733fc84b45c955e69251c3ce9bcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87871 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03Resolves: tdf#130061 numbering dialog adjustments missingCaolán McNamara1-0/+38
since... commit e82b10f21cb8b77f815be3bd7654e0de7e8ceab5 Date: Sun Oct 20 00:44:05 2019 +0200 tdf#128257 Bullet Dialog update so spinbuttons were disabled Change-Id: Id8d54bd6ba359447943832920fce5e0da271f405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87878 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03Related: tdf#130143 freeze/thaw around bulk insertCaolán McNamara1-0/+8
Change-Id: Iedb1229b56b5e7f1af1779b830cf324bcc8735e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87862 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03loplugin:unusedfieldsNoel Grandin2-24/+5
tweak plugin with the name of another clone method Change-Id: I47193d31f53f48297c9e773da375c7255ddde282 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87852 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-03loplugin:constantparamNoel Grandin4-9/+9
Change-Id: If2dee122bf07dc179fd8f6e766442ec1891a5f3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87845 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-03rename SvtFontStyleBox back to FontStyleBoxCaolán McNamara2-12/+12
Change-Id: I709f100541964b8740a7d0639a58214b1553458f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87836 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-02rename RelativeField back to SvxRelativeFieldCaolán McNamara2-10/+10
Change-Id: Iadac47f83aae0f7403f3391e3dd45bef52ad347a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87832 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-02-01make update_pch also consider files in <module>/src/**/incLuboš Luňák1-2/+54
With --enable-pch=full there's not much difference between a "public" header in <module>/inc and a private one in <module>/src/somewhere/inc . And since the script searches recursively, this apparently helps to find even more headers for lower pch levels. Change-Id: I8483d0aa5b4fea5a59107c20a8aa5f1ef694af0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87799 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-01sal_uLong to size_t for sizeof related typesMuhammet Kara1-2/+2
Change-Id: I00055ffd7b79d2e5637b69390ca516f11b0cffd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87801 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-31Related tdf#105225 Remove unused backgroundpage.uiJim Raykowski3-596/+0
Change-Id: I8ddf92d9b349ed8884c971e08c124dba1efc4142 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85792 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-01-30tdf#130219 change labels in Case dropdown box in Font Effects tabSeth Chaiklin1-3/+3
- change "Title" to "Capitalize Every Word" - change "Lowercase" to "lowercase" - change "Capitals" to "UPPERCASE" Change-Id: I67145a384b0220924184b8bc279fb702d8c9f379 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87684 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-29sw: add UI for semi-transparent textMiklos Vajna1-0/+33
Somewhat surprisingly the test passed without the fix, i.e. the uitest operated happily on a hidden widget; so explicitly assert that it's visible. Change-Id: I321c7e0e3cb2d67a07724523c885d50577a116a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87656 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-28tdf#127112 repair "sticky" levels in Customize numbering style dialogSeth Chaiklin2-5/+27
Change-Id: Ifa841e7b63b28d6e0f84f5cd6b1800481b36425b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87149 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 17:13:34 +0000