summaryrefslogtreecommitdiff
path: root/connectivity/source
AgeCommit message (Collapse)AuthorFilesLines
2017-06-05Improved loplugin:cstylecast to reference types: connectivityStephan Bergmann1-1/+1
Change-Id: I63c747efa2aacf4cb23de6fe9ab02af7abc107f9
2017-06-03android: Update configure.ac for NDK r14b versionbrainbreaker1-2/+3
This commits updates the NDK version warning in confiure.ac for NDK r14b as it is now tested for building Android. Also, Modify code in JStatement.cxx to suppress the warning of ignoring return value which turns into error with --enable-werror argument. Change-Id: I40b264c2f39788948dbf947073de63c3347184f9 Reviewed-on: https://gerrit.libreoffice.org/38359 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-06-02Cleaning in table.cxx of firebirdJulien Nabet1-8/+9
- Replace nNullabble by nNullable - Replace wrong var name sNewTableName by sNewColName Change-Id: Ib10de7057c0d131f8504e8387721a05bd9e4434f Reviewed-on: https://gerrit.libreoffice.org/38251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-05-31simplify OSQLScanner::SQLyyerrorNoel Grandin1-28/+10
...buffer management Change-Id: I649a93ed5bd9bd7d4ac8ec73fc956eb8532eac89 Reviewed-on: https://gerrit.libreoffice.org/38206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30remove duplicate 'using namespace'Jochen Nitschke2-7/+1
Change-Id: I7f8828f677cfb588135ff75c03ffb75895773440 Reviewed-on: https://gerrit.libreoffice.org/38201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30fix convertName2SQLNameNoel Grandin1-2/+2
after my commit 47bbe217607374ccd3a76f1ef6d82e43efd31ba1 "untwist the logic in convertName2SQLName" Change-Id: I3d365a24c538d8ecade2b6fe32fa739d8f4bd211
2017-05-30untwist the logic in convertName2SQLNameNoel Grandin1-11/+9
Change-Id: Ib3cfa3a8a2bdc691e3f6db25672a37c8ede1ffd5 Reviewed-on: https://gerrit.libreoffice.org/38180 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30teach redundantcast plugin about functional castsNoel Grandin2-2/+2
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0 Reviewed-on: https://gerrit.libreoffice.org/37910 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-28remove unnecessary use of OString::getStrNoel Grandin4-20/+10
Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-25Related tdf#108068: Use new name of column when it's been changedJulien Nabet1-11/+11
First fix simple case, the rename of a column which is not a primary key Change-Id: Ia0de8e531021cbec0409408008c541c25a4bcd85 Reviewed-on: https://gerrit.libreoffice.org/38014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-05-19loplugin:stringcopy: connectivityStephan Bergmann1-1/+1
Change-Id: I2309a6b943323e42df8bb2b4c971c1388539ead4
2017-05-19loplugin:unusedfieldsNoel Grandin4-14/+0
make it a little smarter in dealing with fields that are smart pointers Change-Id: I44072105170882dc29fb19558f1065cffc7e5f11 Reviewed-on: https://gerrit.libreoffice.org/37751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-15Translate German comments and debug strings (leftovers in dirs a... to c...)Johnny_M14-104/+104
Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "a" to "c". Change-Id: I3b0152ee78ad80a29d714cbd98bf888f31be4763 Reviewed-on: https://gerrit.libreoffice.org/37573 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-05-15remove some unnecessary lockingNoel Grandin1-7/+0
Change-Id: I7da9e82930d3fe8f927c495aeca270b8bb5cf65c Reviewed-on: https://gerrit.libreoffice.org/37602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12remove unused uno::Reference varsNoel Grandin9-14/+3
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke7-7/+0
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-09Fix typosAndrea Gelmini1-1/+1
Change-Id: Ie0f67456e5c7d9b7b26b27b4d633881236ceeadb Reviewed-on: https://gerrit.libreoffice.org/37361 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-09dump exception message on exceptionCaolán McNamara1-1/+1
Change-Id: I30d942e9e8b240be9033b41142831b018bdfc49f
2017-05-09remove unnecessary empty OUString fields and varsNoel Grandin2-10/+8
Change-Id: I940120087a0bc6b1b0abc30a3e7727ce22b7d9a7 Reviewed-on: https://gerrit.libreoffice.org/37394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07revert OSL_ASSERT changesChris Sherlock12-15/+15
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert connectivity module away from OSL_ASSERT to assertChris Sherlock12-15/+15
Change-Id: I1f1296836b07df6e147c8be845486ac4acd15abd
2017-05-05connectivity: convert the other OSL_ENSURE to SAL_WARN_IFMichael Stahl1-4/+4
Change-Id: Ie3d84129b73792e1f129d65350bf0e1455b08566
2017-05-05connectivity: replace OSL_ENSURE with assertMichael Stahl1-209/+210
Change-Id: I0a4a16aa5b78383ee23124d7500b9f12e2add8a7
2017-05-04Replace all OUString("") with OUString()Arnaud Versini2-4/+4
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: https://gerrit.libreoffice.org/37146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-03tdf#107196: fix firebird relationshipJulien Nabet1-12/+12
Let's spread string sanitizing see https://bugs.documentfoundation.org/show_bug.cgi?id=107196#c3 Furthermore, in example file from the bugtracker, relationship between f2 fields were present several times. So I had to delete it several times to really remove it. Change-Id: I4fbe10c479af3d4fa5ccfb290f128fdd2a6d49a9 Reviewed-on: https://gerrit.libreoffice.org/36642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-04-28loplugin:salboolCaolán McNamara1-1/+1
Change-Id: Ic78e1a6fc3fad22f2ffba43730f11b51f555e745
2017-04-28tdf#39486: Translate some randomly found German commentsJens Carl1-4/+4
Change-Id: I4c2950180f504c06666f055d166c51e32a6d5294 Reviewed-on: https://gerrit.libreoffice.org/36969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-28tdf#107457 don't quote columns referred by expression (not by name)Lionel Elie Mamane1-2/+7
Change-Id: I4894313ec27d716e9899c885ddc6be38a2447689
2017-04-28loplugin:checkunusedparams in connectivityNoel Grandin6-15/+7
Change-Id: I302af54f4bcb5807c264f7926cffa025550ccb00 Reviewed-on: https://gerrit.libreoffice.org/37065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-27tdf#39468 cleanup source code commentsdennisroczek3-16/+13
* translate German source code comments * remove ascii art * remove bogus source Code comments * remove old StarOffice/Sun internal bug tracker references Change-Id: I443bf2fdba3780c411d69809111daf3aa3a48451 Reviewed-on: https://gerrit.libreoffice.org/36005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27remove ResourceBasedEventLogger in favor of its base EventLoggerCaolán McNamara7-11/+11
because there are no resources in use anymore Change-Id: I37e4a100aabbf6214533738da3e528ed2f434eae
2017-04-27the only use of this argument is sdbcl which is a deleted resource fileCaolán McNamara1-1/+1
Change-Id: I31c140dcab9a291c4ede62e56d296a224dcd47c8
2017-04-27another name for a nonlocalized string is a stringCaolán McNamara10-380/+25
Change-Id: Ic4ff92720edd1c10dd6d5eff026e79cb02990005
2017-04-25remove bitmaps from .src filesCaolán McNamara3-30/+1
and into includeable .hlst files, add them to postprocess/CustomTarget_images.mk to continue only including used bitmaps in icon-theme zips Change-Id: I5c24c3eca93a9c4101bcdcacb0e4b2712133968e Reviewed-on: https://gerrit.libreoffice.org/36941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock5-0/+5
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-22revert bits of "remove some old MSVC workarounds"Noel Grandin2-4/+5
in commit 841e1a6f3619054ecc9240e061cd83d4e41d1ca9, since MSVC 2015 still does not pack heterogenous bitfields tightly Change-Id: I251c797492762cbd2381496b2f2c6c3223d563c6 Reviewed-on: https://gerrit.libreoffice.org/36800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin3-4/+3
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21remove some old MSVC workaroundsNoel Grandin2-5/+4
Change-Id: I6abd8aaffb27b3c85df7c0518f7f576be4e32222 Reviewed-on: https://gerrit.libreoffice.org/36660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19loplugin:redundantcast (clang-cl)Stephan Bergmann2-5/+5
Change-Id: I97ff3f7c4ebfb7c9db2ceed234da1095ed0eeed6
2017-04-13Removed duplicated includesAndrea Gelmini1-1/+0
No automatic tools. Manual checked and tested. Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754 Reviewed-on: https://gerrit.libreoffice.org/36371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-11sal_Bool -> boolStephan Bergmann2-2/+2
Change-Id: If632eb547aa5082ad13eac8c2ad39a1742309fc7
2017-04-10tdf#106866 query character size instead of bytesTamás Bunth1-2/+3
Change-Id: I7639fb1accdf728a8170ddb7dc9caf84bad8d3ef Reviewed-on: https://gerrit.libreoffice.org/36289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-04-06Improved loplugin:redundantcast, static_cast on arithmetic types: connectivityStephan Bergmann1-1/+1
Change-Id: I8156e528b675c5f27c5d6903f17cb62d228d1488
2017-04-06KAB lo:redundantinline pluginJan-Marek Glogowski3-4/+3
Change-Id: I522be5260b8f61afb2b133a6e32bd0b66c1b7522
2017-04-06loplugin:redundantcast find cstyle double castsNoel Grandin1-1/+1
Change-Id: I5507be190dac781e5cdb545a60acf3d50056c9f8 Reviewed-on: https://gerrit.libreoffice.org/36187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04loplugin:redundantcast (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Ie096d75c1bc774e77c589845f61276d1478234ef Reviewed-on: https://gerrit.libreoffice.org/36065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04loplugin:redundantinline (clang-cl)Stephan Bergmann11-22/+21
Change-Id: I03a19b599005f6ef25040889a1e1802445ebf430 Reviewed-on: https://gerrit.libreoffice.org/36063 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04make UNO enums scoped for internal LO codeNoel Grandin3-22/+22
this modifies codemaker so that, for an UNO enum, we generate code that effectively looks like: #ifdef LIBO_INTERNAL_ONLY && HAVE_CX11_CONSTEXPR enum class XXX { ONE = 1 }; constexpr auto ONE = XXX_ONE; #else ...the old normal way.. #endif which means that for LO internal code, the enums are scoped. The "constexpr auto" trick acts like an alias so we don't have to use scoped naming everywhere. Change-Id: I3054ecb230e8666ce98b4a9cb87b384df5f64fb4 Reviewed-on: https://gerrit.libreoffice.org/34546 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31fix typo: databse --> databasedennisroczek1-1/+1
Change-Id: I3ae198eb599a6b0db1be900a2c464ab7b4c20e89 Reviewed-on: https://gerrit.libreoffice.org/35236 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-30remove type decorations on char literalsJochen Nitschke2-2/+2
they are only needed where type deduction fails. left them in defines for now. Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09 Reviewed-on: https://gerrit.libreoffice.org/35893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>